From: xiaohui.xin@intel.com
Date: Wed, 10 Nov 2010 17:23:28 +0800
quoted text > From: Xin Xiaohui <xiaohui.xin@intel.com>
>
>>2) The idea to key off of skb->dev in skb_release_data() is
>> fundamentally flawed since many actions can change skb->dev on you,
>> which will end up causing a leak of your external data areas.
>
> How about this one? If the destructor_arg is not a good candidate,
> then I have to add an apparent field in shinfo.
If destructor_arg is actually a net_device pointer or similar,
you will need to take a reference count on it or similar.
Which means --> good bye performance especially on SMP.
You're going to be adding new serialization points and at
least two new atomics per packet.
--
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH v15 00/17] Provide a zero-copy method on KVM vi ... , David Miller , (Wed Nov 10, 10:46 am)