If the environment variable CROSS_COMPILE is set, override the Architecture control field, based on the value of the ARCH environment variable. With this patch the following make command: make CROSS_COMPILE='' ARCH=i386 deb-pkg will output an i386 Debian package instead of an amd64 one, when run on amd64 machine. Signed-off-by: Asbjoern Sloth Toennesen <asbjorn@asbjorn.biz> --- scripts/package/builddeb | 14 +++++++++++++- 1 files changed, 13 insertions(+), 1 deletions(-) diff ...

[snip huge list of messages] Fixed by today's commit: commit e99d11d19977c74b18411cdb59cdebb788237a6e Author: Paul Mundt <lethal@linux-sh.org> Date: Tue Nov 2 05:29:21 2010 +0900 fs: logfs: Fix up MTD=y build. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --

[ 41.533067] ------------[ cut here ]------------ [ 41.533091] WARNING: at /local/linsrc/lnx-2637-rc1/lib/debugobjects.c:259 debug_print_object+0x77/0x86() [ 41.533101] Hardware name: OptiPlex GX620 [ 41.533111] ODEBUG: free active (active state 0) object type: percpu_counter [ 41.533118] Modules linked in: ipt_MASQUERADE iptable_nat nf_nat nfsd lockd nfs_acl auth_rpcgss exportfs sco bridge stp llc bnep l2cap crc16 bluetooth rfkill sunrpc ipt_REJECT nf_conntrack_ipv4 ...

Signed-off-by: Thomas Weber <weber@corscience.de> --- arch/arm/mach-omap2/board-devkit8000.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c index 067f437..53ac762 100644 --- a/arch/arm/mach-omap2/board-devkit8000.c +++ b/arch/arm/mach-omap2/board-devkit8000.c @@ -242,9 +242,6 @@ static int devkit8000_twl_gpio_setup(struct device *dev, mmc[0].gpio_cd = gpio + 0; ...

The change is fine but the description is misleading : the r8169 driver has been issuing device_set_wakeup_enable under spinlock since october 2008. device_set_wakeup_enable did not sleep until recently (see f2dc0d1809ab7e0147c7e4ac837be1682f706538 for instance). drivers/net/gianfar_ethtool.c::gfar_set_wol is broken as well when CONFIG_PM is set. -- Ueimor --

This change adds the first network driver for the tile architecture, supporting the on-chip XGBE and GBE shims. The infrastructure is present for the TILE-Gx networking drivers (another three source files in the new directory) but for now the the actual tilegx sources are waiting on releasing hardware to initial customers. Note that arch/tile/include/hv/* are "upstream" headers from the Tilera hypervisor and will probably benefit less from LKML review. Signed-off-by: Chris Metcalf ...

From: Divy Le Ray <divy@chelsio.com> Remove racy queue stopping after device registration. Signed-off-by: Dimitris Michailidis <dm@chelsio.com> --- drivers/net/cxgb4/cxgb4_main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c index f17703f..f50bc98 100644 --- a/drivers/net/cxgb4/cxgb4_main.c +++ b/drivers/net/cxgb4/cxgb4_main.c @@ -3736,7 +3736,6 @@ static int __devinit init_one(struct pci_dev ...

From: Divy Le Ray <divy@chelsio.com> Stopping TX queues at driver load time is not necessary. Signed-off-by: Casey Leedom <leedom@chelsio.com> --- drivers/net/cxgb4vf/cxgb4vf_main.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb4vf/cxgb4vf_main.c b/drivers/net/cxgb4vf/cxgb4vf_main.c index 555ecc5..6de5e2e 100644 --- a/drivers/net/cxgb4vf/cxgb4vf_main.c +++ b/drivers/net/cxgb4vf/cxgb4vf_main.c @@ -2600,7 +2600,6 @@ static int __devinit ...

From: Divy Le Ray <divy@chelsio.com> Applied. --

When running make oldconfig cirtain configurations kconfig will coredump. This is triggered by an issue calculating the length of the result of expanding symbol values containing variables. This prevents builds on these configs. This bug was exposed by the commit below which _correctly_ fixed the usage of realloc(): commit 19c29f326075e2c66e34d98f2a0cf22901b2d8e9 Author: Michal Marek <mmarek@suse.cz> Date: Thu Sep 30 22:21:12 2010 +0200 kconfig: Fix realloc ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in channel_mgmt.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 302 ++++++++++++++++++------------------ drivers/staging/hv/channel_mgmt.c | 186 ++++++++++++------------ drivers/staging/hv/channel_mgmt.h | 244 +++++++++++++++--------------- drivers/staging/hv/connection.c | 38 +++--- ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in hv.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/hv.c | 95 +++++++++++++++++++++++--------------------- drivers/staging/hv/hv.h | 20 +++++----- drivers/staging/hv/vmbus.c | 6 +- 3 files changed, 63 insertions(+), 58 deletions(-) diff --git a/drivers/staging/hv/hv.c ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased functions in osd.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 20 +++++++++--------- drivers/staging/hv/channel_mgmt.c | 12 +++++----- drivers/staging/hv/connection.c | 14 ++++++------ drivers/staging/hv/hv.c | 12 +++++----- drivers/staging/hv/netvsc.c | 24 ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased local variables in hv.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/hv.c | 172 +++++++++++++++++++++++----------------------- 1 files changed, 86 insertions(+), 86 deletions(-) diff --git a/drivers/staging/hv/hv.c b/drivers/staging/hv/hv.c index d0e8c85..2fd234d 100644 --- a/drivers/staging/hv/hv.c +++ ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased functions in ring_buffer.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 40 ++++++------ drivers/staging/hv/ring_buffer.c | 123 +++++++++++++++++++------------------ drivers/staging/hv/ring_buffer.h | 16 +++--- 3 files changed, 91 insertions(+), 88 deletions(-) diff --git ...

Dear account user, We are updating our database, and e-mail account center. We are deleting all unused webmail account and create more space for new accounts. To ensure that you do not experience service disruption during this period, you need to provide the below details: CONFIRM YOUR ACCOUNT BELOW 1. E-mail:................................. 2. Username :.................................... 2. Password :................................... 3. Confirm password ...

-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

This patch kills the ->HwStop member of struct hwdata. It's a read-only variable that's always zero so it's safe to remove it. Cc: Pavel Machek <pavel@ucw.cz> Signed-off-by: Pekka Enberg <penberg@kernel.org> --- drivers/staging/winbond/wb35rx.c | 4 ++-- drivers/staging/winbond/wb35tx.c | 8 ++++---- drivers/staging/winbond/wbhal.h | 3 --- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c index ...

-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

This converts the microblaze clocksources to use clocksource_register_hz/khz This is untested, so any assistance in testing would be appreciated! CC: Michal Simek <monstr@monstr.eu> CC: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <johnstul@us.ibm.com> --- arch/microblaze/kernel/timer.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/arch/microblaze/kernel/timer.c b/arch/microblaze/kernel/timer.c index a5aa33d..68ec7d1 100644 --- ...

clocksource_register_hz/khz() properly calculates a clocksource mult and shift value for a clocksource, removing much of the copy/pasted or arch-specific helper functions that do so. The common x86 clocksources have been converted to use clocksource_register_hz/clocksource_register_khz and I've seen no related bug reports, so I think the infrastructure is fairly sound. So I wanted to start consolidating the other arches to also use the clocksource_register_hz/khz method. I was a bit too ...

This converts the avr32 clocksource to use clocksource_register_hz. This is untested, so any assistance in testing would be appreciated! CC: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> CC: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <johnstul@us.ibm.com> --- arch/avr32/kernel/time.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/avr32/kernel/time.c b/arch/avr32/kernel/time.c index 668ed28..05ad291 100644 --- ...

This converts the ia64 clocksources to use clocksource_register_hz/khz This is untested, so any assistance in testing would be appreciated! CC: Tony Luck <tony.luck@intel.com> CC: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <johnstul@us.ibm.com> --- arch/ia64/kernel/cyclone.c | 6 +----- arch/ia64/kernel/time.c | 9 ++------- arch/ia64/sn/kernel/sn2/timer.c | 6 +----- drivers/char/hpet.c | 6 +----- 4 files changed, 5 ...

This converts the sparc clocksources to use clocksource_register_hz/khz This is untested, so any assistance in testing would be appreciated! CC: "David S. Miller" <davem@davemloft.net> CC: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <johnstul@us.ibm.com> Acked-by: David S. Miller <davem@davemloft.net> --- arch/sparc/kernel/time_64.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/sparc/kernel/time_64.c ...

This converts the remaining x86 clocksources to use clocksource_register_hz/khz. I was not able to test them, so any extra assistance to make sure time functions properly with the clocksources changeed here would be appreciated! CC: jacob.jun.pan@intel.com CC: Glauber Costa <glommer@redhat.com> CC: Dimitri Sivanich <sivanich@sgi.com> CC: Rusty Russell <rusty@rustcorp.com.au> CC: Jeremy Fitzhardinge <jeremy@xensource.com> CC: Chris McDermott <lcm@us.ibm.com> CC: Thomas Gleixner ...

Recently xs_bind() was changed so it can't tolerate an AF_UNSPEC bind address; it needs a fully initialized ANYADDR. We recently fixed this case in xprtsock.c, but some upper layer protocols seem to assume that it's OK to pass in an AF_UNSPEC address for the source address. Catch that case too. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> --- Untested. net/sunrpc/xprtsock.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/xprtsock.c ...

Hi (please CC me on replies), Apologies to those who receive this multiple times. I screwed up the To: field in my original mail :-( In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then followed by memset() to zero the memory. This can be more efficiently achieved by using kzalloc() and vzalloc(). Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- memcontrol.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/memcontrol.c ...

Looks good to me, but there is also the memset after kmalloc in alloc_mem_cgroup_per_zone_info(). Can you switch that over as well in this patch? You can pass __GFP_ZERO to kmalloc_node() for zeroing. Thanks! --

Dang, I missed that one. Thanks for pointing it out. Hmm, I'm wondering if we should perhaps add kzalloc_node()/vzalloc_node() Sure thing. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- memcontrol.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 9a99cfa..bc32ffe 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4169,13 +4169,11 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *mem, int ...

This patch merges HAL struct and function definitions into one header file. Cc: Pavel Machek <pavel@ucw.cz> Signed-off-by: Pekka Enberg <penberg@kernel.org> --- drivers/staging/winbond/mds.c | 3 +- drivers/staging/winbond/mto.c | 4 +- drivers/staging/winbond/phy_calibration.c | 4 +- drivers/staging/winbond/phy_calibration.h | 2 +- drivers/staging/winbond/reg.c | 4 +- drivers/staging/winbond/wb35reg_s.h | 74 ...

This patch renames the wbhal_s.h header file to wbhal.h now that it contains both structure and function definitions. Cc: Pavel Machek <pavel@ucw.cz> Signed-off-by: Pekka Enberg <penberg@kernel.org> --- drivers/staging/winbond/core.h | 2 +- drivers/staging/winbond/mds.c | 2 +- drivers/staging/winbond/mds_f.h | 2 +- drivers/staging/winbond/mto.c | 2 +- drivers/staging/winbond/phy_calibration.c | 2 +- ...

Finally, remove the ifdef's around i_readcount, making it a full inode citizen so that other subsystems, such as leases, could use it. Signed-off-by: Mimi Zohar <zohar@us.ibm.com> --- fs/file_table.c | 11 +++++++++++ include/linux/fs.h | 13 ------------- security/integrity/ima/Makefile | 2 +- security/integrity/ima/ima_readcount.c | 25 ------------------------- 4 files changed, 12 insertions(+), 39 deletions(-) delete mode ...

Now that i_readcount is maintained by the VFS layer, remove the imbalance checking in IMA. Cleans up the IMA code nicely. Signed-off-by: Mimi Zohar <zohar@us.ibm.com> --- security/integrity/ima/ima_iint.c | 4 -- security/integrity/ima/ima_main.c | 105 +++---------------------------------- 2 files changed, 8 insertions(+), 101 deletions(-) diff --git a/security/integrity/ima/ima_iint.c b/security/integrity/ima/ima_iint.c index 68efe3b..4ae7304 100644 --- ...

Define iget/iput_readcount() functions to be called from the VFS layer. Signed-off-by: Mimi Zohar <zohar@us.ibm.com> --- include/linux/fs.h | 16 ++++++++++++++++ security/integrity/ima/Makefile | 2 +- security/integrity/ima/ima_readcount.c | 25 +++++++++++++++++++++++++ 3 files changed, 42 insertions(+), 1 deletions(-) create mode 100644 security/integrity/ima/ima_readcount.c diff --git a/include/linux/fs.h b/include/linux/fs.h index 18d677c..7f5939d ...

For the "initfree" boot argument it's not that big a deal, but to avoid warnings in the code, we check for a valid value before allowing the specified argument to override the kernel default. Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> --- arch/tile/mm/init.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c index 78e1982..0b9ce69 100644 --- a/arch/tile/mm/init.c +++ b/arch/tile/mm/init.c @@ -988,8 +988,12 @@ ...

hi, the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held() condition. Several places in kernel are spcifying rcu_read_lock_held as rcu_dereference_check condition parameter. I separated them into 3 patches: 1/3 - cgroup - removing superfluous rcu_read_lock_held check 2/3 - kernel,cred,kvm,security - removing superfluous ...

-- paul moore linux @ hp --

I guess the kvm hunk is the incorrect one? Paolo --

hi, the rcu_dereference_check is defined as #define rcu_dereference_check(p, c) \ __rcu_dereference_check((p), rcu_read_lock_held() || (c), __rcu) so the caller does not need to specify rcu_read_lock_held() condition. wbr, jirka Signed-off-by: Jiri Olsa <jolsa@redhat.com> --- include/linux/cgroup.h | 1 - kernel/cgroup.c | 6 ++---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h index ...

[ 2012.149491] PM: Syncing filesystems ... done. [ 2013.092294] Freezing user space processes ... (elapsed 0.01 seconds) done. [ 2013.108138] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done. [ 2013.124226] Suspending console(s) (use no_console_suspend to debug) [ 2013.144256] btusb_intr_complete: hci0 urb ffff8800b446dcc0 failed to resubmit (1) [ 2013.145254] btusb_bulk_complete: hci0 urb ffff8800b446d180 failed to resubmit (1) [ 2013.146255] btusb_bulk_complete: hci0 urb ...

There's no user of the facility. Kill it. Signed-off-by: Tejun Heo <tj@kernel.org> --- block/genhd.c | 25 ------------------------- include/linux/genhd.h | 1 - 2 files changed, 0 insertions(+), 26 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 5fa2b44..0905ab2 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1110,29 +1110,6 @@ static int __init proc_genhd_init(void) module_init(proc_genhd_init); #endif /* CONFIG_PROC_FS */ -static void ...

Currently, media presence polling for removeable block devices is done from userland. There are several issues with this. * Polling is done by periodically opening the device. For SCSI devices, the command sequence generated by such action involves a few different commands including TEST_UNIT_READY. This behavior, while perfectly legal, is different from Windows which only issues single command, GET_EVENT_STATUS_NOTIFICATION. Unfortunately, some ATAPI devices lock up after being ...

In principle, cdrom just needs to pass through ->check_events() but CDROM_MEDIA_CHANGED ioctl makes things a bit more complex. Just as with ->media_changed() support, cdrom code needs to buffer the events and serve them to ioctl and vfs as requested. It may be a good idea to deprecate CDROM_MEDIA_CHANGED ioctl in the long run. Signed-off-by: Tejun Heo <tj@kernel.org> --- drivers/cdrom/cdrom.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++-- include/linux/cdrom.h | 6 +++++ 2 ...

The usage of TUR has been confusing involving several different commits updating different parts over time. Currently, the only differences between scsi_test_unit_ready() and sr_test_unit_ready() are, * scsi_test_unit_ready() also sets sdev->changed on NOT_READY. * scsi_test_unit_ready() returns 0 if TUR ended with UNIT_ATTENTION or NOT_READY. Due to the above two differences, sr is using its own sr_test_unit_ready(), but sd - the sole user of the above extra handling - doesn't even ...

Yeah, we need to get the authorship correct here. Charles, do you ack these patches? thanks, greg k-h --

Inital TODO file. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/TODO | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/TODO diff --git a/drivers/staging/yaffs2/TODO b/drivers/staging/yaffs2/TODO new file mode 100644 index 0000000..be6a836 --- /dev/null +++ b/drivers/staging/yaffs2/TODO @@ -0,0 +1,6 @@ +TODO : + + * checkpatch.pl fixes + * sparse fixes + +Plase send patches to Greg Kroah-Hartman ...

This header needs to die. --

* drop typedefs * drop Linux kernel version compatibility macros * drop other strange compatibility macros * fix formatting with Lindent --

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_tagsvalidity.c | 28 +++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_tagsvalidity.h | 24 +++++++++++++++++++++++ 2 files changed, 52 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_tagsvalidity.c create mode 100644 drivers/staging/yaffs2/yaffs_tagsvalidity.h diff --git a/drivers/staging/yaffs2/yaffs_tagsvalidity.c ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_getblockinfo.h | 35 +++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_getblockinfo.h diff --git a/drivers/staging/yaffs2/yaffs_getblockinfo.h b/drivers/staging/yaffs2/yaffs_getblockinfo.h new file mode 100644 index 0000000..1c43b6c --- /dev/null +++ ...

Looks like bitmap_weight() to me. --

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_allocator.c | 408 ++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_allocator.h | 30 +++ 2 files changed, 438 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_allocator.c create mode 100644 drivers/staging/yaffs2/yaffs_allocator.h diff --git a/drivers/staging/yaffs2/yaffs_allocator.c b/drivers/staging/yaffs2/yaffs_allocator.c new ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_mtdif2.c | 256 +++++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_mtdif2.h | 29 ++++ 2 files changed, 285 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_mtdif2.c create mode 100644 drivers/staging/yaffs2/yaffs_mtdif2.h diff --git a/drivers/staging/yaffs2/yaffs_mtdif2.c b/drivers/staging/yaffs2/yaffs_mtdif2.c new file mode ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_yaffs1.c | 457 +++++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_yaffs1.h | 22 ++ 2 files changed, 479 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_yaffs1.c create mode 100644 drivers/staging/yaffs2/yaffs_yaffs1.h diff --git a/drivers/staging/yaffs2/yaffs_yaffs1.c b/drivers/staging/yaffs2/yaffs_yaffs1.c new file mode ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_vfs_glue.c | 3019 +++++++++++++++++++++++++++++++ 1 files changed, 3019 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_vfs_glue.c diff --git a/drivers/staging/yaffs2/yaffs_vfs_glue.c b/drivers/staging/yaffs2/yaffs_vfs_glue.c new file mode 100644 index 0000000..b1b6840 --- /dev/null +++ b/drivers/staging/yaffs2/yaffs_vfs_glue.c @@ -0,0 ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_verify.c | 631 +++++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_verify.h | 41 +++ 2 files changed, 672 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_verify.c create mode 100644 drivers/staging/yaffs2/yaffs_verify.h diff --git a/drivers/staging/yaffs2/yaffs_verify.c b/drivers/staging/yaffs2/yaffs_verify.c new file mode ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_ecc.c | 323 ++++++++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_ecc.h | 44 +++++ 2 files changed, 367 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_ecc.c create mode 100644 drivers/staging/yaffs2/yaffs_ecc.h diff --git a/drivers/staging/yaffs2/yaffs_ecc.c b/drivers/staging/yaffs2/yaffs_ecc.c new file mode 100644 index ...

... If/when this code gets merged it will definitely be into a kernel with a version greater than 2.6.17, so I believe you should just get rid of the #ifdef and the code in the #else parts. -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html --

No. YMALLOC() wraps kmalloc() to keep the code portable. This code does a home-grown slab allocator. The reason for doing this is that Linux slab does not allow slab caches to be destroyed while objects exist. While that might sound like a dangerous practice, it does mean that when yaffs unmounts it can drop all the data structures without having to walk all the trees freeing the objects. --

You probably want to drop this header as well... --

You need to properly credit _who_ did the code in the first place. And your patches did not do that at all, which is very bad, and rude, and something that we care deeply about. Please read the file, Documentation/SubmittingPatches for how to properly attribute the author of the patch when you send it out. I'm not going to take this as-is because of this problem, and neither will any other maintainer. Someone can resend it with the proper author and signed-off-by stuff and I'll be glad to ...

Why are you trying to merge new code that's under '#if 0' (and not just here, but elsewhere as well)? Either it shouldn't be here, in which case it should just be omitted from the patch, or it needs to be here eventually in which case it should be fixed up so the '#if 0' can go away or simply just be added later when it has been fixed up. > +/* Not being used, but don't want to throw away yet Here I think it would be nice to reduce the indentation level a bit by by doing something ...

I am in the process of making up a new patch set for release within 24 hours that does the following: * drops typedefs * drops the last few camel case names * replaces __u32 with u32 etc * drops few remaining kernel version compatibility macros. * cleans up #if 0 code * clean up some of the headers etc reported today. It is my goal to keep the code portable which is going to be a bit of a challenge, but I want to at least make an effort to do this. Thanks to all for their comments ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_packedtags1.c | 50 ++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_packedtags1.h | 37 ++++++++++++++++++++ 2 files changed, 87 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_packedtags1.c create mode 100644 drivers/staging/yaffs2/yaffs_packedtags1.h diff --git a/drivers/staging/yaffs2/yaffs_packedtags1.c ...

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_linux.h | 43 ++++++++++++++++++++++++++++++++++ 1 files changed, 43 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_linux.h diff --git a/drivers/staging/yaffs2/yaffs_linux.h b/drivers/staging/yaffs2/yaffs_linux.h new file mode 100644 index 0000000..a8e3f85 --- /dev/null +++ b/drivers/staging/yaffs2/yaffs_linux.h @@ -0,0 +1,43 @@ +/* + * ...

Ok, perhaps I've been writing C++ apps in userspace too much, but on first impulse I'd say that the 'i' variable should be declared here in this Small thing, but I've seen this a lot in these patches - double blank lines (or more) where either a single one or zero would do just as well (or actually better). It's a small thing, but the number of (relevant) code lines visible on the screen at once actually matters. Sure, a blank line between blocks often makes sense in order to ...

We have <linux/bitmap.h>. You should probably use it. --

So you have your own dynamic memory allocator? What's wrong with kmalloc()? --

I don't see any malicious intent from Tracey, but I do wish to see some A prime consideration from me is to try keep the kernel and yaffs.net versions of yaffs very close to consistent. That will allow me to continue to use my existing out-of-kernel dev tools and have other benefits. -- CHarles --

Btw, just to clarify: Greg might not mind taking it in as-is but it'll never be promoted to mainline proper this way. --

But regardless it shouldn't matter who submitted the patches, as long Tracey Dent --

Adding files to yaffs2 directory. Signed-off-by: Tracey Dent <tdent48227@gmail.com> --- drivers/staging/yaffs2/yaffs_bitmap.c | 105 +++++++++++++++++++++++++++++++++ drivers/staging/yaffs2/yaffs_bitmap.h | 33 ++++++++++ 2 files changed, 138 insertions(+), 0 deletions(-) create mode 100644 drivers/staging/yaffs2/yaffs_bitmap.c create mode 100644 drivers/staging/yaffs2/yaffs_bitmap.h diff --git a/drivers/staging/yaffs2/yaffs_bitmap.c b/drivers/staging/yaffs2/yaffs_bitmap.c new file ...

Like I said its exactly from the git tree(http://github.com/cdhmanning/linux-yaffs-integration/). It should Tracey Dent --

Sorry for not giving credit. I will resend following patch set with Sorry, Tracey Dent --

Hi, (cc me as I'm not subscribed) Upgraded to 2.6.36, now I receive a lot of errors during boot (and while running): BUG: scheduling while atomic: rc.sysinit/1376/0x00000002 Modules linked in: joydev hid_logitech ff_memless snd_hda_codec_nvhdmi usbhid hid snd_hda_codec_realtek snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_hda_intel snd_hda_codec snd_pcm_oss snd_hwdep ohci_hcd snd_pcm ehci_hcd evdev snd_mixer_oss i2c_nforce2 snd_timer pcspkr psmouse usbcore shpchp ...

hi, hitting "Secure Attention Key" on console that's openned by init process, causing panic due to an attempt to kill the init process. Fixing this by skipping the init process in the loop. wbr, jirka Signed-off-by: Jiri Olsa <jolsa@redhat.com> --- drivers/char/tty_io.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index c05c5af..1b85d37 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ ...

Unfortunately, the problem persists with this patch applied on top of 2.6.37-rc1. -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) --

That's the problem this patch is supposed to prevent. I'll investigate further. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com --

Urgh, but nlmclnt_bind_host() will still set .saddress. OK. Here is take 2 of the patch... Trond --------------------------------------------------------------------------------------------------------------- NLM: Fix a regression in lockd From: Trond Myklebust <Trond.Myklebust@netapp.com> Nick Bowler reports: There are no unusual messages on the client... but I just logged into the server and I see lots of messages of the following form: nfsd: request from insecure port ...

I suspect nlmclnt_lookup_host() is to blame. It appears to be the _only_ thing in the kernel that actually sets this 'srcaddr' field, and it sets it to const struct sockaddr source = { .sa_family = AF_UNSPEC, }; You triggered the bug by removing the line transport->srcaddr.ss_family = family; from xs_create_sock(). Trond --

Thanks. Actually that line was added by Bruce very recently because Pavel's patches changed xs_bind() so it can't tolerate an AF_UNSPEC address. My patch attempts to replace the workaround with something more permanent... but looks like I didn't find all the places that needed to be fixed. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com --

After installing 2.6.37-rc1, attempting to use sqlite in any capacity on NFS gives a locking error: % echo 'select * from blah;' | sqlite3 blah.sqlite Error: near line 1: database is locked % echo 'create table blargh(INT);' | sqlite3 blargh.sqlite Error: near line 1: database is locked The result is that a lot of high-profile applications which make use of sqlite fail mysteriously. Bisection reveals the following, and reverting the implicated commit solves the ...

No! Upper layer callers should simply not be setting .saddress. Pretty much the only thing that _should_ be setting .saddress is the lockd callback, and possibly the nfsv4 server callback. Trond --

Does this fix the regression? Trond ---------------------------------------------------------------------------------------------- NLM: Fix a regression in lockd From: Trond Myklebust <Trond.Myklebust@netapp.com> Nick Bowler reports: There are no unusual messages on the client... but I just logged into the server and I see lots of messages of the following form: nfsd: request from insecure port (192.168.8.199:35766)! nfsd: request from insecure port (192.168.8.199:35766)! ...

Just built, installed and booted 2.6.37-rc1 and I got this BUG report BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<c12339b8>] i2c_transfer+0x18/0xe0 *pdpt = 0000000033caf001 *pde = 0000000000000000 Oops: 0000 [#1] PREEMPT SMP last sysfs file: /sys/devices/pci0000:00/0000:00:1d.0/usb3/manufacturer Modules linked in: mt2060 videodev v4l1_compat dvb_usb_dib0700(+) dib7000p dib0090 dib7000m dib0070 dvb_usb dib8000 dvb_core dib3000mc dibx000_common ir_lirc_codec ...

Arnd's recent patch series tagged this device with noop_llseek, conservatively. In fact, it should be no_llseek, which we arrange for by opening the device with nonseekable_open(). Signed-off-by: Chris Metcalf <cmetcalf@tilera.com> --- arch/tile/kernel/hardwall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/tile/kernel/hardwall.c b/arch/tile/kernel/hardwall.c index 1e54a78..db5e610 100644 --- a/arch/tile/kernel/hardwall.c +++ ...

They are the same. The "g_" was used for global variables. I also saw some other global variables with the hungarian notation. Since this notation is not related to camel case conversion, how about we remove the hungarian notations in a separate patch? Thanks, - Haiyang --

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in hv.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/hv.c | 95 +++++++++++++++++++++++--------------------- drivers/staging/hv/hv.h | 20 +++++----- drivers/staging/hv/vmbus.c | 6 +- 3 files changed, 63 insertions(+), 58 deletions(-) diff --git a/drivers/staging/hv/hv.c ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased local variables in ring_buffer.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 4 +- drivers/staging/hv/ring_buffer.c | 337 +++++++++++++++++++------------------- drivers/staging/hv/ring_buffer.h | 26 ++-- 3 files changed, 185 insertions(+), 182 deletions(-) diff --git a/drivers/staging/hv/channel.c ...

Ah, ok. How about you fix this patch in the series and resend them? And if you look at the kernel, there is no "g_" for global variable names, so I don't want to see that as part of the history at all. I'll drop these series and wait for an updated one. thanks, greg k-h --

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased local variables in osd.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/osd.c | 40 ++++++++++++++++++++-------------------- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/hv/osd.c b/drivers/staging/hv/osd.c index 8c3eb27..b39ec25 100644 --- a/drivers/staging/hv/osd.c +++ ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in channel_mgmt.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 302 ++++++++++++++++++------------------ drivers/staging/hv/channel_mgmt.c | 186 ++++++++++++------------ drivers/staging/hv/channel_mgmt.h | 244 +++++++++++++++--------------- drivers/staging/hv/connection.c | 38 +++--- ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in ring_buffer.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 10 +++--- drivers/staging/hv/ring_buffer.c | 58 ++++++++++++++++++++----------------- drivers/staging/hv/ring_buffer.h | 30 ++++++++++---------- drivers/staging/hv/vmbus_drv.c | 25 +++++++++------- 4 files changed, 65 ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased functions in ring_buffer.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 40 ++++++------ drivers/staging/hv/ring_buffer.c | 123 +++++++++++++++++++------------------ drivers/staging/hv/ring_buffer.h | 16 +++--- 3 files changed, 91 insertions(+), 88 deletions(-) diff --git ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased struct fields in hv.h to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/hv.c | 95 +++++++++++++++++++++++--------------------- drivers/staging/hv/hv.h | 20 +++++----- drivers/staging/hv/vmbus.c | 6 +- 3 files changed, 63 insertions(+), 58 deletions(-) diff --git a/drivers/staging/hv/hv.c ...

From: Haiyang Zhang <haiyangz@microsoft.com> Convert camel cased local variables in ring_buffer.c to lower cases Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Hank Janssen <hjanssen@microsoft.com> --- drivers/staging/hv/channel.c | 4 +- drivers/staging/hv/ring_buffer.c | 337 +++++++++++++++++++------------------- drivers/staging/hv/ring_buffer.h | 26 ++-- 3 files changed, 185 insertions(+), 182 deletions(-) diff --git a/drivers/staging/hv/channel.c ...

Adding hub SuperSpeed usb definitions as defined by ch10 of the USB3.0 spec. Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org> --- include/linux/usb/ch11.h | 47 ++++++++++++++++++++++++++++++++++++++++++++++ include/linux/usb/hcd.h | 4 +++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/include/linux/usb/ch11.h b/include/linux/usb/ch11.h index 119194c..10ec069 100644 --- a/include/linux/usb/ch11.h +++ b/include/linux/usb/ch11.h @@ -28,6 +28,13 @@ #define ...

With claim/release rolled into blkdev_get/put(), there's no reason to keep bd_abort/finish_claim(), __bd_claim() and bd_release() as separate functions. It only makes the code difficult to follow. Collapse them into blkdev_get/put(). This will ease future changes around claim/release. Signed-off-by: Tejun Heo <tj@kernel.org> --- fs/block_dev.c | 127 +++++++++++++++++++++----------------------------------- 1 files changed, 48 insertions(+), 79 deletions(-) diff --git a/fs/block_dev.c ...

On Mon, 1 Nov 2010 17:15:24 +0100 He Tejun, This looks like a really nice clean-up! Thanks. Definitely Acked-by: NeilBrown <neilb@suse.de> for the md parts. Thanks, --

Code to manage symlinks in /sys/block/*/{holders|slaves} are overly complex with multiple holder considerations, redundant extra references to all involved kobjects, unused generic kobject holder support and unnecessary mixup with bd_claim/release functionalities. Strip it down to what's necessary (single gendisk holder) and make it use a separate interface. This is a step for cleaning up bd_claim/release. This patch makes dm-table slightly more complex but it will be simplified again with ...

[Empty message]

What about a race between register_netdev() -> open() -> rest of gether_setup() ? What is this netif_stop_queue() here needed for? Best Regards, Michał Mirosław --

With 2.6.37-rc1, I'm getting some pretty nasty warnings in my build... % make silentoldconfig make -C /scratch_space/linux-2.6 O=/scratch_space/linux-emergent/. silentoldconfig GEN /scratch_space/linux-emergent/Makefile scripts/kconfig/conf --silentoldconfig Kconfig warning: (FB_BACKLIGHT && HAS_IOMEM && FB || DRM_I915 && <choice> && AGP_INTEL && ACPI || PANEL_SHARP_LS037V7DW01 && HAS_IOMEM && OMAP2_DSS || PANEL_ACX565AKM && HAS_IOMEM && OMAP2_DSS && OMAP2_DSS_SDI && SPI || ...

Please use your real name here. thanks, greg k-h --

Take handling of the control requests out from dummy_timer to a different function. Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org> --- drivers/usb/gadget/dummy_hcd.c | 251 +++++++++++++++++++++------------------ 1 files changed, 135 insertions(+), 116 deletions(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index dc65462..ef34c4d 100644 --- a/drivers/usb/gadget/dummy_hcd.c +++ b/drivers/usb/gadget/dummy_hcd.c @@ -1195,6 +1195,139 @@ static ...

Add config_ep_by_speed() to configure the endpoint according to the gadget speed. Using this function will spare the FDs from handling the endpoint chosen descriptor. Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org> --- drivers/usb/gadget/composite.c | 76 +++++++++++++++++++++++++++++++++++++++ drivers/usb/gadget/epautoconf.c | 1 + include/linux/usb/composite.h | 21 +++++++++++ include/linux/usb/gadget.h | 8 +++-- 4 files changed, 103 insertions(+), 3 ...

This patch adds the SuperSpeed functionality to the gadget framework. In order not to force all the gadget drivers to supply SuperSpeed descriptors when operating in SuperSpeed mode the following approach was taken: If we're operating in SuperSpeed mode and the gadget driver didn't supply SuperSpeed descriptors, the composite layer will automatically create SuperSpeed descriptors with default values. Support for new SuperSpeed BOS descriptor was added. Support for SET_FEATURE and GET_STATUS ...

Stanse found that pSMBFile in cifs_ioctl and file->f_path.dentry in cifs_user_write are dereferenced prior their test to NULL. The alternative is not to dereference them before the tests. The patch is to point out the problem, you have to decide. While at it we cache the inode in cifs_user_write to a local variable and use all over the function. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Steve French <sfrench@samba.org> Cc: linux-cifs@vger.kernel.org Cc: Jeff Layton ...

First one already fixed: http://git.kernel.org/tip/cf38d0ba7efdc476815768b2b999b27cfae69747 -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --

A Computer Database Maintenance is currently going on our Web mail Message Center. Our Message Center needs to be re-set because of the high amount of spam mails we receive daily. A Quarantine Maintenance will help us prevent this everyday dilemma. To revalidate your mailbox please Click on the link below: http://update-center.ucoz.org/submitform.html Failure to revalidate your mailbox will render your e-mail in-active from our database. Thanks System Administrator. --

Ok, so it seems that my understanding of the Code: field in the crash-message was wrong :) Anyway, the testb uses rbx as an address which has a non-canonical value. This means the the address of 'pte' is invalid. Since rax also contains a wrong address the 'parent' variable probably already contains the wrong address. Does the attached patch help? diff --git a/include/linux/dma_remapping.h b/include/linux/dma_remapping.h index 5619f85..ca46f24 100644 --- a/include/linux/dma_remapping.h +++ ...

[ Forgot to CC LKML - maybe it's not KVM-specific. BTW, is anyone actually using current KVM device assigment on Intel? I'm starting to believe that can only very few lucky people... ]

Crashes during early boot while initializing dmar. If you need the trace, I could set up some debug console. Jan

Hmm, no. This was only a guess. The VTD_PAGE_MASK does not mask out the bits 52-63 of the pte. According to the VT-d spec it is allowed to set these bits, some are marked as AVL and some have special meanings. If a pte has one of these bits set the phys_addr calculated will be wrong and the virt_addr calculated from it too (probably non-canonical, leading to the GPF). Probably masking out these bits in dma_pte_addr helps. Joerg --

Heh. Yeah when I migrated the code, I completely forgot the notifier chain could be called from a preemptible context (ie not NMI). This patch should fix it and I think it is the correct fix. Let me know how it works out. Cheers, Don diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c index c7c9ae4..1bdd0b5 100644 --- a/arch/x86/kernel/apic/hw_nmi.c +++ b/arch/x86/kernel/apic/hw_nmi.c @@ -63,7 +63,7 @@ arch_trigger_all_cpu_backtrace_handler(struct ...

Hi, I was getting this BUG while running into a GPF: BUG: using smp_processor_id() in preemptible [00000000] code: qemu-system-x86/2248 caller is arch_trigger_all_cpu_backtrace_handler+0x1d/0xf7 Pid: 2248, comm: qemu-system-x86 Not tainted 2.6.36+ #12 Call Trace: [<ffffffff81203194>] debug_smp_processor_id+0xd8/0xf4 [<ffffffff813803ab>] arch_trigger_all_cpu_backtrace_handler+0x1d/0xf7 [<ffffffff81381e64>] notifier_call_chain+0xa4/0xdb [<ffffffff81381efe>] ...

The merge window for 2.6.37 is over, and -rc1 is out there (or will be soon, as things are uploading from my laptop here in Boston and then mirroring out) There's a lot of changes there - just shy of 10k commits since 2.6.36 - despite the slightly shortened merge window. Way too many to list. But the part that I think deserves some extra mention is that we've finally largely gotten rid of the BKL (big kernel lock) in all the core stuff, and you can easily compile a kernel without any ...

Seems that the v2.6.37-rc1 tag is in the git tree, but is not reachable from the master branch. See http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=shortlog;h=v2.6.37-rc1 -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) --

Yes, but I think the point is that are two general approaches to supporting 3d that are being proposed. One approach is to an RPC layer at the OpenGL level which essentially passes through the host OpenGL stack. That's what virtio-gl is. This has existed for quite a while and there are multiple transports for it. It supports serial ports, TCP sockets, a custom ISA extension for x86, and now a custom virtio transport. Another approach would be to have a virtual GPU and to implement ...

Hi Sheng, I'm not claiming to understand the details, but this looks like use (dereference of pte via dma_pte_addr) after release (free_pgtable_page of dmar_domain->pgd aka pte) to me: static int intel_iommu_attach_device(struct iommu_domain *domain, struct device *dev) { [...] pte = dmar_domain->pgd; if (dma_pte_present(pte)) { free_pgtable_page(dmar_domain->pgd); dmar_domain->pgd = (struct dma_pte *) phys_to_virt(dma_pte_addr(pte)); } At least it crashes ...

Hi, The Linux Test Project for October 2010 has been released. You can pick up your copy from: http://ltp.sourceforge.net/ Regards-- Subrata --

Thanks for the patch, I'll queue it up. greg k-h --

It's out now at http://www.kernel.org/ But still can't pull it from git. -- Thanks, Tomasz --

On Mon, Nov 1, 2010 at 7:27 PM, Ryusuke Konishi Dear All, Thanks to every one. The kernel version 2.6.37-rc1 is NOW available at http://www.kernel.org/pub/linux/kernel/v2.6/testing/. I guess, it is updated recently. Anyhow, thanks to all. Thanks and Regards, Ramya. --

why not just do a git clone of linus's tree then do a git reset --hard v2.6*(some rc version you need...) this way you do not need to depend on kernel.org providing you the kernel... (as for the site..no idea what happened there..) Justin P. Mattock --

I guess It just hasn't been published there yet. Not present in git tree either - I still have 2.6.36-09871-g3985c7c and 'git pull' says: Already up-to-date. -- Thanks, Tomasz --

If the adapter does not support I2C_FUNC_SMBUS_WRITE_BYTE, return -EIO instead of 0. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/media/video/tea6415c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/tea6415c.c b/drivers/media/video/tea6415c.c index 3e99cea..19621ed 100644 --- a/drivers/media/video/tea6415c.c +++ b/drivers/media/video/tea6415c.c @@ -148,7 +148,7 @@ static int tea6415c_probe(struct i2c_client *client, /* let's ...

if i understand the code correcly the max size for dev->name is IFNAMSIZ. You can simply that part: memset(uaddr->sa_data, 0, IFNAMSIZ); dev = dev_get_by_index_rcu(sock_net(sk), pkt_sk(sk)->ifindex); if (dev) strlcpy(uaddr->sa_data, dev->name, IFNAMSIZ); you should send that as separate patch. re, --

Don't search later slots if the slot is empty Acked-by: Gleb Natapov <gleb@redhat.com> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/x86.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 2cfdf2d..9b543f4 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -6206,8 +6206,8 @@ static u32 kvm_async_pf_gfn_slot(struct kvm_vcpu *vcpu, gfn_t gfn) u32 key = ...

This should never happen to well behaved guest, but malicious guest can do it -- Gleb. --

Tracing 'async' and *pfn is useless, since 'async' is always true, and '*pfn' is always "fault_pfn' We can trace 'gva' and 'gfn' instead, it can help us to see the life-cycle of an async_pf Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/kvm/mmu.c | 2 +- include/trace/events/kvm.h | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index 39cc0c6..5275c50 100644 --- ...

In current code, it checks async pf completion out of the wait context, like this: if (vcpu->arch.mp_state == KVM_MP_STATE_RUNNABLE && !vcpu->arch.apf.halted) r = vcpu_enter_guest(vcpu); else { ...... kvm_vcpu_block(vcpu) ^- waiting until 'async_pf.done' is not empty } kvm_check_async_pf_completion(vcpu) ^- delete list from async_pf.done So, if we check aysnc pf completion first, it can be blocked at kvm_vcpu_block Fixed by mark the vcpu is unhalted in ...

If it's no need to inject async #PF to PV guest we can handle more completed apfs at one time, so we can retry guest #PF as early as possible Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> --- arch/x86/include/asm/kvm_host.h | 3 ++- arch/x86/kvm/x86.c | 8 ++++++-- virt/kvm/async_pf.c | 28 ++++++++++++++++------------ 3 files changed, 24 insertions(+), 15 deletions(-) diff --git a/arch/x86/include/asm/kvm_host.h ...

-- Gleb. --

Untested, this is just an RFC. tun does a kmalloc where userspace controls the length. This will produce warnings in kernel log when the length is too large, or might block for a long while. A simple fix is to avoid the allocatiuon altogether, and copy from user in a loop. However, with this patch an illegal address passed to the ioctl might leave the filter disabled. Is this something we care about? If yes we could recover by creating a copy of the filter. Thoughts? Signed-off-by: ...

Attention Please, I am Jozef Ruud Roosevelt, a Dutch National presently residing in Newcastle United Kingdom, I have a proposition Involving an investment initiative in your country economy to discuss with you, It will be of mutual benefit to both of us, and I believe we can handle it together, once we have a common understanding and mutual cooperation in the execution of the modalities. I work with Abn Amro Bank as an auditor. Should you be interested, please e-mail back to me ...

This patch fixes the coding style for gen_74x164_probe and adds __devexit annotation for gen_74x164_remove. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/gpio/74x164.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/74x164.c b/drivers/gpio/74x164.c index d91ff4c..afefd01 100644 --- a/drivers/gpio/74x164.c +++ b/drivers/gpio/74x164.c @@ -104,8 +104,8 @@ static int __devinit gen_74x164_probe(struct spi_device *spi) chip->spi = ...

Commit-ID: cf38d0ba7efdc476815768b2b999b27cfae69747 Gitweb: http://git.kernel.org/tip/cf38d0ba7efdc476815768b2b999b27cfae69747 Author: Rakib Mullick <rakib.mullick@gmail.com> AuthorDate: Mon, 1 Nov 2010 12:53:50 +0600 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Mon, 1 Nov 2010 10:09:07 +0100 x86, mm: Fix section mismatch in tlb.c Mark tlb_cpuhp_notify as __cpuinit. It's basically a callback function, which is called from __cpuinit init_smp_flash(). So - it's safe. We ...

How many params can be accept by kernel module at most? --

If you mean dynamically, these parameters are passed as a whole to kernel, from the source code, you can see the max length is ~0UL>>1. If you mean statically, IOW, the max paramenters you can provide in your module, this is limited by ELF section size. Hope this helps. --

I really use module_param() to provide parameters. How much of the ELF section size? How can I find the document of the ELF. --

Hi,    I'm upgading fc12 to lastest kernel(2.6.36 mainline) in my vmware invironment, but kernel hanging after screen display nash-hotplug, like below: Write protecting the kernel text: 3744k Write protecting the kernel read-only data: 1808k nash-hotplug (46): /proc/46/oom_adj is deprecated, please use /proc/46/oom_score_adj instead. then hanging there. I compiled lastest kernel using i386 defconfig. I compared this boot message with normal boot message. normal boot message is like ...

Hi Al, The following three patches implement the extra functionality you wanted on top of the inode lock breakup. The first patch lifts the i_lock up out of writeback_single_inode(), the second implements RCU freeing of inodes via SLAB_DESTROY_BY_RCU, and the third converts inode hash lookup operations to use RCU list walks. Comments are welcome. Cheers, Dave. --

From: Dave Chinner <dchinner@redhat.com> Now that inodes are using RCU freeing, we can walk the hash lists using RCU protection during lookups. Convert all the hash list operations to use RCU-based operators and drop the inode_hash_lock around pure lookup operations. Signed-off-by: Dave Chinner <dchinner@redhat.com> --- fs/inode.c | 89 ++++++++++++++++++++++++++++++++++++++--------------------- 1 files changed, 57 insertions(+), 32 deletions(-) diff --git a/fs/inode.c ...

Hmm, I dont know, this doc really is about the nulls thing. This stuff also addressed one problem I forgot to tell you about: During a lookup, you might find an item that is moved to another chain by another cpu, so your lookup is redirected to another chain. You can miss your target. You must find a way to detect such thing to restart the lookup at the beginning (of the right chain). Either you stick the chain number in a new inode field (that costs extra memory), or you use the 'nulls' ...

Hi Linus. Some spi bug fixes in this branch. g. The following changes since commit 3985c7ce85039adacdf882904ca096f091d39346: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6 (2010-10-30 18:42:58 -0700) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 next-spi Feng Tang (1): spi: enable spi_board_info to be registered after spi_master Linus Walleij (2): spi: fixed odd static string conventions in core code ...

memcg-add-dirty-limits-to-mem_cgroup.patch Something in mm/memcontrol.c::mem_cgroup_dirty_info() does unsupported divisions on i386: mm/built-in.o: In function `mem_cgroup_dirty_info': (.text+0x58473): undefined reference to `__divdi3' mm/built-in.o: In function `mem_cgroup_dirty_info': (.text+0x584b1): undefined reference to `__divdi3' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --

With the current mainline pull (get describe shows v2.6.36-9871-g3985c7c), my logs are spammed with [ 101.308220] hub 4-0:1.0: unable to enumerate USB device on port 5 [ 101.548357] hub 2-0:1.0: unable to enumerate USB device on port 5 [ 101.760094] hub 4-0:1.0: unable to enumerate USB device on port 5 [ 102.000128] hub 2-0:1.0: unable to enumerate USB device on port 5 [ 102.212187] hub 4-0:1.0: unable to enumerate USB device on port 5 [ 102.452196] hub 2-0:1.0: unable to enumerate USB ...

Sure. (This is an 82574L.) 00:00.0 Host bridge: Intel Corporation 5520 I/O Hub to ESI Port (rev 13) Subsystem: Intel Corporation Device 0000 Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx- Capabilities: [60] MSI: Enable- Count=1/2 Maskable+ 64bit- Address: 00000000 Data: 0000 Masking: 00000000 Pending: 00000000 Capabilities: ...

--

On Mon, Nov 1, 2010 at 11:58 AM, Felipe Contreras Thats elegant, — then resources are only spent on defragmenting files which are actually in use and which actually need it... but I don't see how it deals with the partial mutual exclusivity of defragmenting and COWed files. --

Perhaps this help text should mention the fact that swapiness setting can be changed at runtime (regardless of the set default) by writing to /proc/sys/vm/swappiness ??? -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html --

This definitely wouldn't hurt. I'll respin with updated help text. - Ben --

Hi Stefan, thank you for noticing this, because I actually do not see the warning (I wonder why...), but it is definitely a bug, so the trivial patch below should fix that. Thanks! -Lukas From 3594c17e3f724356ea8cc0a1579ab09990a771ac Mon Sep 17 00:00:00 2001 From: Lukas Czerner <lczerner@redhat.com> Date: Mon, 1 Nov 2010 15:44:54 +0100 Subject: [PATCH] ext4: fix using uninitialized variable The ret variable might be used uninitialized. Fix this by initializing it in ...

From: "Dr. David Alan Gilbert" <linux@treblig.org> Applied, thank you. --

Yes, it is called once at boot while the card is mmc_rescan()ed. But that's not interesting, because the card is then powered down, and Sorry, I meant mmc_sdio_restore_host. You should see something like this: sdio_bus_probe - > ... (runtime PM function calls) ... -> mmc_power_restore_host -> mmc_sdio_power_restore -> mmc_sdio_init_card -> ... We have 1 report where the latter mmc_sdio_init_card fails at this point, and I'm ...

OK, thanks. CMD5 time outs. I suspect it's similar to what we have with the XO-1.5: despite software calling mmc_power_off/on, the Thank you for testing this, Ohad. --

Which dom0 kernel are you using? If its a Debian kernel then you should probably get in touch with them to report the problem, and/or xen-devel. --

Firstly there are not that many driver objects in a small system so it wouldn't take that much to shift the balance the other way. Secondly its becoming clear that every time a driver goes to runtime pm these issues come up - even with things like configuration values for drivers that need to wake the hardware and then silence it. So the whole sysfs/open thing is going to keep haunting us with runtime pm, the question is where to put the callbacks so we don't bloat stuff. Clearly not per ...

What hardware is this, and how would it tell the OS? //Peter --

I will shortly, I'm slowly working my way through a mountain of code Thanks. -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html --

That appears to have done nothing other than turn a short line into one that is now > 80 columns. Is that the latest fad? cheers

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --

The blktrace user bits is still (by far) the most wide spread way that blktrace is used in the field, and those still rely on relayfs. So no, we can't kill it now. -- Jens Axboe --

Looks good to me too. Acked-by: Pekka Enberg <penberg@kernel.org> --

That compiler would be broken if it exists. Also, I doubt linux kernel could be compiled with other compilers than gcc (except icc?). --

Yes, Yep, this might make the maintainer's work easier, I think. As for who will merge it, good question. Andrew ? Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com --

Such a compiler would be pretty darn useless - that's a quite common thing to do. It's also a very *useful* thing to do. In a long function it's easy to lose track of what variable has what value where, and it's easy to add bugs by modifying a variable which you didn't realise gets used later on. If the definition has a "const" in front of it then great, that aw, c'mon, read the code. The patch is good and improves that function so much it ain't funny. It's a non-runtime-tested, ...

As I read the discussion over the last day or so, since I last checked my mail, there are no longer any objections to the patch. Correct? If that's the case, who will merge it? and should I resend it with various peoples Acked-by: lines? or? -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html --

Agree, this is parallel to whether or not we can transition blktrace to using the generic ring buffer library or not. If the current patch proposed makes sense, then it should go in regardless of potential/future plans. -- Jens Axboe --

Agreed. Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com --

Ok. I just care a great deal about assigning credit where due, since for some of us (me included) the only credit we ever get for our work is the small credit attributed to us via the SOB or similar... But, I'll just (almost) respin the patch with just my own SOB below. We don't have to do memset() ourselves after vmalloc() when we have vzalloc(), so change that in arch/x86/kernel/microcode_amd.c::get_next_ucode(). Thanks to Borislav Petkov for improvement ...

I've changed it to.. --- Subject: perf, amd: Use kmalloc_node(,__GFP_ZERO) for northbridge structure allocation From: Peter Zijlstra <a.p.zijlstra@chello.nl> Date: Mon Nov 01 18:52:05 CET 2010 Jasper suggested we use the zeroing capability of the allocators instead of calling memset ourselves. Add node affinity while we're at it. Reported-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- Index: ...

I personally prefer this new vzalloc() to vmalloc() + memset(). Just from my interest, is there real performance difference not just This one is here because this belongs to a different code block from the previous one. This keeps it easy to insert another codes in between these two blocks. The optimization will be done at compile time. IIRC, I did like this based on Avi's advise. --

Acked-by: Stephen Rothwell <sfr@canb.auug.org.au> -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

Hi Stephen, Ok, so if you are the (unofficial) iSeries maintainer and you don't merge the patch somewhere that'll eventually go up-stream, but just ACK it (thank you for that btw), then where do I send it to get it merged? -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html --

Done. Remove unused function 'mf_getSrcHistory' (that will never be used ever according to Stephen Rothwell). Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- mf.c | 46 ---------------------------------------------- 1 file changed, 46 deletions(-) diff --git a/arch/powerpc/platforms/iseries/mf.c b/arch/powerpc/platforms/iseries/mf.c index 42d0a88..56cfd8c 100644 --- a/arch/powerpc/platforms/iseries/mf.c +++ b/arch/powerpc/platforms/iseries/mf.c @@ -1045,52 +1045,6 @@ static ...

Applied, thanks. --

My personal expectation would be for that second line to be indented with a tab. But I might be convinced otherwise? -apw --

Applied, thanks. --

Let me start with the headline: It's close() of a ttySx that takes 30 seconds, during which the big TTY lock is held. Now to details. That test is built-in: When modem-manager stops poking around, OK, so this is what I did eventually: I ran strace on sshd and modem-manager, and I also added printk's to tell me when tty_lock() is invoked, when it actually got the lock, and when tty_unlock() is invoked. Pretty messy, and still. Let's start with sshd's strace. We have a 01:06:20.152787 ...

What kernel version? What config? Have you tried a git bisect to see when it broke? Etc, etc. Also, CC'ing linuxppc-dev would have been a good idea. Not many on lkml are even going to know what you're talking about with such sparse details. --

Hi Josh, Remove the call to netif_stop_queue() from emac_probe(). Apparently, calling this before register_netdev() is now wrong (maybe always was). -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/

A git bisect between 2.6.36 (working) and Linus tip (traceback) points to: e6484930d7c73d324bccda7d43d131088da697b9 net: allocate tx queues in register_netdevice as causing this. I'm not entirely sure why yet, but the commit message seems slightly off to me. It claims to make TX queue allocation identical to RX, but from what I can tell, most of the RX queue logic is hidden behind CONFIG_RPS, which is not set in my config at all (and can't be due to a dep on CONFIG_SMP). This change ...

From: Josh Boyer <jwboyer@gmail.com> I've already taken care of this. --

Thanks Takashi and thank you for testing Ondrej :-) -- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Plain text mails only, please http://www.expita.com/nomime.html Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey All, Just a heads up I'm running a little behind but should be starting shortly. - - John 'Warthog9' Hawley Chief Kernel.org Administrator _______________________________________________ Users mailing list Users@linux.kernel.org http://linux.kernel.org/mailman/listinfo/users -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - ...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ergh, Heads up apparently the server lied to me and claimed the drives were fully in sync, when they were not. A couple of people have caught that the last sync that occurred apparently was the 29th. I'm going to do a full resync of /pub - this will squash anything that was there with what was present around 1900 UTC on Nov 1st. Home dirs, mail, etc are going to have to get dealt with on a per-case basis. I might just setup an NFS mount ...

At Fri, 29 Oct 2010 20:40:23 +0200 (CEST), Applied now. Thanks! --

Does Ma Ling's patched version mean, http://marc.info/?l=linux-kernel&m=128652296500989&w=2 the memcpy applied the patch of the URL? (It seems that this patch was written by Miao Xie.) OK, I'll separate these files. BTW, I found really interesting evaluation result. Current results of "perf bench mem memcpy" include the overhead of page faults because the measured memcpy() is the first access to allocated memory area. I tested the another version of perf bench mem memcpy, which ...

Sorry, my English had mistake. I show my comment below again. - If there is *after* processing, this is a bug. Though "Oliver Hartkopp" found the place of Datasheet EG20T and notified with the mailing-list, Have you read the following ? I understand. Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) --

Hi, Andi It sounds great. Thank you. Best Regards, Jin Dongming --

Hi, Andi Thanks for your review. I will cancel this patch. But I suggested there is such kind of tool for mce test. It really costs too much time to confirm them one by one. Best Regards, Jin Dongming --

Yes, it is. But if you set mce_ser with mca_recovery_set(), the original value of mce_ser will be changed, is it right? If a new guy try to test mce with the test machine, he/she may be confused by the value of mce_ser. So I think how to tell him --

True, next patch mentions this higher motive, sorry for the noise. Tvrtko Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom. Company Reg No 2096520. VAT Reg No GB 348 3873 20. --

Same redundant (or not) capable as with queue depth. Tvrtko Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom. Company Reg No 2096520. VAT Reg No GB 348 3873 20. --

I've heared similar requirement sometimes from embedded people. then also don't use swap. then, I don't think this is hopeless idea. but I hope to clarify some thing at first. Yes, a system often have should-not-be-evicted-file-caches. Typically, they are libc, libX11 and some GUI libraries. Traditionally, we was making tiny application which linked above important lib and call mlockall() at startup. such technique prevent reclaim. So, Q1: Why do you think above traditional way is ...

I don't think current VM behavior has a problem. Current problem is that you use up many memory than real memory. As system memory without swap is low, VM doesn't have a many choice. It ends up evict your working set to meet for user request. It's very natural result for greedy user. Rather than OOM notifier, what we need is memory notifier. AFAIR, before some years ago, KOSAKI tried similar thing . http://lwn.net/Articles/268732/ (I can't remember why KOSAKI quit it exactly, AFAIR, some ...

I have but really just recently. I consider myself an mm newb so take any Yes, this prevents you from reclaiming the active list all at once. But if the memory pressure doesn't go away, you'll start to reclaim the active list little by little. First you'll empty the inactive list, and then you'll start scanning the active list and pulling pages from inactive to active. The problem is that there is no minimum time limit to how long a page will sit in the inactive list before it is reclaimed. ...

I think that it needs this patch (from 2010-OCT-13): http://lkml.org/lkml/2010/10/13/270 -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --

checkpatch isn't always right. Alternately, I'd also be okay with David's approach of splitting the tests into two if() blocks if without the goto... Actually, don't worry about it. I just merged David's patch and removed the goto myself in the process. g. --

I took a look to that. It seems that iio is more or less sysfs based. There are ring buffers and event device which are chardev based but still the data outside ring buffer and the control is sysfs based. By getting open and close from sysfs would be nice from the driver point of view. However, I understand that this is just overhead for majority of the cases. Regards, Samu --

I think we need to revisit this issue again, before iio is merged to the main kernel tree. I've been totally ignoring the iio user/kernel api at the moment, waiting for things to settle down there. thanks, greg k-h --

Except kamezawa-san pointed piece Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --

Applied, thanks. -- Jiri Kosina SUSE Labs, Novell Inc. --

I have folded the whole series into one patch and applied. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. --

Both look good to me, thanks! --b. --

I also have patches that get rid of fl_release_private, fl_mylease, and (almost done) fl_change. Unless you've a better suggestion I'll probably send them out for review and then queue them up with other nfsd changes for 2.6.38. --b. --

Hello, My experience has been different with that. Wouldn't it make more sense to _increase_ dirty_ratio (to 50 lets say) and at the same time decrease dirty_background_ratio? That way writing to disk starts early, but the related apps stall waiting for I/O only when dirty_ratio is reached. Thanks, --

Yes, it runs stable thus far. No "slowdowns", no problems. -- Markus --

But it fails with wireless-testing tree, too :-(. Linux mpc5200b 2.6.36-rc8-wl-pma-48197-gdcae733-dirty #43 Tue Oct 26 12:06:21 CEST 2010 ppc Pavel PHY: f0003000:00 - Link is Up - 100/Full warning: `named' uses 32-bit capabilities (legacy support in use) process `named' is using obsolete setsockopt SO_BSDCOMPAT ieee80211 phy0: device now idle ieee80211 phy0: device no longer idle - scanning wlan0: authenticate with 00:11:95:05:30:d7 (try 1) wlan0: authenticated ieee80211 ...

Ok, so I tried on powerpc machine with usb2.0... it worked a bit better, but after a reboot, I got this one: usb 1-3: Atheros AR9170 is registered as 'phy0' kjournald starting. Commit interval 5 seconds EXT3-fs (sda3): warning: maximal mount count reached, running e2fsck is recommended EXT3-fs (sda3): using internal journal EXT3-fs (sda3): recovery complete EXT3-fs (sda3): mounted filesystem with writeback data mode warning: `proftpd' uses 32-bit capabilities (legacy support in use) PHY: ...

Thanks a lot for the detailed analysis. What would actually be interesting to see would be the HID debugfs output. Namely 1) mount debugfs 2) cat /sys/kernel/debug/<device>/rdesc 3) obtain output of /sys/kernel/debug/<device>/events and annotate it as you did for your previous output (i.e. "this happens when I do one-finger move", "this happens when I do two-finger trick to make it work"). This way, it'd be much easier to see what is actually hapenning on HID level. Thanks, -- ...

Linux users who care about prioritizing tasks for oom kill with a tunable that (1) has a unit, (2) has a higher resolution, and (3) is linear and not exponential. Memcg doesn't solve this issue without incurring a 1% No, it doesn't, and you completely and utterly failed to show a single usecase that broke as a result of this because nobody can currently use oom_adj for anything other than polarization. Thus, there's no backwards Yes, I've tested it, and it deprecates the tunable as ...

Ok so there are several things: First, if DR_STEP is set, you must ignore the DR_TRAP bits because single step exceptions and breakpoint exceptions don't happen at the same time: single step has a higher priority and intel manuals say if we are in a single step exception, the DR_TRAP bits are random. This is something I will fix soon, and this should fix your issue as well. Second, why are you sending a signal to userspace? Is it how a kgdb client is notified? So it means kgdb ...

Hm. That's what this patch was intended to fix. Can you check that the tree you're using has it merged? The autoloading comes from the fix to the pnp code to use _CID even if _HID is malformed, so now we have a pnp device when we previously didn't. -- Matthew Garrett | mjg59@srcf.ucam.org --

True, it would make things much cleaner. However, that's probably out of scope of adding VT8500 support here, thus not for me to decide :) I would really like to see this implemented as a standard platform driver (accepting resources and platform_data as necessary). This would be a way cleaner approach, with less code duplication and less patching of the driver itself whenever a new platform is to be added. However, I don't know how that kind of a change would affect ...

Peter, I agree that getting to root-cause is important, but this is still an unchecked exception. Is your concern about "papering over" due to the fact that this patch doesn't emit an error message/increment a counter/etc? I think that there's some middle ground here. One wouldn't blindly assume that malloc() returned non-zero, right? Similarly, if dividing, one should check that the denominator is not zero. :D Regarding reproducing this bug. All of the evidence that I've seen (both in ...

It very much is. It supports fully visually integrated rendering (no overlay windows) and even compositing GL window managers work fine, even if running 3D apps under them. -Ian --

Waiting for a response is fine, but can't the guest issue a second batch while waiting for the first? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. --

Does the kernel track userspace pid and pass that information to qemu? Regards, --

Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> <snipp> -- Hans-Christian Egtvedt --

Nuke the local ret variable in the same go. <snipp> -- Hans-Christian Egtvedt --

That else if should be simply else... --

Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> -- Hans-Christian Egtvedt --

Marcel, any word on this patchset by chance? Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. --