On Fri, 8 Oct 2010, Thomas Gleixner wrote:

quoted text
> On Wed, 6 Oct 2010, Yinghai Lu wrote:
> > On 10/06/2010 09:01 PM, Thomas Gleixner wrote:
> > > Well, I'm not too happy about this preallocated stuff anyway, which is
> > > the reason for the warning below.
> > >  
> > >> [   80.726176] WARNING: at drivers/pci/intr_remapping.c:67 irq_2_iommu_alloc+0x52/0xdc()
> > >> [   80.745935] Hardware name: Sun Fire X4800
> > >> [   80.746179] irq_2_iommu!=NULL irq 8
> > > 
> > 
> > no, irq_2_iommu are all dynamically allocated even for irq < 16.
> 
> I know. I was talking about the preallocated irq descriptors and the
> handling of it in general.
> 
> Nevertheless, that irq_2_iommu stuff does not need it's own allocation
> function. It's bound to a specific irq_cfg anyway, so the next logical
> step is to move irq_2_iommu into struct irq_cfg and get rid of the
> extra allocation/free in intr_remapping.c.

Forgot to say, that I updated the git tree with all the fallout
fixes.

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-sparse-irq.git master

Can you please retest ?

Thanks,

	tglx
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/