Re: [PATCH] serial8250: ratelimit "too much work" error

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Joe Perches

Subject: Re: [PATCH] serial8250: ratelimit "too much work" error

Date: Monday, October 4, 2010 - 3:10 pm

On Mon, 2010-10-04 at 15:02 -0700, Andrew Morton wrote:
quoted text> On Mon, 4 Oct 2010 14:51:01 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > someone stuck a
> > DEFINE_RATELIMIT_STATE() in include/linux/kernel.h and it ain't defined
> > anywhere.  Let me fix that up...
> 
> Well that's a PITA.  Can't include ratelimit.h into kernel.h because a)
> it'll slow everyone's compiels down and b) ratelimit.h needs spinlock.h
> which surely needs kernel.h.  Fixable by adding a new
> printk_ratelimit.h and including that from 135 source files, blah.
> 
> I'll give up and pronounce that users of printk_ratelimited() need to
> include ratelimit.h as well.

What I suggested several months ago was to move the
macro definitions to ratelimit.h

http://lkml.org/lkml/2010/2/18/377


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] serial8250: ratelimit "too much work" error, Daniel Drake, (Sat Oct 2, 4:04 am)

Re: [PATCH] serial8250: ratelimit "too much work" error, Alan Cox, (Sat Oct 2, 7:22 am)

Re: [PATCH] serial8250: ratelimit "too much work" error, Andrew Morton, (Mon Oct 4, 2:51 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Andrew Morton, (Mon Oct 4, 3:02 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Joe Perches, (Mon Oct 4, 3:10 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Andrew Morton, (Mon Oct 4, 3:21 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Joe Perches, (Mon Oct 4, 3:59 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Andrew Morton, (Mon Oct 4, 4:11 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Joe Perches, (Mon Oct 4, 4:34 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Andrew Morton, (Mon Oct 4, 4:49 pm)

Re: [PATCH] serial8250: ratelimit "too much work" error, Joe Perches, (Mon Oct 4, 5:26 pm)

Navigation

Popular discussions


linux-kernel:
Gene Heskett	Re: New thread RDSL, post-2.6.20 kernels and amanda (tar) miss-fires
Ray Lee	Re: New thread RDSL, post-2.6.20 kernels and amanda (tar) miss-fires
Michael Moore	Re: underage models, pre teen models, lolita porn, young preteens, little lolitas
Ray Lee	Re: New thread RDSL, post-2.6.20 kernels and amanda (tar) miss-fires
Gene Heskett	Re: New thread RDSL, post-2.6.20 kernels and amanda (tar) miss-fires
git:
Bill Lear	cpio command not found
Gary Yang	fatal: did you run git update-server-info on the server? mv post-update.sample pos...
Junio C Hamano	Re: [Discussion] cherry-picking a merge
Uwe	Re: "bash: git-upload-pack: command not found" ??
Oliver Hoffmann	git init --bare versus git --bare init
openbsd-misc:
Netmaffia.hu	Tini Lányok AKCIÓBAN OTTHON
Paul M	Corrupted RAIDFrame device
Ted Unangst	Re: OpenSMTPd actual development and integration
new_guy	Longest Uptime?
BetClic	Benfica vs Porto - Qual o seu palpite?
linux-netdev:
Francois-Xavier Le Bail	[PATCH v2] net: typos in comments in include/linux/igmp.h
Jamie Lokier	Re: [2/3] POHMELFS: Documentation.
Stephen Hemminger	Re: vlan JMicron Technologies, Inc. JMC250 PCI Express Gigabit Ethernet
Sage Weil	Re: [2/3] POHMELFS: Documentation.
David Miller	Re: [net-next-2.6 PATCH 5/5] be2net: remove BUG_ON() when be2net runs out of mccq ...
git-commits-head:
Linux Kernel Mailing List	Remove empty comment in acpi/power.c
Linux Kernel Mailing List	USB: rename usb_buffer_alloc() and usb_buffer_free()
Linux Kernel Mailing List	powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List	intel_idle: native hardware cpuidle driver for latest Intel processors
Linux Kernel Mailing List	powerpc/fsl-booke: Move the entry setup code into a seperate file

Colocation donated by:

Syndicate