login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
October
»
4
Re: [PATCH v2 1/1] nouveau: ratelimit IRQ messages
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Marcin Slusarz
Subject:
Re: [PATCH v2 1/1] nouveau: ratelimit IRQ messages
Date: Monday, October 4, 2010 - 9:24 am
On Mon, Oct 04, 2010 at 03:11:30PM +0200, Jiri Slaby wrote:
quoted text
> There are two messages in the ISR of nouveau which might be printed out > hundred times in a second. Ratelimit them. (We need to move > nouveau_ratelimit to the top of the file.) > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: Marcin Slusarz <marcin.slusarz@gmail.com>
FWIW Reviewed-by: Marcin Slusarz <marcin.slusarz@gmail.com>
quoted text
> --- > drivers/gpu/drm/nouveau/nouveau_irq.c | 23 +++++++++++++---------- > 1 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_irq.c b/drivers/gpu/drm/nouveau/nouveau_irq.c > index 794b0ee..5b097b4 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_irq.c > +++ b/drivers/gpu/drm/nouveau/nouveau_irq.c > @@ -41,6 +41,13 @@ > #include "nouveau_connector.h" > #include "nv50_display.h" > > +static DEFINE_RATELIMIT_STATE(nouveau_ratelimit_state, 3 * HZ, 20); > + > +static int nouveau_ratelimit(void) > +{ > + return __ratelimit(&nouveau_ratelimit_state); > +} > + > void > nouveau_irq_preinstall(struct drm_device *dev) > { > @@ -200,7 +207,9 @@ nouveau_fifo_irq_handler(struct drm_device *dev) > } > > if (status & NV_PFIFO_INTR_DMA_PUSHER) { > - NV_INFO(dev, "PFIFO_DMA_PUSHER - Ch %d\n", chid); > + if (nouveau_ratelimit()) > + NV_INFO(dev, "PFIFO_DMA_PUSHER - Ch %d\n", > + chid); > > status &= ~NV_PFIFO_INTR_DMA_PUSHER; > nv_wr32(dev, NV03_PFIFO_INTR_0, > @@ -227,8 +236,9 @@ nouveau_fifo_irq_handler(struct drm_device *dev) > } > > if (status) { > - NV_INFO(dev, "PFIFO_INTR 0x%08x - Ch %d\n", > - status, chid); > + if (nouveau_ratelimit()) > + NV_INFO(dev, "PFIFO_INTR 0x%08x - Ch %d\n", > + status, chid); > nv_wr32(dev, NV03_PFIFO_INTR_0, status); > status = 0; > } > @@ -505,13 +515,6 @@ nouveau_pgraph_intr_notify(struct drm_device *dev, uint32_t nsource) > nouveau_graph_dump_trap_info(dev, "PGRAPH_NOTIFY", &trap); > } > > -static DEFINE_RATELIMIT_STATE(nouveau_ratelimit_state, 3 * HZ, 20); > - > -static int nouveau_ratelimit(void) > -{ > - return __ratelimit(&nouveau_ratelimit_state); > -} > - > > static inline void > nouveau_pgraph_intr_error(struct drm_device *dev, uint32_t nsource) > -- > 1.7.3.1 > >
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH v2 1/1] nouveau: ratelimit IRQ messages
, Jiri Slaby
, (Mon Oct 4, 6:11 am)
Re: [PATCH v2 1/1] nouveau: ratelimit IRQ messages
, Marcin Slusarz
, (Mon Oct 4, 9:24 am)
Re: [PATCH v2 1/1] nouveau: ratelimit IRQ messages
, Ben Skeggs
, (Mon Oct 4, 4:40 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [patch 00/13] Syslets, "Threadlets", generic AIO support, v3
Vivek Goyal
[PATCH] x86_64: Display more intutive error message if kernel is not 2MB aligned
Andi Kleen
[PATCH] [0/35] Some x86 2.6.22 candidate patches for review
Andrew Morton
Re: [PATCH] lazy freeing of memory through MADV_FREE 2/2
Peter Zijlstra
Re: [RFC PATCH 1/2] Marker probes in futex.c
git
:
Felipe Contreras
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Johannes Schindelin
[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Johannes Schindelin
Re: [PATCH] Fix install-doc-quick target
Nicolas Pitre
Re: About git and the use of SHA-1
Alex Riesen
Re: git exclude patterns for directory
git-commits-head
:
Linux Kernel Mailing List
sh: Fix compile error by operands(mov.l) in sh3/entry.S
Linux Kernel Mailing List
New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List
powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List
[ARM] 5388/1: Add hwcap bits for VFPv3 and VFPv3D16
Linux Kernel Mailing List
drivers/acpi: use kasprintf
linux-netdev
:
David Dillow
Re: [PATCH 2.6.30-rc4] r8169: avoid losing MSI interrupts
Andi Kleen
Re: RFC: Nagle latency tuning
Paul E. McKenney
Re: [PATCH 1/3] rcu: Introduce hlist_nulls variant of hlist
Russell King
Re: [BUG] New Kernel Bugs
David Miller
Re: [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap
openbsd-misc
:
Andres Salazar
About priorities in /etc/resolv.conf
Rob Shepherd
x86 hardware for router system
Henning Brauer
Re: Sun Blade 1000?
Mitja Muženič
Re: isakmpd -- NCP IPsec client: peer proposed invalid phase 2 IDs
Damien Miller
Re: Patching a SSH 'Weakness'
Colocation donated by:
Syndicate