Re: Transparent Hugepage Support #30

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Naoya Horiguchi
Date: Sunday, October 3, 2010 - 8:24 pm

Hi,

I experienced build error of "calling pte_alloc_map() with 3 parameters, 
while it's defined to have 4 parameters" in arch/x86/kernel/tboot.c etc.
Is the following chunk in patch "pte alloc trans splitting" necessary?

@@ -1167,16 +1168,18 @@ static inline void pgtable_page_dtor(struct page *page)
        pte_unmap(pte);                                 \
 } while (0)
 
-#define pte_alloc_map(mm, pmd, address)                        \
-       ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \
-               NULL: pte_offset_map(pmd, address))
+#define pte_alloc_map(mm, vma, pmd, address)                           \
+       ((unlikely(pmd_none(*(pmd))) && __pte_alloc(mm, vma,    \
+                                                       pmd, address))? \
+        NULL: pte_offset_map(pmd, address))
 
Thanks,
Naoya Horiguchi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Transparent Hugepage Support #30, Andrea Arcangeli, (Wed Sep 1, 12:08 pm)
[patch] transparent hugepage sysfs meminfo, David Rientjes, (Wed Sep 1, 12:44 pm)
Re: [patch] transparent hugepage sysfs meminfo, Andrea Arcangeli, (Wed Sep 1, 12:50 pm)
Re: Transparent Hugepage Support #30, Balbir Singh, (Thu Sep 9, 3:46 am)
Re: Transparent Hugepage Support #30, Andrea Arcangeli, (Thu Sep 9, 4:40 pm)
Re: Transparent Hugepage Support #30, Balbir Singh, (Mon Sep 13, 2:34 am)
Re: Transparent Hugepage Support #30, Andrea Arcangeli, (Wed Sep 15, 6:42 am)
Re: Transparent Hugepage Support #30, Naoya Horiguchi, (Sun Oct 3, 8:24 pm)
Re: Transparent Hugepage Support #30, Andrea Arcangeli, (Tue Oct 5, 12:18 pm)