I prefer the original indenting as it clearly stands the `1' on its own
thus emphasising that the warning will be printed everytime the WARN()
statement is executed. I surmise that the original programmer thought
it important to emphasise this as it might not be considered the
"normal" usage of WARN().
I agree that, in general, coalesced strings aid grepping but this broken
string isn't one that will benefit.
I recall the story that when someone pointed out parallel fifths (an
absolute no-no according to the rules of classical harmony) in a
composition of Beethoven's to Beethoven himself, Beethoven was so
indignant that he proceeded to compose a set of variations on a theme
where in each variation he extensively violated one of the rules of
classical harmony, and wrote down the bottom of each variation "You Ass"
to the authority who had made the rule.
The moral here is that when a _competent_ programmer breaks the "style
guide" they are most likely doing so for a very good reason. Thus,
those who would submit whitespace fix patches should take time to ask
themselves why the original programmer has laid out the code in such a
fashion and learn from it, before submitting so-called "fixes".
Cheers
Michael.
--
