[PATCH 2/2] jump label: disable due to compiler bug

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jason Baron
Date: Wednesday, October 27, 2010 - 2:07 pm

Unfortunately, we found a compiler bug in the implementation of
'asm goto'. The bug can cause the kernel to crash.

For now, we are disabling jump labels with a big hammer. When the
gcc fix is committed, we will update the kernel with a better check
for either the version number it's fix in, or some detection of
whether gcc has the fix in place.

Signed-off-by: Jason Baron <jbaron@redhat.com>
---
 include/linux/jump_label.h |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
index b67cb18..954462a 100644
--- a/include/linux/jump_label.h
+++ b/include/linux/jump_label.h
@@ -1,11 +1,20 @@
 #ifndef _LINUX_JUMP_LABEL_H
 #define _LINUX_JUMP_LABEL_H
 
+/*
+ * A compiler bug was found in the implementation of 'asm goto'. Thus,
+ * we are disabling it for now pending a better check for compiler version
+ * that fixes it.
+ */
+#if 0
+
 #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL)
 # include <asm/jump_label.h>
 # define HAVE_JUMP_LABEL
 #endif
 
+#endif
+
 enum jump_label_type {
 	JUMP_LABEL_ENABLE,
 	JUMP_LABEL_DISABLE
-- 
1.7.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] jump label updates, Jason Baron, (Wed Oct 27, 2:07 pm)
[PATCH 1/2] move arch_init_ideal_nop5 later, Jason Baron, (Wed Oct 27, 2:07 pm)
[PATCH 2/2] jump label: disable due to compiler bug, Jason Baron, (Wed Oct 27, 2:07 pm)
Re: [PATCH 0/2] jump label updates, David Miller, (Wed Oct 27, 2:15 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, H. Peter Anvin, (Wed Oct 27, 3:21 pm)
Re: [PATCH 1/2] move arch_init_ideal_nop5 later, H. Peter Anvin, (Wed Oct 27, 3:24 pm)
Re: [PATCH 0/2] jump label updates, Steven Rostedt, (Wed Oct 27, 6:33 pm)
Re: [PATCH 1/2] move arch_init_ideal_nop5 later, Steven Rostedt, (Wed Oct 27, 7:11 pm)
Re: [PATCH 1/2] move arch_init_ideal_nop5 later, H. Peter Anvin, (Wed Oct 27, 7:59 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, David Daney, (Thu Oct 28, 11:55 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Ingo Molnar, (Thu Oct 28, 11:34 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 5:18 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 5:46 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Mathieu Desnoyers, (Fri Oct 29, 6:35 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Richard Henderson, (Fri Oct 29, 8:59 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 9:18 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, David Daney, (Fri Oct 29, 10:18 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 10:33 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, David Daney, (Fri Oct 29, 10:48 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 11:03 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Richard Henderson, (Fri Oct 29, 11:13 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 11:25 am)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Mathieu Desnoyers, (Fri Oct 29, 1:05 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, H. Peter Anvin, (Fri Oct 29, 1:15 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Mathieu Desnoyers, (Fri Oct 29, 1:42 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 1:44 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 1:47 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, H. Peter Anvin, (Fri Oct 29, 1:51 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Fri Oct 29, 1:58 pm)
Re: [PATCH 2/2] jump label: disable due to compiler bug, Steven Rostedt, (Sat Oct 30, 7:00 am)