Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Dmitry Torokhov

Subject: Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, pr_fmt. Fix dbg and __FILE__ use

Date: Tuesday, October 26, 2010 - 6:00 pm

On Oct 26, 2010, at 5:46 PM, Joe Perches <joe@perches.com> wrote:

quoted text> On Tue, 2010-10-26 at 17:40 -0700, Dmitry Torokhov wrote:
>>> Mind if I move the time to the front like this?
>>> +#define dbg(format, arg...)                                            \
>>> +do {                                    \
>>> +    if (i8042_debug)                        \
>>> +        printk(KERN_DEBUG KBUILD_MODNAME ": [%d]" format),    \
>>> +                      (int)(jiffies - i8042_start_time), ##arg);    \
>>> +} while (0)
>> Another option would be to leave '\n' in dbg() and leave most of the
>> callers as is.
> 
> That's really error prone though.
> 

In what way?

-- 
Dmitry

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 06/10] drivers/input/serio/i8042: Use pr_<level>, p ..., Joe Perches, (Mon Oct 25, 7:44 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Dmitry Torokhov, (Tue Oct 26, 8:50 am)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Joe Perches, (Tue Oct 26, 4:25 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Dmitry Torokhov, (Tue Oct 26, 5:40 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Joe Perches, (Tue Oct 26, 5:46 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Dmitry Torokhov, (Tue Oct 26, 6:00 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Joe Perches, (Tue Oct 26, 6:10 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Dmitry Torokhov, (Tue Oct 26, 6:28 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Joe Perches, (Tue Oct 26, 6:35 pm)

Re: [PATCH 06/10] drivers/input/serio/i8042: Use pr_<level ..., Dmitry Torokhov, (Tue Oct 26, 8:00 pm)