Home » Mailing list archives » linux-kernel » 2010 » October » 26

Re: [PATCH 01/11] IMA: use rbtree instead of radix tree for inode information cache

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds
Subject: Re: [PATCH 01/11] IMA: use rbtree instead of radix tree for inode information cache
Date: Tuesday, October 26, 2010 - 8:22 am

On Tue, Oct 26, 2010 at 7:01 AM, John Stoffel <john@stoffel.org> wrote:

ALL new features should have "default n" for them. And if you had
actually looked at it, you would see that it already has that ("n" is
the default if no default is listed) _and_ it says

  "If unsure, say N"

in the comments.

So why the hell are people complaining about a patch-series that
_clearly_ improves on the current situation?

And yes, Fedora should never have enabled it. If the distro doesn't
use a feature, it shouldn't be enabled, because it's inevitably just a
source of problems. In this case, I think we should be happy that it
was enabled just because it made people notice the problem, but at the
same time the fact that Fedora enabled it is _not_ justification for
then saying "well, if you enable it and don't use it, it must be
zero-overhead".

If you want zero overhead and you think nobody uses it (and that seems
to be the _only_ logic the people complaining about it keep drumming
on), then DON'T ENABLE IT, FOR CHRISSAKE!

This thread has been a total waste of everybody's time.

Did I miss any actual _constructive_ criticism of the patches? Is
there any reason I shouldn't actually apply them? If there is, I've
lost it in the roar of pointlessness.

                      Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/11] IMA: use rbtree instead of radix tree for in ..., Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 02/11] IMA: drop the inode opencount since it isn't ..., Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 03/11] IMA: use unsigned int instead of long for co ..., Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 05/11] IMA: use inode-&gt;i_lock to protect read and w ..., Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 06/11] IMA: use i_writecount rather than a private ..., Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 07/11] IMA: move read counter into struct inode, Eric Paris, (Mon Oct 25, 11:41 am)
[PATCH 08/11] IMA: only allocate iint when needed, Eric Paris, (Mon Oct 25, 11:42 am)
[PATCH 09/11] IMA: drop refcnt from ima_iint_cache since i ..., Eric Paris, (Mon Oct 25, 11:42 am)
[PATCH 10/11] IMA: explicit IMA i_flag to remove global lo ..., Eric Paris, (Mon Oct 25, 11:42 am)
[PATCH 11/11] IMA: fix the ToMToU logic, Eric Paris, (Mon Oct 25, 11:42 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., John Stoffel, (Mon Oct 25, 12:21 pm)
Re: [PATCH 06/11] IMA: use i_writecount rather than a priv ..., John Stoffel, (Mon Oct 25, 12:27 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., J.H., (Mon Oct 25, 12:38 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Linus Torvalds, (Mon Oct 25, 1:55 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Christoph Hellwig, (Mon Oct 25, 1:57 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Linus Torvalds, (Mon Oct 25, 2:11 pm)
Re: [PATCH 06/11] IMA: use i_writecount rather than a priv ..., Eric Paris, (Mon Oct 25, 2:52 pm)
Re: [PATCH 06/11] IMA: use i_writecount rather than a priv ..., H. Peter Anvin, (Mon Oct 25, 3:25 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Dave Chinner, (Mon Oct 25, 4:22 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Eric Paris, (Mon Oct 25, 5:12 pm)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., John Stoffel, (Tue Oct 26, 6:45 am)
Re: [PATCH 06/11] IMA: use i_writecount rather than a priv ..., John Stoffel, (Tue Oct 26, 6:53 am)
Re: [PATCH 06/11] IMA: use i_writecount rather than a priv ..., John Stoffel, (Tue Oct 26, 6:57 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., John Stoffel, (Tue Oct 26, 7:01 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., John Stoffel, (Tue Oct 26, 7:07 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Linus Torvalds, (Tue Oct 26, 8:22 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Eric Paris, (Tue Oct 26, 8:30 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., Al Viro, (Tue Oct 26, 11:13 am)
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree fo ..., James Morris, (Wed Oct 27, 6:35 am)