On Tue, 2010-10-26 at 09:07 +0200, Mike Galbraith wrote:
quoted text
> On Thu, 2010-10-21 at 18:29 +0200, Oleg Nesterov wrote:
> 
> > It is not clear to me why do we need rcu_read_lock() and how it can help.
> > The tty can go away right after dereferencing signal->tty.
> 
> Which was Marcus' crash.  Didn't happen here only because I didn't have
> CONFIG_PREEMPT set.
> 
> Changes since v2:
>   - drop  

Bumped mouse, message escaped.

Doesn't matter though, damn thing just blew up during enable/disable
plus hackbench stress test, despite holding a reference to the tty at
every place tty changes (under sighand lock), and moving the task with
that reference held.

CONFIG_PREEMPT is being a little S.O.B.

	-Mike

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/