linux-kernel mailing list

FromSubjectsort iconDate
William Sherman
usbhid: HP LD4200tm touchscreen ALMOST works
Hello, I'm looking to dig into the usbhid driver code to get me the last mile and get my HP LD4200tm touchscreen working on my Linux system. [NOTE: I posted about this elsewhere, but as I think about it more, this is more of a linux-kernel issue than anything else, so I'm reprising that note here.] So, in first connecting the HP touchscreen (with touchscreen hardware from Nexio) to the Linux system (running Ubuntu 10.10 -- 2.6.35-22 generic) things were looking up, as the unit almost worked ...
Oct 25, 4:48 pm 2010
Mrs.Irena Ruddy
Do email us !!!,
Attn,call us !!! This is to inform you that your e-mail address has won us$2,000,000,00.{Two Million Dollars} from Eu lucky day lottery Nl in computer balloting system draw 2010 kindly contact your claim agent Mr.Jong Ramco by via e-mail: payagency3@netscape.net ,Expiring date is 15th of november 2010 in all email user All response should be send Via agent e-mail: payagency3@netscape.net telex-fax, +31-6111-464-78,telephone numbers : +31-617-444-557, Clarification and procedure ...
Oct 25, 6:22 am 2010
Kees Cook
[PATCH] ipc: explicitly clear stack memory in user structs
CVE-2010-4072 The old shm interface will leak a few bytes of stack contents. Explicitly clear structure using memset instead of C99-style initialization in case there are ever holes in the packing. Cc: stable <stable@kernel.org> Signed-off-by: Kees Cook <kees.cook@canonical.com> --- This was originally sent as http://lkml.org/lkml/2010/10/6/486 but was never taken into any tree. --- ipc/shm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ipc/shm.c ...
Oct 25, 4:58 pm 2010
Axel Lin
[PATCH 2/2 v2] regulator: max8952 - fix max8952_set_voltage
In current implementation, vid is declared as u8, then "vid == -1" is always false, and "vid >= 0" is always true. Thus change it to s8. Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/max8952.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index f2af0b1..d5cc051 100644 --- a/drivers/regulator/max8952.c +++ b/drivers/regulator/max8952.c @@ -136,7 +136,7 @@ static int ...
Oct 25, 4:55 pm 2010
Michal Simek
[GIT PULL] arch/microblaze changes for 2.6.37
Hi Linus, please pull the following changes. The main part is adding Microblaze little endian support for AXI bus. There are two out-of-tree patches which have ACKs from respective maintainers (David S. Miller - emaclite , Grant Likely - xilinxfb). Both of them proposed to merge it via Microblaze tree. Thanks, Michal The following changes since commit f6f94e2ab1b33f0082ac22d71f66385a60d8157f: Linus Torvalds (1): Linux 2.6.36 are available in the git repository at: ...
Oct 25, 4:48 pm 2010
Webmaster Help Desk ...
Technical Support
-- You have reached the limit of your email quota. You will not be able to send or receive new mail until you boost your mailbox size. Click the below link and fill the form to upgrade your account. http://use.my/system-helpdeskdesk/ Technical Support 192.168.0.1 --
Oct 25, 10:50 am 2010
Randy Dunlap
Re: [bug 2.6.37-git] lockdep: invalid subclass in moused ...
Hi Dave, Please see this reply: http://lkml.org/lkml/2010/10/25/48 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Oct 25, 4:46 pm 2010
Dave Chinner
[bug 2.6.37-git] lockdep: invalid subclass in mousedev_c ...
Folks, Just got this booting a VM on a 2.6.37-git tree from a couple of days ago: [ 1.547497] BUG: looking up invalid subclass: 31 [ 1.548238] turning off the locking correctness validator. [ 1.548923] Pid: 1, comm: swapper Not tainted 2.6.36-dgc+ #580 [ 1.549637] Call Trace: [ 1.550024] [<ffffffff810b88b0>] register_lock_class+0x540/0x550 [ 1.550880] [<ffffffff810baded>] ? trace_hardirqs_on+0xd/0x10 [ 1.552001] [<ffffffff810b8925>] ? lockdep_init_map+0x65/0x150 [ ...
Oct 25, 4:40 pm 2010
Randy Dunlap
[PATCH] signal.c: coding style and comment fixes
From: Randy Dunlap <randy.dunlap@oracle.com> General coding style and comment fixes: - Use multi-line-comment coding style. - Hyphenate some words. - Spell Posix as POSIX. - Correct typos & spellos in some comments. - Drop trailing whitespace. - End sentences with periods. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- kernel/signal.c | 82 +++++++++++++++++++++++++--------------------- 1 file changed, 45 insertions(+), 37 deletions(-) --- ...
Oct 25, 4:03 pm 2010
Nicolas Kaiser
[PATCH] ext4: fix unbalanced mutex unlock
Although the mutex isn't locked yet, if ext4_li_request_new fails, the mutex would get unlocked on the error path. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- fs/ext4/super.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index d0c3328..8bca022 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2915,10 +2915,8 @@ static int ext4_register_li_request(struct super_block *sb, } elr = ext4_li_request_new(sb, ...
Oct 25, 4:15 pm 2010
British Canada Award ...
AWARD WINNING PRIZE: CLAIMING IS FREE!!
TO REDEEM YOUR PRIZE IS FREE OF CHARGE!! Your E-ID was selected online in this week's AWARD PROMO BRITISH CANADIAN LOTTERY BC-49 05 07 14 20 32 34 06 Your draw has a total value of $1,000,000.00 USD And your Winning No:05 07 14 20 32 34 06. Please acknowledge the receipt of this mail with the details below to our claim agent. Contact Agent: Mr.Garry Lee. E-mail: dr.garry0107lee@live.co.uk Claims Requirements 1.Full name 2.Home Address 3.Age 4.Sex 5.Occupation 6.Phone ...
Oct 25, 3:58 pm 2010
Dave Jones
conflicting options in makefile ?
While diagnosing a ccache problem, I noticed the following command line being used.. [2010-10-25T18:45:16.715078 25689] Executing /usr/bin/cc -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -Os -m64 -mtune=generic -mno-red-zone -mcmodel=kernel -funit-at-a-time -maccumulate-outgoing-args -fstack-protector -DCONFIG_AS_CFI=1 ...
Oct 25, 3:50 pm 2010
David Howells
[PATCH] MN10300: Fix the PERCPU() alignment to allow for ...
In the MN10300 arch, we occasionally see an assertion being tripped in alloc_cwqs() at the following line: /* just in case, make sure it's actually aligned */ ---> BUG_ON(!IS_ALIGNED(wq->cpu_wq.v, align)); return wq->cpu_wq.v ? 0 : -ENOMEM; The values are: wa->cpu_wq.v => 0x902776e0 align => 0x100 and align is calculated by the following: const size_t align = max_t(size_t, 1 << WORK_STRUCT_FLAG_BITS, ...
Oct 25, 3:41 pm 2010
Andi Kleen
[PATCH] Fix install_process_keyring error handling
From: Andi Kleen <ak@linux.intel.com> Fix incorrect error check that returns 1 for error instead of the expected error code. Signed-off-by: Andi Kleen <ak@linux.intel.com> --- security/keys/process_keys.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c index f8e7251..504bdd2 100644 --- a/security/keys/process_keys.c +++ b/security/keys/process_keys.c @@ -207,7 +207,7 @@ static int ...
Oct 25, 3:31 pm 2010
Venkatesh Pallipadi
[PATCH 2/6] cleanup account_system_vtime with this_cpu_* -v1
this_cpu_* variants are optimal than per_cpu(). Cleanup IRQ_TIME_ACCOUNTING account_system_vtime to use this_cpu_*. Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- kernel/sched.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index fae668b..a37bb83 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -1966,7 +1966,6 @@ static u64 irq_time_cpu(int cpu) void account_system_vtime(struct task_struct *curr) { ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 1/6] Free up pf flag PF_KSOFTIRQD -v1
Cleanup patch, freeing up PF_KSOFTIRQD and use per_cpu ksoftirqd pointer instead, as suggested by Eric Dumazet. Tested-by: Shaun Ruffell <sruffell@digium.com> Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- include/linux/interrupt.h | 7 +++++++ include/linux/sched.h | 1 - kernel/sched.c | 2 +- kernel/softirq.c | 3 +-- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/linux/interrupt.h ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 0/6] Proper kernel irq time reporting -v1
This is Part 2 of "Proper kernel irq time accounting -v4" http://lkml.indiana.edu/hypermail//linux/kernel/1010.0/01175.html and applies over those changes. Changes since v0: ( v0 - http://lkml.indiana.edu/hypermail//linux/kernel/1010.2/02420.html ) - Use of this_cpu_* variants - Other comments on v0 version addressed Part 1 solves the way irqs are accounted in scheduler and tasks. This patchset solves how irq times are reported in /proc/stat and also not to include irq time in ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 3/6] Add nsecs_to_cputime64 interface for asm-gen ...
Add nsecs_to_cputime64 interface. This is used in following patches that updates cpu irq stat based on ns granularity info in IRQ_TIME_ACCOUNTING. Tested-by: Shaun Ruffell <sruffell@digium.com> Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- include/asm-generic/cputime.h | 3 +++ include/linux/jiffies.h | 1 + kernel/time.c | 23 +++++++++++++++++++++-- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/include/asm-generic/cputime.h ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 4/6] Refactor account_system_time separating id-u ...
Refactor account_system_time, to separate out the logic of identifying the update needed and code that does actual updating. This is used by following patch for IRQ_TIME_ACCOUNTING, which has different identification logic and same update logic. Tested-by: Shaun Ruffell <sruffell@digium.com> Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- kernel/sched.c | 46 +++++++++++++++++++++++++++++++--------------- 1 files changed, 31 insertions(+), 15 deletions(-) diff --git ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 5/6] Export ns irqtimes through /proc/stat -v1
CONFIG_IRQ_TIME_ACCOUNTING adds ns granularity irq time on each CPU. This info is already used in scheduler to do proper task chargeback (earlier patches). This patch retro-fits this ns granularity hardirq and softirq information to /proc/stat irq and softirq fields. The update is still done on timer tick, where we look at accumulated ns hardirq/softirq time and account the tick to user/system/irq/hardirq/guest accordingly. No new interface added. Earlier versions looked at adding this as ...
Oct 25, 3:30 pm 2010
Venkatesh Pallipadi
[PATCH 6/6] Account ksoftirqd time as cpustat softirq -v1
softirq time in ksoftirqd context is not accounted in ns granularity per cpu softirq stats, as we want that to be a part of ksoftirqd exec_runtime. Accounting them as softirq on /proc/stat separately. Tested-by: Shaun Ruffell <sruffell@digium.com> Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- kernel/sched.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index 49f6f61..0955050 100644 --- a/kernel/sched.c +++ ...
Oct 25, 3:30 pm 2010
Guenter Roeck
[GIT PULL] hwmon changes for 2.6.37
Hi Linus, Please pull hwmon subsystem changes for Linux 2.6.37 from: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git hwmon-for-linus Thanks, Guenter Roeck ------ The following changes since commit 72e58063d63c5f0a7bf65312f1e3a5ed9bb5c2ff: Merge branch 'davinci-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci (2010-10-25 10:59:31 -0700) are available in the git repository at: ...
Oct 25, 3:03 pm 2010
Sven Eckelmann
[PATCH] Staging: batman-adv: Remove useless braces
77099f0afe94928b5b0066a7efa5fa9f81696b54 added changes to vis.c which trigger a checkpatch.pl warning about braces which are not necessary anymore. WARNING: braces {} are not necessary for any arm of this statement + if (entry->primary) [...] + else { [...] Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Marek Lindner <lindner_marek@yahoo.de> Cc: Simon Wunderlich <siwu@hrz.tu-chemnitz.de> Cc: Andrew ...
Oct 25, 2:43 pm 2010
David Howells
Re: [Linux-am33-list] [PATCH] workqueue: Fix alignment c ...
Actually, no, that's not right either. Need to subtract log2(BITS_PER_BYTE). David --
Oct 25, 2:38 pm 2010
David Howells Oct 25, 2:46 pm 2010
David Howells
[PATCH] workqueue: Fix alignment calculation in alloc_cwqs()
In the MN10300 arch, we occasionally see an assertion being tripped in alloc_cwqs() at the following line: /* just in case, make sure it's actually aligned */ ---> BUG_ON(!IS_ALIGNED(wq->cpu_wq.v, align)); return wq->cpu_wq.v ? 0 : -ENOMEM; The values are: wa->cpu_wq.v => 0x902776e0 align => 0x100 and align is calculated by the following: const size_t align = max_t(size_t, 1 << WORK_STRUCT_FLAG_BITS, __alignof__(unsigned long long)); which is wrong. __alignof__() ...
Oct 25, 2:27 pm 2010
Linus Torvalds
Re: [PATCH] workqueue: Fix alignment calculation in allo ...
No it doesn't. Those bits really require that many bytes of alignment. Think about it: if the low 8 bits of the pointer are used for flags, then the actual pointer itself needs to be aligned to a 256-byte boundary. So the code is right. If needs to ask for "1 << WORK_STRUCT_FLAG_BITS" alignment, and if it doesn't get it (because the allocator is somehow broken - percpu allocator issues?), things will break. Linus --
Oct 25, 2:43 pm 2010
Steven Rostedt
Re: bug in streamline_config.pl
Then this is a bug and should be reported. I've add LKML to the Cc list, so that this becomes public for all kernel developers. I'm a bit confused to exactly what is broken? What did you do on what kernel and what did you find that broke? Could you try the lastest stable kernel and see if it is broken there too? 2.6.36. Thanks! -- Steve --
Oct 25, 2:14 pm 2010
Jill Nash Oct 25, 1:00 pm 2010
Elvis Dowson
Re: How to prevent + being appended to kernel image name
Hi, I found the solution. You can disable the plus sign is the LOCALVERSION environment variable or make variable: make LOCALVERSION= all make ARCH=arm CROSS_COMPILE=arm-angstrom-linux-gnueabi- LOCALVERSION= -j6 uImage Elvis Dowson --
Oct 25, 1:26 pm 2010
Stefan Richter
Re: How to prevent + being appended to kernel image name
scripts/setlocalversion is the culprit. Read at the bottom of the file under which conditions it adds the +. -- Stefan Richter -=====-==-=- =-=- ==--= http://arcgraph.de/sr/ --
Oct 25, 1:38 pm 2010
Elvis Dowson
How to prevent + being appended to kernel image name
Hi, When I build the linux-2.6.36 kernel (wl12xx wireless repo) using OpenEmbedded (OE), the kernel image that gets created has the name "Linux-2.6.36-rc8-wl" However, when I build it from within TI CCS v5 (eclipse IDE), the resulting kernel image name has a + sign appended to the image name "Linux-2.6.36-rc8-wl+" How can I prevent the + symbol from being prefixed to the kernel image name? I'm using OE to build the rootfilesystem and the kernel driver modules, but using TI CCS v5 to ...
Oct 25, 12:54 pm 2010
Trond Myklebust
[GIT PULL] Please pull NFS client changes for mainline
Hi Linus, Please pull from the "nfs-for-2.6.37" branch of the repository at git pull git://git.linux-nfs.org/projects/trondmy/nfs-2.6.git nfs-for-2.6.37 This will update the following files through the appended changesets. Cheers, Trond ---- Documentation/filesystems/nfs/00-INDEX | 2 + Documentation/filesystems/nfs/idmapper.txt | 67 ++ Documentation/filesystems/nfs/nfsroot.txt | 22 + Documentation/kernel-parameters.txt | 5 +- fs/lockd/clntlock.c ...
Oct 25, 12:37 pm 2010
Matt Garman
linux thread scheduling (on multi-socket nehalem)?
Hello list, Can someone give a general explanation of how Linux's thread-scheduling algorithm works? Or provide a link to a document that describes it? I've searched the web, but can't find any recent documents. In particular, the question I am trying to answer is: does Linux generally try spread threads out as far as possible across physical CPU cores, or try to keep them close together? Furthermore, have their been any changes to this strategy recently ("recent" as in the last few ...
Oct 25, 12:01 pm 2010
Fernando Guzman Lugo
[PATCHv5 0/4] omap: iovmm - fixes for iovmm module
Version 5: * Changes in "iommu: create new api to set valid da range" - Change range variables to platform data structure. Version 4: * Changes in "iommu: create new api to set valid da range" - Validate range for fixed address. - Change way of change boundaries to avoid possible overflow instead of style : start + bytes >= end which start + end can overflow use style: end - start < bytes Version 3: * change patch 2 base on Felipe Contreras' comments, ...
Oct 25, 12:10 pm 2010
Fernando Guzman Lugo
[PATCHv5 1/4] omap: iovmm - no gap checking for fixed address
If some fixed da address is wanted to be mapped and the page is freed but it is used as gap, the mapping will fail. This patch is fixing that and olny keeps the gap for not fixed address. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 24ca9c4..34f0012 100644 --- a/arch/arm/plat-omap/iovmm.c +++ ...
Oct 25, 12:10 pm 2010
Fernando Guzman Lugo
[PATCHv5 3/4] omap: iovmm - replace __iounmap with omap_ ...
Omap platform is omap_iounmap function. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 93a34d9..5489ca9 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da) struct sg_table *sgt; typedef void (*func_t)(const void *); - sgt = ...
Oct 25, 12:10 pm 2010
Fernando Guzman Lugo
[PATCHv5 2/4] omap: iovmm - add superpages support to fi ...
This patch adds superpages support to fixed ad address inside iommu_kmap function. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 62 +++++++++++++++++++++++++------------------ 1 files changed, 36 insertions(+), 26 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 34f0012..93a34d9 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -87,35 +87,43 @@ static size_t sgtable_len(const ...
Oct 25, 12:10 pm 2010
Fernando Guzman Lugo
[PATCHv5 4/4] omap: iommu - create new api to set valid ...
Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF rage. With this new API the valid range can be set. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/include/plat/iommu.h | 3 ++ arch/arm/plat-omap/iommu.c | 33 +++++++++++++++++++++++++++++++ arch/arm/plat-omap/iovmm.c | 18 ++++++++++------ 3 files changed, 47 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/iommu.h ...
Oct 25, 12:10 pm 2010
Tony Lindgren
[GIT PULL] omap updates for 2.6.37
Hi Linus, Please pull omap updates from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-for-linus There are few minor merge conflicts, but I've left them unmerged as I believe that's the way you want them nowadays. The merge conflicts are just overlapping additions, and a OMAP2/OMAP2 vs OMAP24XX/OMAP34XX ifdef issue where the former is the way to go. Looks like the crypto device platform data got accidentally added in both the crypto and omap trees. I've ...
Oct 25, 11:44 am 2010
Eric Paris
[PATCH 01/11] IMA: use rbtree instead of radix tree for ...
The IMA code needs to store the number of tasks which have an open fd granting permission to write a file even when IMA is not in use. It needs this information in order to be enabled at a later point in time without losing it's integrity garantees. At the moment that means we store a little bit of data about every inode in a cache. We use a radix tree key'd on the inode's memory address. Dave Chinner pointed out that a radix tree is a terrible data structure for such a sparse key space. This ...
Oct 25, 11:41 am 2010
Eric Paris
[PATCH 07/11] IMA: move read counter into struct inode
IMA currently allocated an inode integrity structure for every inode in core. This stucture is about 120 bytes long. Most files however (especially on a system which doesn't make use of IMA) will never need any of this space. The problem is that if IMA is enabled we need to know information about the number of readers and the number of writers for every inode on the box. At the moment we collect that information in the per inode iint structure and waste the rest of the space. This patch moves ...
Oct 25, 11:41 am 2010
Eric Paris
[PATCH 03/11] IMA: use unsigned int instead of long for ...
Currently IMA uses 2 longs in struct inode. To save space (and as it seems impossible to overflow 32 bits) we switch these to unsigned int. The switch to unsigned does require slightly different checks for underflow, but it isn't complex. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 4 ++-- security/integrity/ima/ima_iint.c | 4 ++-- security/integrity/ima/ima_main.c | 15 ++++++++++----- 3 ...
Oct 25, 11:41 am 2010
Eric Paris
[PATCH 05/11] IMA: use inode->i_lock to protect read and ...
Currently IMA used the iint->mutex to protect the i_readcount and i_writecount. This patch uses the inode->i_lock since we are going to start using in inode objects and that is the most appropriate lock. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 1 + security/integrity/ima/ima_main.c | 57 +++++++++++++++---------------------- 2 files changed, 24 insertions(+), 34 deletions(-) diff --git ...
Oct 25, 11:41 am 2010
John Stoffel
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
>>>>> "Eric" == Eric Paris <eparis@redhat.com> writes: Eric> The IMA code needs to store the number of tasks which have an Eric> open fd granting permission to write a file even when IMA is not Eric> in use. It needs this information in order to be enabled at a Eric> later point in time without losing it's integrity garantees. This sounds completely wrong to me. If I disable IMA (but have the sucker compiled in due to a vendor...) I don't want *any* overhead, and this is speaking using my ...
Oct 25, 12:21 pm 2010
John Stoffel
Re: [PATCH 06/11] IMA: use i_writecount rather than a pr ...
>>>>> "Eric" == Eric Paris <eparis@redhat.com> writes: Eric> IMA tracks the number of struct files which are holding a given Eric> inode readonly and the number which are holding the inode write Eric> or r/w. It needs this information so when a new reader or Eric> writer comes in it can tell if this new file will be able to Eric> invalidate results it already made about existing files. Eric> aka if a task is holding a struct file open RO, IMA measured the Eric> file and recorded those ...
Oct 25, 12:27 pm 2010
J.H.
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
I'll second both points. If IMA is disabled, but compiled in, it *HAS* to consume 0 resources. It's defective by design if something that is only useful to 1% of the userbase (guesstimating) consumes even 1% of the resources on any and all machines that are deployed with it. It's just plain wasteful of power, cooling, ram, compute resources, etc. Keep in mind distros are going to err on the side of compiling things in (either into the kernel or as modules) because there is a ...
Oct 25, 12:38 pm 2010
Eric Paris
[PATCH 08/11] IMA: only allocate iint when needed
IMA always allocates an integrity structure to hold information about every inode, but only needed this structure to tract the number of readers and writers currently accessing a given inode. Since that information was moved into struct inode instead of the integrity struct this patch stops allocating the integrity stucture until it is needed. Thus greatly reducing memory usage. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> --- ...
Oct 25, 11:42 am 2010
Eric Paris
[PATCH 10/11] IMA: explicit IMA i_flag to remove global ...
Currently for every removed inode IMA must take a global lock and search the IMA rbtree looking for an associated integrity structure. Instead we explicitly mark an inode when we add an integrity structure so we only have to take the global lock and do the removal if it exists. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> --- include/linux/fs.h | 2 ++ security/integrity/ima/ima_iint.c | 16 +++++++++++----- ...
Oct 25, 11:42 am 2010
Christoph Hellwig
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
Kyle sent a very useful patch to simply disable the ima tracking unless you enable it on the command line. --
Oct 25, 1:57 pm 2010
Dave Chinner
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
I'm not sure this is the right fix, though. Realistically, there is a 1:1 relationship between the inode and the IMA information. I fail to see why an external index is needed here at all - just use a separate structure to store the IMA information that the inode points to. That makes the need for a new global index and global lock go away completely. You're already adding 8 bytes to the inode, so why not make it a pointer. We've got 4 conditions: 1. not configured - no overhead 2. ...
Oct 25, 4:22 pm 2010
Eric Paris
[PATCH 02/11] IMA: drop the inode opencount since it isn ...
The opencount was used to help debugging to make sure that everything which created a struct file also correctly made the IMA calls. Since we moved all of that into the VFS this isn't as necessary. We should be able to get the same amount of debugging out of just the reader and write count. Signed-off-by: Eric Paris <eparis@redhat.com> Acked-by: Mimi Zohar <zohar@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 1 - security/integrity/ima/ima_iint.c | 6 ------ ...
Oct 25, 11:41 am 2010
H. Peter Anvin
Re: [PATCH 06/11] IMA: use i_writecount rather than a pr ...
Case #2 is the bad one, as long as distros are likely to compile it in. -hpa --
Oct 25, 3:25 pm 2010
Linus Torvalds
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
I disagree. First off, this isn't actually true. Look at things like quota support: it eats more memory in the inode than IMA does after this patch-series (two pointers), and most people don't use that either. So the "it must use zero extra memory" is bogus - it's a balance between simplicity of the code and memory use. Secondly, right now we're in the situation that IMA just sucks. Sucks with all capital letters, in fact. This patch-series may not be perfect, but it's _so_ much better than ...
Oct 25, 1:55 pm 2010
Linus Torvalds
Re: [PATCH 01/11] IMA: use rbtree instead of radix tree ...
And exactly how does that invalidate _any_ of the patches in the IMA series in question? All of them are basically still equally valid. And the "four bytes in 'struct inode' is a total no-no" crowd clearly haven't looked at struct inode. As mentioned, we've got things like quota stuff there too. And quite frankly, it sounds like the right thing to do for Fedora &co is to simply _disable_ CONFIG_IMA. If there is no support for it on a distro level, then you shouldn't enable it. ...
Oct 25, 2:11 pm 2010
Eric Paris
[PATCH 09/11] IMA: drop refcnt from ima_iint_cache since ...
Since finding a struct ima_iint_cache requires a valid struct inode, and the struct ima_iint_cache is supposed to have the same lifetime as a struct inode (technically they die together but don't need to be created at the same time) we don't have to worry about the ima_iint_cache outliving or dieing before the inode. So the refcnt isn't useful. Just get rid of it and free the structure when the inode is freed. Signed-off-by: Eric Paris <eapris@redhat.com> Acked-by: Mimi Zohar ...
Oct 25, 11:42 am 2010
Eric Paris
[PATCH 06/11] IMA: use i_writecount rather than a privat ...
IMA tracks the number of struct files which are holding a given inode readonly and the number which are holding the inode write or r/w. It needs this information so when a new reader or writer comes in it can tell if this new file will be able to invalidate results it already made about existing files. aka if a task is holding a struct file open RO, IMA measured the file and recorded those measurements and then a task opens the file RW IMA needs to note in the logs that the old measurement may ...
Oct 25, 11:41 am 2010
Eric Paris
[PATCH 11/11] IMA: fix the ToMToU logic
Current logic looks like this: rc = ima_must_measure(NULL, inode, MAY_READ, FILE_CHECK); if (rc < 0) goto out; if (mode & FMODE_WRITE) { if (inode->i_readcount) send_tomtou = true; goto out; } if (atomic_read(&inode->i_writecount) > 0) send_writers = true; Lets assume we have a policy which states that all files opened for read by root must be ...
Oct 25, 11:42 am 2010
Eric Paris
Re: [PATCH 06/11] IMA: use i_writecount rather than a pr ...
You admit that you don't know what you are talking about and then state that this kills systems performance. Interesting conclusion. I'm not going to try to refute you point by point but will instead paint a broad picture. I see 3 possible states: 1) Configured out - 0 overhead. period. 2) Configured in but default disabled 3) Configured in and enabled by admin intervention I have (I think) pretty clearly discussed the overhead and the changes made in case #2. We expand struct inode by ...
Oct 25, 2:52 pm 2010
Guzman Lugo, Fernando
RE: [PATCHv5 0/4] iovmm: fixes for iovmm module
Please discard this set of patches I will send them again with The correct prefix (omap) to avoid confusion with other Iommu componets. Sorry for the noise. Regards,
Oct 25, 11:49 am 2010
Fernando Guzman Lugo
[PATCHv5 0/4] iovmm: fixes for iovmm module
Version 5: * Changes in "iommu: create new api to set valid da range" - Change range variables to platform data structure. Version 4: * Changes in "iommu: create new api to set valid da range" - Validate range for fixed address. - Change way of change boundaries to avoid possible overflow instead of style : start + bytes >= end which start + end can overflow use style: end - start < bytes Version 3: * change patch 2 base on Felipe Contreras' comments, ...
Oct 25, 11:52 am 2010
Fernando Guzman Lugo
[PATCHv5 1/4] iovmm: no gap checking for fixed address
If some fixed da address is wanted to be mapped and the page is freed but it is used as gap, the mapping will fail. This patch is fixing that and olny keeps the gap for not fixed address. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 24ca9c4..34f0012 100644 --- a/arch/arm/plat-omap/iovmm.c +++ ...
Oct 25, 11:52 am 2010
Fernando Guzman Lugo
[PATCHv5 2/4] iovmm: add superpages support to fixed da ...
This patch adds superpages support to fixed ad address inside iommu_kmap function. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 62 +++++++++++++++++++++++++------------------ 1 files changed, 36 insertions(+), 26 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 34f0012..93a34d9 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -87,35 +87,43 @@ static size_t sgtable_len(const ...
Oct 25, 11:52 am 2010
Fernando Guzman Lugo
[PATCHv5 4/4] iommu: create new api to set valid da range
Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF rage. With this new API the valid range can be set. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/include/plat/iommu.h | 3 ++ arch/arm/plat-omap/iommu.c | 33 +++++++++++++++++++++++++++++++ arch/arm/plat-omap/iovmm.c | 18 ++++++++++------ 3 files changed, 47 insertions(+), 7 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/iommu.h ...
Oct 25, 11:52 am 2010
Fernando Guzman Lugo
[PATCHv5 3/4] iovmm: replace __iounmap with omap_iounmap
Omap platform is omap_iounmap function. Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com> --- arch/arm/plat-omap/iovmm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c index 93a34d9..5489ca9 100644 --- a/arch/arm/plat-omap/iovmm.c +++ b/arch/arm/plat-omap/iovmm.c @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da) struct sg_table *sgt; typedef void (*func_t)(const void *); - sgt = ...
Oct 25, 11:52 am 2010
Paul Fulghum
Re: [PATCH] n_hdlc fix read and write locking
Yes if I embed an assignment in the event expression: rc = wait_event_interruptible(&wait, (buf = get_buf())); if (!rc) process_buf(buf); Is that considered acceptable? -- Paul Fulghum MicroGate Systems, Ltd. =Customer Driven, by Design= (800)444-1982 (512)345-7791 (Direct) (512)343-9046 (Fax) Central Time Zone (GMT -5h) www.microgate.com --
Oct 25, 4:18 pm 2010
Arnd Bergmann
Re: [PATCH] n_hdlc fix read and write locking
Right. I must have missed this when I was not checking for interruptible_sleep_on(). I did systematically check for this problem with the wait_event family as well as work_queues, mutexes, semaphores and hand-written schedule loops, but for some reason I did not check for sleep_on :( I've double-checked it now, and it seems that all other instances of sleep_on are waiting for close_wait in block_til_ready or open functions, and I remember that Would it be possible to express the same ...
Oct 25, 1:31 pm 2010
Andrew Morton
Re: [PATCH] n_hdlc fix read and write locking
On Mon, 25 Oct 2010 13:22:39 -0500 It's not a bug afaict, but beware that a copy_to_user() will unconditionally flip this task back into TASK_RUNNING state if it takes a pagefault. This means that the below schedule() will fall straight through. It looks like the code will handle this correctly? If so, --
Oct 25, 1:05 pm 2010
Paul Fulghum
[PATCH] n_hdlc fix read and write locking
Fix locking in read and write code of n_hdlc line discipline. 2.6.36 replaced lock_kernel() with tty_lock(). The tty mutex is not dropped automatically when the thread sleeps like the BKL. This results in a blocked read or write holding the tty mutex and stalling operations by other devices that use the tty mutex. A review of n_hdlc read and write code shows: 1. neither BKL or tty mutex are required for correct operation 2. read can block while read data is available if data is posted ...
Oct 25, 1:29 pm 2010
Paul Fulghum
Re: [PATCH] n_hdlc fix read and write locking
copy_to_user is only called when data is available to complete the read and break terminates the loop without I'll change it to __set_current_state() and resubmit. -- Paul Fulghum MicroGate Systems, Ltd. =Customer Driven, by Design= (800)444-1982 (512)345-7791 (Direct) (512)343-9046 (Fax) Central Time Zone (GMT -6h) www.microgate.com --
Oct 25, 2:19 pm 2010
Paul Fulghum
[PATCH] n_hdlc fix read and write locking
Fix locking in read and write code of n_hdlc line discipline. 2.6.36 replaced lock_kernel() with tty_lock(). The tty mutex is not dropped automatically when the thread sleeps like the BKL. This results in a blocked read or write holding the tty mutex and stalling operations by other devices that use the tty mutex. A review of n_hdlc read and write code shows: 1. neither BKL or tty mutex are required for correct operation 2. read can block while read data is available if data is posted ...
Oct 25, 11:22 am 2010
Maciej Szmigiero
[V4L][SAA7134] fix tda9887 detection on cold and eeprom ...
[V4L][SAA7134] fix tda9887 detection on cold and eeprom read corruption on warm Medion 7134 When Medion 7134 analog+DVB-T card is cold (after powerup) the tda9887 analog demodulator won't show on i2c bus. This results in no signal on analog TV. After loading driver for second time eeprom (required for tuner autodetection) read is corrupted, but tda9987 is detected properly and analog TV works when tuner model is forced. Fix tda9887 problem by moving its detect code after tuner setup which ...
Oct 25, 10:59 am 2010
Mathieu Desnoyers
[RFC] TRACE_EVENT: mapping "=" and memcpy to macros
LTTng needs to override the assignment primitives to deal with cross-page writes. A first step needed to move LTTng to TRACE_EVENT is to introduce the following macros: for ftrace and perf: #define __assign(dest, src) (dest) = (src) #define __assign_memcpy(dest, src, len) memcpy(dest, src, len) which would turn (e.g.) TP_fast_assign( memcpy(__entry->comm, t->comm, TASK_COMM_LEN); __entry->pid = t->pid; ...
Oct 25, 10:39 am 2010
Divy Le Ray
[PATCH net-2.6] cxgb3: fix device opening error path
From: Divy Le Ray <divy@chelsio.com> Only negative return from bind_qsets() should be considered an error and propagated. It fixes an issue reported by IBM on P Series platform. Signed-off-by: Divy Le Ray <divy@chelsio.com> Tested-by: Nishanth Aravamudan <nacc@us.ibm.com> --- drivers/net/cxgb3/cxgb3_main.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cxgb3/cxgb3_main.c index a04ce6a..4e3c123 100644 --- ...
Oct 25, 10:35 am 2010
Kevin Hilman
[GIT PULL] davinci updates for 2.6.37
Linus, Please pull davinci platform updates for 2.6.37: ssh://master.kernel.org/pub/scm/linux/kernel/git/khilman/linux-davinci.git davinci-for-linus Note that I also merged Russell King's devel branch (which you already merged) in order to fixup some final conflicts. diffstat/shortlog follows for just the davinci specific parts. Thanks, Kevin MAINTAINERS | 4 +- arch/arm/configs/da8xx_omapl_defconfig | 3 + ...
Oct 25, 10:08 am 2010
Boaz Harrosh
[GIT PULL] exofs: few changes for the 2.6.37 merge window
Linus please pull the following changes since commit cd07202c Linux 2.6.36-rc8 (2010-10-14 16:26:43 -0700) From the git repository at: git://git.open-osd.org/linux-open-osd.git for-linus Just a few fixes and cleanups that have accumulated. Nothing really exiting expect one patch that is important for Nick's scalability work. Boaz Harrosh (3): exofs: Cleaup read path in regard with read_for_write exofs: Set i_mapping->backing_dev_info anyway exofs: Remove ...
Oct 25, 10:05 am 2010
Per Forlin
DMAENGINE: Client reuse of desc
Hi, DMA_CTRL_ACK is used if the client needs to set up a dependency chain of descriptor. This mean the driver cannot reuse or free the descriptor until the client release it. I wonder if the client is permitted/safe to reuse the descriptor and submit it again to the driver? Or would dmaengine need an additional flag for this feature. I know that the intent of DMA_CTRL_ACK is not to allow reuse of desc from a client perspective. I am asking because I made this assumption when implementing it ...
Oct 25, 9:43 am 2010
Alex Dubov
Re: [PATCH 0/29] My patch queue for memorystick subsystem
I would like to summarize my impression until now: 1. There are 3 functional fixes to Jmicron driver, which are rather small when taken to their essence (disregarding renames and idle code movements). 2. There is 1 functional enhancement to the MS Pro driver, not too big, pertaining to extended command execution and resulting in 10% speedup in some cases. 3. There are 25 patches which just rewrite everything for no good reason (by this I mean bugs or missing functionality). Why don't we ...
Oct 25, 9:25 am 2010
Alex Dubov Oct 25, 9:17 am 2010
Alex Dubov Oct 25, 9:14 am 2010
Alex Dubov
Re: [PATCH 23/29] memstick: jmb38x_ms: use DMA for all T ...
I have not noticed this one before, and for all I know the driver was tested at Jmicron. Can you explain the issue a bit more? --
Oct 25, 9:12 am 2010
Alex Dubov Oct 25, 9:11 am 2010
Alex Dubov
Re: [PATCH 0/29] My patch queue for memorystick subsystem
My problem here is that out of 30 patches, 20 appear to be rewrites and clean-ups of things not broken. That's why I'd rather prefer to see actual functional changes first. --
Oct 25, 9:10 am 2010
Alex Dubov Oct 25, 9:08 am 2010
Alex Dubov
Re: [PATCH 20/29] memstick: jmb38x_ms: rework PIO
Yet, you are fixing something that was not broken before. --
Oct 25, 9:05 am 2010
Alex Dubov
Re: [PATCH 19/29] memstick: jmb38x_ms: add register read ...
This looks like a case of: 1. You've run into a technical difficulty. 2. You used some temporary code to resolve and document it. 3. Now this temporary code is forever here to stay. --
Oct 25, 9:03 am 2010
Alex Dubov
Re: [PATCH 18/29] memstick: jmb38x_ms: rename functions
Just like 2/3 of your patches in this pack, until now. --
Oct 25, 9:00 am 2010
Alex Dubov Oct 25, 9:00 am 2010
Alex Dubov
Re: [PATCH 16/29] memstick: jmb38x_ms: s/jmb38x_ms/j38ms/g
What sort of patch/argument is this? Function prefix should match the module name, to be immediately and unambiguously identifiable in the stack trace. --
Oct 25, 8:58 am 2010
Alex Dubov
Re: [PATCH 15/29] memstick: jmb38x_ms: Create header
Yet again, what's wrong with DYNAMIC_DEBUG? --
Oct 25, 8:56 am 2010
Alex Dubov
Re: [PATCH 14/29] memstick: remove the memstick_set_rw_addr
How is an obscure invalidate_reg_window function is any better than explicit set_rw_addr? Total number of calls to either of them is exactly the same. Sony state machine diagrams suggest that doing a precise set_rw_addr when necessary is a good thing. The feature was originally conceived because Sony intended to manufacture MSIO and hybrid devices, which might have very large number of registers (hundreds). It was also supposed to help with backward compatibility of devices, as well as ...
Oct 25, 8:55 am 2010
Sam Ravnborg
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
I have a nice eval board at my desk with a dual-core LEON4 processor. I only lack time to play with it... Sam --
Oct 25, 9:11 am 2010
David Miller
Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
From: Namhyung Kim <namhyung@gmail.com> The generic non-hw perf event stuff builds fine on sparc32, please don't remove this unless you have a legitimate build failure to report and fix. Even if sparc32 doesn't provide atomic64_t support, it very easily could do so using include/asm-generic/atomic64.h which implements them using spinlocks. --
Oct 25, 8:59 am 2010
Namhyung Kim
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
If I understood correctly, you meant this? diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 4db8bc0..a6685ba 100644 --- a/arch/sparc/Kconfig +++ b/arch/sparc/Kconfig @@ -463,7 +463,7 @@ config SERIAL_CONSOLE config SPARC_LEON bool "Sparc Leon processor family" - depends on SPARC32 + depends on SPARC32 && !SMP ---help--- If you say Y here if you are running on a SPARC-LEON processor. The LEON processor is a synthesizable ...
Oct 25, 9:07 am 2010
David Miller
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
From: Namhyung Kim <namhyung@gmail.com> Yes, something like that. --
Oct 25, 9:09 am 2010
Namhyung Kim
[PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
Remove HAVE_PERF_EVENTS and PERF_USE_VMALLOC under config SPARC because they're under SPARC64 too. Supporting perf_event needs atomic64 operations but AFAIK sparc32 doesn't provide them, CMIIW. ;-) Also removes redundant HAVE_IRQ_WORK line. Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- arch/sparc/Kconfig | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig index 3e9d314..4db8bc0 100644 --- a/arch/sparc/Kconfig +++ ...
Oct 25, 8:52 am 2010
Namhyung Kim
[PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON
CC arch/sparc/kernel/irq_32.o arch/sparc/kernel/irq_32.c: In function 'request_fast_irq': arch/sparc/kernel/irq_32.c:370:25: error: conflicting types for 'trapbase_cpu1' arch/sparc/include/asm/leon.h:366:22: note: previous declaration of 'trapbase_cpu1' was here arch/sparc/kernel/irq_32.c:370:40: error: conflicting types for 'trapbase_cpu2' arch/sparc/include/asm/leon.h:367:22: note: previous declaration of 'trapbase_cpu2' was here arch/sparc/kernel/irq_32.c:370:55: error: conflicting types ...
Oct 25, 8:52 am 2010
David Miller
Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
From: Namhyung Kim <namhyung@gmail.com> Nevermind, I see the issue. Ok, your patch is fine: Acked-by: David S. Miller <davem@davemloft.net> --
Oct 25, 11:55 am 2010
Sam Ravnborg
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
Yup - I agree. My only intention was to tell that such a processor exists in reality and not only on paper. Sam --
Oct 25, 12:41 pm 2010
David Miller
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
From: Sam Ravnborg <sam@ravnborg.org> Ok. But whenever someone gets a time to play with it and verify it works, we can sort out this build failure by modifying the code as needed. But for now I prefer the Kconfig SMP dependency fix. --
Oct 25, 11:53 am 2010
Namhyung Kim
[PATCH 1/3] sparc: don't #include asm/system.h in asm/ju ...
It seems that #include <asm/system.h> makes a circular dependency between kernel.h and bitmap.h which breaks allmodconfig build. Removing the line makes no change because jump_label.h doesn't need it actually AFAICS. Compile tested on sparc32 allmodconfig. Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- Failed build log is as following: CC arch/sparc/kernel/asm-offsets.s In file included from include/linux/cpumask.h:11:0, from ...
Oct 25, 8:52 am 2010
David Miller
Re: [PATCH 3/3] sparc32: fix build failure on CONFIG_SPA ...
From: Namhyung Kim <namhyung@gmail.com> I doubt SMP LEON chips even exist, so better to just anti-dep this in arch/sparc/Kconfig --
Oct 25, 9:00 am 2010
Namhyung Kim
Re: [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option
Now I see following build failure without this patch. Maybe some work is needed to deal with atomic64_t. I'll try to prepare for it soon. Thanks. CC arch/sparc/kernel/setup_32.o In file included from arch/sparc/include/asm/local64.h:1:0, from include/linux/perf_event.h:465, from include/linux/ftrace_event.h:8, from include/trace/syscall.h:6, from include/linux/syscalls.h:76, from ...
Oct 25, 9:31 am 2010
David Miller
Re: [PATCH 1/3] sparc: don't #include asm/system.h in as ...
From: Namhyung Kim <namhyung@gmail.com> Acked-by: David S. Miller <davem@davemloft.net> --
Oct 25, 8:57 am 2010
Alexey Zaytsev
Adding more stuff to devres.
Hi. Would it be a good idea to get things other than resources managed by the devres? In my probe() method, I still have to handle alloc_netdev() and mdiobus_alloc(). Adding corresponding devm_ functions should be trivial. So, should I prepare the patches, or is there something wrong with the approach? --
Oct 25, 8:52 am 2010
Hin-Tak Leung
Re: [PATCH] drivers: rtl818x: request DMA-able memory
okay - sorry about the confusion - I was grep'ing for GFP_DMA and only b43/b43lagacy have it and it is relatively rare. AFAIK none of the rtl8187 devices are non-USB... probably a NACK then, but I should ask Serafeim if there is a reason for him to submit this patch? (other than "it says dma"...) Hin-tak --
Oct 25, 8:39 am 2010
Larry Finger
Re: [PATCH] drivers: rtl818x: request DMA-able memory
There are some devices driven by b43/b43legacy that implement only 24-bit DMA. For that reason, they need to allocate DMA buffers in the low 16 MB of RAM. For rtl8187, that consideration does not apply. Larry --
Oct 25, 11:01 am 2010
Robert Richter
[GIT PULL] oprofile updates for v2.6.37
Ingo, please consider to pull AMD oprofile cpu updates for tip/perf/core and v2.6.37: git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git x86 Thanks, -Robert The following changes since commit d4429f608abde89e8bc1e24b43cd503feb95c496: Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc (2010-10-21 21:19:54 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git ...
Oct 25, 8:46 am 2010
Ingo Molnar Oct 25, 10:16 am 2010
Paul E. McKenney
Re: Question about synchronize_sched_expedited()
I believe so -- there was a mutex guarding the whole operation, including Hmmm... But it would be necessary to flip the queues somewhere, and wouldn't determining where that somewhere was involve the same analysis and complexity as determining where to increment the counter? Thanx, Paul --
Oct 25, 12:41 pm 2010
Tejun Heo
Re: Question about synchronize_sched_expedited()
Hello, Paul. I think your concern is valid and this can happen w/o preemption given enough cpus and perfect timing. Was the original code free from this problem? IMHO the counter based mechanism is a bit too difficult to ponder and verify. Can we do more conventional double queueing (ie. flipping pending and executing queues so that multiple sync calls can get coalesced while another one is in progress)? That's what the code is trying to achieve anyway, right? Thanks. -- ...
Oct 25, 9:03 am 2010
Paul E. McKenney
Question about synchronize_sched_expedited()
Hello, Tejun, I was taking another look at synchronize_sched_expedited(), and was concerned about the scenario listed out in the following commit. Is this scenario a real problem, or am I missing the synchronization that makes it safe? (If my concerns are valid, I should also be able to change this to non-atomically increment synchronize_sched_expedited_count, but one step at a time...) Thanx, Paul ------------------------------------------------------------------------ commit ...
Oct 25, 8:43 am 2010
Alex Dubov
Re: [PATCH 13/29] memstick: core: stop passing pointer t ...
Unfortunately, the description does not match the patch. While the main optimization (merging req and card arguments for good) is fully reasonable given the posterior knowledge of MSPro evolution, this patch introduces some functional changes as well, which can not be --
Oct 25, 8:41 am 2010
emprestador do empré ...
empréstimo
Bem-vindo oferecer garantia de empréstimo a taxa reduzida de 3% para o seu negócio e outros motivos pessoais. Para mais informações contacte-nos através do email: adambarrys@gmail.com --
Oct 25, 8:09 am 2010
Alex Dubov
Re: [PATCH 12/29] memstick: mspro: rework interface switch
This patch does somewhat more, than just removing the dead code. Description/rationale? --
Oct 25, 8:28 am 2010
Alex Dubov
Re: [PATCH 11/29] memstick: mspro: use MS_TPC_EX_SET_CMD
1. Names for states. 2. Coding style. 3. Introduction of struct mspro_cmdex_argument belongs to this patch. --
Oct 25, 8:27 am 2010
Alex Dubov
Re: [PATCH 10/29] memstick: mspro: create _setup_io helper.
1. This should precede the read_attribute function patch. 2. Coding style. --
Oct 25, 8:25 am 2010
Richard Weinberger
[PATCH] um: Fix IRQ flag handling naming
Commit df9ee292 changed the IRQ flag handling naming scheme and broke UML. This patch brings the new scheme to UML and makes it work again. Signed-off-by: Richard Weinberger <richard@nod.at> --- arch/um/include/asm/system.h | 49 +++++++++++++++++++++++++++-------------- 1 files changed, 32 insertions(+), 17 deletions(-) diff --git a/arch/um/include/asm/system.h b/arch/um/include/asm/system.h index 93af1cf..68a90ec 100644 --- a/arch/um/include/asm/system.h +++ ...
Oct 25, 8:24 am 2010
Andrew Morton
Re: [PATCH] um: Fix IRQ flag handling naming
On Mon, 25 Oct 2010 17:24:33 +0200 Please always fully describe a bug when fixing it. Something more than "broke". In the case of compilation errors or warnings, that means quoting the compiler error output and, if necessary, the means of reproducing it (config, compiler version, etc). I did an allnoconfig uml build and saw this: In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5, from /usr/src/25/arch/um/include/shared/um_uaccess.h:10, ...
Oct 25, 12:29 pm 2010
Richard Weinberger
Re: [PATCH] um: Fix IRQ flag handling naming
Sorry! I forgot to add the LKML-Reference to my initial report. Yes, this is the error. Thanks, //richard --
Oct 25, 12:38 pm 2010
Alex Dubov
Re: [PATCH 09/29] memstick: rework state machines + attr ...
As I said before: 1. Rationale for this "new style". 2. Human readable names for states and state transitions. Belongs to separate patch. Attribute read function is quite isolated from everything else. --
Oct 25, 8:23 am 2010
Alex Dubov
Re: [PATCH 08/29] memstick: mspro: add comments to few f ...
Comments of new functions belong to the patch which introduces these new functions. And those functions (as I already said) belong to the patch which introduces new functionality, using these functions, desirably, one function at a time. --
Oct 25, 8:18 am 2010
Alex Dubov Oct 25, 8:13 am 2010
Alex Dubov
Re: [PATCH 06/29] memstick: mspro: kill the BKL
It is indeed, but I don't see the functionality this patch is trying to revert neither in my running kernel (2.6.32.8) nor in current git tree. --
Oct 25, 8:12 am 2010
Alex Dubov
Re: [PATCH 05/29] memstick: mspro_block: move declaratio ...
Subjective and irrelevant. My editor makes it easier to look up things when they are in the same file, and this declarations are not expected to be used by any other compilation Should be done through a common kernel infrastructure, namely DYNAMIC_DEBUG feature (pr_debug and friends). --
Oct 25, 8:07 am 2010
Alex Dubov
Re: [PATCH 04/29] memstick: core: rework state machines
1. This is an important functional patch. At present, "new style" exists only in your head. You should make an effort to justify it to everybody else by providing a rationale in patch description. 2. You are using an integer state variable (instead of function pointers which were self-describing by virtue of the referred function names). Please, define an enumerated type for this state variable, giving states human-readable, descriptive names. If you need to do state variable arithmetic, you ...
Oct 25, 8:01 am 2010
Alex Dubov
Re: [PATCH 03/29] memstick: core: add new functions
You're adding here a lot of temporarily dead code, which, while being useful, should be better added together with the actual driver functionality. Besides this, the patch has a lot of unneeded clean-ups which are better be set as a separate patch. And it doesn't conform to the coding guideline either (4 byte indents, instead of tabs). --
Oct 25, 7:56 am 2010
Alex Dubov
Re: [PATCH 02/29] memstick: core: reorder functions This ...
I'm not sure this purely subjective patch is of any real utility. And at any rate, it belongs to the end of the patchset (where the clean-up normally go), not to the beginning. --
Oct 25, 7:50 am 2010
Richard Röjfors
[PATCH 0/2 v3] media, mfd: Add timberdale video-in driver
To follow are two patches. The first adds the timberdale video-in driver to the media tree. The second adds it to the timberdale MFD driver. Changes since last version: * Using the unlocked_ioctl to avoid BKL, instead using a mutex in the ioctl callbacks where needed. * The try_fmt function does _not_ set the format anymore. As Samuel pointed out earlier the patch to timberdale should be trivial so I hope Mauro can take the patches via his tree. Thanks --Richard --
Oct 25, 7:40 am 2010
Richard Röjfors
[PATCH 2/2 v3] mfd: Add timberdale video-in driver to ti ...
This patch defines platform data for the video-in driver and adds it to all configurations of timberdale. Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com> Acked-by: Samuel Ortiz <sameo@linux.intel.com> --- diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c index ac59950..52a651b 100644 --- a/drivers/mfd/timberdale.c +++ b/drivers/mfd/timberdale.c @@ -40,6 +40,7 @@ #include <linux/spi/mc33880.h> #include <media/timb_radio.h> +#include <media/timb_video.h> ...
Oct 25, 7:40 am 2010
Alex Dubov
Re: [PATCH 01/29] memstick: core: header cleanups
This introduces unnecessary noise and can be merged into a common clean-up This functional changes are better be joined with the first patch which --
Oct 25, 7:44 am 2010
Eric Dumazet
Re: [PATCH] net: b43legacy: fix compile error
Anyway, Arnd patch is fine by me, I didnt want to supply an alternate patch. I only was wondering why the include was in this driver... --
Oct 25, 12:56 pm 2010
Larry Finger
Re: [PATCH] net: b43legacy: fix compile error
That probably makes the difference. Using Eric's fix that removes the #include <linux/dst.h> should be better. Does it work for you? There are probably a lot more of the system includes that may not be needed. If I send you a patch removing them, could you test? Larry --
Oct 25, 11:36 am 2010
Arnd Hannemann
Re: [PATCH] net: b43legacy: fix compile error
As it turns out my card is not supported by b43legacy, but compilation testing, sure I can test that. Regards, Arnd --
Oct 25, 11:44 am 2010
Eric Dumazet
Re: [PATCH] net: b43legacy: fix compile error
Well, x86_64 must include cache.h, this is probably why I missed it in my build tests. I wonder also why #include <net/dst.h> is needed at all in this driver... diff --git a/drivers/net/wireless/b43legacy/xmit.c b/drivers/net/wireless/b43legacy/xmit.c index 7d177d9..a261aec 100644 --- a/drivers/net/wireless/b43legacy/xmit.c +++ b/drivers/net/wireless/b43legacy/xmit.c @@ -28,8 +28,6 @@ */ -#include <net/dst.h> - #include "xmit.h" #include "phy.h" #include "dma.h" --
Oct 25, 8:51 am 2010
Arnd Hannemann
[PATCH] net: b43legacy: fix compile error
On todays linus tree the following compile error happened to me: CC [M] drivers/net/wireless/b43legacy/xmit.o In file included from include/net/dst.h:11, from drivers/net/wireless/b43legacy/xmit.c:31: include/net/dst_ops.h:28: error: expected ':', ',', ';', '}' or '__attribute__' before '____cacheline_aligned_in_smp' include/net/dst_ops.h: In function 'dst_entries_get_fast': include/net/dst_ops.h:33: error: 'struct dst_ops' has no member named ...
Oct 25, 7:41 am 2010
Arnd Hannemann
Re: [PATCH] net: b43legacy: fix compile error
Exactly the same git describe here. Maybe your arch includes cache.h already, in my case its a compile for ARM (shmobile). Regards Arnd --
Oct 25, 11:26 am 2010
Larry Finger
Re: [PATCH] net: b43legacy: fix compile error
I have no idea why that header was included - likely historical in the transformation from bcm43xx to b43legacy. For completeness, there are 2 more places to change: Index: linux-2.6/drivers/net/wireless/b43legacy/dma.c =================================================================== --- linux-2.6.orig/drivers/net/wireless/b43legacy/dma.c +++ linux-2.6/drivers/net/wireless/b43legacy/dma.c @@ -38,7 +38,6 @@ #include <linux/delay.h> #include <linux/skbuff.h> #include ...
Oct 25, 11:11 am 2010
Larry Finger
Re: [PATCH] net: b43legacy: fix compile error
Strange. Compiling b43legacy from the linux-2.6.git tree (git describe is v2.6.36-4464-g229aebb) works fine on x86_64. I wonder what is different. Larry --
Oct 25, 8:32 am 2010
Larry Finger
Re: [PATCH] net: b43legacy: fix compile error
If it is a Broadcom card, it is likely handled by b43. Attached is a trial removal of a number of include statements. Does it compile? Larry
Oct 25, 11:59 am 2010
Arnd Hannemann
Re: [PATCH] net: b43legacy: fix compile error
Nope: NSTALL_MOD_PATH=/home/arnd/projekte/renesas-2/nfs modules CHK include/linux/version.h CHK include/generated/utsrelease.h make[1]: `include/generated/mach-types.h' is up to date. CALL scripts/checksyscalls.sh CC [M] drivers/net/wireless/b43legacy/main.o drivers/net/wireless/b43legacy/main.c: In function 'b43legacy_upload_microcode': drivers/net/wireless/b43legacy/main.c:1688: error: implicit declaration of function 'signal_pending' make[4]: *** ...
Oct 25, 1:13 pm 2010
Richard Röjfors
[PATCH 1/2 v3] media: Add timberdale video-in driver
This patch adds the timberdale video-in driver. The video IP of timberdale delivers the video data via DMA. The driver uses the DMA api to handle DMA transfers, and make use of the V4L2 video buffers to handle buffers against user space. If available the driver uses an encoder to get/set the video standard Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com> --- diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index f6e4d04..1afbe26 100644 --- ...
Oct 25, 7:40 am 2010
Alex Dubov
Re: [PATCH 0/29] My patch queue for memorystick subsystem
If I understand the process correctly, probably no. It's going to take more time, considering the volume and nature of changes. There's also additional very unfortunate property of your patchset, namely you're mixing purely cosmetic and functional patches. Normally, functional patches should precede the cosmetic one, so that the functionality can be discussed first. --
Oct 25, 7:39 am 2010
Andrew Morton
Re: [PATCH 0/29] My patch queue for memorystick subsystem
More usually it's the other way around, actually: cleanups come first. Because the cleanups are usually uncontroversial, and because substantive changes against cleaner code are easier to review/understand and because the substantive changes are then easier to revert or fix. --
Oct 25, 9:07 am 2010
Robert Richter
[PATCH 0/5] mce, amd: code rework and cleanups
This patch set reworks code for the initial setup of MCE threshold block registers. It adds helper functions to make functions smaller and better to read. Finally some changes to error messages. -Robert --
Oct 25, 7:03 am 2010
Robert Richter
[PATCH 2/5] mce, amd: Shorten local variables mci_misc_{hi,lo}
Shorten this variables to make later changes more readable. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 26 +++++++++++++------------- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index f438318..eb771b9 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -93,37 +93,37 @@ struct thresh_restart { ...
Oct 25, 7:03 am 2010
Robert Richter
[PATCH 1/5] mce, amd: Implement mce_threshold_block_init ...
This patch adds a helper function for the initial setup of an mce threshold block. The LVT offset is passed as argument. Also making variable threshold_defaults local as it is only used in function mce_amd_feature_init(). Function threshold_restart_bank() is extended to setup the LVT offset, the change is backward compatible. Thus, now there is only a single wrmsrl() to setup the block. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 48 ...
Oct 25, 7:03 am 2010
Robert Richter
[PATCH 4/5] mce, amd: Remove goto in threshold_create_device()
Removing the goto in threshold_create_device(). Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index e316684..5bf2fac 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -622,9 +622,9 @@ static __cpuinit int threshold_create_device(unsigned int ...
Oct 25, 7:03 am 2010
Robert Richter
[PATCH 5/5] apic, amd: Make firmware bug messages more m ...
This improves error messages in case the BIOS was setting up wrong LVT offsets. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/kernel/apic/apic.c | 15 ++++++++------- arch/x86/oprofile/op_model_amd.c | 1 + 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 850657d..cb13048 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -433,17 +433,18 @@ int ...
Oct 25, 7:03 am 2010
Robert Richter
[PATCH 3/5] mce, amd: Add helper functions to setup APIC
This patch reworks and cleans up mce_amd_feature_init() by introducing helper functions to setup and check the LVT offset. It also fixes line endings in pr_err() calls. Signed-off-by: Robert Richter <robert.richter@amd.com> --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 67 +++++++++++++++++++--------------- 1 files changed, 38 insertions(+), 29 deletions(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index eb771b9..e316684 100644 --- ...
Oct 25, 7:03 am 2010
Martin Schwidefsky
[GIT PULL] s390 patches for 2.6.37
Hi Linus, please pull from 'for-linus' branch of git://git390.marist.edu/pub/scm/linux-2.6.git for-linus to receive the following updates: Andy Shevchenko (1): [S390] cio: remove custom implementation of hex_to_bin() Christian Borntraeger (2): [S390] kvm: Fix badness at include/asm/mmu_context.h:83 [S390] kvm: Enable z196 instruction facilities Christof Schmitt (1): [S390] set ARCH_HAS_SG_CHAIN for s390 FUJITA Tomonori (1): [S390] enable ...
Oct 25, 7:21 am 2010
David Howells
[PATCH] Partially revert patch that encloses asm-offset. ...
Partially revert patch: commit 3234282f33b29d349bcada40204fc7c8fda7fe72 Author: Jan Beulich <JBeulich@novell.com> Date: Tue Oct 19 14:52:26 2010 +0100 x86, asm: Fix CFI macro invocations to deal with shortcomings in gas This breaks MN10300 arch as this changes many instances of instructions similar to the following: MOV number,D0 which represents an immediate value load into: MOV (number),D0 which the assembler then interprets as a load from absolute ...
Oct 25, 7:02 am 2010
David Howells
Re: [PATCH] Partially revert patch that encloses asm-off ...
Whoever defined the gas assembly syntax for binutils specified that (N) as an operand defines an absolute address and N defines an immediate value. However, prefixing an expression with a unary plus works for me, so adding this into my patch: - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \ + s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \ Does that work for you? David --
Oct 25, 7:54 am 2010
David Howells Oct 25, 8:59 am 2010
Linus Torvalds
Re: [PATCH] Partially revert patch that encloses asm-off ...
This all seems very wrong. The whole "add parenthesis" seems to break several architectures (Power apparently had problems too due to redefining one of the macros), and it is ugly. And the whole thing was added for some stupid gas bug for a very specific case, and now we're adding _more_ crap to an already ugly workaround. How about just removing the idiotic workaround entirely, and then on x86 passing "-traditional" to cpp for asm input so that it doesn't add spaces in argument ...
Oct 25, 8:17 am 2010
H. Peter Anvin
Re: [PATCH] Partially revert patch that encloses asm-off ...
We already tried using -traditional, it didn't help the gas braindamage and it caused severe problems with header files (since -traditional removes the support for #x and x ## y). Bringing it back won't help. As such, the only options I can really think about overriding the sed expression for x86 or just saying gcc 2.16.90 or later is required... -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. --
Oct 25, 8:50 am 2010
Linus Torvalds
Re: [PATCH] Partially revert patch that encloses asm-off ...
gas, not gcc. But yeah, maybe we can do that. How long has this space breakage been going on? If it's a "we got a report from this one guy" kind of thing, then just saying "we don't support old gas versions because they are too broken" is probably the right thing to do. No reason to make for maintenance problems and uglier code if we can just say "get a newer gas" to a few people. It's not like we haven't done that with gcc and other tools too. Linus --
Oct 25, 9:16 am 2010
H. Peter Anvin Oct 25, 10:51 am 2010
Jan Beulich
Re: [PATCH] Partially revert patch that encloses asm-off ...
Hmm, I think it was an actual improvement to remove the use of -traditional. If fiddling with the globally used sed expression isn't considered acceptable, how about allowing the architecture to override it as necessary? Jan --
Oct 25, 8:29 am 2010
Ingo Molnar
Re: [PATCH] Partially revert patch that encloses asm-off ...
But that's not a valid argument - MN10300 worked before and we broke it => that's a This argument is not valid either - we added this change to fix a GAS bug to begin Correct - we should apply David's partial revert and then we'll need to solve our x86 quirk differently: for example by using a x86 and broken-GAS specific quirk. Thanks, Ingo --
Oct 25, 7:43 am 2010
Jan Beulich
Re: [PATCH] Partially revert patch that encloses asm-off ...
No, that's not going to work for x86. You're removing the parentheses Isn't this a gas bug then? Anywhere you use a plain number you This basically gets us back to the way things were before, thus Jan --
Oct 25, 7:34 am 2010
H. Peter Anvin
Re: [PATCH] Partially revert patch that encloses asm-off ...
The problem is that 2.16 isn't all that old; al lot of the "enterprise" distros still ship it or AFAIK even older versions. 2.6.90 which I *think* is the first fixed version dates from April 2005, so is currently 5 years old; maybe that is within reason to kill off. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. --
Oct 25, 9:37 am 2010
Jan Beulich
Re: [PATCH] Partially revert patch that encloses asm-off ...
Alexander, you seem to be having access to a worst case system - could you give this a try? Thanks, Jan --
Oct 25, 8:05 am 2010
Takashi Iwai
[GIT PULL] sound updates for 2.6.37-rc1
Linus, please pull ALSA updates for v2.6.37-rc1 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus The biggest changes are the update of ASoC core API, in addition to lots of fixes/updates in ASoC drivers. The summary regarding ASoC are: - Overhaul of the core APIs for registration of all kinds of devices, reducing the level of direct coupling between machine drivers and their CODEC and CPU drivers allowing ASoC machines to have multiple CODEC ...
Oct 25, 6:59 am 2010
Figo.zhang
[PATCH] mm/rmap.c: fix comment
clean up comment. Signed-off-by: Figo.zhang <figo1802@gmail.com> --- mm/rmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 92e6757..479540d 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -94,7 +94,7 @@ void anon_vma_chain_free(struct anon_vma_chain *anon_vma_chain) * anonymous pages mapped into it with that anon_vma. * * The common case will be that we already have one, but if - * if not we either need to find an adjacent ...
Oct 25, 6:32 am 2010
Rik van Riel
Re: [PATCH] mm/rmap.c: fix comment
Acked-by: Rik van Riel <riel@redhat.com> -- All rights reversed --
Oct 25, 8:21 am 2010
Ilkka Koskinen
[PATCH] input: spi: Driver for SPI data stream driven vibrator
This driver provides access to drive a vibrator connected to SPI data line via Input layer's Force Feedback interface. Client application provides samples (data streams) to be played as CUSTOM_DATA. The samples are stored in driver's internal buffers. The driver is not able to mix the given samples. Instead, it remembers the currently played sample and next one to be played. Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com> --- drivers/input/misc/Kconfig | 5 + ...
Oct 25, 6:31 am 2010
Matthew Garrett
[git pull] x86 platform drivers for 2.6.37
Hi Linus, Nothing hugely exciting here - some cleanups, a pile of bugfixes in the WMI code and an update of the ideapad driver so it works on a wider range of hardware. The IBM SMI-disabling driver might prove to be interesting to some, though. The following changes since commit f6f94e2ab1b33f0082ac22d71f66385a60d8157f: Linux 2.6.36 (2010-10-20 13:30:22 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mjg59/platform-drivers-x86.git ...
Oct 25, 6:17 am 2010
Masami Hiramatsu
[PATCH] [BUGFIX][RESEND] kprobes: Remove redundant text_ ...
Remove text_mutex locking in optimize_all_kprobes, because this function doesn't modify text. It simply queues probes on optimization list for kprobe_optimizer worker thread. Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Ingo Molnar <mingo@elte.hu> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Jason Baron <jbaron@redhat.com> Cc: ...
Oct 25, 6:18 am 2010
David Vrabel
[GIT PULL] UWB/WLP subsystem updates for 2.6.37-rc1
Linus, Please pull my final set of changes for the UWB/WLP subsystems that a) removes entire WLP subsystem and the single driver and b) orphans the UWB/WUSB subsystems. The WLP subsystem is being removed because there was never any commercially available hardware for it and there is little prospect of such hardware ever existing in the future. Thanks. David The following changes since commit 229aebb873e29726b91e076161649cf45154b0bf: Linus Torvalds (1): Merge branch ...
Oct 25, 6:17 am 2010
Miklos Szeredi
[PATCH] vfs: fix possible use after free in finish_open()
From: Miklos Szeredi <mszeredi@suse.cz> In finish_open() nd->path is used after nameidata_to_filp() already released it. Fix by acquiring a ref to nd->path and releasing after the last use. Similar fix needed in do_last(). Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> CC: stable@kernel.org --- fs/namei.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) Index: linux-2.6/fs/namei.c =================================================================== --- ...
Oct 25, 6:16 am 2010
Grant Likely
[git pull] device tree changes for 2.6.37
The following changes since commit d4429f608abde89e8bc1e24b43cd503feb95c496: Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc (2010-10-21 21:19:54 -0700) are available in the git repository at: git://git.secretlab.ca/git/linux-2.6 next-devicetree Andres Salomon (8): sparc: stop exporting openprom.h header of/sparc: convert various prom_* functions to use phandle sparc: break out some PROM device-tree building code out into ...
Oct 25, 5:58 am 2010
Nicolas Kaiser
[PATCH] davinci: simplify if-statement
A common do-while loop can be factored out from the end of the branches. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- arch/arm/mach-davinci/psc.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-davinci/psc.c b/arch/arm/mach-davinci/psc.c index 1b15dbd..a415804 100644 --- a/arch/arm/mach-davinci/psc.c +++ b/arch/arm/mach-davinci/psc.c @@ -83,21 +83,16 @@ void davinci_psc_config(unsigned int domain, unsigned int ctlr, pdctl1 = ...
Oct 25, 5:41 am 2010
KOSAKI Motohiro
mem-hotplug + ksm make lockdep warning
Hi Hugh, commit 62b61f611e(ksm: memory hotremove migration only) makes following lockdep warnings. Is this intentional? More detail: current lockdep hieralcy is here. memory_notify offline_pages lock_system_sleep(); mutex_lock(&pm_mutex); memory_notify(MEM_GOING_OFFLINE) __blocking_notifier_call_chain down_read(memory_chain.rwsem) ksm_memory_callback() mutex_lock(&ksm_thread_mutex); // memory_chain.rmsem -> ksm_thread_mutex ...
Oct 25, 3:49 am 2010
Toshiharu Okada
[PATCH v7] USB device driver of Topcliff PCH
Hi Greg This patch was acked by Michal Nazarewicz. Could you review this patch? Best regards Toshiharu Okada (OKI SEMICONDUCTOR) --- This patch adds the USB device driver of EG20T PCH. EG20T PCH is the platform controller hub that is going to be used in Intel's upcoming general embedded platform. All IO peripherals in EG20T PCH are actually devices sitting on AMBA bus. EG20T PCH has USB device I/F. Using this I/F, it is able to access system devices connected to USB ...
Oct 25, 3:24 am 2010
Richard Weinberger
um: function "foo" in kernel-offsets.h
Hi Al, Your commit a31769ed ("uml: cross-build support : kernel_offsets") adds this function to kernel-offsets.h: ---cut--- void foo(void) { #include <common-offsets.h> } ---cut--- What is the purpose of foo? Thanks, //richard --
Oct 25, 3:02 am 2010
Bernd Petrovitsch
Re: On Linux numbering scheme
On Mon, 2010-10-25 at 05:45 -0400, Artem S. Tashkinov wrote: `diff -urN` will show. SCNR ... What' the difference between 2010-3 and 2010-11? Hooray, 8 months. But what does that really tell us? Nothing about the released item. And we loose the information if there Yes, those that use years (and months) in their release numbering scheme. And no, because they release so often new "major" releases that they are thus inherently unstable and buggy. SCNR ... It makes absolutely no sense to ...
Oct 25, 3:04 am 2010
Artem S. Tashkinov
Re: On Linux numbering scheme
That's my point. "2.6" prefix is totally meaningless nowadays. I just want to rejuvenate the numbering scheme and make it easy to understand and comprehend. What's the difference between .16 and .36? Besides, I just think these huge numbers look unsightly. Do you know any other piece of software which has the same huge numbers? --
Oct 25, 2:45 am 2010
Tejun Heo
Re: On Linux numbering scheme
Well, there's no difference between 16 and 36, so what would be the rationale for changing it? The only reason is that it's unsightly and uncommon, but, if you ask me, 36 is _much_ closer to 42 and so is _much_ better. The glory days of kernel 42 are coming. Lo and behold. Also, it costs to change numbering scheme. Think about all the scripts, distros, poor admins and technical writers (and the dolphins and fishes). If 2.6. is too ugly and useless, let's let it wither away in places it ...
Oct 25, 2:56 am 2010
Nick Bowler
Re: On Linux numbering scheme
Yup: % less --version less 436 % xterm -version XTerm(262) 36 is small fry :) -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) --
Oct 25, 1:30 pm 2010
Denys Fedoryshchenko
2.6.35->2.6.36 regression, vanilla kernel panic, ppp or ...
Hi Here is what i got from netconsole [ 259.238755] BUG: unable to handle kernel paging request at f8ba001c [ 259.238953] IP: [<c0199ebe>] do_select+0x2cc/0x502 [ 259.239008] *pdpt = 0000000000a55001 *pde = 0000000036dd6067 *pte = 0000000000000000 [ 259.239008] Oops: 0000 [#1] SMP [ 259.239008] last sysfs file: /sys/devices/pnp0/00:02/rtc/rtc0/dev [ 259.239008] Modules linked in: rtc_cmos rtc_core rtc_lib act_skbedit sch_ingress sch_prio ...
Oct 25, 2:22 am 2010
Mike Frysinger
[PATCH 0/5] Blackfin updates for 2.6.37 (part 2)
My last push meant to include the new bfin_twi header, but I guess I fat fingered it. Other than a few tweaks the existing Blackfin tree, this pulls in the bfin_mac platform resource clean up as acked by David. He wanted one changeset to preserve bisection. Mike Frysinger (4): Blackfin: bfin_twi.h: start a common TWI header Blackfin: update defconfigs Blackfin: ppi/spi/twi headers: add missing __BFP undef Blackfin: fix inverted anomaly 05000481 logic Sonic Zhang (1): netdev: ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 18/18] ARM: LPAE: Add the Kconfig entries
This patch adds the ARM_LPAE and ARCH_PHYS_ADDR_T_64BIT Kconfig entries allowing LPAE support to be compiled into the kernel. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/mm/Kconfig | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig index 8493ed0..fb85a5f 100644 --- a/arch/arm/mm/Kconfig +++ b/arch/arm/mm/Kconfig @@ -615,6 +615,16 @@ config IO_36 comment "Processor Features" +config ...
Oct 25, 2:01 am 2010
Arnd Bergmann
Re: [RFC PATCH 13/18] ARM: LPAE: ensure dma_addr_t is th ...
This patch will become obsolete once the "unify dma_addr_t typedef" series from Fujita Tomonori is upstream, you will instead have to set CONFIG_ARCH_DMA_ADDR_T_64BIT. Arnd --
Oct 25, 4:08 am 2010
Catalin Marinas
[RFC PATCH 13/18] ARM: LPAE: ensure dma_addr_t is the sa ...
From: Will Deacon <will.deacon@arm.com> Now that phys_addr_t can be 64-bit on ARM, we must ensure that dma_addr_t is sufficiently large to hold physical addresses. This patch uses the types.h implementation in asm-generic to define the dma_addr_t type as the same width as phys_addr_t. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/types.h | 19 ++----------------- 1 files changed, 2 insertions(+), 17 ...
Oct 25, 2:00 am 2010
Arnd Bergmann
Re: [RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level p ...
Since the PGD is so extremely small, would it be possible to fold it into the mm_context_t in order to save an allocation? Or does the PGD still require page alignment? Do you also have patches to allow 40-bit virtual space? I suppose we will need that for KVM support in the future. Arnd --
Oct 25, 4:15 am 2010
Catalin Marinas
Re: [RFC PATCH 13/18] ARM: LPAE: ensure dma_addr_t is th ...
Yes, I know this and it's on my list to fix once I update the patches to 2.6.37-rc1. Thanks, Catalin --
Oct 25, 4:32 am 2010
Catalin Marinas
[RFC PATCH 14/18] ARM: LPAE: mark memory banks with star ...
From: Will Deacon <will.deacon@arm.com> Memory banks living outside of the 32-bit physical address space do not have a 1:1 pa <-> va mapping and therefore the __va macro may wrap. This patch ensures that such banks are marked as highmem so that the Kernel doesn't try to split them up when it sees that the wrapped virtual address overlaps the vmalloc space. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/mm/mmu.c | ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 11/18] ARM: LPAE: Add SMP support for the 3-l ...
With 3-level page tables, starting secondary CPUs required allocating the pgd as well. Since LPAE Linux uses TTBR1 for the kernel page tables, this patch reorders the CPU setup call in the head.S file so that the swapper_pg_dir is used. TTBR0 is set to the value generated by the primary CPU. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/kernel/head.S | 10 +++++----- arch/arm/kernel/smp.c | 34 +++++++++++++++++++++++++++++++--- 2 files changed, 36 insertions(+), ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 15/18] ARM: LPAE: use phys_addr_t for physica ...
From: Will Deacon <will.deacon@arm.com> The physical start address of memory may be > 4GB and therefore unrepresentable using an unsigned long. This patch changes early_mem and arm_add_memory to use phys_addr_t instead of unsigned long for the start address. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/kernel/setup.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 03/18] ARM: LPAE: use u32 instead of unsigned ...
From: Will Deacon <will.deacon@arm.com> When using 2-level paging, pte_t and pmd_t are typedefs for unsigned long but phys_addr_t is a typedef for u32. This patch uses u32 for the page table entry types when phys_addr_t is not 64-bit, allowing the same conversion specifier to be used for physical addresses and page table entries regardless of LPAE. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- ...
Oct 25, 1:59 am 2010
Catalin Marinas
[RFC PATCH 02/18] ARM: LPAE: Factor out 2-level page tab ...
This patch moves page table definitions from asm/page.h, asm/pgtable.h and asm/ptgable-hwdef.h into corresponding *-2level* files. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/page.h | 40 ------- arch/arm/include/asm/pgtable-2level-hwdef.h | 91 +++++++++++++++++ arch/arm/include/asm/pgtable-2level-types.h | 64 ++++++++++++ arch/arm/include/asm/pgtable-2level.h | 147 +++++++++++++++++++++++++++ ...
Oct 25, 1:59 am 2010
Catalin Marinas
[RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level page ...
This patch introduces the pgtable-3level*.h files with definitions specific to the LPAE page table format (3 levels of page tables). Each table is 4KB and has 512 64-bit entries. An entry can point to a 40-bit physical address. The young, write and exec software bits share the corresponding hardware bits (negated). Other software bits use spare bits in the PTE. The patch also changes some variable types from unsigned long or int to pteval_t or pgprot_t. Signed-off-by: Catalin Marinas ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 07/18] ARM: LPAE: Page table maintenance for ...
This patch modifies the pgd/pmd/pte manipulation functions to support the 3-level page table format. Since there is no need for an 'ext' argument to cpu_set_pte_ext(), this patch conditionally defines a different prototype for this function when CONFIG_ARM_LPAE. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/cpu-multi32.h | 8 ++++ arch/arm/include/asm/cpu-single.h | 4 ++ arch/arm/include/asm/pgalloc.h | 26 +++++++++++++ ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 12/18] ARM: LPAE: use phys_addr_t instead of ...
From: Will Deacon <will.deacon@arm.com> This patch ensures that the phys_addr_t datatype is used to represent physical addresses which may be beyond the range of an unsigned long. The virt <-> phys macros are updated accordingly to ensure that virtual addresses can remain as they are. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/memory.h | 17 +++++++++-------- arch/arm/include/asm/outercache.h | ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 08/18] ARM: LPAE: MMU setup for the 3-level p ...
This patch adds the MMU initialisation for the LPAE page table format. The swapper_pg_dir size with LPAE is 5 rather than 4 pages. The __v7_setup function configures the TTBRx split based on the PAGE_OFFSET and sets the corresponding TTB control and MAIRx bits (similar to PRRR/NMRR for TEX remapping). The 36-bit mappings (supersections) and a few other memory types in mmu.c are conditionally compiled. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/kernel/head.S | ...
Oct 25, 2:00 am 2010
Kirill A. Shutemov Oct 25, 3:17 am 2010
Catalin Marinas
[RFC PATCH 01/18] ARM: LPAE: Use PMD_(SHIFT|SIZE|MASK) i ...
PGDIR_SHIFT and PMD_SHIFT for the classic 2-level page table format have the same value (21). This patch converts the PGDIR_* uses in the kernel to the PMD_* equivalent. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/kernel/module.c | 2 +- arch/arm/kernel/smp.c | 2 +- arch/arm/mm/dma-mapping.c | 6 +++--- arch/arm/mm/mmu.c | 16 ++++++++-------- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/arm/kernel/module.c ...
Oct 25, 1:59 am 2010
Catalin Marinas
Re: [RFC PATCH 13/18] ARM: LPAE: ensure dma_addr_t is th ...
Yes, that's the plan, I was just waiting for -rc1 to rebase my patches (given the loooong review process on the ARM list, I don't expect the LPAE patches to be merged any time soon :)). Thanks, Catalin --
Oct 25, 5:31 am 2010
Catalin Marinas Oct 25, 3:35 am 2010
Catalin Marinas
Re: [RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level p ...
There are alignment restrictions, though not to a page size. Given the TTBR0 access range of the full 4GB (TTBCR.T0SZ = 0), the alignment required is 64 (2^6). We get this for the slab allocator anyway when the L1_CACHE_SHIFT is 6 but I could make this requirement explicit by I'm not sure how these would look like since the architecture is 32-bit (and I'm not familiar with KVM). With the MMU disabled, you can't access beyond the 4GB space anyway. KVM could use something like the pfn but ...
Oct 25, 4:59 am 2010
Catalin Marinas
[RFC PATCH 16/18] ARM: LPAE: add support for ATAG_MEM64
From: Will Deacon <will.deacon@arm.com> LPAE provides support for memory banks with physical addresses of up to 40 bits. This patch adds a new atag, ATAG_MEM64, so that the Kernel can be informed about memory that exists above the 4GB boundary. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/setup.h | 10 +++++++++- arch/arm/kernel/compat.c | 4 ++-- arch/arm/kernel/setup.c | 12 ...
Oct 25, 2:01 am 2010
Catalin Marinas
[RFC PATCH 00/18] ARM: Add support for the Large Physica ...
Hi, This set of patches adds support for the Large Physical Extensions on the ARM architecture (available with the Cortex-A15 processor). LPAE comes with a 3-level page table format (compared to 2-level for the classic one), allowing up to 40-bit physical address space. These patches split the arch/arm/ page table definitions into corresponding 2-level and 3-level files and ensure that the common code works with both variants. They also fix assumptions regarding the size of the physical ...
Oct 25, 1:59 am 2010
Catalin Marinas
[RFC PATCH 10/18] ARM: LPAE: Add context switching support
With LPAE, TTBRx registers are 64-bit. The ASID is stored in TTBR0 rather than a separate Context ID register. This patch makes the necessary changes to handle context switching on LPAE. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/mm/context.c | 18 ++++++++++++++++-- arch/arm/mm/proc-v7.S | 8 +++++++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c index b0ee9ba..d40d3fa 100644 --- ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 04/18] ARM: LPAE: Do not assume Linux PTEs ar ...
Placing the Linux PTEs at a 2KB offset inside a page is a workaround for the 2-level page table format where not enough spare bits are available. With LPAE this is no longer required. This patch changes such assumption by using a different macro, LINUX_PTE_OFFSET, which is defined to PTRS_PER_PTE for the 2-level page tables. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/pgalloc.h | 6 +++--- arch/arm/include/asm/pgtable-2level.h | 1 + ...
Oct 25, 1:59 am 2010
Arnd Bergmann
Re: [RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level p ...
I think you only need to set ARCH_MIN_TASKALIGN for that, which I was only talking about the Virtualization Extensions, my impression from the information that is publically available was that you'd only need to set some mode bits differently in order to make the virtual address space (I suppose that's what you call IPA) up to 40 bits instead of 32, and you'd be able to have the guest use a 40 bit physical address space from that. Are there any significant differences to Linux between ...
Oct 25, 6:25 am 2010
Catalin Marinas
[RFC PATCH 05/18] ARM: LPAE: Introduce L_PTE_NOEXEC and ...
The LPAE page table format needs to explicitly disable execution or write permissions on a page by setting the corresponding bits (similar to the classic page table format with Access Flag enabled). This patch introduces null definitions for the 2-level format and the actual noexec and nowrite bits for the LPAE format. It also changes several PTE maintenance macros and masks. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/pgtable-2level.h | 2 ++ ...
Oct 25, 2:00 am 2010
Kirill A. Shutemov Oct 25, 5:01 am 2010
Catalin Marinas
Re: [RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level p ...
The mm_context_t is part of mm_struct, so I'm not sure how ARCH_MIN_TASKALIGN would affect this (unless I misunderstood your You can look at the IPA as the virtual address translation set up by the hypervisor (stage 2 translation). The guest OS only sets up stage 1 translations but can use 40-bit physical addresses (via stage 1) with or without the hypervisor. The input to the stage 1 translations is always can use (you need some code running in hypervisor mode to turn this on). The format ...
Oct 25, 9:18 am 2010
FUJITA Tomonori
Re: [RFC PATCH 13/18] ARM: LPAE: ensure dma_addr_t is th ...
On Mon, 25 Oct 2010 12:32:09 +0100 This patch also conflicts with the patchset removing dma64_addr_t (you really don't need dma64_addr_t): http://marc.info/?l=linux-arch&m=128685377524976&w=2 Both in -mm and I think Andrew will merge both CONFIG_ARCH_DMA_ADDR_T_64BIT and dma64_addr_t patchset. So how about dropping this patch and folding the following into your 18th patch. Then Andrew will not get the conflict and -rc1 works fine for you. diff --git a/arch/arm/mm/Kconfig ...
Oct 25, 5:01 am 2010
Catalin Marinas
[RFC PATCH 09/18] ARM: LPAE: Add fault handling support
The DFSR and IFSR register format is different when LPAE is enabled. In addition, DFSR and IFSR have the similar definitions for the fault type. This modifies modifies the fault code to correctly handle the new format. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/mm/alignment.c | 8 ++++- arch/arm/mm/fault.c | 80 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 87 insertions(+), 1 deletions(-) diff --git a/arch/arm/mm/alignment.c ...
Oct 25, 2:00 am 2010
Catalin Marinas
[RFC PATCH 17/18] ARM: LPAE: define printk format for ph ...
From: Will Deacon <will.deacon@arm.com> Now that the Kernel supports 2 level and 3 level page tables, physical addresses (and also page table entries) may be 32 or 64-bits depending upon the configuration. This patch adds a conversion specifier (PHYS_ADDR_FMT) which represents a u32 or u64 depending on the width of a physical address. Signed-off-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm/include/asm/types.h | 6 ++++++ ...
Oct 25, 2:01 am 2010
Arnd Bergmann
Re: [RFC PATCH 06/18] ARM: LPAE: Introduce the 3-level p ...
Sorry about that, I was following the wrong code path. It should Good point. At the very least, qemu would need a way to get at the highmem portion of the guest that is not normally part of the qemu virtual address space. In fact this would already be required without LPAE in order to run a VM with 4GB guest physical addressing. There are probable (slow) ways of doing that, e.g. remap_file_pages or a new syscall for accessing high guest memory. It's not entirely clear to me how useful ...
Oct 25, 11:25 am 2010
Mathias Burén
ext4 file system size limit
Hi lkml, (please cc as not subscribed) The ext4 documentation says the current file system size limit is 16TB. I currently have an fs of 6TB which is working fine, but I'm planning to expand it. Are there any known bugs with large file systems, or is it safe for me to proceed and extent the fs? (up to 16TB) Regards, // Mathias --
Oct 25, 1:41 am 2010
Toshiharu Okada
Re: [PATCH v6] USB device driver of Topcliff PCH
----- Date: Mon, 25 Oct 2010 11:09:23 +0200 Thank you for your reply and information. Best regards Toshiharu Okada (OKI SEMICONDUCTOR) --
Oct 25, 2:41 am 2010
Michał Nazarewicz
Re: [PATCH v6] USB device driver of Topcliff PCH
I'm in no power of deciding what gets accepted or rejected. My Acked-by only meant that after looking at the code a few times, I saw no obvious problems with the patch. If you wish for this patch to be included you should send it to or at least cc Also, emtpy line at the end of file. If you're going to resend the patch, please remove the line. -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer ...
Oct 25, 2:09 am 2010
Toshiharu Okada
[PATCH v6] USB device driver of Topcliff PCH
Hi Michal This driver AUTHOR was changed to "Toshiharu Okada" from "Masayuki Ohtake". We updated the Kconfig and Makefile, renamed "Topcliff" to "EG20T". This patch had not been added to the Linus's kernel tree yet after your "Acked-by". Do we need other actions in order to add this driver to the Linus's kernel tree. Best regards Toshiharu Okada (OKI SEMICONDUCTOR) --- This patch adds the USB device driver of EG20T PCH. EG20T PCH is the platform controller hub that is going to be used ...
Oct 25, 1:17 am 2010
Feng Tang
[PATCH] x86: unify current 3 similar ways of saving IRQ info
There are 3 places defining the similar function of saving IRQ vector info into mp_irqs[] array: mmparse/acpi/sfi. This patch will reduce the redundant code, and make it only one API: void mp_save_irq(struct mpc_intsrc *m); Signed-off-by: Feng Tang <feng.tang@intel.com> Cc: x86@kernel.org <x86 maintainers> Cc: Len Brown <len.brown@intel.com> --- arch/x86/include/asm/mpspec.h | 6 ++++++ arch/x86/kernel/acpi/boot.c | 32 +++----------------------------- arch/x86/kernel/mpparse.c ...
Oct 25, 1:36 am 2010
Huang Ying
[PATCH -v2 0/9] ACPI, APEI patches for 2.6.37
v2: - Some minor changes according to Andi's comments. [PATCH -v2 1/9] ACPI, APEI, Add ERST record ID cache [PATCH -v2 2/9] Add lock-less version of bitmap_set/clear [PATCH -v2 3/9] lock-less NULL terminated single list implementation [PATCH -v2 4/9] lock-less general memory allocator [PATCH -v2 5/9] Hardware error device core [PATCH -v2 6/9] Hardware error record persistent support [PATCH -v2 7/9] ACPI, APEI, Use ERST for hardware error persisting before panic [PATCH -v2 8/9] ACPI, APEI, ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 1/9] ACPI, APEI, Add ERST record ID cache
APEI ERST firmware interface and implementation has no multiple users in mind. For example, there is four records in storage with ID: 1, 2, 3 and 4, if two ERST readers enumerate the records via GET_NEXT_RECORD_ID as follow, reader 1 reader 2 1 2 3 4 -1 -1 where -1 signals there is no more record ID. Reader 1 has no chance to check record 2 and 4, while reader 2 has no chance to check record 1 and 3. And any other GET_NEXT_RECORD_ID will return -1, that is, other readers ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 3/9] lock-less NULL terminated single list im ...
Cmpxchg is used to implement adding new entry to list, deleting first entry of the list and some other operations. Because this is a single list, so the tail can not be accessed in O(1). This can be used in NMI handler. Signed-off-by: Huang Ying <ying.huang@intel.com> Reviewed-by: Andi Kleen <ak@linux.intel.com> --- include/linux/llist.h | 64 ++++++++++++++++++++++++++++++++++++++ lib/Kconfig | 3 + lib/Makefile | 2 + lib/llist.c | 84 ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 8/9] ACPI, APEI, Report GHES error record wit ...
One hardware error device (struct herr_dev) is created for each GHES in GHES platform device "probe" function. Then when GHES hardware error handler is notified by firmware, the hardware error records will be reported on the struct herr_dev. In the previous GHES support, only corrected memory error can be reported to user space via /dev/mcelog, now all kinds of hardware errors notified with SCI can be reported. Signed-off-by: Huang Ying <ying.huang@intel.com> Reviewed-by: Andi Kleen ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 5/9] Hardware error device core
Hardware error device is a kind of device which can report hardware errors. The examples of hardware error device include APEI GHES, PCIe AER, etc. Hardware error device core in this patch provides common services for various hardware error devices. Hardware error record data structure is defined to accommodate various hardware error information. Several error sections can be incorporated into one error record to accumulate information for multiple hardware components related to one error. ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 9/9] ACPI, APEI, Generic Hardware Error Sourc ...
Generic Hardware Error Source provides a way to report platform hardware errors (such as that from chipset). It works in so called "Firmware First" mode, that is, hardware errors are reported to firmware firstly, then reported to Linux by firmware. This way, some non-standard hardware error registers or non-standard hardware link can be checked by firmware to produce more valuable hardware error information for Linux. This patch adds POLL/IRQ/NMI notification types support. Because the ...
Oct 25, 12:43 am 2010
Mauro Carvalho Chehab
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
I agree with Ingo NAK. Having vendor-dependent API's for errors is not the way to solve those issues. We should focus on an unique hardware error report facility that will provide a clean, consistent, vendor-independent interface to userspace. EDAC successfully achieved this target for the current designs, and it is evolving to cover newer hardware needs. We had some discussions with Intel during the Collaboration summit about that, trying to integrate Nehalem EX on such environment, ...
Oct 25, 5:04 am 2010
Andi Kleen
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Perhaps a simple example (simplified, in practice there are more complications) makes it more clear: The memory error handler does different actions depending on what the state the page the error is happening on is in. To get reasonable coverage of the recovery code you need to present it with pages in different states (like locked, clean, dirty, IO etc. etc. ) Now it turns out this is very hard to do if you just inject the error at the hardware level, because there are lots of races ...
Oct 25, 5:37 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
That's my whole point, _why_ do they have different interfaces? EDAC is the upstream mechanism to organize hardware error reporting and to get hardware errors to user-space. It is already successful in handling a wide range of hardware in a similar fashion. Furthermore, there is work ongoing to do the reporting via perf event channels, some of that work is upstream already. Boris is working on persistent events, on RAS tooling (tools/ras/) and on event injection. Here's a past ...
Oct 25, 4:15 am 2010
Andi Kleen
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Different events in different contexts with different drivers with different parameters using different tools. Commonality: about 0% exept there's "error" somewhere in the description. -Andi --
Oct 25, 6:11 am 2010
Ingo Molnar
[NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardware E ...
WTF? Sigh, please integrate all this into EDAC (drivers/edac/) properly, instead of turning it into YET ANOTHER hardware vendor special hw-errors thing. We can do better than this. EDAC is almost there: it has support for Nehalem, AMD, a couple of older chips. Guys, instead of carving out a special driver area where you can produce crap without anyone looking too much, and pretending that the EDAC code does not exist, please try to work with others who are aiming higher and who are ...
Oct 25, 1:45 am 2010
Andi Kleen
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
First if you want to avoid fragmentation please contribute to mce-test git://git.kernel.org/pub/scm/utils/cpu/mce/mce-test.git That's the standard area for tests in this area for several years with many contributors. If anyone has anything new they want to inject and it roughly fits hardware errors it can be placed there. These days it already tests more than just mces. Then the tools are actually more like test suites that do all kind of different things. For example the testers for ...
Oct 25, 8:14 am 2010
Andi Kleen
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Yes they're solving quite different problems from EDAC with different interfaces and for different devices in the ACPI space. The earlier nack seems to be based on a lot of confusion on what the code does. Besides it nacks code in areas Ingo doesn't even maintain. (if he's allowed to nack random other code he doesn't like do I get this Also having multiple error injecting interfaces is a good thing. Error injection is hard and one size definitely doesn't fit all. You need quite ...
Oct 25, 2:19 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
The differences in those tools do not seem natural. Those tools are mostly just different for difference's sake - which is sad. They could also admittedly benefit from a proper build mechanism and other integration goodies. For example when building mce-inject i get: $ make Makefile:42: .depend: No such file or directory When running the mce-inject tool it apparently hangs: $ ./mce-inject (it's waiting for stdin) it does not recognize any of the standard ...
Oct 25, 10:10 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Sigh. I did not say integrate the drivers - integrate the _error event facilities_. You can have drivers/edac/apei/ghes* bits just fine (in fact it would be desirable, to keep things modular). Really, just read the two Kconfig entries: bool "EDAC (Error Detection And Correction) reporting" EDAC is designed to report errors in the core system. These are low-level errors that are reported in the CPU or supporting chipset or other subsystems: ...
Oct 25, 2:25 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
What you appear to be arguing for is the ability to inject different types of events. _OF COURSE_ we want that. Just like we want to be able to _receive_ multiple types of events from wildly different hardware and wildly different kernel subsystems ... Duh. That desire does not necessiate 'three different injectors' at all. It does not necessiate multiple incompatible facilities with random ABIs. What we want is a single injector facility visible to RAS/hw-testing/etc. apps, and ...
Oct 25, 5:55 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
That's possible, but i'd expect tools/ras/ to be populated with uniformly working Wrong. Their main purpose is common: they are events attached to existing hardware topologies, which events can be configured, which events can be received and which can be injected with attributes for rare-event simulation purposes. The tool people have spoken to us clear and loud that they want to _receive_ events in a unified and structured way - not via lots of separate ABIs from facilities that ...
Oct 25, 6:47 am 2010
Borislav Petkov
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Concerning fatal errors, take a look at drivers/edac/mce_amd.(c|h)¹ - this is not in arch/x86/ and still decodes MCEs in the kernel. And it works fine - it even helped in several cases where people simply read their serial console/dmesg and didn't have to collect it first and run it through some tool to understand which functional unit in the CPU is mchecking. And I have an error injection module which can inject MCEs using 2 /sysfs files only. It is software injection only for now but ...
Oct 25, 2:51 pm 2010
Tony Luck
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
On Mon, Oct 25, 2010 at 5:04 AM, Mauro Carvalho Chehab The chipset registers that are needed to write an EDAC driver for Nehalem-EX (a.k.a Xeon 7500 series) are not accessible to OS (ring 0) code. Documenting them An excellent idea. See you there. -Tony --
Oct 25, 10:07 am 2010
Ingo Molnar
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
And note that once there's a generic facility that allows event injection, the actual low level implementation might of course be hardware specific. There's no reduction in actual feature richness: if the hw can do fancy things, it can be expressed via a generic facility as well. What i object to is the narrow hardware specificity (and ad-hocness) of the high level interface and its non-integration into existing facilities. Thanks, Ingo --
Oct 25, 6:02 am 2010
Mauro Carvalho Chehab
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Yeah, I know. The error reporting mechanism could do something similar to i7core_edac driver to parse the MCE NMI errors to userspace via EDAC interface, but without any way to get the memory topology, this wouldn't work. With some documentation, maybe we could find a way for a kernel code to retrieve OK, See you there. Thanks, Mauro --
Oct 25, 10:19 am 2010
Borislav Petkov
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
You may be right but what we actually want is a consistent RAS infrastructure. Didn't you point out at the last edac meeting in Boston that concerning RAS Linux were in the stone ages? (at least this is what I remember reading). What we should do is put all that post-system-reset error info, ECC errors mapping to DRAM devices, L3 cache index manipulation based on excessive errors - you name it - together and stick it in ras/ or drivers/ras or whatever. And all with a nice and easy to use ...
Oct 25, 1:23 pm 2010
Huang Ying
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
I think APEI (ACPI Platform Error Interface) is another driver. Why Maybe they are not good name. But they are defined in ACPI specification. Using the same name makes it easier for people to link EINJ is a true platform feature, not just software feature. We need to support it to debug various hardware error features. Best Regards, Huang Ying --
Oct 25, 1:58 am 2010
Thomas Gleixner
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
Errm. That patch series carries a lot of other weird stuff including a new "memory allocator", a new ioremap implementation private to the acpi code and new character device driver for hardware error But it does not even make an attempt to explain why this error reporting cannot be done via the existing interfaces and why they can't be extended to fit your needs. What's so special about APEI GHES and PCIe AER that we need another incompatible "just fits your needs" ABI which makes tooling ...
Oct 25, 9:38 am 2010
Tony Luck
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
That meeting was in San Francisco - but your recollection is correct. Right now we have ways to count errors, and to attribute them to specific hardware components (if we are lucky). This is only the This is what we should be working towards. I don't think we have a clear picture of what that high level infrastructure looks like. It needs to be very flexible to take input from all sorts of platform specific "driver" code that collects data. The "perf events" mechanism looks plausible as a ...
Oct 25, 2:23 pm 2010
Tony Luck
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
As mentioned above these 4-letter names from from the ACPI specification. ERST is perhaps the dumbest name of them all - "Error Record Serialization Table" is ACPI-speak for platform level non-volatile memory. This code simply provides a mechanism for Linux to stash some information in nvram before the system is reset, and to retrieve it after the reboot. The naming could be better - but I don't see any overlap with EDAC here. -Tony --
Oct 25, 10:14 am 2010
Tony Luck
Re: [NAK] Re: [PATCH -v2 9/9] ACPI, APEI, Generic Hardwa ...
That looks neat ... but end-users seem to have some conflicting requirements here. Your uses seem to like it but the LLNL folks at the S.F. meeting said that solutions that involved looking at console logs from thousands of machines in a cluster were not acceptable. I doubt very much if any end-user cares which unit *within* a cpu failed (their replaceable unit is the whole of the cpu). So much of your driver could be replaced with: printk("CPU%d is bad\n", cpu); -Tony --
Oct 25, 4:35 pm 2010
Huang Ying
[PATCH -v2 7/9] ACPI, APEI, Use ERST for hardware error ...
Corrected/Recoverable hardware errors can usually be saved into disk and/or sent to network for logging. But if uncorrected/fatal hardware errors occur, system may not reliable enough for desk and/or network accessing and needs to go panic as soon as possible for error containment. In this situation, ERST can be used to save the valuable error records into some persistent storage such as flash. This patch implements herr_persist interface using ERST. So that hardware error device core can ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 4/9] lock-less general memory allocator
Lock-less memory allocator, can be used to allocate/free memory in IRQ/NMI handler. This is useful for hardware error handling, which needs to collect hardware error information in IRQ/NMI handler. The memory pages for lock-less memory allocator are pre-allocated during initialization. Bitmap is used to record allocated/free memory blocks. To support lock-less allocate/free operation, lock-less bitmap set/clear operations are used. The difference between this allocator and the gen_pool ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 2/9] Add lock-less version of bitmap_set/clear
cmpxchg is used to change the bitmap instead of the ordinary unsigned long assigning. Several users can set/clear the same bitmap simultaneously without lock. If there is conflict between two user, (set/clear same bit), one will return remain bits immediately. This can be used to implement the lock-less resource allocator. Signed-off-by: Huang Ying <ying.huang@intel.com> Reviewed-by: Andi Kleen <ak@linux.intel.com> --- include/linux/bitmap.h | 4 + lib/bitmap.c | 101 ...
Oct 25, 12:43 am 2010
Huang Ying
[PATCH -v2 6/9] Hardware error record persistent support
Normally, corrected hardware error records will go through the kernel processing and be logged to disk or network finally. But for uncorrected errors, system may go panic directly for better error containment, disk or network is not usable in this half-working system. To avoid losing these valuable hardware error records, the error records are saved into some kind of simple persistent storage such as flash before panic, so that they can be read out after system reboot successfully. Different ...
Oct 25, 12:43 am 2010
Stefan Richter
[git pull] FireWire updates post 2.6.36 (ieee1394 removal)
Linus, please pull from the ieee1394-removal branch at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git ieee1394-removal to receive what it says on the outside. The replacement, drivers/firewire/, although superior in many respects, still has some issues that are not present in the old drivers. But I think we are at a point now where two IEEE 1394 stacks in the kernel are becoming more burden than convenience for downstreams. There is a trivial merge conflict: ...
Oct 25, 12:32 am 2010
Rakib Mullick
[PATCH]: char, mxser: Fix compilation warning in mxser.c
Both function mxser_disable_must_enchance_mode() and mxser_get_must_hardware_id() called from function CheckIsMoxaMust(), when CONFIG_PCI=y. So mark both the functions under CONFIG_PCI. We were warned by the following warning. drivers/char/mxser.c:306: warning: ‘mxser_disable_must_enchance_mode’ defined but not used drivers/char/mxser.c:391: warning: ‘mxser_get_must_hardware_id’ defined but not used Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> --- diff --git ...
Oct 25, 12:14 am 2010
Judy Abbott
Email Quota Limit
You have exceeded the storage limit on your mailbox. You will not be able to send or receive new mail until you upgrade your email quota. click the below link and fill the form to upgrade your account. http://do.my/email-accountquota-limit/ System Administrator 192.168.0.1 --
Oct 24, 10:52 pm 2010
Jaswinder Singh
[PATCH] apic, x86: Need to set offset before using it
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Robert Richter <robert.richter@amd.com> Cc: Ingo Molnar <mingo@elte.hu> --- arch/x86/oprofile/op_model_amd.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c index 42fb46f..c65a924 100644 --- a/arch/x86/oprofile/op_model_amd.c +++ b/arch/x86/oprofile/op_model_amd.c @@ -285,6 ...
Oct 24, 10:46 pm 2010
Ingo Molnar
Re: [PATCH v2] apic, x86: Need to set offset before using it
I queued up a different fix, one which also address some of the structural details in this function. Thanks, Ingo --
Oct 24, 11:50 pm 2010
Jaswinder Singh
[PATCH v2] apic, x86: Need to set offset before using it
Fix the issue pointed by Stephen. Stephen Rothwell wrote : In building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced this warning: arch/x86/oprofile/op_model_amd.c: In function 'ibs_eilvt_valid': arch/x86/oprofile/op_model_amd.c:289: warning: 'offset' may be used uninitialized in this function Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Robert Richter <robert.richter@amd.com> Cc: Ingo ...
Oct 24, 10:58 pm 2010
Dan Carpenter
[patch] serial/mrst_max3110: make buffer larger
This is used to store the spi_device ->modalias so they have to be the same size. SPI_NAME_SIZE is 32. Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/drivers/serial/mrst_max3110.c b/drivers/serial/mrst_max3110.c index b62857b..37e13c3 100644 --- a/drivers/serial/mrst_max3110.c +++ b/drivers/serial/mrst_max3110.c @@ -51,7 +51,7 @@ struct uart_max3110 { struct uart_port port; struct spi_device *spi; - char name[24]; + char name[SPI_NAME_SIZE]; wait_queue_head_t ...
Oct 24, 10:28 pm 2010
Dmitry Torokhov
[git pull] Input updates for 2.6.37-rc0
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Changelog: --------- Abraham Arce (4): Input: add support for OMAP4 keyboard controller Input: omap4-keypad - use platform device helpers Input: omap4-keypad - SYSCONFIG register configuration Input: omap4-keypad - fix interrupt line ...
Oct 24, 10:17 pm 2010
Luke Hutchison
kernel bug?: Reopening a browser session with many tabs ...
I have a Toshiba Satellite Pro S300M-S2142 laptop with a Core 2 Duo P8600 CPU, Intel GM45 gfx, Intel 82567V Gigabit Ethernet and Intel 5100 Wifi.  Since around Linux kernel 2.6.33 or so (but maybe as early as 2.6.31, not sure exactly what version), when restoring a crashed or closed browser session of either Firefox or Chrome where lots of tabs (say 10-40) open simultaneously, the networking stack is brought to its knees -- most or all the tabs eventually time out without data, or a few tabs ...
Oct 24, 10:13 pm 2010
aaltahergroup2000
Tarek Aal Taher Group Of Company
Tarek Aal Taher Group Of Company AL-TAHER GROUP OF COMPANY (AAL Taher Group) are group of company from United Kingdom,,we value our client as an asset,taking this mission as a priority,we provide our valuable customers a platform where they can proliferate and gain profits through through our association,currently seeking means of expanding and relocating our business interest in the following sectors: real estate, mining, transportation and farming . If you think you have a solid ...
Oct 24, 9:52 pm 2010
Dan Carpenter
[patch] hfsplus: fix double lock typo in ioctl
This was supposed to be a mutex_unlock() instead of a mutex_lock(). Signed-off-by: Dan Carpenter <error27@gmail.com> diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c index 5b4667e..40a85a3 100644 --- a/fs/hfsplus/ioctl.c +++ b/fs/hfsplus/ioctl.c @@ -92,7 +92,7 @@ static int hfsplus_ioctl_setflags(struct file *file, int __user *user_flags) mark_inode_dirty(inode); out_unlock_inode: - mutex_lock(&inode->i_mutex); + mutex_unlock(&inode->i_mutex); out_drop_write: ...
Oct 24, 9:53 pm 2010
Christoph Hellwig Oct 25, 11:44 am 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (netfilter/nf_conntr ...
net/ipv6/netfilter/nf_conntrack_reasm.c:628: error: 'nf_ct_frag6_sysctl_header' undeclared (first use in this function) net/ipv6/netfilter/nf_conntrack_reasm.c:628: error: 'nf_net_netfilter_sysctl_path' undeclared (first use in this function) net/ipv6/netfilter/nf_conntrack_reasm.c:629: error: 'nf_ct_frag6_sysctl_table' undeclared (first use in this function) net/ipv6/netfilter/nf_conntrack_reasm.c:640: error: 'nf_ct_frag6_sysctl_header' undeclared (first use in this function) config file is ...
Oct 25, 4:55 pm 2010
Randy Dunlap
[PATCH -next] pch_can: depends on PCI
From: Randy Dunlap <randy.dunlap@oracle.com> Fix pch_can build when CONFIG_PCI is not enabled. It uses pci interfaces and data structures, so it should depend on PCI. drivers/net/can/pch_can.c:1044: error: implicit declaration of function 'pci_enable_msi' drivers/net/can/pch_can.c:1079: error: implicit declaration of function 'pci_disable_msi' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- ...
Oct 25, 4:25 pm 2010
David Miller
Re: [PATCH -next] pch_can: depends on PCI
From: Randy Dunlap <randy.dunlap@oracle.com> Applied, thanks Randy. --
Oct 25, 4:47 pm 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (acpi_video)
drivers/built-in.o: In function `acpi_video_bus_put_one_device': video.c:(.text+0x7b716): undefined reference to `video_output_unregister' drivers/built-in.o: In function `acpi_video_device_find_cap': video.c:(.text+0x7c615): undefined reference to `video_output_register' config file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Oct 25, 4:57 pm 2010
Stephen Rothwell
linux-next: Tree for October 25
Hi all, Reminder: do not add 2.6.38 destined stuff to linux-next until after 2.6.37-rc1 is released. Changes since 20101022: The net-current tree gained a build failure for which I applied a patch. The tegra tree lost its conflicts. The powerpc tree lost its conflict. The kvm tree lost its conflict. The net tree lost its conflicts. The crypto tree lost its conflict. The block tree lost its conflict. The mmc tree gained a build failure so I used the version from ...
Oct 24, 8:58 pm 2010
Stephen Rothwell
Re: linux-next: Tree for October 25
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au $ git checkout master $ git reset --hard stable Merging origin/master Merging fixes/fixes Merging arm-current/master Merging m68k-current/for-linus Merging powerpc-merge/merge Merging sparc-current/master Merging scsi-rc-fixes/master Merging net-current/master Merging sound-current/for-linus Merging pci-current/for-linus Merging wireless-current/master Merging kbuild-current/rc-fixes Merging ...
Oct 24, 8:59 pm 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (acpi/apei-related)
drivers/built-in.o: In function `herr_record_init': (.text+0x85149): undefined reference to `trace_clock_local' drivers/built-in.o: In function `herr_record_alloc': (.text+0x851ab): undefined reference to `trace_clock_local' drivers/built-in.o: In function `herr_record_alloc': (.text+0x8521c): undefined reference to `trace_clock_local' config ACPI_APEI bool "ACPI Platform Error Interface (APEI)" depends on X86 select HERR_DEV_CORE but kernel/trace/trace_clock is not built unless one ...
Oct 25, 4:51 pm 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (netfilter/xt_socket)
xt_socket.c:(.text+0x39ff8): undefined reference to `ipv6_find_hdr' xt_socket.c:(.init.text+0x1703): undefined reference to `nf_defrag_ipv6_enable' config file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Oct 25, 4:54 pm 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (nouveau_pm)
drivers/built-in.o: In function `nouveau_hwmon_init': nouveau_pm.c:(.text+0x179825): undefined reference to `hwmon_device_register' nouveau_pm.c:(.text+0x1798b9): undefined reference to `hwmon_device_unregister' config file is attached. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
Oct 25, 4:59 pm 2010
Randy Dunlap
Re: linux-next: Tree for October 25 (coda)
The coda BKL fixes (git tree) are not in here yet, right? fs/coda/* currently has 12 warnings like these: fs/coda/psdev.c:140: error: implicit declaration of function 'lock_kernel' fs/coda/psdev.c:142: error: implicit declaration of function 'unlock_kernel' --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Oct 25, 4:33 pm 2010
Stephen Rothwell
Re: linux-next: Tree for October 25 (coda)
Hi Randy, I have no coda tree in linux-next (hint, hint :-)). However, there were Hopefully these are fixed today by the above commits? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Oct 25, 4:52 pm 2010
Oleg Nesterov
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_ ...
I believe the patch is fine (it already has my reviewed-by). Except: I am not sure about -stable. At least, this patch should not go into the <2.6.35 kernels, it relies on misc changes which changed the scope of task->signal. Before 2.6.35 almost any user of ->cred_guard_mutex can race with exit and hit ->signal == NULL. Oleg. --
Oct 25, 10:42 am 2010
Roland McGrath
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_ ...
I see no justification for a change like this in any -stable tree. It's just a cleanup, right? If it's a prerequisite for the fix we like for an "important" bug, then that's a different story. In its own right, it's clearly not appropriate for backporting. Thanks, Roland --
Oct 25, 10:51 am 2010
David Rientjes
Re: [resend][PATCH 2/4] Revert "oom: deprecate oom_adj t ...
NACK as a logical follow-up to my NACK for "oom: remove totalpage normalization from oom_badness()" --
Oct 25, 1:40 pm 2010
KOSAKI Motohiro
[resend][PATCH 1/4] oom: remove totalpage normalization ...
Current oom_score_adj is completely broken because It is strongly bound google usecase and ignore other all. 1) Priority inversion As kamezawa-san pointed out, This break cgroup and lxr environment. He said, > Assume 2 proceses A, B which has oom_score_adj of 300 and 0 > And A uses 200M, B uses 1G of memory under 4G system > > Under the system. > A's socre = (200M *1000)/4G + 300 = 350 > B's score = (1G * 1000)/4G = 250. > > In the cpuset, it has 2G of memory. > A's ...
Oct 24, 8:26 pm 2010
KOSAKI Motohiro
[resend][PATCH 3/4] move cred_guard_mutex from task_stru ...
Changelog o since v1 - function comment also change current->cred_guard_mutex to current->signal->cred_guard_mutex. --------------------------------------------------------------------------- Oleg Nesterov pointed out we have to prevent multiple-threads-inside-exec itself and we can reuse ->cred_guard_mutex for it. Yes, concurrent execve() has no worth. Let's move ->cred_guard_mutex from task_struct to signal_struct. It naturally prevent multiple-threads-inside-exec. Cc: ...
Oct 24, 8:28 pm 2010
KOSAKI Motohiro
[resend][PATCH 4/4] oom: don't ignore rss in nascent mm
ChangeLog o since v2 - Move ->in_exec_mm from task_struct to signal_struct - clean up oom_rss_swap_usage() o since v1 - Always use thread group leader's ->in_exec_mm. It slightly makes efficient oom when a process has many thread. - Add the link of Brad's explanation to the description. ----------------------------------------------------------- Brad Spengler published a local memory-allocation DoS that evades the OOM-killer (though not the virtual memory ...
Oct 24, 8:29 pm 2010
KOSAKI Motohiro
[resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable"
oom_adj is not only used for kernel knob, but also used for application interface. Then, adding new knob is no good reason to deprecate it. Don't do stupid! Also, after former patch, oom_score_adj can't be used for setting OOM_DISABLE. We need "echo -17 > /proc/<pid>/oom_adj" thing. This reverts commit 51b1bd2ace1595b72956224deda349efa880b693. Cc: stable@kernel.org Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> --- Documentation/feature-removal-schedule.txt | 25 ...
Oct 24, 8:27 pm 2010
David Rientjes Oct 25, 1:37 pm 2010
Roland McGrath
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_ ...
This has my ACK if Oleg doesn't see any problems. Thanks, Roland --
Oct 25, 10:26 am 2010
pageexec
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm
On 25 Oct 2010 at 12:29, KOSAKI Motohiro wrote: hi, what happens when two (or more) threads in the same process call execve? the above set_exec_mm calls will race (de_thread doesn't happen until much later in execve) and overwrite each other's ->in_exec_mm which will still lead to problems since there will be at most one temporary mm accounted for in the oom killer. [update: since i don't seem to have been cc'd on the other patch that serializes execve, the above point is moot ...
Oct 25, 4:28 am 2010
KAMEZAWA Hiroyuki
Re: [resend][PATCH] mm: increase RECLAIM_DISTANCE to 30
On Mon, 25 Oct 2010 12:24:24 +0900 (JST) Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --
Oct 24, 9:35 pm 2010
KOSAKI Motohiro
[resend][PATCH] mm: increase RECLAIM_DISTANCE to 30
Recently, Robert Mueller reported zone_reclaim_mode doesn't work properly on his new NUMA server (Dual Xeon E5520 + Intel S5520UR MB). He is using Cyrus IMAPd and it's built on a very traditional single-process model. * a master process which reads config files and manages the other process * multiple imapd processes, one per connection * multiple pop3d processes, one per connection * multiple lmtpd processes, one per connection * periodical "cleanup" processes. Then, there ...
Oct 24, 8:24 pm 2010
David Miller
Re: Section msimatch warnings
From: Stephen Rothwell <sfr@canb.auug.org.au> I think it has to do with how function descriptors work on powerpc. Code references to static (local) things work different from how global scope references work. --
Oct 25, 4:27 pm 2010
Stephen Hemminger
Re: linux-next: build failure after merge of the final t ...
On Sun, 24 Oct 2010 22:26:02 -0700 (PDT) The section mismatch warning on x86 is not shown by default because there are still so many problems. -- --
Oct 25, 10:36 am 2010
Stephen Rothwell
Section msimatch warnings (Was: Re: linux-next: build fa ...
Hi Stephen, This is actually different - it is generated by the compiler. I am not sure why we only get them on PowerPC. Rusty suggested that we could dynamically create a file that just referenced all the EXPORTed symbols (we know what they are) and try to link that. Then we would find all the static ones. PowerPC would still find them earlier, of course, but since a lot of poeple only compile for x86(_64), they may not get as far as the PowerPC builds. The other section mismatch ...
Oct 25, 4:04 pm 2010
Stephen Rothwell
linux-next: build failure after merge of the final tree ...
Hi all, After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this: net/l2tp/l2tp_core.c:1228: error: __ksymtab_l2tp_tunnel_closeall causes a section type conflict net/l2tp/l2tp_core.c:1228: error: __ksymtab_l2tp_tunnel_closeall causes a section type conflict net/l2tp/l2tp_core.c:1006: error: __ksymtab_l2tp_xmit_core causes a section type conflict net/l2tp/l2tp_core.c:1006: error: __ksymtab_l2tp_xmit_core causes a section type ...
Oct 24, 8:19 pm 2010
David Miller
Re: linux-next: build failure after merge of the final t ...
From: Stephen Rothwell <sfr@canb.auug.org.au> I'll add this thanks Stephen. --
Oct 24, 10:26 pm 2010
Stephen Rothwell
linux-next: build warning in Linus' tree
Hi Linus, In building Linus' tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: In file included from arch/powerpc/platforms/iseries/exception.S:32: arch/powerpc/include/asm/ptrace.h:60:1: warning: "STACK_FRAME_OVERHEAD" redefined In file included from arch/powerpc/include/asm/asm-offsets.h:1, from arch/powerpc/platforms/iseries/exception.S:30: include/generated/asm-offsets.h:87:1: warning: this is the location of the previous definition Caused ...
Oct 24, 7:52 pm 2010
Tomoya
[PATCH net-next-2.6 v2] can: Topcliff: PCH_CAN driver: F ...
Hi David, From: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> - Fix build warnings when PM_CONFIG is disabled. - Modify Copyright "Co" to "CO". Reported-by: David S. Miller <davem@davemloft.net> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> --- drivers/net/can/pch_can.c | 208 ++++++++++++++++++++++---------------------- 1 files changed, 104 insertions(+), 104 deletions(-) diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index 55ec324..2889e11 ...
Oct 24, 7:32 pm 2010
David Miller
Re: [PATCH net-next-2.6 v2] can: Topcliff: PCH_CAN drive ...
From: Tomoya <tomoya-linux@dsn.okisemi.com> This patch has been corrupted by your email client. --
Oct 25, 12:14 pm 2010
Stephen Rothwell
linux-next: build failure after merge of the xen tree
Hi all, After merging the xen tree, today's linux-next build (s86_64 allmodconfig) failed like this: arch/x86/xen/setup.c: In function 'xen_memory_setup': arch/x86/xen/setup.c:161: error: implicit declaration of function 'xen_initial_domain' Caused by commit 9e9a5fcb04e3af077d1be32710298b852210d93f ("xen: use host E820 map for dom0"). See Rule 1 from Documentation/SubmitChecklist. I have used the xen tree from next-20101021 for today (due to the complex conflict in Friday's tree). -- ...
Oct 24, 7:30 pm 2010
Jeremy Fitzhardinge Oct 25, 4:57 pm 2010
Ian Campbell
Re: linux-next: build failure after merge of the xen tree
Sorry about that, there was a missing #include which was hidden for me by a change in the swiotlb-xen tree (d8e0420603cf "xen: define BIOVEC_PHYS_MERGEABLE()", FWIW). We shouldn't be relying on indirect includes in that way so: 8<----- Subject: xen: include xen/xen.h for definition of xen_initial_domain() CC arch/x86/xen/setup.o arch/x86/xen/setup.c: In function 'xen_memory_setup': arch/x86/xen/setup.c:161: error: implicit declaration of function ...
Oct 25, 1:38 am 2010
Harald Welte
Re: [PATCH] mfd: Add __devexit annotation for vx855_remove
Acked-by: Harald Welte <HaraldWelte@viatech.com> -- - Harald Welte <HaraldWelte@viatech.com> http://linux.via.com.tw/ --
Oct 25, 12:59 am 2010
Axel Lin
[PATCH] mfd: Add __devexit annotation for vx855_remove
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mfd/vx855.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/vx855.c b/drivers/mfd/vx855.c index ebb0597..348052a 100644 --- a/drivers/mfd/vx855.c +++ b/drivers/mfd/vx855.c @@ -112,7 +112,7 @@ out: return ret; } -static void vx855_remove(struct pci_dev *pdev) +static void __devexit vx855_remove(struct pci_dev *pdev) { mfd_remove_devices(&pdev->dev); pci_disable_device(pdev); -- ...
Oct 24, 7:32 pm 2010
Szekely, Robin
(No subject)
MY name is Capt James Roy, I am in artillery military unit here in Iraq, we discovered some oil money in Iraq, we are working for the government we can not keep it.We want you to keep the funds for us. reply to this email address (r.captjames@yahoo.com.hk) --
Oct 24, 7:04 pm 2010
Axel Lin
Re: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage
Ok. I will send a v2 thant only change u8 to s8. Regards, Axel --
Oct 25, 4:55 pm 2010
Mark Brown
Re: [PATCH 1/2] regulator: max8952 - fix max8952_pmic_pr ...
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --
Oct 25, 10:53 am 2010
Axel Lin
[PATCH 2/2] regulator: max8952 - fix max8952_set_voltage
In current implementation, vid is declared as u8, then "vid == -1" is always false, and "vid >= 0" is always true. Thus change it to s8. vid is always less than MAX8952_NUM_DVS_MODE in current implementation, thus remove the cheking for "vid < MAX8952_NUM_DVS_MODE". Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/max8952.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index ...
Oct 24, 7:17 pm 2010
Mark Brown
Re: [PATCH 2/2] regulator: max8952 - fix max8952_set_voltage
This bit seems like reasonable paranoia in the face of future code changes and we're not really in a sufficiently fast path to worry about cycles - are you sure that this is essential? --
Oct 25, 10:55 am 2010
Axel Lin
[PATCH 1/2] regulator: max8952 - fix max8952_pmic_probe ...
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/regulator/max8952.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c index f2af0b1..7d6aacf 100644 --- a/drivers/regulator/max8952.c +++ b/drivers/regulator/max8952.c @@ -212,9 +212,11 @@ static int __devinit max8952_pmic_probe(struct i2c_client *client, max8952->rdev = regulator_register(&regulator, max8952->dev, &pdata->reg_data, ...
Oct 24, 7:11 pm 2010
Tomoya
[PATCH net-next-2.6 v2] can: Topcliff: Update PCH_CAN dr ...
Hi David, I have modified for your indications. - Warning issue when "CONFIG_PM" is disabled. Thanks, Tomoya(OKI SEMICONDUCTOR CO., LTD.) --- CAN driver of Topcliff PCH Topcliff PCH is the platform controller hub that is going to be used in Intel's upcoming general embedded platform. All IO peripherals in Topcliff PCH are actually devices sitting on AMBA bus. Topcliff PCH has CAN I/F. This driver enables CAN function. Signed-off-by: Tomoya MORINAGA ...
Oct 24, 6:53 pm 2010
David Miller
Re: [PATCH net-next-2.6 v2] can: Topcliff: Update PCH_CA ...
From: Tomoya <tomoya-linux@dsn.okisemi.com> I said to send me a relative patch to your previous one. I already added the driver to the tree, so sending me a complete new patch adding the driver isn't going to work. --
Oct 24, 7:08 pm 2010
Paul Mundt
[GIT PULL] sh updates for 2.6.37-rc1
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git Which contains: Akinobu Mita (1): sh: fix uninitialized spinlock Andrew Murray (1): sh: Use __GFP_ZERO for dma_generic_alloc_coherent(). Arnd Bergmann (1): sh: kill big kernel lock Carmelo AMOROSO (1): sh: Add syscall entries for non multiplexed socket calls Guennadi Liakhovetski (5): dmaengine: initialise DMA engine before MMC sh: move a debug printk() to a ...
Oct 24, 6:50 pm 2010
Mathieu Desnoyers
[RELEASE] LTTng 0.233 for kernel 2.6.36, lttng-modules 0.19.1
LTTng, the Linux Trace Toolkit Next Generation, is a project that aims at producing a highly efficient full system tracing solution. It is composed of several components to allow tracing of the kernel, of userspace, trace viewing and analysis and trace streaming. LTTng is open source software. It is being actively developed with the community. Changelog: * LTTng 0.233 and lttng-modules 0.19.1 now support Linux 2.6.36. Project website: http://lttng.org Download link: ...
Oct 24, 6:39 pm 2010
Avi Kivity
Re: [PATCH RFC] kvm: write protect memory after slot swap
Er, autotest. I'm just having problems my 2.6.36+ autofs setup. -- error compiling committee.c: too many arguments to function --
Oct 25, 4:51 am 2010
Avi Kivity
Re: [PATCH RFC] kvm: write protect memory after slot swap
Deadly. Yes autofs passed it happily. Yes. -- error compiling committee.c: too many arguments to function --
Oct 25, 4:50 am 2010
Michael S. Tsirkin
[PATCH RFC] kvm: write protect memory after slot swap
I have observed the following bug trigger: 1. userspace calls GET_DIRTY_LOG 2. kvm_mmu_slot_remove_write_access is called and makes a page ro 3. page fault happens and makes the page writeable fault is logged in the bitmap appropriately 4. kvm_vm_ioctl_get_dirty_log swaps slot pointers a lot of time passes 5. guest writes into the page 6. userspace calls GET_DIRTY_LOG At point (5), bitmap is clean and page is writeable, thus, guest modification of memory is not logged and ...
Oct 24, 6:21 pm 2010
Takuya Yoshikawa
Re: [PATCH RFC] kvm: write protect memory after slot swap
On Mon, 25 Oct 2010 03:21:24 +0200 This may be the reason why my commit is a corruption magnifier. My patch moved the vmalloc() right after kvm_mmu_slot_remove_write_access() and made this chance bigger: because vmalloc() takes some time. Thanks, --
Oct 25, 12:27 am 2010
Avi Kivity
Re: [PATCH RFC] kvm: write protect memory after slot swap
Excellent catch, I stared at this code for a while and didn't see the bug. Patch applied. -- error compiling committee.c: too many arguments to function --
Oct 25, 2:32 am 2010
Michael S. Tsirkin Oct 25, 5:05 am 2010
Jan Kiszka
Re: [PATCH RFC] kvm: write protect memory after slot swap
BTW, while this was an annoying one for graphic emulation, wasn't it potentially lethal for live migration? The issue looks like is was introduced with the switch to SRCU, so every kernel since 2.6.34 should be affected, correct? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux --
Oct 25, 4:40 am 2010
Jan Kiszka
Re: [PATCH RFC] kvm: write protect memory after slot swap
Cool, seems to be the key to the corruptions I've seen. Applying your Assuming that a page cannot be write-enabled without having a dirty entry in the old bitmap and due to the fact that user space won't get hold of that old bitmap to read out the page before we reset write access again, your patch should actually be safe. If no one else sees some remaining race, let's get this applied upstream ASAP and pushed down to the stable trees. Thanks, -- Siemens AG, Corporate Technology, CT ...
Oct 25, 2:07 am 2010
Stephen Rothwell
linux-next: build failure after merge of the mmc tree
Hi Chris, After merging the mmc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/mmc/card/block.c:57: error: 'CONFIG_MMC_BLOCK_MINORS' undeclared here (not in a function) Caused by commit d8714fbfc66e16fc64a4525c02eebc34bac8385c ("mmc: make number of mmcblk minors configurable"). Forget to include a Kconfig update? I have used the mmc tree from next-20101022 for today. -- Cheers, Stephen Rothwell ...
Oct 24, 6:12 pm 2010
Chris Ball
Re: linux-next: build failure after merge of the mmc tree
Hi Stephen, Sorry, yes. I've tested and pushed a fixed version. Thanks very much, -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child --
Oct 24, 7:21 pm 2010
Stephen Rothwell
linux-next: build warning in Linus' tree
Hi all, In building Linus' tree, today's linux-next build (x86_64 allmodconfig) produced this warning: arch/x86/oprofile/op_model_amd.c: In function 'ibs_eilvt_valid': arch/x86/oprofile/op_model_amd.c:289: warning: 'offset' may be used uninitialized in this function .. and indeed it may be. Introduced by commit 27afdf2008da0b8878a73e32e4eb12381b84e224 ("apic, x86: Use BIOS settings for IBS and MCE threshold interrupt LVT offsets"). Sorry I missed this earlier. -- Cheers, Stephen ...
Oct 24, 5:57 pm 2010
Ingo Molnar
Re: linux-next: build warning in Linus' tree
Yep, that looks bogus. I've queued up the fix. Thanks, Ingo --
Oct 24, 11:36 pm 2010
Ingo Molnar
Re: [tip:perf/urgent] x86/oprofile: Fix uninitialized va ...
Weird - should be very obvious for a compiler to see that. Ingo --
Oct 25, 3:27 am 2010
tip-bot for Ingo Molnar
[tip:perf/urgent] x86/oprofile: Fix uninitialized variab ...
Commit-ID: 2c78ffeca98fcd5a1dfd4a322438944506ed5e64 Gitweb: http://git.kernel.org/tip/2c78ffeca98fcd5a1dfd4a322438944506ed5e64 Author: Ingo Molnar <mingo@elte.hu> AuthorDate: Mon, 25 Oct 2010 08:41:09 +0200 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Mon, 25 Oct 2010 08:46:20 +0200 x86/oprofile: Fix uninitialized variable use in debug printk Stephen Rothwell reported this build warning: arch/x86/oprofile/op_model_amd.c: In function 'ibs_eilvt_valid': ...
Oct 24, 11:52 pm 2010
Robert Richter
Re: [tip:perf/urgent] x86/oprofile: Fix uninitialized va ...
Ingo, thanks for changing this, it all looks good to me, though we actually don't have to print the offset as the valid bit is not set. For some reason I didn't catch the warning: ... LD arch/x86/kernel/acpi/built-in.o CC arch/x86/oprofile/op_model_amd.o CC arch/x86/kernel/cpu/intel_cacheinfo.o ... (using gcc (Gentoo 4.4.3-r2 p1.2) 4.4.3) ... but it should warn. -- Advanced Micro Devices, Inc. Operating System Research Center --
Oct 25, 3:21 am 2010
Stephen Rothwell
Re: linux-next: build warning in Linus' tree
^^^^^^^^^^^^^^^^^^^^^^^^^^ Ignore this :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Oct 24, 5:45 pm 2010
Stephen Rothwell
Re: linux-next: build warning in Linus' tree
It been pointed out that I may have not bee clear enough. My statement above was meant to mean: "Ignore the bit about merging the hid tree, but the report is otherwise valid" -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Oct 24, 7:39 pm 2010
Stephen Rothwell
linux-next: build warning in Linus' tree
Hi Linus, After merging the hid tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/scsi/hpsa.c:94:1: warning: "PCI_DEVICE_ID_HP_CISSF" redefined In file included from include/linux/pci.h:58, from drivers/scsi/hpsa.c:25: include/linux/pci_ids.h:746:1: warning: this is the location of the previous definition Introduced by commit 6362beea8914cbd4630ccde3617d944aeca2d48f ("cciss: fix PCI IDs for new Smart Array controllers") a commit that never ...
Oct 24, 5:38 pm 2010
Greg Ungerer
[git pull] m68knommu arch updates
Hi Linus, Can you please pull the m68knommu git tree, for-linus branch. git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu.git for-linus Changes include support for the ColdFire 548x family, removal of __do_IRQ use, strace cleanups, some minor bug fixes, and quite a few cleanup patches (remove un-used symbols, whitespace formating, comments, etc). Thanks Greg The following changes since commit f6f94e2ab1b33f0082ac22d71f66385a60d8157f: Linus Torvalds (1): ...
Oct 24, 5:29 pm 2010
Phillip Lougher
[PATCH 2/2] Squashfs: fix function prototype
The fourth argument should be unsigned. Also add missing include so that the function prototype is defined in xattr_id.c This fixes a couple of sparse warnings. Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk> --- fs/squashfs/xattr.h | 4 ++-- fs/squashfs/xattr_id.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/squashfs/xattr.h b/fs/squashfs/xattr.h index 49fe0d7..b634efc 100644 --- a/fs/squashfs/xattr.h +++ b/fs/squashfs/xattr.h @@ ...
Oct 24, 5:06 pm 2010
Phillip Lougher
[PATCH 1/2] Squashfs: fix use of __le64 annotated variable
This fixes a sparse with endian checking warning. Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk> --- fs/squashfs/xattr.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/squashfs/xattr.c b/fs/squashfs/xattr.c index 652b854..3876c36 100644 --- a/fs/squashfs/xattr.c +++ b/fs/squashfs/xattr.c @@ -158,17 +158,18 @@ static int squashfs_xattr_get(struct inode *inode, int name_index, strncmp(target, name, name_size) == 0) { /* ...
Oct 24, 5:05 pm 2010
Phillip Lougher
[PATCH 0/2] Squashfs: a couple of sparse fixes
Hi, The following patches fix a couple of sparse warnings in Squashfs... Squashfs: fix use of __le64 annotated variable Squashfs: fix function prototype Thanks Phillip --
Oct 24, 5:01 pm 2010
Stephen Rothwell
Re: linux-next: error importing i2c quilt series
Hi Jean, What actually happens is I fetch all the trees and quilt series I import the quilt series to git branches I merge the trees. So you cannot depend on the merge order (which sometimes changes as well). This makes sense since I have no influence over the order that the trees get merged by Linus ... If there are dependencies, they need to be explicit, sorry, using NEXT_BASE in quilt series or merging (sub) trees for git. -- Cheers, Stephen Rothwell ...
Oct 25, 3:13 am 2010
Stephen Rothwell
Re: linux-next: error importing i2c quilt series
Hi Jean, Your series file says that your series is based on 2.6.36-git5, not Jesse's pci tree. You can add: # NEXT-BASE pci to your series file to force me to import your series on top of Jesse's OK, thanks -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Oct 25, 1:53 am 2010
Jean Delvare
Re: linux-next: error importing i2c quilt series
Hi Stephen, This patch depends on a patch adding/updating PCI IDs which I thought was in Jesse Barnes' pci tree which you also pull in linux-next. Apparently my assumption was wrong. Jesse, where's this patch? https://patchwork.kernel.org/patch/230361/ I certainly hope it's scheduled for merge soon! Meanwhile I've removed the other patch from my i2c-next tree, it will be back only when I'm certain it applied fine. Thanks, -- Jean Delvare --
Oct 25, 1:34 am 2010
Jean Delvare
Re: linux-next: error importing i2c quilt series
I thought it was NEXT_BASE, with an underscore not dash? And I also expected the trees to be merged in the order shows in: http://git.kernel.org/?p=linux/kernel/git/sfr/linux-next.git;a=blob;f=Next/Trees;hb=HEAD As pci is listed before i2c, I (wrongly) concluded that everything -- Jean Delvare --
Oct 25, 2:25 am 2010
Luciano Coelho
Re: [PATCH] wireless/wl1271: remove redundant if-statement
Yes, this patch is good, but please rewrite the description, as Larry suggested. -- Cheers, Luca. --
Oct 25, 6:10 am 2010
Nicolas Kaiser
[PATCH] wireless/wl1271: remove redundant if-statement v2
wl1271_ps_elp_sleep() is void and cannot return a value. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- Sorry for the poor wording of the initial description. drivers/net/wireless/wl12xx/wl1271_event.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/wl12xx/wl1271_event.c b/drivers/net/wireless/wl12xx/wl1271_event.c index 7b3f503..38ccef7 100644 --- a/drivers/net/wireless/wl12xx/wl1271_event.c +++ ...
Oct 25, 6:30 am 2010
Dmitry Torokhov
Re: 2.6.36-git4 -- BUG: looking up invalid subclass: 31 ...
Hi Miles, This should be fixed by: commit f74eef95e33a07379aa2b950c7f313cbfd55ebbe Author: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> Date: Wed Oct 13 11:35:40 2010 -0700 Input: mousedev - correct lockdep annotation When annotating mutex to avoid false lockdep reports we should not be using MOUSEDEV_MIX as lock subclass but rather SINGLE_DEPTH_NESTING. Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> Signed-off-by: Dmitry Torokhov ...
Oct 25, 12:56 am 2010
James Morris
Re: [PATCH] MIPS: MT: Fix build error iFPU affinity code
-- James Morris <jmorris@namei.org> --
Oct 25, 3:15 am 2010
KOSAKI Motohiro Oct 24, 5:40 pm 2010
Serafeim Zanikolas Oct 25, 10:44 am 2010
John W. Linville
Re: [PATCH] drivers: rtl818x: request DMA-able memory
It doesn't mean what you think it means. It is a relic of the past, used to indicate memory below 16MB so that ISA devices could do DMA. John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. --
Oct 25, 7:22 am 2010
John W. Linville
Re: [PATCH] drivers: rtl818x: request DMA-able memory
Are you sure about this? Are there USB controllers out there with the ISA 16MB limitation for DMA? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. --
Oct 25, 6:35 am 2010
Johannes Berg
Re: [PATCH] drivers: rtl818x: request DMA-able memory
I think there's some confusion here about ZONE_DMA vs. DMA-able memory. All memory you get with kmalloc can be used for DMA, GFP_DMA means using ZONE_DMA which is a hack for ISA (and in b43 maybe PCMCIA/Cardbus) devices to put memory into something they can address. I don't think the latter is necessary for USB devices. johannes --
Oct 25, 7:23 am 2010
Larry Finger Oct 25, 6:24 am 2010
Linus Torvalds
Re: [GIT PULL] Revert of the IO stat fix
Does Jens' suggested patch (the non-revert one) fix your oops? Or only the revert? IOW, I would want to know whether I could try just merging the fix instead of backing out the patch that looks like a real improvement.. Linus --
Oct 24, 5:07 pm 2010
Maxim Levitsky
Re: [GIT PULL] Revert of the IO stat fix
Yes, revert works. Tested xD, MS, USB. Best regards, --
Oct 24, 6:30 pm 2010
Maxim Levitsky
Re: [GIT PULL] Revert of the IO stat fix
The suggested patch doesn't fix the oops. Testing revert now. Best regards, --
Oct 24, 5:55 pm 2010
Vivek Goyal
Re: [GIT PULL] Revert of the IO stat fix
Ok, not allowing requests of different partitions to merge will atleast solve part of the problem for Yasuaki Ishimatsu. (in-flight accounting Not allowing request merging across partitions, I guess should remove the need of storing this info in request and allow us to remove req->part I think atleast one of the bugs was that we don't know whether request queue pointer obtained from disk->queue is still valid or not. Looking at the backtrace of crash reported by Maxim Levitsky ...
Oct 25, 12:24 pm 2010
Dmitry Torokhov
Re: [PATCH] drivers/input: ab8500-ponkey: fix error path
Yep, it is. Applied, thank you Nicolas. -- Dmitry --
Oct 24, 9:51 pm 2010
Sundar R IYER Oct 24, 8:36 pm 2010
Sundar R IYER Oct 24, 9:32 pm 2010
Dmitry Torokhov
Re: Bug#594089: keyboard-configuration: caps lock keycod ...
Hmm, the question is whether the real "favorites" key send the same usage and the fake one after caps lock. Any chance Tom could locate evtest utility and see what MSC_SCAN events being emitted? Thanks. -- Dmitry --
Oct 24, 9:50 pm 2010
Tom Vier
Re: Bug#594089: keyboard-configuration: caps lock keycod ...
Sure. Here's caps-lock: Event: time 1288013671.633008, -------------- Report Sync ------------ Event: time 1288013674.171812, type 4 (Misc), code 4 (ScanCode), value 70039 Event: time 1288013674.171853, type 1 (Key), code 58 (CapsLock), value 1 Event: time 1288013674.171862, -------------- Report Sync ------------ Event: time 1288013674.172210, type 17 (LED), code 1 (CapsLock), value 1 Event: time 1288013674.299553, type 4 (Misc), code 4 (ScanCode), value 70039 Event: time 1288013674.299580, ...
Oct 25, 6:37 am 2010
Samuel Thibault
Re: Bug#594089: keyboard-configuration: caps lock keycod ...
Could you also post results when pressing the "favorite" and the "prev" internet keys of your keyboard? Samuel --
Oct 25, 11:03 am 2010
Dmitry Torokhov
Re: Bug#594089: keyboard-configuration: caps lock keycod ...
Actually, if these are all the events that evtest reports when pressing CapsLock then I am confused where the "favorites" ghost press is coming from... They are not emitted by the device. Do you have a funky keymap loaded somewhere? Also, was 'showkey -s' issued while in X or in the text console? -- Dmitry --
Oct 25, 11:25 am 2010
Milan Broz
Re: CFQ and dm-crypt
Not sure but it will be discussed now. There are more situations where the process id is lost because of other queue, Sorry, both must be issued from separate thread, you must not block in common crypt_map() call: - READ must first allocate BIO clone for ciphertext data (it can wait here - memory allocation, imagine it waits for swap -> swap is on another crypt device -> deadlock) - WRITES first run encryption thus must allocate memory too. Moreover if encryption runs in async mode, it ...
Oct 25, 4:09 am 2010
Richard Kralovic
Re: CFQ and dm-crypt
Do you think it is possible to handle this in device-mapper, without any support from the cfq code? I also noticed that a solution for this problem was proposed a few years ago by Hirokazu Takahashi (a patch for linux-2.6.25, http://lkml.org/lkml/2008/4/22/193), but there was no response to it. Is Would the problem with deadlock be still present if the io worker queue was used for writes only, but reads were issued directly? (Even this would be a significant improvement for people using cfq ...
Oct 25, 2:53 am 2010
Jeff Moyer
Re: CFQ and dm-crypt
It would probably be helpful to CC Jens (which I did). I haven't looked very deeply at the approach in the referenced mail thread (though I did look far enough to tell that the aio bits were wrong), but in general I think this sort of thing is worthwhile. I'm not sure what the barriers are. Jens? Cheers, --
Oct 25, 7:22 am 2010
Vivek Goyal
Re: CFQ and dm-crypt
Richard, So what problem are you facing? I know you are referring to CFQ ioprio not working with dm targets but how does it impact you? So it is not about overall disk performance or any slow down with dm-crypt target but just Conceptually it makes sense to put some kind of info in bio so that we can associate with right context. I think above thread kind of of died down. Re-reading the thread now, and it looks like that Hirokazu also planned to use this info for associating IO to right ...
Oct 25, 1:59 pm 2010
Jeff Chua Oct 24, 5:45 pm 2010
Scott Wood
Re: [GIT PULL] KVM updates for the 2.6.37 merge window
On Sun, 24 Oct 2010 15:29:12 +0200 How about these patches which are in kvm.git/next but not kvm-updates/2.6.37? PPC: KVM: Book E doesn't have __end_interrupts. KVM: PPC: e500: Call kvm_vcpu_uninit() before kvmppc_e500_tlb_uninit() KVM: PPC: BookE: fix sleep with interrupts disabled KVM: PPC: BookE: Load the lower half of MSR -Scott --
Oct 25, 9:49 am 2010
Avi Kivity
Re: [GIT PULL] KVM updates for the 2.6.37 merge window
Alex, if you want them in, please prepare backports for 2.6.36.1. -- error compiling committee.c: too many arguments to function --
Oct 25, 9:59 am 2010
Herbert Xu
Re: [PATCH] drivers/crypto: dubious error check
Applied to crypto-2.6. Thanks! -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Oct 25, 4:26 pm 2010
Andrew Morton
Re: atmel_serial: fix RTS high after initialization in R ...
On Sun, 24 Oct 2010 12:48:29 +0200 That was a lot of code! How about just this? if (port->rs485.flags & SER_RS485_ENABLED) { UART_PUT_MR(&port->uart, ATMEL_US_USMODE_NORMAL); UART_PUT_CR(&port->uart, ATMEL_US_RTSEN); } --
Oct 25, 3:54 pm 2010
Suresh Siddha
Re: [PATCH 15/15] x86: Disabling x2apic if nox2apic is s ...
Yinghai, Have you validated this patch on a system having apicid's > 255 and when the bios has enabled x2apic? When a bios enables x2apic (typically when it finds processors with apic id's > 255), it also enables interrupt-remapping before enabling x2apic in the bios. So not sure what is the behavior with this patch(along with the nox2apic boot option). Does the kernel boot with cpu's having < 255 apicid, and also use the interrupt-remapping but with xapic mode? Also, the boot cpu's apic id ...
Oct 25, 10:50 am 2010
Yinghai Lu
[PATCH] x86, ioapic: Add debug printing when mapping for ...
It is in mp_register_ioapic(). Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/io_apic.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) Index: linux-2.6/arch/x86/kernel/apic/io_apic.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c +++ linux-2.6/arch/x86/kernel/apic/io_apic.c @@ -4068,6 +4068,9 @@ void __init mp_register_ioapic(int id, u mp_ioapics[idx].apicaddr = ...
Oct 25, 9:55 am 2010
Yinghai Lu
[PATCH] x86, ioapic: Don't map ioapic regs two times
Normal path: When mptable or madt is used, and ioapic address is correct, We already set mapping in mp_register_ioapic(). So only set_fixmap for dummy case. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/io_apic.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6/arch/x86/kernel/apic/io_apic.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c +++ ...
Oct 25, 9:59 am 2010
Dmitry Torokhov
Re: [PATCH] toshiba_acpi.c: Add key_entry for a lone FN ...
Well, if FN key can generate separate events then we should report KEY_FN, not KEY_UNKNOWN. Thanks. -- Dmitry --
Oct 25, 11:27 am 2010
Azael Avalos
Re: [PATCH] toshiba_acpi.c: Add key_entry for a lone FN ...
Hi, It actually generates on key press/release with different key codes, 0x17f and 0x100 respectively. So I think that both should be added. On Mon, Oct 25, 2010 at 12:27 PM, Dmitry Torokhov -- -- El mundo apesta y vosotros apestais tambien -- --
Oct 25, 11:42 am 2010
Masami Hiramatsu
Re: [PATCH 5/5] perf probe: Fix format specified for Dwa ...
Oops, right. Thanks Arnaldo! -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com --
Oct 24, 11:35 pm 2010
Masami Hiramatsu
Re: [PATCH 5/5] perf probe: Fix format specified for Dwa ...
Oops, right. Thanks Arnaldo! -- Masami HIRAMATSU 2nd Dept. Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com --
Oct 24, 11:36 pm 2010
Alon Ziv
Re: [PATCH v2 1/2] Export usb_serial_generic_write_room ...
Hi Johan, Well... the latest changes (due to your review) removed even my driver's use of this function. So probably there is no need to export it (at least not yet). If you prefer that I leave the export in place (and unused), I will clarify the patch description. -az --
Oct 25, 12:57 pm 2010
Johan Hovold
Re: [PATCH v2 1/2] Export usb_serial_generic_write_room ...
There's no need to export it unless it's got a use (and it's easily done later should need arise). I'm off for a week to UK (Embedded Linux Conference and some holidays) with limited mail access from tomorrow so I'll have to get back to you on your other mail when I'm back. Thanks, Johan --
Oct 25, 3:40 pm 2010
Johan Hovold
Re: [PATCH v2 2/2] opticon: use generic code where possible
Hi Alon, Some comments follow below. Here it seems you're turning write into a blocking function if you have Why limit to 64b in the no-bulk-out case when driver used to report and You should remove this function and set the throttle field to You should remove this function and set the unthrottle field in This is a fairly large value. Have you made any benchmarking to determine it? 256b have otherwise proven to be a good trade-off value for several drivers. (In particular, ...
Oct 25, 4:11 am 2010
Johan Hovold
Re: [PATCH v2 1/2] Export usb_serial_generic_write_room ...
As I mentioned elsewhere, this description is a little misleading as any driver can use the generic write_room implementation simply by not overriding it (i.e. leaving the write_room field undefined). There is nothing wrong with exporting it, but it is currently only your other patch that requires that. Could you perhaps just modify the patch description? Thanks, Johan --
Oct 25, 4:20 am 2010
Alon Ziv
Re: [PATCH v2 2/2] opticon: use generic code where possible
Hi Johan, Thanks for the review. Please see my replies below. Right... I considered doing it differently (which would require more code--I would need to track the outstanding control URBs, and would need a callback to free the kmalloc()ed setup packet). In the end, I left it as blocking because the actual protocol used by the OPN2001 is very light on writes (in fact, it never writes anything without waiting for a response, and its longest outgoing message is Good question, ...
Oct 25, 12:48 pm 2010
Milan Broz
[PATCH] loop: Properly clear sysfs in autoclear mode
In autoclear mode bdev is NULL but the sysfs entry should be destroyed otherwise this warning appears: WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0x82/0x95() sysfs: cannot create duplicate filename '/devices/virtual/block/loop0/loop' Fixes commit ee86273062cbb310665fe49e1f1937d2cf85b0b9 Signed-off-by: Milan Broz <mbroz@redhat.com> --- drivers/block/loop.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index ...
Oct 25, 12:11 am 2010
Jeff Chua Oct 25, 5:41 am 2010
Andrew Morton
Re: [PATCH UPDATED] fs/buffer.c: call __block_write_begi ...
On Sun, 24 Oct 2010 01:11:54 +0900 It looks OK. Was it tested? (ext2 mounted with -o nobh) --
Oct 25, 4:11 pm 2010
Namhyung Kim
[PATCH RESEND] fs/buffer.c: call __block_write_begin() i ...
If we have the appropriate page already, call __block_write_begin() directly instead of releasing and regrabbing it inside of block_write_begin(). Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- Shared error path. fs/buffer.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 7f0b9b0..a132c2b 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2466,11 +2466,10 @@ int nobh_write_begin(struct address_space *mapping, *fsdata ...
Oct 24, 11:01 pm 2010
scameron
Re: [PATCH 1/2] block: cciss: fix information leak to userland
leaking of contents of kernel stack memory to userland, Ack. Thanks. I would think hpsa needs a similar fix, and also cciss_ioctl32_big_passthru(). I suppose it's possible the big passthru alignment just "works out", (I haven't checked), but even if that is the case, probably best not to rely on such an accident, -- steve --
Oct 25, 7:03 am 2010
Miller, Mike (OS Dev) Oct 25, 7:40 am 2010
Miller, Mike (OS Dev)
RE: [PATCH 1/2] block: cciss: fix information leak to userland
BTW: this change needs to go into the cciss_ioctl32_big_passthru and the other passthru ioctls, also. --
Oct 25, 9:36 am 2010
Xu, Andiry
RE: XHCI: sleep inside atomic
Hmm....You're right. Thanks for catching this, I'll submit a patch later. Thanks & Best regards, --
Oct 25, 2:10 am 2010
Borislav Petkov
[PATCH] x86-32, mm: Remove duplicated include
Ok, here it is, 32-bit randconfig tested for a day. -- From: Borislav Petkov <bp@alien8.de> Date: Mon, 25 Oct 2010 18:15:22 +0200 Subject: [PATCH] x86-32, mm: Remove duplicated include b40827fa7268fda8a62490728a61c2856f33830b added an include directive which is needless and is taken care of by a previous one. Remove it. Caught-by: Jaswinder Singh Rajput <jaswinderlinux@gmail.com> Signed-off-by: Borislav Petkov <bp@alien8.de> --- arch/x86/kernel/acpi/sleep.c | 1 - 1 files changed, ...
Oct 25, 9:25 am 2010
Maxim Levitsky
Re: [PATCH 0/29] My patch queue for memorystick subsystem
Any update? Can I expect this in 2.6.37? Best regards, Maxim Levitsky --
Oct 24, 7:01 pm 2010
KOSAKI Motohiro
Re: [PATCH] vmscan: move referenced VM_EXEC pages to act ...
Hi Mandeep, Yeah, if you have enough time, can you please consider to join this testing? or can you please explain your interactivity experience if there is. Thanks. --
Oct 24, 5:44 pm 2010
=?utf-8?q?R=C3=A9mi? ...
Re: [64/66] Phonet: disable network namespace support
I don´t actually remember, but I obviously missed something :-( With similar problem reports in Nokia/MeeGo, that´ s what I added last week: From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Subject: [PATCH] Phonet: device notifier only runs on initial namespace This should really fix the OOPS when doing: unshare(CLONE_NEWNET); exit(0); while the phonet module is loaded. Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- net/phonet/pn_dev.c | 3 ...
Oct 25, 12:43 am 2010
Dr. Werner Fink
Re: [PATCH 28/49] tty: Add a new file /proc/tty/consoles
This is the main reason for what I've done this patch: To see on which console line the reading process is located. Please do not skip this part as this is currently the only way to detect the real console below /dev/console ... it could be used in user space: e.g. in plymouth or bootlogd (to deterime the main console) or sulogin (to be able to provide a prompt on all console Werner -- "Having a smoking section in a restaurant is like having a peeing section in a swimming ...
Oct 25, 12:51 am 2010
Jesper Nilsson
Re: [PATCH 08/49] ioctl: Use asm-generic/ioctls.h on cri ...
Excellent, looks great. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com --
Oct 25, 7:10 am 2010
Nguyen Dinh-R00091 Oct 25, 4:33 pm 2010
Uwe Kleine-König
Re: [PATCHv5 2/3] ARM: imx: Add gpio-keys to plat-mxc
Hello Lothar, I'd use the the for-rmk branch that rmk just pulled for .37. imx/master is at v2.6.35-rc4 which feels wrong. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | --
Oct 25, 12:21 am 2010
Lothar Waßmann
Re: [PATCHv5 2/3] ARM: imx: Add gpio-keys to plat-mxc
Hi Uwe, What kernel version should I base it on? The master branch of git://git.pengutronix.de/git/imx/linux-2.6.git? Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | ...
Oct 25, 12:02 am 2010
Gene Heskett
Re: 2.6.36, make oldconfig broken
I removed the mrproper line, reran the scripts and its all running like it should. I also had it run a pass of memtest86+, no problems found. I apologize for the noise. -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) We don't like their sound. Groups of guitars are on the way out. -- Decca Recording Company, turning down the Beatles, 1962 --
Oct 25, 7:23 am 2010
Nicolas Ferre
[PATCH 2/2 v2] AT91: pm: make sure that r0 is 0 when dea ...
When using CP15 cache operations (c7), we make sure that Rd (r0) is actually 0 as ARM 926 TRM is saying. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- v2: modify asm according to Russell's comments: be sure to insert asm lines in the proper order and inform gcc about register used. arch/arm/mach-at91/pm.c | 9 +++++++-- arch/arm/mach-at91/pm.h | 3 ++- arch/arm/mach-at91/pm_slowclock.S | 1 + 3 files changed, 10 insertions(+), 3 ...
Oct 25, 4:09 am 2010
Nicolas Ferre
Re: [PATCH 2/2] AT91: pm: make sure that r0 is 0 when de ...
Hi Russell, Thanks a lot for your detailed explanation. I modify my patch according to your comments: --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -261,8 +261,13 @@ static int at91_pm_enter(suspend_state_t state) * For ARM 926 based chips, this requirement is weaker * as at91sam9 can access a RAM in self-refresh mode. */ - asm("b 1f; .align 5; 1:"); - ...
Oct 25, 2:56 am 2010
Namhyung Kim
Re: [PATCH] kconfig: don't select 64 bit option on sparc ...
Looks better. :-) I didn't noticed that CONFIG_64BIT setup on sparc was just same as x86's. Adding sparc32 target will simply resolve the issue. The patch follows, Thanks. kbuild: add ARCH=sparc32 target Add 'sparc32' ARCH target to test all{yes,mod}config for 32-bit build. Signed-off-by: Namhyung Kim <namhyung@gmail.com> diff --git a/Makefile b/Makefile index 3e43805..8da6685 100644 --- a/Makefile +++ b/Makefile @@ -204,6 +204,9 @@ ifeq ($(ARCH),x86_64) endif # ...
Oct 24, 10:48 pm 2010
Randy Dunlap
Re: [PATCH] kbuild: check return value of asprintf()
Thanks, Michal. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** --
Oct 25, 7:42 am 2010
Michal Marek Oct 25, 2:30 am 2010
Davidlohr Bueso
Re: [PATCH RESEND] drm: include missing types header to ...
Yeah that's what made me send the patch. Thanks, Davidlohr --
Oct 24, 7:13 pm 2010
samu.p.onkalo Oct 24, 11:10 pm 2010
Li Zefan
Re: [PATCH 7/7] cgroups: Update documentation for bindab ...
But, wait. It stuck when I moved a task from a sub-cgroup to the root. Need to dig more.. --
Oct 24, 5:56 pm 2010
Li Zefan Oct 24, 5:59 pm 2010
Li Zefan
Re: [PATCH 0/7] cgroups: Allow to bind/unbind subsystems ...
Paul had a patch to allow some subsystems to be added to multi-hierarchies, which may help. But it forbids accessing t->cgroups, which makes this feature of limited use. Thanks! --
Oct 24, 6:07 pm 2010
KAMEZAWA Hiroyuki
Re: [PATCH 7/7] cgroups: Update documentation for bindab ...
On Fri, 22 Oct 2010 16:12:25 +0800 Can this operation be used with noop cgroup ? (IOW, perf cgroup can be attached to noop cgroup ?) Thanks, -Kame --
Oct 24, 5:36 pm 2010
Li Zefan
Re: [PATCH 2/7] cgroups: Allow to bind a subsystem to a ...
Nope. For some subsystems we just set the flag and need not to --
Oct 24, 6:23 pm 2010
Li Zefan Oct 24, 5:52 pm 2010
Li Zefan
Re: [PATCH 5/7] cgroups: Make freezer subsystem bindable
How about, we allow unbinding only when all the cgroups' state is We can use bindable:1 along with a callback can_bind(). For some subsystems, we just set bindable to true. For freezer subsystem, we set it to true and provide freezer_can_bind(), and return true only if no cgroup's state is FROZEN. --
Oct 24, 6:15 pm 2010
divya
Re: BUG with the kernel version 2.6.36-rc1 on power machine
The patch at http://lkml.org/lkml/2010/10/13/67 resolves the issue. But this is not a part of 2.6.36-git6 , when will it be pulled into the upstream? Thanks Divya --
Oct 25, 4:02 am 2010
Yong Zhang
Re: BUG with the kernel version 2.6.36-rc1 on power machine
That patch is splited into two parts. The lockdep one is 4ba053c04aece1f4734056f21b751eee47ea3fb1 upstream. The mousedev one is taken by Dmitry Torokhov(Cc'ing) Thanks, Yong --
Oct 25, 6:57 am 2010
Yong Zhang
Re: BUG with the kernel version 2.6.36-rc1 on power machine
Just notice Dmitry has sent pull request to Linus. You can also get the mousedev one here: http://git.kernel.org/?p=linux/kernel/git/dtor/input.git;a=commit;h=f74eef95e33a07379a... Thanks, Yong --
Oct 25, 7:15 am 2010
Martyn Welch
Re: [PATCH 27/30] staging/vme: rework the bus model
There are plenty of instances where a driver can be loaded before the bus is probed or a device is even present. When the bus become It is certainly not artificial. The VME64 spec (as approved in 1995) defines a CR/CSR space. This is a special 24-bit address space, which is divided in to 512KB blocks - specific offsets are assigned for Vendor and Device IDs. In fact, the VME64 spec also states that a rack must not have more than 21 slots. I'm sure there is hardware out there that doesn't ...
Oct 25, 4:24 am 2010
Suresh Jayaraman
Re: CIFS is slooow, gvfs is fast
Could you try mounting from commandline with something like `mount -t cifs //server/share /mnt/point -o user=user1` (commenting out the fstab entry) and try copying the file? -- Suresh Jayaraman --
Oct 25, 3:14 am 2010
Tejun Heo
Re: On Linux numbering scheme
Agreed. These days, I use just the last digit, as in kernel 36, in casual contexts. It's a number as good as any other. I don't think it needs to be changed actively. If the 2.6. prefix is bothering, just use the last number and maybe that will become semi-official in the future, or maybe not. Doesn't really matter. -- tejun --
Oct 25, 2:08 am 2010
Micha Nelissen
Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO ...
It does not take an ID away, it shares it with a connected endpoint to that switch. The tag uses one extra bit to identify the device as a switch instead of an endpoint. This provides the information to unambiguously identify a switch from an endpoint. Micha --
Oct 25, 9:13 am 2010
Bounine, Alexandre
RE: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO ...
OK taking away #2. But do not see how it justifies storing two values of destid. And you have just confirmed using CT for unique identification. We simply have differences in interpretation of CT: you are using component tag to pass unique identification and I am using CT as a unique identification. I prefer not to assume any relationship between routing information and the component tag. Alex. --
Oct 25, 10:13 am 2010
Micha Nelissen
Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO ...
I look at it this way: it prevents the need for another layer of Why no relation? My experience is that during debugging it's useful to have the destid directly at hand, it's just very practical. (Otherwise any drawing of a random network would need two "identification" numbers per drawn node: the component tag (true identification), and destid since that's what everyone uses to identify a device, what needs to programmed into the LUTs of a switch, identification in sysfs, ...
Oct 25, 1:06 pm 2010
Bounine, Alexandre
RE: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO ...
The component tag is the way to identify a RIO device (switch or endpoint). 1. it is defined by RIO spec as a register existing in both types of devices (this provides a universal access to the identification information by any processor). 2. the Error Management specification already uses the CT as a device identifier. 3. the CT value is large enough to be unique for max number of endpoints in the large system and any reasonable number of switches. BTW, I am planning to provide a patch that ...
Oct 25, 6:22 am 2010
Arnd Bergmann
Re: [microblaze-uclinux] Re: [PATCH v2 22/22] bitops: re ...
I think it needs to be set up in a way that new architectures (and those that never cared about minixfs) automatically get a reasonable default and should not need to set anything. I don't see a reason why little-endian microblaze should use big-endian bitops in minixfs, since that file system layout would also be incompatible with every other one. CONFIG_MINIX_FS_NATIVE_ENDIAN seems reasonable for both big- and little- endian microblaze, but new architectures should just keep the ...
Oct 25, 6:31 am 2010
Li Zefan
Re: [PATCH v2][GIT PULL] tracing: Prevent unloadable mod ...
Agreed. Add this trace_mod_printk() and add some comments to explain why and when use it. --
Oct 24, 6:32 pm 2010
KAMEZAWA Hiroyuki
Re: [PATCH V3] nommu: add anonymous page memcg accounting
On Fri, 22 Oct 2010 08:26:08 -0500 Hmm. I think fixing RLIMIT_AS is better. (but no nack to this patch.) Using memcg for _a_ program sounds like overkill... Thanks, -Kame --
Oct 24, 5:13 pm 2010
Gustavo F. Padovan
Re: [PATCH 0/1] Bluetooth: fix crash in L2CAP
Hi Greg, It is now on Linus' tree, sorry for doing this wrong first time. It was my first report to stable. ;) commit d793fe8caa3911e6a1e826b45d4ee00d250cdec8 -- Gustavo F. Padovan ProFUSION embedded systems - http://profusion.mobi --
Oct 25, 4:15 am 2010
Gui Jianfeng
Re: [PATCH 1/4 v2] cfq-iosched: add cfq group hierarchic ...
Hi Vivek, In short, All of the problems are bacause of the fixed weight "Hidden group". So how about make the "hidden group" weight becoming dynamic according to the cfqq number and priority. Or whether we can export an new user interface Do you mean that let cfqq and cfq group schedule at the same service tree. If we choose a cfq queue, ok let it run. If we choose the cfq group, we should continue to choose a cfq queue in that group. If that's the case, I think the original CFQ logic has ...
Oct 24, 7:48 pm 2010
Vivek Goyal
Re: [PATCH 1/4 v2] cfq-iosched: add cfq group hierarchic ...
Gui, Even if you do that it will still not solve the problem of RT tread in root group getting all the disk. Secondly, somehow the idea of hidden group is just not appealing to me and trying to even expose it to user will make it even uglier. I guess without going into implementation details, we need to first figure out what's the right thing to do from a design perspective and then later dive into what are the complexities involved in doing the Can you give more details about what's ...
Oct 25, 1:20 pm 2010
Zimny Lech
Re: [RFC] Removal of dead code from arch/arm/*
Ping? Kind regards, Macavity -- Slawa! N.P.S. Les fleurs du mal unfold Comme les fleurs du mal Dark demons of my soul Un amour fatal --
Oct 25, 4:35 pm 2010
Christoph Hellwig
Re: [Xen-devel] Re: linux-next regression: IO errors in ...
I don't think this has much to do with the backend. Xen never implemented empty barriers correctly. This has been a bug since day one, although before no one noticed because the cruft in the old barrier code made them look like they succeed without them actually succeeding. With the new barrier code you do get an error back for them - and you do get them more often because cache flushes aka empty barriers are the only thing we send now. The right fix is to add a cache flush command to the ...
Oct 25, 11:47 am 2010
Konrad Rzeszutek Wilk
Re: [Xen-devel] Re: linux-next regression: IO errors in ...
I think we just blindly assume that we would pass the request to the backend. And if the backend is running under an ancient version (2.6.18), the behavior would be quite different. Perhaps we should negotiate with the backend whether it runs under a kernel with the new barrier support? And if so, then enable them? If the backend says it has no idea what we are talking about then disable the barrier support? How does that sound? (Adding Daniel to this email thread as he has much more ...
Oct 25, 11:26 am 2010
Konrad Rzeszutek Wilk
Re: [Xen-devel] Re: linux-next regression: IO errors in ...
Ok, thank you for the pointer. Daniel, you are the resident expert, what do you say? Jens, for 2.6.37 is the patch for disabling write barrier support by the xen-blkfront the way to do it? Or if we came up with a patch now would it potentially make it in 2.6.37-rcX (I don't know if the fix for this would qualify as a bug or regression since it looks to be adding a new command)? And what Christoph suggest that this has been in v2.6.36, v2.6.35, etc. so that would definitly but it outside ...
Oct 25, 12:05 pm 2010
Mathias Burén
Re: sata_mv and Highpoint RocketRAID 230x, corruption?
Sorry for the noise, I already tried that and it broke the RAID. Instead I shrunk the "Used Dev Size" of each RAID member, like so (mdadm -E dev): Avail Dev Size : 3907025072 (1863.01 GiB 2000.40 GB) Used Dev Size : 3900702720 (1860.00 GiB 1997.16 GB) I hope that should be OK. Thanks for all the info. // Mathias --
Oct 25, 2:31 pm 2010
Mark Lord Oct 25, 2:26 pm 2010
Michal Marek
Re: linux-next: Tree for October 20
The zconf_curname() prototype was changed in 2e7a091 and the scripts/kconfig/lex.zconf.c_shipped file was updated as well. What probably happened is that you ended up using an updated scripts/kconfig/lkc.h header versus an old version of scripts/kconfig/lex.zconf.c. Ie. the rule that copies scripts/kconfig/lex.zconf.c_shipped to scripts/kconfig/lex.zconf.c did not trigger, very strange. I'll look further. Michal --
Oct 25, 1:47 am 2010
Huang Ying
Re: [PATCH 9/9] ACPI, APEI, Generic Hardware Error Sourc ...
Hi, Andi, Thank you very much for your review! Best Regards, Huang Ying --
Oct 24, 7:03 pm 2010
Huang Ying
Re: [PATCH 1/9] ACPI, APEI, Add ERST record ID cache
Hi, Andi, Yes. But will try to do that in another patch. Best Regards, Huang Ying --
Oct 24, 7:08 pm 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
here's another crash: Testing event wbc_balance_dirty_written: OK Testing event wbc_balance_dirty_wait: OK Testing event wbc_writepage: PPS event at 4294897530 OK Testing event kmalloc: OK Testing event kmem_cache_alloc: OK Testing event kmalloc_node: OK Testing event kmem_cache_alloc_node: BUG: unable to handle kernel paging request at ffffffff IP: [<96c35f7c>] 0x96c35f7c *pde = 01b29067 *pte = 00000000 Oops: 0002 [#1] SMP last sysfs file: Pid: 2, comm: kthreadd Not tainted ...
Oct 25, 1:59 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
here's a repeat bootup with the same config: Testing event kmalloc: OK Testing event kmem_cache_alloc: OK Testing event kmalloc_node: OK Testing event kmem_cache_alloc_node: BUG: unable to handle kernel paging request at ffffffff IP: [<b6c35f7c>] 0xb6c35f7c *pde = 01b29067 *pte = 00000000 Oops: 0002 [#1] SMP last sysfs file: Pid: 2, comm: kthreadd Not tainted 2.6.36-tip+ #52248 / EIP: 0060:[<b6c35f7c>] EFLAGS: 00010282 CPU: 1 EAX: ffffffff EBX: 7902361a ECX: 00000000 EDX: ...
Oct 25, 2:30 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
and here's a new crash with a new config: [ 11.810471] Testing event timer_expire_exit: OK [ 11.850475] Testing event timer_cancel: OK [ 11.890508] Testing event hrtimer_init: OK [ 11.930469] Testing event hrtimer_start: OK [ 11.970475] Testing event hrtimer_expire_entry: [ 11.980002] BUG: unable to handle kernel NULL pointer dereference at (null) [ 11.980010] IP: [<(null)>] (null) [ 11.980010] *pde = 00000000 [ 11.980010] Oops: 0000 [#1] SMP [ 11.980010] last ...
Oct 25, 4:45 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
Here's the disassembly of the crash site: c103d282: 89 da mov %ebx,%edx c103d284: 8b 4c 24 04 mov 0x4(%esp),%ecx c103d288: ff 16 call *(%esi) c103d28a: 83 c6 08 add $0x8,%esi c103d28d: 83 3e 00 cmpl $0x0,(%esi) c103d290: eb eb jmp c103d27d <__run_hrtimer+0x77> c103d292: 89 d8 mov %ebx,%eax c103d294: ff 14 24 ...
Oct 25, 5:10 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
As task.ti is 8K aligned (as it should be), and ESP is just a tad off the top of the stack (as it should be: a light timer irq interrupted the idle task). The relevant stack section looks like this: [ 11.980010] c103d297 00000000 c10460c1 c13dff4c ca105369 00000002 ffffffff 7fffffff [ 11.980010] c103d52b ca105369 00000002 ca105369 0000002c f6806a00 00000000 f6806a04 [ 11.980010] ca105369 00000002 ca105369 00000002 00000000 f6805dac 00000000 c1420788 and that 00000000 value ...
Oct 25, 5:32 am 2010
Peter Zijlstra
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
Right, and its doing an indirect function call from the first stack entry.. which would seem to suggest someone scribbled our stack.. --
Oct 25, 5:18 am 2010
Peter Zijlstra
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
So I can reproduce this using the .config provided a few emails ago: [ 22.945481] Testing event hrtimer_expire_entry: [ 22.950013] Symbol: __run_hrtimer @ c103d3c2 0x105 [ 22.954988] Ideal-NOP: 0f 1f 44 00 00 [ 22.958840] Transform: c103d429 -> e9 03 00 00 00 [ 22.963723] Code: 55 57 56 53 89 c3 83 ec 08 89 54 24 04 8b 68 20 8b 7d 00 9c 58 8d 74 26 00 f6 c4 02 74 0f ba bd 0 4 00 00 b8 02 0f 36 c1 e8 0b 89 fe ff 0f 1f 44 00 00 eb 19 8b 35 b0 ad 40 c1 85 f6 74 0f 8b 46 04 89 da ...
Oct 25, 8:47 am 2010
Peter Zijlstra
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
Is it me, or is this the first site where %esp is loaded with a value?, --
Oct 25, 9:07 am 2010
Peter Zijlstra
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
4.5.1 explodes in a very similar and very reproducable manner for me: [ 22.660537] Testing event hrtimer_expire_entry: [ 22.665071] Symbol: __run_hrtimer @ c103bfc5 0x103 [ 22.670061] Ideal-NOP: 0f 1f 44 00 00 [ 22.673907] Transform: c103c02c -> e9 03 00 00 00 [ 22.678793] Code: 55 57 56 53 89 c3 83 ec 08 8b 68 20 89 54 24 04 8b 7d 00 9c 58 8d 74 26 00 f6 c4 02 74 0f ba bd 04 00 00 b8 0b 8e 35 c1 e8 e0 94 fe ff 0f 1f 44 00 00 eb 19 8b 35 f0 2c 40 c1 85 f6 74 0f 8b 46 04 89 da ff 16 ...
Oct 25, 9:09 am 2010
Peter Zijlstra
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
OK, new theory.. 56 pushl 0 67 nopl jmp 0x6f popl jmp 0x8c 6f mov test je 0x8c 8c mov call *(%esp) So in the jumped path we miss a popl which pop's the 0 pushed before, which is the exact address call is failing on.. Looks like gcc got its branches confused or something.. Am I reading this right? --
Oct 25, 10:45 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
Hm, the NOP looks correct, and none of the instructions before or after the patch site seem to be corrupted. Another piece of info: i'm using Athlon64, while Peter is using westmere EP. So it's not CPU model dependent. Thanks, Ingo --
Oct 25, 10:25 am 2010
Jason Baron
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
thanks. I've been able to re-produce both the fork, and the timer interrupt crashes. It looks to me like we are patching the correct addresses with the correct instructions, based on looking at the disassembly and tracing what is getting patched when before the crash. That's not say we aren't missing a cache flush somewhere...but I don't see any code in a bad state so far... I'm also wondering if the self tests arent' enabled. If we run them after the system is up, if that works. ...
Oct 25, 8:55 am 2010
Jason Baron
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
Hi Peter, (adding Richard Henderson to the 'cc list) Yes, the missing popl in the enabled looked wrong to me as well...I've been inquiring about this with gcc folks. thanks, -Jason --
Oct 25, 10:52 am 2010
Ingo Molnar
Re: [PATCH][GIT PULL] tracing: Fix compile issue for tra ...
another data point is that applying the patch below from Peter seems to stabilize things, i've got 130 successful randconfig iterations so far and no crash. I.e. it's directly jump labels related. Thanks, Ingo NOT-Signed-off-by: Ingo Molnar <mingo@elte.hu> --- include/linux/jump_label.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h index b67cb18..4732acd 100644 --- ...
Oct 25, 10:32 am 2010
Joshua Hoke
RE: [PATCH] macb: Don't re-enable interrupts while in po ...
Thanks for pointing this out. It looks fine in my sent folder but here's a second try. In case this doesn't work, I've attached the contents to the bug as: https://bugzilla.kernel.org/attachment.cgi?id=34972 Contents of first e-mail follow, maybe not mangled this time. From: Joshua Hoke <joshua.hoke@sixnet.com> [PATCH] macb: Don't re-enable interrupts while in polling mode On a busy network, the macb driver could get stuck in the interrupt handler, quickly triggering the watchdog, ...
Oct 25, 4:44 am 2010
David Miller
Re: [PATCH] macb: Don't re-enable interrupts while in po ...
From: "Joshua Hoke" <Joshua.Hoke@sixnet.com> Applied. --
Oct 25, 12:15 pm 2010
Ted Ts'o
Re: [PATCH] ext4: Check return value of sb_getblk() and ...
Thanks, I've added this patch to the ext4 patch queue. - Ted --
Oct 25, 7:51 am 2010
KAMEZAWA Hiroyuki
Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global ...
On Sun, 24 Oct 2010 11:44:38 -0700 Hmm. I think it's better to add enough comments. Or easier logic will be simple double-check. 1) calculates global-dirty-limit (always do) If this hits global_dirty_limit, skip below. 2) if under memcg, calculate memcg-dirty-limit. Sure. Thank you. -Kame --
Oct 24, 5:24 pm 2010
Daisuke Nishimura
Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global ...
On Sun, 24 Oct 2010 11:44:38 -0700 I have one concern now. I've noticed that global_dirty_limits() is called bdi_debug_stats_show(), so the output of "cat /sys/kernel/debug/bdi/.../stats" changes depending on the memcg where the command is executed. Can you take it into account too ? Thanks, Daisuke Nishimura. --
Oct 24, 7:00 pm 2010
Ciju Rajan K
Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global ...
What about the following scenarios? a) limit usage sys 9 7 B 8 6 A 4 1 Now assume B consumes 2 more. The total of B reaches 8 (memcg max) and the system total reaches 9 (Global limit). The scenario will be like this. limit usage sys 9 9 B 8 8 A 4 1 In this case, group A is not getting a fair chance to utilize its limit. Do we need to consider this case also? b) Even though we are defining per cgroup dirty limit, it is not actually the case. Is it indirectly dependent on the the ...
Oct 25, 12:03 am 2010
KAMEZAWA Hiroyuki
Re: [PATCH v2][memcg+dirtylimit] Fix overwriting global ...
On Mon, 25 Oct 2010 12:33:23 +0530 IMHO, it's admin's job to make the limitation fair. Yes, it should be. memory cgroup isn't a backdoor to break system's control. Thanks, -Kame --
Oct 25, 12:08 am 2010
Raju Rameshwar Uprade
Re: pl2303 ttyUSB0: pl2303_write - failed submitting wri ...
Hi Greg. I am now able to transmit the Address byte with mark parity and data bytes with space parity properly. Thanks a lot greg for you help.... Below is the control signal and data going out on USB bus number 7. f5aafd00 2277683484 S Co:7:002:0 s 21 20 0000 0000 0007 7 = 80250000 000308 // Control signal for mark parity f5aafd00 2277684456 C Co:7:002:0 0 7 > f5aafd00 2277684497 S Co:7:002:0 s 21 22 0003 0000 0000 0 f5aafd00 2277685456 C Co:7:002:0 0 ...
Oct 25, 2:30 am 2010
Tony Lindgren
Re: [PATCH 3/3] omap: add hwspinlock device
Yes (2) please. I would assume there will be more use of this. And then we (or probably me again!) don't have to deal with cleaning up the drivers Yes variation of (2) where you only pass the locking function via platform data would be best. Regards, Tony --
Oct 25, 12:02 pm 2010
Ben Dooks
Re: [Device-drivers-devel] [PATCH] i2c: add irq_flags to ...
I also dislike set_irq_type() as it doesn't check whether there is anyone registered with the interrupt, which means that you could set the irq type of someone else's irq. I wonder if we should pass a struct resource instead, in case there are multiple interrupt sources, as well as having it registered with the right resource systems. -- Ben Q: What's a light-year? A: One-third less calories than a regular year. --
Oct 24, 5:45 pm 2010
Jonathan Cameron
Re: [Device-drivers-devel] [PATCH] i2c: add irq_flags to ...
Either works as far as I am concerned. Having seen a large set of drivers using the flags option (posted to linux-iio yesterday) I'm definitely convinced some means of allowing devices to match what the board config asks for is useful. I personally prefer the struct resource option as I have multiple drivers in IIO which have two interrupts and this is the only reason some of them use platform data. Thanks, Jonathan --
Oct 25, 7:12 am 2010
Andrew Morton
Re: [PATCH] lib/atomic64_test: do not build on non-atomi ...
Not really. If someone implements atomic64 on 32-bit they may do it by putting a spinlock in the atomic64_t. Or they might use hashed spinlocks, in which case that'll work. Probably hashed spinlocks, given the (realtively new) convention that the all-zeroes pattern is a legit way of initialising an atomic_t. --
Oct 24, 6:52 pm 2010
Rafael J. Wysocki
Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown ...
I posted a patch fixing that in a different way (makng the battery driver return -ENODEV instead of -ENODATA) in the meantime, which has been confirmed to work. Thanks, Rafael --
Oct 25, 1:36 pm 2010
Pavel Machek
Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown ...
I'd say that reporting -1 for unknown is ugly. You can have -1A current easily (charging at 1A), and I've seen machines reporting <0 current -- when charging. Logical and well-defined. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Oct 25, 6:17 am 2010
Pavel Machek
Re: ima: use of radix tree cache indexing == massive was ...
Well, I'm arguing that the criteria are wrong. Duplicated crap is creeping in (TOMOYO vs. AppArmor), and strange stuff that has no legitimate use is in (IMA -- what is it good for? locking machines I do disagree, and I do not think 'satistfaction of all parties' is reasonable goal. Rest of kernel has different rules, and IMO they are better. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Oct 25, 6:18 am 2010
H. Peter Anvin
Re: [PATCH 1/5] xen: events: use irq_alloc_desc(_at) ins ...
I think the number is not necessarily "never before used", but rather "not currently used". -hpa --
Oct 25, 4:05 pm 2010
Jeremy Fitzhardinge Oct 25, 4:21 pm 2010
Ian Campbell
[PATCH 2/5] xen: events: turn irq_info constructors into ...
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/xen/events.c | 102 ++++++++++++++++++++++++++++++++------------------ 1 files changed, 65 insertions(+), 37 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index c8f3e43..33fae3d 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -129,46 +129,76 @@ static struct irq_chip xen_dynamic_chip; static struct irq_chip xen_percpu_chip; static struct irq_chip xen_pirq_chip; -/* Constructor ...
Oct 25, 9:23 am 2010
Ian Campbell
[PATCH 5/5] xen: events: use per-cpu variable for cpu_ev ...
I can't see any reason why it isn't already. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/xen/events.c | 31 +++++++++++-------------------- 1 files changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 9b58505..144ff72 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -110,19 +110,9 @@ static int *pirq_to_irq; static int nr_pirqs; static int *evtchn_to_irq; -struct cpu_evtchn_s { - unsigned ...
Oct 25, 9:23 am 2010
Ian Campbell
Re: [PATCH 1/5] xen: events: use irq_alloc_desc(_at) ins ...
I suspect what we should really be doing is to segregate the different classes of event channel in IRQ space. I _think_ this new stuff is happy with a discontinuous (but presumably clustered) IRQ space, I should probably check. e.g. regular interdomain event channels, VIRQs and the like should probably request allocations from some range higher than nr_hw_irqs, thus avoiding conflicts with hardware PIRQ event channels which would ask for a 1-1 mapping with the GSI (i.e. same interrupt numbers ...
Oct 25, 11:02 am 2010
Ian Campbell
[PATCH 3/5] xen: events: push setup of irq<->{evtchn,pir ...
Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/xen/events.c | 23 +++++++++-------------- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 33fae3d..94055ea 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -137,6 +137,7 @@ static struct irq_info *info_for_irq(unsigned irq) /* Constructors for packed IRQ information. */ static void xen_irq_info_common_init(struct irq_info *info, + ...
Oct 25, 9:23 am 2010
Ian Campbell
[PATCH 4/5] xen: events: dynamically allocate irq info s ...
Removes nr_irq sized array allocation at start of day. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/xen/events.c | 50 +++++++++++++++++++++++++++++++++++++++++--------- 1 files changed, 41 insertions(+), 9 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 94055ea..9b58505 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -56,6 +56,8 @@ */ static DEFINE_SPINLOCK(irq_mapping_update_lock); +static ...
Oct 25, 9:23 am 2010
Ian Campbell
[PATCH 00/05] xen: events: cleanups after irq core impro ...
I'm about to followup with an initial stab at some cleanups which are made possible by these core changes, including hanging the per-irq info off the handler_data. These patches are on top of recent Linus master tree plus Konrad's swiotlb-xen tree and Stefano's PVHVM tree since the latter in particular touches the same area. Ian. --
Oct 25, 9:22 am 2010
Ian Campbell
[PATCH 1/5] xen: events: use irq_alloc_desc(_at) instead ...
Encapsulate allocate and free in xen_irq_alloc and xen_irq_free. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- drivers/xen/events.c | 68 ++++++++++++++++++++----------------------------- 1 files changed, 28 insertions(+), 40 deletions(-) diff --git a/drivers/xen/events.c b/drivers/xen/events.c index 97612f5..c8f3e43 100644 --- a/drivers/xen/events.c +++ b/drivers/xen/events.c @@ -394,41 +394,29 @@ static int find_unbound_pirq(void) return -1; } -static int ...
Oct 25, 9:23 am 2010
Jeremy Fitzhardinge
Re: [PATCH 00/05] xen: events: cleanups after irq core i ...
This looks pretty good. How much testing have you given it? Do you have a git branch I can pull? Thanks, J --
Oct 25, 4:03 pm 2010
Konrad Rzeszutek Wilk
Re: [PATCH 1/5] xen: events: use irq_alloc_desc(_at) ins ...
So I am curious what the /proc/interrupts looks?The issue (and the reason for this implementation above) was that under PV with PCI devices we would overlap PCI devices IRQs with Xen event channels. So we could have a USB device at IRQ 16 _and_ also a xen_spinlock4 handler. That would throw off the system since the xen_spinlock4 was an edge type handler while the USB device was an level (at least on my box). But with this shinny sparse_irq rework, maybe this is not an issue anymore? Can we ...
Oct 25, 10:35 am 2010
Jeremy Fitzhardinge
Re: [PATCH 1/5] xen: events: use irq_alloc_desc(_at) ins ...
What? Why? How? Surely if we're asking the irq subsystem to allocate us an irq, it will return a fresh never-before-used (and certainly not shared) irq? Shared irqs only make sense if multiple devices are actually sharing, say, a wire on the board. Or am I missing something? J --
Oct 25, 4:03 pm 2010
Wolfgang Grandegger
Re: [PATCH net-next-2.6 v1] can: Topcliff: Update PCH_CA ...
Ah, oh, and I added my review to yours :-(. Sorry, for the inconvenience it caused: https://lists.berlios.de/pipermail/socketcan-core/2010-October/004787.html Anyway, Ohtake should have received the review. The driver is *not* yet ready for inclusion. Therefore, please fix the remaining issues asap. Thanks, Wolfgang. --
Oct 25, 12:06 am 2010
Jesse Barnes
Re: [PATCH v4 6/6] x86: allocate space within a region t ...
On Thu, 14 Oct 2010 17:18:52 -0600 Applied this series to linux-next; assuming nothing blows up I'll send it to Linus this week (previous versions got some testing and landed in a separate branch so this should be fine). -- Jesse Barnes, Intel Open Source Technology Center --
Oct 25, 2:01 pm 2010
Bjorn Helgaas
Re: [PATCH v4 6/6] x86: allocate space within a region t ...
We tripped over another issue in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=646027 I think I see the problem, and posted a patch for testing. When it's resolved, I'll post an updated series. Bjorn --
Oct 25, 2:08 pm 2010
Bjorn Helgaas
Re: [PATCH v4 6/6] x86: allocate space within a region t ...
By the way, it's been a *great* help to have Fedora being willing to go out on a limb and help get these tested. I know it sucks to get those Rawhide bug reports, but they have been extremely useful to me. Thanks! Bjorn --
Oct 25, 2:15 pm 2010
Jesse Barnes
Re: [PATCH v4 6/6] x86: allocate space within a region t ...
On Mon, 25 Oct 2010 15:08:48 -0600 Ok thanks, I'll drop it from -next then. -- Jesse Barnes, Intel Open Source Technology Center --
Oct 25, 2:17 pm 2010
Michael Cree
Re: [PATCH 0/3] alpha: __do_IRQ just say no
I had this running on a PWS600au for a few hours without any problems showing up. That tests the generic Alpha code and the irq_pyxis and irq_i8259 machine specific code. Tested-by: Michael Cree <mcree@orcon.net.nz> Cheers Michael. --
Oct 25, 3:09 pm 2010
Peter Zijlstra
Re: High CPU load when machine is idle (related to PROBL ...
Not really, CPUs can stay idle for _very_ long times (!x86 cpus that don't have crappy timers like HPET which roll around every 2-4 seconds). But all CPUs staying idle for a long time is exactly the scenario you fix before using the decay_load_misses() stuff, except that is for the load-balancer per-cpu load numbers not the global cpu load avg. Won't a similar approach work here? --
Oct 25, 3:12 am 2010
Venkatesh Pallipadi
Re: High CPU load when machine is idle (related to PROBL ...
Yes. Thought about that. One problem there is that works with nohz_idle_balance, which will not be called if all the CPUs are idle for example. As this is once in 5 secs, probably doing nr_running() and nr_uninterruptible() should be OK even on huge systems. But, that was the original code here, except that it was inside xtime_lock. Thanks, Venki --
Oct 25, 9:29 am 2010
Miller, Mike (OS Dev) Oct 25, 1:26 pm 2010
scameron
Re: [PATCH 01/13] cciss: remove controllers supported by hpsa
I don't think we want to open this can of worms. We want disjoint sets if at all possible. The only reason they weren't disjoint sets from the get go was because at the time, nobody had any of the newer boards, and we needed something to test hpsa on. From what I've seen of newer distro betas, the udev stuff does seem to behave pretty nicely nowadays and one can transparently boot up and mount filesystems and so on despite swapping out cciss for hpsa or vice versa without any need to fix ...
Oct 25, 3:04 pm 2010
James Bottomley
Re: [PATCH 01/13] cciss: remove controllers supported by hpsa
This hunk conflicts with the update Mike Miller sent commit 6362beea8914cbd4630ccde3617d944aeca2d48f Author: Mike Miller <mike.miller@hp.com> Date: Tue Oct 19 09:40:34 2010 +0200 cciss: fix PCI IDs for new Smart Array controllers And which is now mainline. James --
Oct 25, 1:09 pm 2010
Nao Nishijima
Re: [RFD] Device Renaming Mechanism
Hello, Indeed, device-mapper can provide a fixed name. However, still there is mismatch between the dm device name and the troubling device name in kernel log. That is the reason why I'm still sticking around the device renaming method. In addition, using of device-mapper is worry about the performance and management cost. I think the method of using the intermediate device is the simplest solution. Furthermore that method is compatible with old applications which are hard to Even ...
Oct 25, 3:55 am 2010
Thomas Gleixner
Re: [PATCH 11/18] fs: Introduce per-bucket inode hash locks
And a locking macro/structure is better in self documenting than a helper function which was proposed by Christoph? Thanks, tglx --
Oct 24, 9:41 pm 2010
Thomas Gleixner
Re: [PATCH 11/18] fs: Introduce per-bucket inode hash locks
Independently of what data structure you folks agree on, we really do _NOT_ want to have open coded bit_spin_*lock() anywhere in the code. As I said before, aside of RT it's a basic requirement to switch bit spinlocks to real ones for lockdep debugging. Thanks, tglx --
Oct 25, 12:04 am 2010
Miklos Szeredi
Re: [PATCH 7/9 updated] vfs: protect remounting superblo ...
And add a nice bit of overhead to a hot path... Making it per-cpu would help, but then we'd end up with the same ifdef mess as mnt_writers and still a non-zero overhead. But what's the point anyway, the per-sb write count always equals SUM(mnt->mnt_writers). How about this variant? It addresses the vfsmount vs. sb read only status independence: Index: linux-2.6/fs/internal.h =================================================================== --- ...
Oct 25, 5:36 am 2010
J. Bruce Fields Oct 25, 12:09 pm 2010
Neil Brown
Re: Deadlock possibly caused by too_many_isolated.
On Mon, 25 Oct 2010 00:52:34 +0800 Hi, thanks for the patch. I'll make a few changes to what I finally apply - for example we don't really need mempools in r1buf_poll_alloc as that isn't on the writeout path - so I'll tidy that up first. Also I'll avoid making changes to fs/bio.c at first. It may still be a good idea to have a bio_clone_bioset, but that should be a separate patch - there are at least 3 places that would use it. Thanks - I'll try to get this into the current ...
Oct 24, 11:40 pm 2010
Wu Fengguang
Re: Deadlock possibly caused by too_many_isolated.
OK. That change is not absolutely necessary for the deadlock fix. It's done just in hope of improving things a bit under memory pressure: r1buf_poll_alloc() allocates N bios at one time, which might temporarily exhaust BIO_POOL_SIZE. Since that path is independent of Fair enough. I did the fs_bio_set->bio_destructor = bio_fs_destructor; hack for the same reason: it's better to pass the destructor func as a parameter to bioset_create(), however that requires changing ...
Oct 25, 12:26 am 2010
DDD Oct 24, 10:58 pm 2010
H. Peter Anvin
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
It's still a completely unnecessary waste of startup time some potentially significant fraction of the time. Startup time matters, especially as the number of tracepoints grow. -hpa --
Oct 25, 2:54 pm 2010
H. Peter Anvin
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
This is pure conjecture, I have not measured it, but I suspect in fact that we could just change the composite nops in nops.h to use a 3E prefix instead of a separate 90 nop. Some platforms will take a penalty on the prefix, but that would be balanced against handling two instructions. The P5 core and others of the same generation might suffer, as it might have been able to do U+V pipe pairing on two instructions which it wouldn't for prefixes. -hpa --
Oct 25, 3:19 pm 2010
H. Peter Anvin
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
That's fair. I think jump labels are still a win even in the double-jump case (especially if the the tracepoint turns into a NOP rather than a JMP.) Code generated with -Os has a bunch of other problems, too. -hpa --
Oct 25, 3:32 pm 2010
Mathieu Desnoyers
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
Cool, thanks for the info! Steven and Jason should probably update their respective infrastructure to use the 32-bit 5-byte nop you propose rather than the 5-byte jump. Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com --
Oct 25, 3:55 pm 2010
H. Peter Anvin
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
On 64 bits, use P6_NOP5; it seems to not suck on any platform. On 32 bits, 3E 8D 74 26 00 (i.e. DS: + GENERIC_NOP4) seems to at least do okay. I can't say these are the *best* (in fact, they are guaranteed not the best on some significant number of chips), but they haven't sucked on any chips I have been able to measure -- and are way faster than JMP. -hpa --
Oct 25, 3:12 pm 2010
H. Peter Anvin
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
-Os unfortunately drops a bunch of optimizations. With gcc 4.5.1 there is actually a way to guarantee to get rid of double jumps, which is that you tell gcc that it is branching to one of two targets: asm goto("1: .byte 0xe9 ; .long %l[t_no]-2f\n" "2:\n" /* patching infrastructure goes here */ : : "i" (bit) : : t_no, t_yes); __builtin_unreachable(); t_no: return false; t_yes: return ...
Oct 25, 3:31 pm 2010
Mathieu Desnoyers
Re: [PATCH] tracing: Cleanup the convoluted softirq trac ...
We're still waiting for input for the best single-5-byte-instruction nop that will work on all x86 variants. Please note that the GENERIC_NOP5 is actually two instructions one next to each other, which is not appropriate here. Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com --
Oct 25, 3:01 pm 2010
Tejun Heo
Re: [PATCH] block: remove REQ_HARDBARRIER
Looks good to me. Reviewed-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun --
Oct 25, 1:54 am 2010
Jeremy Fitzhardinge
Re: [PATCH 1/5] Add a global synchronization point for pvclock
Unfortunately this is breaking Xen save/restore: if you restore on a host which was booted more recently than the save host, causing the system time to be smaller. The effect is that the domain's time leaps forward to a fixed point, and stays there until the host catches up to the source host... I guess last_time needs to be reset on this type of event. I guess the cleanest way would be for pvclock.c to register a sysdev suspend/resume handler. --
Oct 25, 4:30 pm 2010
previous daytodaynext day
October 24, 2010October 25, 2010October 26, 2010