Re: [PATCH] um: Fix IRQ flag handling naming

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Monday, October 25, 2010 - 12:29 pm

On Mon, 25 Oct 2010 17:24:33 +0200
Richard Weinberger <richard@nod.at> wrote:


Please always fully describe a bug when fixing it.  Something more than
"broke".  In the case of compilation errors or warnings, that means
quoting the compiler error output and, if necessary, the means of
reproducing it (config, compiler version, etc).

I did an allnoconfig uml build and saw this:

In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5,
                 from /usr/src/25/arch/um/include/shared/um_uaccess.h:10,
                 from /usr/src/25/arch/um/include/asm/uaccess.h:41,
                 from /usr/src/25/arch/um/include/asm/thread_info.h:13,
                 from include/linux/thread_info.h:56,
                 from include/linux/preempt.h:9,
                 from include/linux/spinlock.h:50,
                 from include/linux/seqlock.h:29,
                 from include/linux/time.h:8,
                 from include/linux/stat.h:60,
                 from include/linux/module.h:10,
                 from init/main.c:13:
/usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags" redefined

which I shall assume is the error which this patch addresses.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] um: Fix IRQ flag handling naming, Richard Weinberger, (Mon Oct 25, 8:24 am)
Re: [PATCH] um: Fix IRQ flag handling naming, Andrew Morton, (Mon Oct 25, 12:29 pm)
Re: [PATCH] um: Fix IRQ flag handling naming, Richard Weinberger, (Mon Oct 25, 12:38 pm)