Home » Mailing list archives » linux-kernel » 2010 » October » 25

Re: [resend][PATCH 3/4] move cred_guard_mutex from task_struct to signal_struct

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Nesterov
Subject: Re: [resend][PATCH 3/4] move cred_guard_mutex from task_struct to signal_struct
Date: Monday, October 25, 2010 - 10:42 am

On 10/25, Roland McGrath wrote:

I believe the patch is fine (it already has my reviewed-by).

Except: I am not sure about -stable. At least, this patch should
not go into the <2.6.35 kernels, it relies on misc changes which
changed the scope of task->signal. Before 2.6.35 almost any user
of ->cred_guard_mutex can race with exit and hit ->signal == NULL.

Oleg.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[resend][PATCH 1/4] oom: remove totalpage normalization fr ..., KOSAKI Motohiro, (Sun Oct 24, 8:26 pm)
[resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tunable&quot;, KOSAKI Motohiro, (Sun Oct 24, 8:27 pm)
[resend][PATCH 3/4] move cred_guard_mutex from task_struct ..., KOSAKI Motohiro, (Sun Oct 24, 8:28 pm)
[resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Sun Oct 24, 8:29 pm)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, pageexec, (Mon Oct 25, 4:28 am)
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_st ..., Roland McGrath, (Mon Oct 25, 10:26 am)
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_st ..., Oleg Nesterov, (Mon Oct 25, 10:42 am)
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_st ..., Roland McGrath, (Mon Oct 25, 10:51 am)
Re: [resend][PATCH 1/4] oom: remove totalpage normalizatio ..., David Rientjes, (Mon Oct 25, 1:37 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Mon Oct 25, 1:40 pm)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Tue Oct 26, 12:25 am)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Tue Oct 26, 6:01 am)
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_st ..., KOSAKI Motohiro, (Tue Oct 26, 6:04 am)
Re: [resend][PATCH 3/4] move cred_guard_mutex from task_st ..., Roland McGrath, (Tue Oct 26, 6:18 am)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Tue Oct 26, 12:37 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Mon Nov 1, 12:06 am)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Mon Nov 1, 12:36 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Mon Nov 8, 7:26 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Mon Nov 8, 8:28 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Tue Nov 9, 4:33 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., Alan Cox, (Tue Nov 9, 4:35 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Tue Nov 9, 4:48 pm)
[patch] oom: document obsolete oom_adj tunable, David Rientjes, (Tue Nov 9, 4:55 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Sat Nov 13, 10:07 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Sun Nov 14, 2:39 pm)
Re: [patch] oom: document obsolete oom_adj tunable, KOSAKI Motohiro, (Sun Nov 14, 5:22 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Sun Nov 14, 5:24 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Mon Nov 15, 2:59 am)
Re: [patch] oom: document obsolete oom_adj tunable, David Rientjes, (Mon Nov 15, 3:38 am)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Tue Nov 23, 12:16 am)
Re: [patch] oom: document obsolete oom_adj tunable, KOSAKI Motohiro, (Tue Nov 23, 12:16 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Tue Nov 23, 7:34 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Tue Nov 23, 5:24 pm)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Wed Nov 24, 4:09 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Thu Nov 25, 4:06 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Thu Nov 25, 7:02 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Thu Nov 25, 12:36 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Sat Nov 27, 6:41 pm)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Sun Nov 28, 10:25 pm)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Mon Nov 29, 4:33 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, Oleg Nesterov, (Mon Nov 29, 11:23 am)
Re: [resend][PATCH 4/4] oom: don't ignore rss in nascent mm, KOSAKI Motohiro, (Mon Nov 29, 5:06 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., KOSAKI Motohiro, (Tue Nov 30, 6:03 am)
[PATCH 0/2] exec: more excessive argument size fixes for 2 ..., Oleg Nesterov, (Tue Nov 30, 12:54 pm)
[PATCH 1/2] exec: make argv/envp memory visible to oom-killer, Oleg Nesterov, (Tue Nov 30, 12:55 pm)
[PATCH 2/2] exec: copy-and-paste the fixes into compat_do_ ..., Oleg Nesterov, (Tue Nov 30, 12:56 pm)
[PATCH 0/4] exec: unify compat/non-compat code, Oleg Nesterov, (Tue Nov 30, 1:00 pm)
[PATCH 1/4] exec: introduce get_arg_ptr() helper, Oleg Nesterov, (Tue Nov 30, 1:00 pm)
[PATCH 2/4] exec: introduce &quot;bool compat&quot; argument, Oleg Nesterov, (Tue Nov 30, 1:01 pm)
[PATCH 3/4] exec: unify compat_do_execve() code, Oleg Nesterov, (Tue Nov 30, 1:01 pm)
[PATCH 4/4] exec: unexport acct_arg_size() and get_arg_page(), Oleg Nesterov, (Tue Nov 30, 1:01 pm)
Re: [resend][PATCH 2/4] Revert &quot;oom: deprecate oom_adj tun ..., David Rientjes, (Tue Nov 30, 1:07 pm)
Re: [PATCH 1/2] exec: make argv/envp memory visible to oom ..., KOSAKI Motohiro, (Tue Nov 30, 5:12 pm)
Re: [PATCH 2/2] exec: copy-and-paste the fixes into compat ..., KOSAKI Motohiro, (Tue Nov 30, 8:04 pm)
Re: [PATCH 0/4] exec: unify compat/non-compat code, KOSAKI Motohiro, (Tue Nov 30, 8:09 pm)
(No subject header), Milton Miller, (Wed Dec 1, 10:37 am)
Re: [PATCH 1/2] exec: make argv/envp memory visible to oom ..., Oleg Nesterov, (Wed Dec 1, 11:07 am)
Re: (No subject header), Oleg Nesterov, (Wed Dec 1, 11:27 am)