Re: [PATCH] wireless/wl1271: remove redundant if-statement

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Luciano Coelho

Subject: Re: [PATCH] wireless/wl1271: remove redundant if-statement

Date: Monday, October 25, 2010 - 6:10 am

On Mon, 2010-10-25 at 00:24 +0200, ext Larry Finger wrote:
quoted text> On 10/24/2010 05:07 PM, Nicolas Kaiser wrote:
> > Apparently the return value of wl1271_ps_elp_sleep never gets
> > checked anyway.
> 
> The patch is fine, but this comment is a little misleading as
> wl1271_ps_elp_sleep() is void and cannot return a value.

Yes, this patch is good, but please rewrite the description, as Larry
suggested.

-- 
Cheers,
Luca.

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] wireless/wl1271: remove redundant if-statement, Nicolas Kaiser, (Sun Oct 24, 3:07 pm)

Re: [PATCH] wireless/wl1271: remove redundant if-statement, Larry Finger, (Sun Oct 24, 3:24 pm)

Re: [PATCH] wireless/wl1271: remove redundant if-statement, Luciano Coelho, (Mon Oct 25, 6:10 am)

[PATCH] wireless/wl1271: remove redundant if-statement v2, Nicolas Kaiser, (Mon Oct 25, 6:30 am)

Re: [PATCH] wireless/wl1271: remove redundant if-statement v2, Luciano Coelho, (Tue Oct 26, 3:27 am)


linux-kernel:
Ken Chen	[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar	Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt	Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov	Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki	[Bug #16380] Loop devices act strangely in 2.6.35
git:
Steven Grimm	Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King	Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt	Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin	Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce	Re: [PATCH v2] Speed up bash completion loading
git-commits-head:
Linux Kernel Mailing List	cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List	sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List	IB/core: Add support for masked atomic operations
Linux Kernel Mailing List	V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List	ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev:
Inaky Perez-Gonzalez	[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil	[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux	Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller	Re: tun: Use netif_receive_skb instead of netif_rx
David Miller	Re: [net-next PATCH v2] llc enhancements
freebsd-current:
Matthew Fleming	Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com	Re: OT: 2d password
Hartmut Brandt	Re: problem with nss_ldap
Andrew Reilly	Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier	Re: Upcoming ABI Breakage in RELENG_7