They just hide the sameness of methods. Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> --- I may be missing something but frankly I don't see the reason for hiding sameness here, the reverse -- if you're going to change something then instead of looking into direct method implementation you are to tear through wrapping calls. Of course if implementation is differ from 'default_' one (as in x2apic, uv) it deserves own method. No? arch/x86/kernel/apic/apic_flat_64.c | 17 ...

The patch is fine, but this comment is a little misleading as wl1271_ps_elp_sleep() is void and cannot return a value. Larry --

Hi, I suddenly noticed that sound is not working on 2.6.36; there's no error, or warning, everything seems to be working, but there's no sound coming out. I tried the rc's and AFAICR it was working fine, maybe I changed the config, but everything seems to be ok. I went back to the rc's and still couldn't get them to work. 2.6.35.7 works though. I'm attaching the config. -- Felipe Contreras

Change the message displayed to the user according to the current mode used. Fix trailing white-space and spelling Signed-off-by: Nicolas Palix <npalix.work@gmail.com> --- scripts/coccicheck | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index 7529af1..1bb1a1b 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -32,7 +32,7 @@ if [ "$MODE" = "" ] ; then fi MODE="chain" elif [ "$MODE" = ...

From: Julia Lawall <julia@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Nicolas Palix <npalix.work@gmail.com> --- scripts/coccinelle/tests/doublebitand.cocci | 54 +++++++++++++++++++++++++++ scripts/coccinelle/tests/doubletest.cocci | 40 ++++++++++++++++++++ 2 files changed, 94 insertions(+), 0 deletions(-) create mode 100644 scripts/coccinelle/tests/doublebitand.cocci create mode 100644 scripts/coccinelle/tests/doubletest.cocci diff --git ...

Hi Rob, I suspect the following one-line patch should fix the problem. Cheers Trond ------------------------------------------------------------------------------------------------------ From 118df3d17f11733b294ea2cd988d56ee376ef9fd Mon Sep 17 00:00:00 2001 From: Trond Myklebust <Trond.Myklebust@netapp.com> Date: Sun, 24 Oct 2010 17:17:31 -0400 Subject: [PATCH] SUNRPC: After calling xprt_release(), we must restart from call_reserve Rob Leslie reports seeing the following Oops after ...

Despite the indicated intention in comment, the kmalloc() call was not explicitly requesting memory from ZONE_DMA. Signed-off-by: Serafeim Zanikolas <sez@debian.org> --- drivers/net/wireless/rtl818x/rtl8187_dev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/rtl818x/rtl8187_dev.c b/drivers/net/wireless/rtl818x/rtl8187_dev.c index 38fa824..771794d 100644 --- a/drivers/net/wireless/rtl818x/rtl8187_dev.c +++ ...

Hi Linus, The fix for cross-partition merges screwing up disk stats turns out to be problematic on various levels. Lets revert this one so we have time to come up with a proper solution for this. git://git.kernel.dk/linux-2.6-block.git for-linus Jens Axboe (1): Revert "block: fix accounting bug on cross partition merges" block/blk-core.c | 24 ++++++++---------------- block/blk-merge.c | 2 +- block/blk.h | 4 ++++ block/genhd.c ...

Hmm.. I think the reverted patch looks like it really is the right thing to do, so I hate reverting it this early. What were the problems with it? Btw, one thing that seems to be missing in the original commit (which is not necessarily the reason for the trouble, of course), is that elv_rq_merge_ok() seems to not check the partition. As far as I can tell, we should have a if (req->part != bio->bi_bdev->bd_part) return 0; there, no? And you should _not_ set rq->part in ...

The patch itself is sound, the problems are around the area of it not really liking non-elevator devices with the elv_quiesce_start/end() parts. I had the below patch for that, but then I could not decide whether we were fully safe on queue free after talking to Vivek about it. So that shows up as an oops on removal of mspro for instance, and loop throws a fit as well. Coverage of the bug is too large just to let side idle for a few days. And since I'll be travelling the next few days, I ...

Hello, Please forgive this post but I am new. I am building an installation media set and I am looking for the Linux-libc-headers for 2.6.35.7. I am following instructions from: http://www.tldp.org/LDP/lfs/LFS-BOOK-6.1.1-HTML/index.html and http://www.phenix.bnl.gov/~purschke/RescueCD/ I want to use my old computers (Presario 433 with Evergreen AMD 586 overdrive) to participate as a debugger. I figure if I can find problems between the various base packages, I can inform the appropriate ...

Hi, Simple modprobe loop ; rmmod loop on Linus' tree now produces now OOPS. Bisected to patch (and reverting fixes problem) commit 7681bfeeccff5efa9eb29bf09249a3c400b15327 Author: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Date: Tue Oct 19 09:05:00 2010 +0200 block: fix accounting bug on cross partition merges The problem is probably that patch uses directly q->queue_lock even if queue is being destroyed (QUEUE_FLAG_DEAD is set). See what loop (and not only this code) ...

Hi Linus, Please pull i2c subsystem updates for Linux 2.6.37 from: git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging.git i2c-for-linus MAINTAINERS | 6 + drivers/gpu/drm/nouveau/nouveau_i2c.h | 1 - drivers/gpu/drm/radeon/radeon_mode.h | 1 - drivers/i2c/Kconfig | 3 +- drivers/i2c/Makefile | 4 +- drivers/i2c/algos/Kconfig | 12 + drivers/i2c/algos/Makefile | 4 +- ...

Hi Linus, The bulk of changes here are from Christoph Lameter's SLUB unification patch series. I've included SLUB cleanups that don't change the core allocator and hope to queue the more interesting patches for 2.6.38. There's also bug fixes and other cleanups included here from David Rientjes and Namhyung Kim. The SLUB patches were built on Tejun Heo's UP per-CPU patches which is why they show up in the pull request although you already have them in master. ...

It looks to me like it was intended to check the return value at this point. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- drivers/media/video/gspca/cpia1.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/cpia1.c b/drivers/media/video/gspca/cpia1.c index 9b12168..58325db 100644 --- a/drivers/media/video/gspca/cpia1.c +++ b/drivers/media/video/gspca/cpia1.c @@ -829,7 +829,7 @@ static int goto_low_power(struct gspca_dev *gspca_dev) ...

hm, i'm not aware of that - where, which commit? Thanks, Ingo --

Hi, I've run into a couple of issues using perf timechart: 1. (On 2.6.36) If I issue echo 0 > /proc/sys/kernel/perf_event_paranoid as root before running perf timechart record echo as a normal user the following is printed: Fatal: Permission error - are you root? Consider tweaking /proc/sys/kernel/perf_event_paranoid. Shouldn't it just say it needs root permissions for a timechart record? 2. (On -tip) Running perf timechart record echo outputs ...

CFQ related problem should be solved - probably device-mapper core have to provide some help. (It is not only about dm-crypt, lot of situations when IO is submitted from different internal process. The proposed patch is not the proper and complete way how to solve it.) For the per-cpu patch - I am waiting for replay, apparently some additional work there is needed. But I would like to solve it ASAP. Milan --

Thank for you replying ^ ^ I was aware with the problems and I am following Andi's dm-crypt per-cpu patch (I haven't applied or tested it). However, I didn't know about http://lkml.org/lkml/2010/10/24/59 --> So this may well be the root of the problem! Also, won't http://lkml.org/lkml/2010/10/24/59 need to be altered (again) to work with Andi's patch ? -- There's small choice in rotten apples. -- William Shakespeare, "The Taming of the Shrew" --

The short story is: Tom's keyboard sends all that when he presses caps lock: press: 0x3a 0xe0 0x66 repeat: 0x3a release: 0xba 0xe0 0xe6 0xe0 0x66 happens to be the "favorites" key on his keyboard with internet navigation keys. I thus believe there's a bug in his keyboard that needs to be filtered at the kernel level. The long story can be read on http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594089 Yes, as I said in a previous mail, squeeze Xorg now interprets the internet ...

CFQ io scheduler relies on using task_struct current to determine which process makes the io request. On the other hand, some dm modules (such as dm-crypt) use separate threads for doing io. As CFQ sees only these threads, it provides a very poor performance in such a case. IMHO the correct solution for this would be to store, for every io request, the process that initiated it (and preserve this information while the request is processed by device mapper). Would that be feasible? Other ...

Please can you try patch I posted here http://lkml.org/lkml/2010/10/24/30 ? Thanks, Milan --

As per thread title. Thank you very much for your kind attention. -- Yours sincerely, Singapore Citizen Mr. Teo En Ming (Zhang Enming) 张恩鸣 Dip(Mechatronics) BEng(Hons)(Mechanical Engineering) Singapore Identity Card No.: S78*6*2*H Location: Bedok Reservoir Road, Singapore ZIP: 470103 Mobile Phone (Starhub Pre-paid): +65-8369-2618 Windows Live Messenger: teoenming-at-hotmail.com My Youtube videos: http://www.youtube.com/user/enmingteo Alma Maters: [1] Singapore Polytechnic (Graduated ...

Linus, the repository and branch git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/2.6.37 contains the kvm updates for the 2.6.37 merge window. Major changes this time around include powerpc paravirtualization, a virtual tsc rework, and exposing npt to the guest for fast nested virtualization. Please pull. Shortlog/diffstat: Alexander Graf (68): KVM: PPC: Introduce shared page KVM: PPC: Convert MSR to shared page KVM: PPC: Convert DSISR to shared ...

I am a registered money lender who offer loans to people with a low interest rate (2%) and also with so much considerations. We also offer loan to private,public and to co-operate bodies,so, i will kindly advice you apply for an easy loan now so that you can solve out your financial problems and also pay off your bills Contact lenderwill@gmail.com --

Looks like a copy-and-paste problem to me. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- drivers/crypto/n2_core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c index 88ee015..7614126 100644 --- a/drivers/crypto/n2_core.c +++ b/drivers/crypto/n2_core.c @@ -1832,7 +1832,7 @@ static int __devinit get_irq_props(struct mdesc_handle *mdesc, u64 node, return -ENODEV; ino = mdesc_get_property(mdesc, ...

This patch adds basic support for the new VX900 IGP. Almost everything that was implemented for other IGPs is expected to work also on VX900 after this patch. The only known issue is that on the CRT output mode setting does not always work. It is clear that the possibility for regressions is zero. A big thanks to VIA Technologies for making this possible and supporting this work. Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Cc: Joseph Chan <JosephChan@via.com.tw> Cc: ...

On Sat, 23 Oct 2010, Yinghai Lu wrote: This part is adding and changing functionality, so it needs to be a different series with a 0/N mail which explains what and why. And please take your time addressing the review issues as this is going to be 2.6.38 material if at all. Thanks, tglx --

Failure to create drbd_ee_mempool appears not to get checked. Looks like a copy-and-paste problem to me. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> --- drivers/block/drbd/drbd_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index c5dfe64..25c7a73 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -2982,7 +2982,7 @@ static int drbd_create_mempools(void) ...

Remove some sched_info_queue(), sched_info_dequeue() code comment. We no longer belongs to the era of O(1) and we don't use active or expired array anymore. Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> --- diff --git a/kernel/sched_stats.h b/kernel/sched_stats.h index 25c2f96..48ddf43 100644 --- a/kernel/sched_stats.h +++ b/kernel/sched_stats.h @@ -157,15 +157,7 @@ static inline void sched_info_reset_dequeued(struct task_struct *t) } /* - * Called when a process is ...

From: Marco Stornelli <marco.stornelli@gmail.com> This patch adds a new function called ioremap_change_write_prot. Goal of this patch is to create a general function for all archs to be able to change a write protection of a memory mapped area. x86 has already got a similar framework, so this function is only a wrapper. Next target will be arm and powerpc. This function will be used by Pramfs (see its latest review). Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com> --- diff ...

From: Yong Zhang <yong.zhang@windriver.com> Now curr_timer doesn't resident in struct hrtimer_cpu_base anymore. Signed-off-by: Yong Zhang <yong.zhang0@gmail.com> --- include/linux/hrtimer.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h index fd0c1b8..dd9954b 100644 --- a/include/linux/hrtimer.h +++ b/include/linux/hrtimer.h @@ -158,7 +158,6 @@ struct hrtimer_clock_base { * @lock: lock protecting the base and ...

That pr_info is not really important, but it makes the function --

For 32bit mptable path, setup_ids_from_mpc() always write io apic id register, even there is no change needed. So try to do that when they are different bewteen reading out and mptable Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/io_apic.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index ce3c6fb..0579b3b 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ ...

1. Merge acpi_register_lapic_address, smp_register_lapic_address, sfi_register_lapic_address 2. nox2apic support: disable x2apic for preenabled system or kexec path. Thanks Yinghai Lu 71fee2d: x86: Disabling x2apic if nox2apic is specified 017b8d0: acpi: Reverse uid and apic_id print out for x2apic 0c2a5ca: x86, apic, acpi: Handle xapic/x2apic entries in MADT at same time 88c4f93: x86, x2apic: Don't map lapic addr for preenabled x2apic 7084cf3: x86, ioapic: Only print mapping for ioapic ...

kill mp_sfi_register_lapic_address, they are the same Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/sfi.c | 13 +------------ 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/arch/x86/kernel/sfi.c b/arch/x86/kernel/sfi.c index dd4c281..4dc8065 100644 --- a/arch/x86/kernel/sfi.c +++ b/arch/x86/kernel/sfi.c @@ -34,17 +34,6 @@ #ifdef CONFIG_X86_LOCAL_APIC static unsigned long sfi_lapic_addr __initdata = APIC_DEFAULT_PHYS_BASE; -static void __init ...

Need ? You can, because the check is redundant if I understand the above correctly. Thanks, --

How is this restricted to early == 1 ? It's called unconditionally which is nonsense. Thanks, tglx --

If x2apic is reenabled, and used in kernel, We don't need to map that lapic address. That mapping will never be used. So just skip that in smp_register_lapic_address() Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/apic.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 2cfa622..d286db1 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ ...

One system have mixing xapic and x2apic entries in MADT and SRAT. Need to handle every entry in MADT at same time with xapic and x2apic. so we can honor sequence in MADT. We can use max_cpus= command line to use thread0 in every core, because recent MADT always have all thread0 at first. Also it could make the cpu to node mapping more sane. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/acpi/boot.c | 35 ++++++++++++++++++++------- drivers/acpi/numa.c | 18 ...

Check if mp_lapic_addr is assigned or not. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/apic.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 3a4e770..2cfa622 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1682,6 +1682,9 @@ void __init init_apic_mappings(void) void __init smp_register_lapic_address(unsigned long address) { + if ...

So if set_fixmap_nocache is not called, don't print out anything Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/apic.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 05b8bf7..a5ce130 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1656,10 +1656,7 @@ void __init init_apic_mappings(void) * acpi_register_lapic_address() */ if ...

And why must this be restricted to smp ? Thanks, tglx --

Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/visws_quirks.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/visws_quirks.c b/arch/x86/kernel/visws_quirks.c index 3371bd0..a70bc71 100644 --- a/arch/x86/kernel/visws_quirks.c +++ b/arch/x86/kernel/visws_quirks.c @@ -211,6 +211,7 @@ static void __init visws_find_smp_config(void) MP_processor_info(mp++); mp_lapic_addr = APIC_DEFAULT_PHYS_BASE; + set_fixmap(FIX_APIC_BASE, ...

So fixmap will be setup there. Signed-off-by: Yinghai Lu <yinghai@kernel.org> --- arch/x86/kernel/apic/apic.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index a5ce130..3a4e770 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1527,7 +1527,7 @@ static int __init detect_init_APIC(void) return -1; } - mp_lapic_addr = ...

Pulled. With one modification: I didn't take the top merge commit. I _really_ prefer to see the clashes myself, and the extra merges just make history less readable. So if the conflicts are trivial, please don't pre-merge stuff - it just hides things from me. Now, admittedly the things it hides shouldn't matter for something like the trivial tree, but at the same time, exactly because it's the trivial tree I would also expect the conflicts to be really trivial, so I'd rather just have ...

Bah, it's still pending in my TODO folder, sorry for that. I am not really convinced whether it's the right aproach. First, I'll go check HUT how much non-standard the usages you are adding to generic code, are. Perhaps it would satisfy separate driver on the hid bus? (Second, I hope to shovel all the 'drivers' which only do specialized mappings into userspace/udev actually). -- Jiri Kosina SUSE Labs, Novell Inc. --

Looking at that trace, it's not yet deleted. But if it's in the to-free path, by the time we invoke the rcu callback and do the quiesce end it could be gone. Needs a bit of thought, feel free to poke at it today if you have time (because I really do not :-/) Didn't get it twice. -- Jens Axboe --

Darn. Your fix is on the right path, you missed one though. I think it's cleaner to move this into the elevator helpers, so that the callers can remain clean. Can you verify that this works too? diff --git a/block/elevator.c b/block/elevator.c index 2569512..f08ae2d 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -590,11 +590,8 @@ void elv_drain_elevator(struct request_queue *q) /* * Call with queue lock held, interrupts disabled */ -void elv_quiesce_start(struct ...

Pulled, thanks Arnaldo! Ingo --

Oops, typo... Last sentence was supposed to end with "in usb_debug". usb_debug invokes usb_serial_generic_write from break_ctl and ignores the result; therefore, if there is no room in the generic write FIFO, the write will fail. However--usb_debug _only_ uses usb_serial_generic_write for break_ctl; so if there is no room, it is because of a previous (uncompleted) break_ctl, and according to standard UART semantics there is no difference between one break and two... -a --

You are not only correcting a typo. You are changing the sense of the comment, unfortunately in the wrong way. Why wouldn't it be recommended that the interrupt hardware ticks at the requested HZ value ? The inability of it to tick accurately at the requested HZ value is one of the causes which make jiffies clocksource inaccurate. And that what the comment says. Thanks, tglx --

Thomas, Please reread the patch again, I think it does exactly what he said it I misread it the first time myself, mentally combining the second line Cheers, Kyle Moffett --

yes, seems I forgot bdev can be NULL in destructor (autoclear mode). can you try if patch below helps? Milan loop: Properly clear sysfs in autoclear mode Signed-off-by: Milan Broz <mbroz@redhat.com> diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 6c48b35..c21d4f3 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1049,9 +1049,9 @@ static int loop_clr_fd(struct loop_device *lo, struct block_device *bdev) if (bdev) invalidate_bdev(bdev); ...

I did a make clean, and it fixed the problem. I tried checking out a 2.6.35.7 kernel, build it, checkout 2.6.36 on top, then build without make clean, and it works fine now. So I cannot reproduce the problem. Thanks for the hint! -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com --

The added benefit is that if you (or someone else) do(es) they don't occupy memory when a different machine is booted because the functions and their input data can live in .init sections. I didn't measure the impact on booting time, but I think it doesn't make much difference. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | --

I think I reported this before CC drivers/scsi/scsi_transport_sas.o make[4]: *** No rule to make target `drivers/scsi/aic7xxx/aicasm/*.[chyl]', needed by `drivers/scsi/aic7xxx/aicasm/aicasm'. Stop. make[3]: *** [drivers/scsi/aic7xxx] Error 2 make[2]: *** [drivers/scsi] Error 2 make[1]: *** [drivers] Error 2 make: *** [sub-make] Error 2 This one is new to me CC [M] ...

IMO the 'struct pad_desc' should be replaced with an u64 bitmap that would allow for the pullup and other definitions that may be board specific to be simply or'ed to the pad definition. I could try to provide a patch if this is agreed on. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: ...

Hi Gene, I don't understand the last few lines of buildit26 script: make oldconfig make mrproper make xconfig 'make mrproper' is going to blow away the .config file that was just generated by 'make oldconfig'. 'make help' in the kernel top-level directory says (for mrproper): mrproper - Remove all generated files + config + various backup files then 'make xconfig' is basically going to give you a 'make defconfig', so yes, you would see lots of .config file differences ...

> >  > There's a _single_ commit that looks like this: > >  > > >  >  220 files changed, 34823 insertions(+), 43478 deletions(-) > > > > Hey, you're not using git properly... if I use '-M' to show moved > > files, I see: > > > >  212 files changed, 30007 insertions(+), 38662 deletions(-) > > > > which is a lot nicer. > > It really doesn't make any difference what-so-ever. Lookie here: Sorry to set you off ... I was being a bit sarcastic, and playing off your tendency to show ...

Can't this be fixed in the sparc Makefile/Kconfig instead? E.g. have ARCH=sparc -> ask ARCH=sparc64 -> CONFIG_64BIT=y ARCH=sparc32 -> # CONFIG_64BIT is not set like the x86/i386/x86_64 ARCH option for x86. Michal --

Never mind. Played a bit with git, learned something new, and got it all merged. Now compiling. Eric, once I pushed the changes into above branch (hopefully by tonight), would be great if you could give it another test run. Thanks, Guenter --

Great, thanks. Unfortunately, the patches don't apply to my staging branch, probably because of the other pending lis3 changes. Samu, please rebase your patches to git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git hwmon-next and resubmit. Thanks, Guenter --

--

--

--

--

--

Thanks for the fix Jens. I had done testing with pulling out a usb key from a running system to check for hot remove/ blk_cleanup_queue() path and not sure why didn't I catch it. I have got one little concern here. blk_throtl_exit() takes requeust queue spin locks and relies on the fact that q->queue_lock is still around. IIUC, in blk_release_queue(), there is no gurantee that driver has not freed up the memory associated with spin lock (If it is a driver provided spin lock). Checking ...

Applied to osd/linux-next. I'll push it for 2.6.37 Thanks --

As I wrote I don't know anybody who wants to use minixfs that's why we don't need to do anything with it. I can test it but it has no high priority. Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian --

Now that I've looked into it I think we basically fine right now. If we're in umount there should be no other I_FREEING inodes. - concurrent prune_icache is prevented by iprune_sem. - concurrent other invalidate_inodes should not happen because we're in unmount and the filesystem should not be reachable any more, and even if it did iprune_sem would protect us. - how could a concurrent iput_final happen? filesystem is not accessible anymore, and iput of fs internal inodes is ...

Note that we would only have to do this for the umount case. For others it's pretty pointless. But I think there's a better way to do it, and that's per-sb inode lru lists. By adopting the scheme from prune_dcache we'd always have s_umount exclusive for inode reclaims, and per defintion we would not have any ongoing reclaim when we do enter umount. It would also allow us to get rid of iprune_sem and the nasty unsolved locking issues it causes. --

And having it fail is a good thing. XIP mode means different file and address_space operations, which we don't even try to deal with right I don't think it should mess with fsnotify. fsnotify_unmount_inodes assumes it's only called on umount right now, and sends umount notifications to userspace (see my mail from a few days ago). So if you split invalidate_inodes it really should only go into the umount one. --

Hey again, Wow, somehow it looks like it's actually OK now. I don't know why to be honest. Details: [root@ion raid-MBR-backup]# cat /proc/mdstat Personalities : [raid6] [raid5] [raid4] md0 : active raid5 sdg1[0] sdc1[3] sdd1[4] sdb1[1] 5851054080 blocks super 1.2 level 5, 128k chunk, algorithm 2 [4/4] [UUUU] unused devices: <none> So it successfully grew to 4 devices. Yay! It's online and happy. The ~3.7TB ext4 fs under the LVM beneath md0 is fine. What I need to do now, is ...

In [PATCH 08/11] IMA: only allocate iint when needed + if (unlikely(inode->i_readcount == 0) && + !ima_limit_imbalance(file)) { + printk(KERN_INFO "%s: open/free imbalance (r:% u)\n", + __func__, inode->i_readcount); + dump_stack(); + } else { + inode->i_readcount--; + } Please separate the i_readcount test from the ...

Interesting, the jump was to NULL. I'm thinking it hit a trace point and jumped to a NULL address. I guess there's some strange race here. Is a cache flush missing somewhere. I'll look more into this on Monday. --

Thanks, I will try it RSN, hopefully one of the next few days. -- Stefan Richter -=====-==-=- =-=- ==--- http://arcgraph.de/sr/ --

The following is as per Ingo's suggestion. Agains 2.6.36. Thanks. In the function ui__dialog_yesno(), automatic buffers have to be used as long as we are compiling perf with the -Wwrite-stings and -Werror options. This is because the Newt library does not declare the string parameters in newtWinChoice() as constant when it should. But the automatic buffers are not large enough to benefit from ssp at least on some gcc versions, e.g. the one that comes with Ubuntu 9.0.4. This along with ...

Hi Tony, I share this concern as well. We basically have three options here: 1. Have the hwspinlock driver inside the omap folders and use pdata func ptrs 2. Have a generic hwspinlock framework, with a small omap-specific implementation 3. Have a misc driver which is currently omap specific, but can very easily be converted to a common framework I don't like (1) so much; it's a driver that has very little that is hardware specific (mainly just the two lines that actually access ...

> That's only part of the problem. The following won't build also: > drivers/infiniband/hw Interesting... I hadn't looked at that usage before. Both drivers that seem to use atomic64 already depend on 64BIT in Kconfig, so I suspect the intersection of 64BIT and !ATOMIC64 is empty? But eg drivers/infiniband/hw/qib/qib_rc.c does essentially: atomic64_t *maddr; u64 sdata = <something> ... maddr = (atomic64_t *) qp->r_sge.sge.vaddr; atomic64_add_return(sdata, maddr) is it legit ...

IMHO this driver needs some improvements. There are some open points from Wolfgangs and my review. On the other side, it's a new driver and there's some time left before it hits mainline. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |

Please send a patch against the current driver which will fix these build warnings that occur when CONFIG_PM is disabled: drivers/net/can/pch_can.c:258:13: warning: 'pch_can_set_int_custom' defined but not used drivers/net/can/pch_can.c:269:13: warning: 'pch_can_get_int_enables' defined but not used drivers/net/can/pch_can.c:420:13: warning: 'pch_can_get_rx_enable' defined but not used drivers/net/can/pch_can.c:438:13: warning: 'pch_can_get_tx_enable' defined but not ...

Commit-ID: ffec516976f64b4e3e59ba1bb8a5020008cc678a Gitweb: http://git.kernel.org/tip/ffec516976f64b4e3e59ba1bb8a5020008cc678a Author: Sonny Rao <sonnyrao@linux.vnet.ibm.com> AuthorDate: Thu, 14 Oct 2010 20:51:00 -0500 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sat, 23 Oct 2010 15:31:20 -0200 perf tools: Document event modifiers Existing documentation doesn't discuss event modifiers, so add a description of what's currently possible to the documentation of ...

Commit-ID: d1e95bb5309f98368dd4fbef6ff3a8f573b24506 Gitweb: http://git.kernel.org/tip/d1e95bb5309f98368dd4fbef6ff3a8f573b24506 Author: Ben Hutchings <ben@decadent.org.uk> AuthorDate: Sun, 10 Oct 2010 16:11:02 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sat, 23 Oct 2010 15:31:20 -0200 perf trace: Fix detection of script extension The extension starts with the last dot in the name, not the first. Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras ...

Right, a look at the docmentation and another layer of indirection for a reader. And it's not exactly "properly" documented. It doesn't say if it may turn into a sleeping lock or is allowed to be used from irq or bh You do not want to add a bloated mutex to each inode hash bucket and think you can just dust off your hands and walk away. You would probably make a smaller auxiliary hash of locks, sanely sized, and protect it with that. So it would be wrong to just bloat hlist_bl by a ...

FWIW neither is a real name and I have troubles understanding why a contributor would want to play tricks like this, but there you go... There are legal reasons we want to keep accurate records of contributions to the Linux kernel for -- this is free software and we want to do our best so as to keep its legal status clear. This is explained in greater detail in Documentation/SubmittingPatches. Please do keep this in mind. Maciej --

Hi Frederic, Sorry I'm not quite sure how I missed your reply - I've only just noticed it: I was checking with 2.6.36-rc4. I have just checked again with a recent tip:/perf/core (66a301c380d4e463424db572b348de4913ec191a) and the problem can still be reliably triggered. I've narrowed the steps to cause the problem too. Running perf record -a -f -g "sleep 5s" and then doing echo 0 > /sys/class/backlight/eeepc/brightness will reliably trigger the problem (on this EeePC 900 the ...

On Fri, 22 Oct 2010 19:05:32 +0200 Now I have tried a kernel config with almost everything disabled - please find below. If I have overlooked anything I should disable (or if you suggest I should not disable, but enable any option) - please tell me. I've created an ~2.5MB bootable ISO image based on buildroot/busybox with this kernel, which also shows this bug (e.g. when run in VirtualBox). If anybody is interested I could send this image as mail attachment or provide a download ...

I still observe this behavior on 2.6.36-rc8. This is starting to get frustrating, so I will be happily following akpm's advise to poke people. Thread entrypoint: http://lkml.org/lkml/2010/2/12/41 Previously, many concurrent extractions of tarballs and so on have been one way to trigger the issue; I now also have a rather small testcase (below) that freezes the box here (which has 24G RAM, so even if I'm lacking to call msync, I should be fine) sometime after memset ...