Home » Mailing list archives » linux-kernel » 2010 » October » 24

Re: [PATCH 16/21] fs: Protect inode->i_state with the inode->i_lock

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig
Subject: Re: [PATCH 16/21] fs: Protect inode->i_state with the inode->i_lock
Date: Sunday, October 24, 2010 - 1:04 pm

On Sun, Oct 24, 2010 at 08:17:35PM +0100, Al Viro wrote:

And having it fail is a good thing.  XIP mode means different file and
address_space operations, which we don't even try to deal with right
now.  Not allowing transitions from/to it is the right thing.


I don't think it should mess with fsnotify.  fsnotify_unmount_inodes
assumes it's only called on umount right now, and sends umount
notifications to userspace (see my mail from a few days ago).  So if
you split invalidate_inodes it really should only go into the umount
one.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Inode Lock Scalability V6, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 03/21] fs: Convert nr_inodes and nr_unused to per-c ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 04/21] fs: Implement lazy LRU updates for inodes, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 05/21] fs: inode split IO and LRU lists, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 06/21] fs: Clean up inode reference counting, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 07/21] exofs: use iput() for inode reference count ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 08/21] fs: rework icount to be a locked variable, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 10/21] fs: Stop abusing find_inode_fast in iunique, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 11/21] fs: move i_ref increments into find_inode/fi ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 12/21] fs: remove inode_add_to_list/__inode_add_to_list, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 13/21] fs: Introduce per-bucket inode hash locks, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 14/21] fs: add a per-superblock lock for the inode list, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 15/21] fs: split locking of inode writeback and LRU ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 16/21] fs: Protect inode->i_state with the inode->i ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 17/21] fs: protect wake_up_inode with inode->i_lock, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 18/21] fs: introduce a per-cpu last_ino allocator, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 19/21] fs: icache remove inode_lock, Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 20/21] fs: Reduce inode I_FREEING and factor inode ..., Dave Chinner, (Wed Oct 20, 5:49 pm)
[PATCH 21/21] fs: do not assign default i_ino in new_inode, Dave Chinner, (Wed Oct 20, 5:49 pm)
Re: [PATCH 06/21] fs: Clean up inode reference counting, Christoph Hellwig, (Wed Oct 20, 6:41 pm)
Re: [PATCH 17/21] fs: protect wake_up_inode with inode->i_lock, Christoph Hellwig, (Wed Oct 20, 7:17 pm)
Re: Inode Lock Scalability V7 (was V6), Dave Chinner, (Wed Oct 20, 10:04 pm)
Re: [PATCH 04/21] fs: Implement lazy LRU updates for inodes, Nick Piggin, (Thu Oct 21, 3:07 am)
Re: [PATCH 04/21] fs: Implement lazy LRU updates for inodes, Christoph Hellwig, (Thu Oct 21, 5:22 am)
Re: [PATCH 17/21] fs: protect wake_up_inode with inode->i_lock, Nick Piggin, (Thu Oct 21, 6:16 am)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 6:20 am)
Re: [PATCH 08/21] fs: rework icount to be a locked variable, Al Viro, (Thu Oct 21, 12:40 pm)
Re: [PATCH 08/21] fs: rework icount to be a locked variable, Dave Chinner, (Thu Oct 21, 3:32 pm)
Re: Inode Lock Scalability V7 (was V6), Dave Chinner, (Thu Oct 21, 4:52 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 5:45 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Al Viro, (Thu Oct 21, 6:56 pm)
Re: Inode Lock Scalability V7 (was V6), Al Viro, (Thu Oct 21, 7:20 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Nick Piggin, (Thu Oct 21, 7:26 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 7:41 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 7:48 pm)
Re: Inode Lock Scalability V7 (was V6), Al Viro, (Thu Oct 21, 8:07 pm)
Re: Inode Lock Scalability V7 (was V6), Al Viro, (Thu Oct 21, 8:12 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Dave Chinner, (Thu Oct 21, 8:14 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 9:46 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 9:48 pm)
Re: Inode Lock Scalability V7 (was V6), Nick Piggin, (Thu Oct 21, 10:01 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Al Viro, (Fri Oct 22, 3:37 am)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Christoph Hellwig, (Fri Oct 22, 4:40 am)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Al Viro, (Sat Oct 23, 2:37 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Nick Piggin, (Sat Oct 23, 7:18 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Christoph Hellwig, (Sun Oct 24, 7:13 am)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Christoph Hellwig, (Sun Oct 24, 9:21 am)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Al Viro, (Sun Oct 24, 12:17 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Christoph Hellwig, (Sun Oct 24, 1:04 pm)
Re: [PATCH 16/21] fs: Protect inode->i_state with the inod ..., Al Viro, (Sun Oct 24, 1:36 pm)