[PATCH 1/2] block: cciss: fix information leak to userland

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Vasiliy Kulikov
Date: Saturday, October 23, 2010 - 1:25 am

Structure IOCTL_Command_struct is copied to userland with some
padding fields at the end of the struct unitialized.
It leads to leaking of stack memory.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
---
 drivers/block/cciss.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 762a81a..cd08324 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1142,6 +1142,7 @@ static int cciss_ioctl32_passthru(struct block_device *bdev, fmode_t mode,
 	int err;
 	u32 cp;
 
+	memset(&arg64, 0, sizeof(arg64));
 	err = 0;
 	err |=
 	    copy_from_user(&arg64.LUN_info, &arg32->LUN_info,
-- 
1.7.0.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] block: cciss: fix information leak to userland, Vasiliy Kulikov, (Sat Oct 23, 1:25 am)
RE: [PATCH 1/2] block: cciss: fix information leak to userland, Miller, Mike (OS Dev), (Mon Oct 25, 7:40 am)
RE: [PATCH 1/2] block: cciss: fix information leak to userland, Miller, Mike (OS Dev), (Mon Oct 25, 9:36 am)