Re: [PATCH v2] POWER: Add gpio charger driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Anton Vorontsov
Date: Thursday, October 21, 2010 - 9:26 am

On Thu, Oct 21, 2010 at 05:55:01PM +0200, Lars-Peter Clausen wrote:

Hm. I'm getting older, it seems. Now can anybody remind me why
pda_power.c doesn't work here? ;-)

This driver looks like a light-weigh version of pda_power, except
that it can do GPIOs directly (instead of is_*_online() callbacks).

Can we instead improve pda_power? Like this:

	if (!pdata->is_ac_online && pdata->ac_monitor_gpio)
		pdata->is_ac_online = pda_ac_monitor_gpio;

Should look quite cool, I think.

(Plus, we might get rid of ac/usb stuff in that driver, and 
pass enum power_supply_type to the callbacks instead).

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH v2] power: bq24617: Adding initial charger support, Lars-Peter Clausen, (Thu Oct 21, 5:20 am)
[PATCH] POWER: Add gpio chager driver, Lars-Peter Clausen, (Thu Oct 21, 5:25 am)
Re: [PATCH] POWER: Add gpio chager driver, Piotr Hosowicz, (Thu Oct 21, 5:43 am)
Re: [PATCH] POWER: Add gpio chager driver, Anton Vorontsov, (Thu Oct 21, 7:14 am)
Re: [PATCH] POWER: Add gpio chager driver, Lars-Peter Clausen, (Thu Oct 21, 7:52 am)
Re: [PATCH] POWER: Add gpio chager driver, Lars-Peter Clausen, (Thu Oct 21, 7:53 am)
Re: [PATCH] POWER: Add gpio chager driver, Anton Vorontsov, (Thu Oct 21, 8:05 am)
[PATCH v2] POWER: Add gpio charger driver, Lars-Peter Clausen, (Thu Oct 21, 8:55 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Mark Brown, (Thu Oct 21, 9:00 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Lars-Peter Clausen, (Thu Oct 21, 9:16 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Mark Brown, (Thu Oct 21, 9:19 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Anton Vorontsov, (Thu Oct 21, 9:26 am)
RE: [PATCH] POWER: Add gpio chager driver, Rhyland Klein, (Thu Oct 21, 10:22 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Lars-Peter Clausen, (Thu Oct 21, 10:47 am)
RE: [PATCH v2] POWER: Add gpio charger driver, Rhyland Klein, (Fri Oct 22, 2:41 pm)
RE: [PATCH v2] POWER: Add gpio charger driver, Rhyland Klein, (Thu Oct 28, 2:17 pm)
Re: [PATCH v2] POWER: Add gpio charger driver, Anton Vorontsov, (Thu Nov 4, 10:47 am)
RE: [PATCH v2] POWER: Add gpio charger driver, Rhyland Klein, (Wed Nov 10, 5:53 pm)
Re: [PATCH v2] POWER: Add gpio charger driver, Lars-Peter Clausen, (Wed Nov 10, 6:33 pm)
RE: [PATCH v2] POWER: Add gpio charger driver, Rhyland Klein, (Wed Nov 10, 6:46 pm)
RE: [PATCH v2] POWER: Add gpio charger driver, Rhyland Klein, (Tue Nov 16, 6:37 pm)
Re: [PATCH v2] POWER: Add gpio charger driver, Anton Vorontsov, (Thu Nov 18, 7:05 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Lars-Peter Clausen, (Thu Nov 18, 7:30 am)
Re: [PATCH v2] POWER: Add gpio charger driver, Anton Vorontsov, (Thu Nov 18, 7:42 am)