Re: mmotm 2010-10-20-15-01 uploaded

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Konrad Rzeszutek Wilk
Date: Thursday, October 21, 2010 - 7:28 am

> >>> Got this:

I got this patch queued up. You mentioned that commenting it out did fix
the problem, so I stuck a Tested-by tag from you on it.

From 5bba6c56dc99ff88f79a79572e29ecf445710878 Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Thu, 21 Oct 2010 09:36:07 -0400
Subject: [PATCH 27/27] X86/PCI: Remove the dependency on isapnp_disable.

This looks to be vestigial dependency that had never been used even
in the original code base (2.6.18) from which this driver
was up-ported. Without this fix, with the CONFIG_ISAPNP, we get this
compile failure:

arch/x86/pci/xen.c: In function 'pci_xen_init':
arch/x86/pci/xen.c:138: error: 'isapnp_disable' undeclared (first use in this function)
arch/x86/pci/xen.c:138: error: (Each undeclared identifier is reported only once
arch/x86/pci/xen.c:138: error: for each function it appears in.)

Reported-by: Li Zefan <lizf@cn.fujitsu.com>
Tested-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/pci/xen.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c
index b19c873..4e37106 100644
--- a/arch/x86/pci/xen.c
+++ b/arch/x86/pci/xen.c
@@ -133,11 +133,6 @@ int __init pci_xen_init(void)
 	acpi_noirq = 1;
 #endif
 
-#ifdef CONFIG_ISAPNP
-	/* Stop isapnp from probing */
-	isapnp_disable = 1;
-#endif
-
 #ifdef CONFIG_PCI_MSI
 	x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
 	x86_msi.teardown_msi_irq = xen_teardown_msi_irq;
-- 
1.7.1

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
mmotm 2010-10-20-15-01 uploaded, akpm, (Wed Oct 20, 3:01 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Li Zefan, (Wed Oct 20, 7:54 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Li Zefan, (Wed Oct 20, 8:15 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Konrad Rzeszutek Wilk, (Wed Oct 20, 8:38 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Li Zefan, (Wed Oct 20, 8:44 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Andrew Morton, (Wed Oct 20, 8:46 pm)
Re: mmotm 2010-10-20-15-01 uploaded, Peter Zijlstra, (Thu Oct 21, 12:17 am)
Re: mmotm 2010-10-20-15-01 uploaded, Andrew Morton, (Thu Oct 21, 12:30 am)
HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Jiri Slaby, (Thu Oct 21, 12:41 am)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Takashi Iwai, (Thu Oct 21, 12:49 am)
Re: mmotm 2010-10-20-15-01 uploaded, Peter Zijlstra, (Thu Oct 21, 2:52 am)
Re: mmotm 2010-10-20-15-01 uploaded, Peter Zijlstra, (Thu Oct 21, 2:54 am)
Re: mmotm 2010-10-20-15-01 uploaded, Zimny Lech, (Thu Oct 21, 4:10 am)
mmotm 2010-10-20 - netfilter Kconfig whinge, Valdis.Kletnieks, (Thu Oct 21, 4:14 am)
Re: mmotm 2010-10-20-15-01 uploaded, Konrad Rzeszutek Wilk, (Thu Oct 21, 7:28 am)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Valdis.Kletnieks, (Thu Oct 21, 8:22 am)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Takashi Iwai, (Thu Oct 21, 12:20 pm)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Takashi Iwai, (Thu Oct 21, 12:22 pm)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Takashi Iwai, (Thu Oct 21, 12:40 pm)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Valdis.Kletnieks, (Thu Oct 21, 1:29 pm)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Valdis.Kletnieks, (Thu Oct 21, 2:24 pm)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Colin Guthrie, (Fri Oct 22, 1:46 am)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Colin Guthrie, (Fri Oct 22, 2:41 am)
Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded], Mauro Carvalho Chehab, (Fri Oct 22, 6:56 am)
Re: HDA: no sound [was: mmotm 2010-10-20-15-01 uploaded], Colin Guthrie, (Fri Oct 22, 12:53 pm)
Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded], Mauro Carvalho Chehab, (Wed Oct 27, 9:12 am)
Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded], Mauro Carvalho Chehab, (Wed Oct 27, 10:05 am)
Re: DVB: af9015 defunct [was: mmotm 2010-10-20-15-01 uploaded], Mauro Carvalho Chehab, (Wed Oct 27, 10:11 am)
Re: mmotm 2010-10-20 - netfilter Kconfig whinge, Patrick McHardy, (Fri Oct 29, 12:11 pm)