Home » Mailing list archives » linux-kernel » 2010 » October » 20

Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Guenter Roeck
Subject: Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;
Date: Wednesday, October 20, 2010 - 11:03 am

On Wed, Oct 20, 2010 at 12:46:40PM -0400, Jean Delvare wrote:

I don't really understand the resistance to add the module name to the default
pr_fmt in kernel.h, and I really don't like the idea to spread pr_fmt defines
throughout the code instead.

Maybe I am missing something, but to me the result of this cleanup is less clean 
code than before.

What is your take ?

Guenter
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 4:13 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Oct 19, 8:29 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 8:34 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Oct 19, 8:53 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 9:07 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Henrik Rydberg, (Tue Oct 19, 11:04 pm)
[PATCH 00/32] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 01/32] drivers/hwmon/abituguru.c: Use pr_fmt and pr ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 02/32] drivers/hwmon/abituguru3.c: Use pr_fmt and p ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 03/32] drivers/hwmon/adt7470.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 04/32] drivers/hwmon/applesmc.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 05/32] drivers/hwmon/asb100.c: Use pr_fmt and pr_&lt;l ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 07/32] drivers/hwmon/coretemp.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 08/32] drivers/hwmon/dme1737.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 09/32] drivers/hwmon/f71805f.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 10/32] drivers/hwmon/f71882fg.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 11/32] drivers/hwmon/hp_accel.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 12/32] drivers/hwmon/hwmon-vid.c: Use pr_fmt and pr ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 13/32] drivers/hwmon/hwmon.c: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 14/32] drivers/hwmon/ibmaem.c: Use pr_fmt and pr_&lt;l ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 15/32] drivers/hwmon/it87.c: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 16/32] drivers/hwmon/lis3lv02d.c: Use pr_fmt and pr ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 17/32] drivers/hwmon/lm70.c: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 18/32] drivers/hwmon/lm78.c: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 19/32] drivers/hwmon/pc87360.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 20/32] drivers/hwmon/pc87427.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 21/32] drivers/hwmon/pcf8591.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 22/32] drivers/hwmon/pkgtemp.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 23/32] drivers/hwmon/sis5595.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 24/32] drivers/hwmon/smsc47b397.c: Use pr_fmt and p ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 25/32] drivers/hwmon/smsc47m1.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 26/32] drivers/hwmon/via-cputemp.c: Use pr_fmt and ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 27/32] drivers/hwmon/via686a.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 28/32] drivers/hwmon/vt1211.c: Use pr_fmt and pr_&lt;l ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 29/32] drivers/hwmon/vt8231.c: Use pr_fmt and pr_&lt;l ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 30/32] drivers/hwmon/w83627ehf.c: Use pr_fmt and pr ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 31/32] drivers/hwmon/w83627hf.c: Use pr_fmt and pr_ ..., Joe Perches, (Tue Oct 19, 11:51 pm)
[PATCH 32/32] drivers/hwmon/w83781d.c: Use pr_fmt and pr_&lt; ..., Joe Perches, (Tue Oct 19, 11:51 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 12:34 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 12:42 am)
Re: [PATCH 04/32] drivers/hwmon/applesmc.c: Use pr_fmt and ..., Henrik Rydberg, (Wed Oct 20, 2:54 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 7:46 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 8:59 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 9:08 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 9:27 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 9:38 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 9:42 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 9:43 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 9:45 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 9:46 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 9:49 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 9:54 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 10:18 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 10:28 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 10:48 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 11:02 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>, Guenter Roeck, (Wed Oct 20, 11:03 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Wed Oct 20, 11:35 am)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 12:08 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Davidlohr Bueso, (Wed Oct 20, 12:19 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 12:38 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 12:52 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 12:57 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Joe Perches, (Wed Oct 20, 12:59 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jean Delvare, (Wed Oct 20, 1:13 pm)
Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_&lt;level&gt;, Jim Cromie, (Wed Oct 20, 1:36 pm)
Re: [PATCH 15/32] drivers/hwmon/it87.c: Use pr_fmt and pr_ ..., Jean Delvare, (Tue Nov 9, 2:21 am)
Re: [PATCH 18/32] drivers/hwmon/lm78.c: Use pr_fmt and pr_ ..., Jean Delvare, (Tue Nov 9, 2:25 am)
Re: [PATCH 19/32] drivers/hwmon/pc87360.c: Use pr_fmt and ..., Jean Delvare, (Tue Nov 9, 2:31 am)
Re: [PATCH 20/32] drivers/hwmon/pc87427.c: Use pr_fmt and ..., Jean Delvare, (Tue Nov 9, 2:35 am)
Re: [PATCH 32/32] drivers/hwmon/w83781d.c: Use pr_fmt and ..., Jean Delvare, (Tue Nov 9, 2:39 am)
Re: [PATCH 19/32] drivers/hwmon/pc87360.c: Use pr_fmt and ..., Joe Perches, (Tue Nov 9, 2:59 am)
Re: [PATCH 32/32] drivers/hwmon/w83781d.c: Use pr_fmt and ..., Joe Perches, (Tue Nov 9, 3:04 am)
Re: [PATCH 19/32] drivers/hwmon/pc87360.c: Use pr_fmt and ..., Jean Delvare, (Tue Nov 9, 5:08 am)
Re: [01/32] drivers/hwmon/abituguru.c: Use pr_fmt and pr_&lt; ..., Guenter Roeck, (Tue Nov 9, 9:25 am)
Re: [02/32] drivers/hwmon/abituguru3.c: Use pr_fmt and pr_ ..., Guenter Roeck, (Tue Nov 9, 9:28 am)
Re: [03/32] drivers/hwmon/adt7470.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:29 am)
Re: [04/32] drivers/hwmon/applesmc.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 9:35 am)
Re: [05/32] drivers/hwmon/asb100.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:35 am)
Re: [06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and p ..., Guenter Roeck, (Tue Nov 9, 9:37 am)
Re: [07/32] drivers/hwmon/coretemp.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 9:38 am)
Re: [08/32] drivers/hwmon/dme1737.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:39 am)
Re: [09/32] drivers/hwmon/f71805f.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:40 am)
Re: [10/32] drivers/hwmon/f71882fg.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 9:41 am)
Re: [11/32] drivers/hwmon/hp_accel.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 9:42 am)
Re: [12/32] drivers/hwmon/hwmon-vid.c: Use pr_fmt and pr_&lt; ..., Guenter Roeck, (Tue Nov 9, 9:43 am)
Re: [13/32] drivers/hwmon/hwmon.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:44 am)
Re: [14/32] drivers/hwmon/ibmaem.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:44 am)
Re: [16/32] drivers/hwmon/lis3lv02d.c: Use pr_fmt and pr_&lt; ..., Guenter Roeck, (Tue Nov 9, 9:46 am)
Re: [17/32] drivers/hwmon/lm70.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:47 am)
Re: [21/32] drivers/hwmon/pcf8591.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:49 am)
Re: [22/32] drivers/hwmon/pkgtemp.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:50 am)
Re: [23/32] drivers/hwmon/sis5595.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:51 am)
Re: [24/32] drivers/hwmon/smsc47b397.c: Use pr_fmt and pr_ ..., Guenter Roeck, (Tue Nov 9, 9:51 am)
Re: [25/32] drivers/hwmon/smsc47m1.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 9:52 am)
Re: [26/32] drivers/hwmon/via-cputemp.c: Use pr_fmt and pr ..., Guenter Roeck, (Tue Nov 9, 9:53 am)
Re: [27/32] drivers/hwmon/via686a.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:54 am)
Re: [28/32] drivers/hwmon/vt1211.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:57 am)
Re: [29/32] drivers/hwmon/vt8231.c: Use pr_fmt and pr_&lt;level&gt;, Guenter Roeck, (Tue Nov 9, 9:58 am)
Re: [30/32] drivers/hwmon/w83627ehf.c: Use pr_fmt and pr_&lt; ..., Guenter Roeck, (Tue Nov 9, 9:59 am)
Re: [31/32] drivers/hwmon/w83627hf.c: Use pr_fmt and pr_&lt;l ..., Guenter Roeck, (Tue Nov 9, 10:00 am)
Re: [06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and p ..., Luca Tettamanti, (Tue Nov 9, 1:15 pm)
Re: [06/32] drivers/hwmon/asus_atk0110.c: Use pr_fmt and p ..., Guenter Roeck, (Tue Nov 9, 1:34 pm)