Home » Mailing list archives » linux-kernel » 2010 » October » 20

Re: [PATCH 4/6] IMA: only allocate iint when needed

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Al Viro
Subject: Re: [PATCH 4/6] IMA: only allocate iint when needed
Date: Tuesday, October 19, 2010 - 8:53 pm

On Tue, Oct 19, 2010 at 06:58:33PM -0400, Eric Paris wrote:

OK, I'm really confused.  Could you explain what's going on with refcounts
now?  AFAICS, you allocate them in process_measurement() now and they live
until the inode is torn down.  Fine by me.  However
	* why bother with bumping refcount in ima_file_free()?  It's not going
to die until we free the inode, for fsck sake...
	* i_mutex is a damn strange choice for protecting your write counter
	* for that matter, why bother with refcount at all?  What could
hold a reference to that sucker without holding a reference to struct inode?
I don't see anything of that sort, other that delayed freeing that'll hold
the only remaining pointer to iint until the callback where it'll promptly
drop it.

And while we are at it, you are forcing a hash lookup on _every_ _damn_
close(2) of a regular file.  How about marking the inode as ima-infested
so that it wouldn't bother?  For that matter, this "final writer" logics
needs explanation as well...
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/6] IMA: move read/write counters into struct inode, Eric Paris, (Tue Oct 19, 3:58 pm)
[PATCH 2/6] IMA: drop the inode opencount since it isn't n ..., Eric Paris, (Tue Oct 19, 3:58 pm)
[PATCH 3/6] IMA: use unsigned int instead of long for counters, Eric Paris, (Tue Oct 19, 3:58 pm)
[PATCH 4/6] IMA: only allocate iint when needed, Eric Paris, (Tue Oct 19, 3:58 pm)
[PATCH 5/6] IMA: use rbtree instead of radix tree for inod ..., Eric Paris, (Tue Oct 19, 3:58 pm)
[PATCH 6/6] IMA: use i_writecount rather than a private co ..., Eric Paris, (Tue Oct 19, 3:58 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Dave Chinner, (Tue Oct 19, 4:17 pm)
Re: [PATCH 1/6] IMA: move read/write counters into struct ..., Linus Torvalds, (Tue Oct 19, 5:25 pm)
Re: [PATCH 4/6] IMA: only allocate iint when needed, Al Viro, (Tue Oct 19, 8:53 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Peter Zijlstra, (Wed Oct 20, 4:31 am)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Dave Chinner, (Wed Oct 20, 3:05 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Linus Torvalds, (Wed Oct 20, 3:22 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Trond Myklebust, (Wed Oct 20, 3:47 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Linus Torvalds, (Wed Oct 20, 5:58 pm)
Re: [PATCH 5/6] IMA: use rbtree instead of radix tree for ..., Dave Chinner, (Wed Oct 20, 7:17 pm)
Re: [PATCH 1/6] IMA: move read/write counters into struct ..., Eric Paris, (Fri Oct 22, 8:01 pm)
Re: [PATCH 1/6] IMA: move read/write counters into struct ..., Mimi Zohar, (Sat Oct 23, 11:52 pm)