Home » Mailing list archives » linux-kernel » 2010 » October » 19

Re: [PATCH 1/3] IMA: move read/write counters into struct inode

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Matthew Wilcox
Subject: Re: [PATCH 1/3] IMA: move read/write counters into struct inode
Date: Tuesday, October 19, 2010 - 12:11 pm

On Tue, Oct 19, 2010 at 06:28:05PM +0100, Al Viro wrote:

Hm.  Sounds like the same question that the file leases code needs
answered.  The important difference is that the leases code can just
refuse to set a lease on inodes with multiple dentries.

While my mind's on it ... Al, is this code even close to correct?

                if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0))
                        goto out;
                if ((arg == F_WRLCK)
                    && ((atomic_read(&dentry->d_count) > 1)
                        || (atomic_read(&inode->i_count) > 1)))
                        goto out;

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Eric Paris, (Tue Oct 19, 9:36 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Al Viro, (Tue Oct 19, 9:55 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Linus Torvalds, (Tue Oct 19, 10:03 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Al Viro, (Tue Oct 19, 10:28 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Mimi Zohar, (Tue Oct 19, 11:16 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Matthew Wilcox, (Tue Oct 19, 12:11 pm)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Eric Paris, (Tue Oct 19, 3:49 pm)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Al Viro, (Tue Oct 19, 8:15 pm)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., John Stoffel, (Wed Oct 20, 6:10 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Al Viro, (Wed Oct 20, 6:36 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Ingo Molnar, (Wed Oct 20, 7:38 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Eric Paris, (Wed Oct 20, 7:46 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Ingo Molnar, (Wed Oct 20, 8:15 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Eric Paris, (Wed Oct 20, 8:25 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., J. Bruce Fields, (Wed Oct 20, 10:38 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Casey Schaufler, (Thu Oct 21, 9:15 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Ingo Molnar, (Fri Oct 22, 1:48 am)
Re: [PATCH 1/3] IMA: move read/write counters into struct ..., Casey Schaufler, (Fri Oct 22, 10:50 am)