After merging the irqflags tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
fs/cifs/sess.c: In function 'CIFS_SessSetup':
fs/cifs/sess.c:595: warning: unused variable 'blob_len'
Introduced by commit 15f6bdfb9914b0c41848f874719911ba053be931 ("cifs
NTLMv2/NTLMSSP ntlmv2 within ntlmssp autentication code").
CONFIG_CIFS_UPCALL is not set in this build.
Stephen Rothwell email@example.com://www.canb.auug.org.au/~sfr/
On Tue, 19 Oct 2010 16:21:20 +1100
Yep. Looks clearly broken. blob_len is also declared twice in that
function which is just plain wrong. What probably makes the most sense
is to make it a u16 and get rid of the second declaration lower in the
function. But, there's another semi-related problem here too...
blob_len gets assigned the return value of build_ntlmssp_auth_blob.
That function however doesn't have any mechanism to pass back an
error, even though it calls setup_ntlmv2_rsp and that function can
The whole house of cards needs a bit of rework I think...
Shirish, since you're already doing work in this area, can you fix that
Jeff Layton <firstname.lastname@example.org>