login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
October
»
19
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation error with -fstack-protector and -Werror
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Arnaldo Carvalho de Melo
Subject:
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation error with -fstack-protector and -Werror
Date: Tuesday, October 19, 2010 - 6:11 am
Em Tue, Oct 19, 2010 at 01:49:04PM +0200, Ingo Molnar escreveu:
quoted text
> > * Brian Gitonga Marete <marete@toshnix.com> wrote: > > > > OK. Now that I actually look closely at that fragment I can see its useless to > > > create the automatic arrays. Local string literals would also work (i.e. just > > > pass `"Yes"' and `"No"' to newtWinChoice). But can also do what you suggested if > > > it is anticipated that they will be used somewhere else within the file at some > > > other time -- Currently they are not. > > > > Oops. Sorry. What I suggested won't work because of the -Wwrite-strings default > > option. Which actually makes me understand why the original author of the code > > made it the way it is. Your suggestion of file-scope, static does solve the > > problem. > > Btw., -Wwrite-strings has proven to be a really useful warning in practice, in that > it ensured that we propagate string immutability/const-ness as widely as possible. > This resulted is cleaner perf code in the long run. > > Here we cannot fix the Newt prototype (it's an existing library outside of our > control) to take a const so we have to do the (mild) workaround of moving it to file > scope. (if this becomes common then we'd have to re-evaluate the use of this > warning) > > I think Arnaldo has plans to get rid of the libnewt dependency altogether - that > might be a fix too.
Yeah, but for now I'll just reap the results of this long discussion about this issue. :) - Arnaldo --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] [PERF] (Userspace Tools) Fix a compilation error w ...
, Brian Gitonga Marete
, (Mon Oct 18, 4:24 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Frederic Weisbecker
, (Mon Oct 18, 4:38 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Brian Gitonga Marete
, (Mon Oct 18, 5:06 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Frederic Weisbecker
, (Mon Oct 18, 5:20 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Ingo Molnar
, (Mon Oct 18, 11:40 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Américo Wang
, (Tue Oct 19, 2:03 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Brian Gitonga Marete
, (Tue Oct 19, 4:12 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Brian Gitonga Marete
, (Tue Oct 19, 4:33 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Brian Gitonga Marete
, (Tue Oct 19, 4:37 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Ingo Molnar
, (Tue Oct 19, 4:49 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Arnaldo Carvalho de Melo
, (Tue Oct 19, 6:11 am)
[PATCH] Fix a compile error with -fstack-protector, -Wstac ...
, Brian Gitonga Marete
, (Sun Oct 24, 2:23 pm)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Eric Dumazet
, (Thu Nov 11, 3:25 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Arnaldo Carvalho de Melo
, (Thu Nov 11, 10:05 am)
Re: [PATCH] [PERF] (Userspace Tools) Fix a compilation err ...
, Eric Dumazet
, (Thu Nov 11, 10:13 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Mel Gorman
Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck
Re: [lm-sensors] Location for thermal drivers
David Woodhouse
Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B
Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra
Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head
:
Linux Kernel Mailing List
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List
USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List
lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List
[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List
[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev
:
MERCEDES
Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller
Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller
Re: skb_segment() questions
Shan Wei
[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git
:
Nicolas Sebrecht
git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano
Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff
Re: [PATCH] GIT commit statistics.
Alexandre Julliard
[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett
[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc
:
Taisto Qvist XX
Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer
Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier
Re: jetway board sensors (Fintek F71805F)
admin
Drive a 2009 car from R799p/m
Antti Harri
Re: how to create a sha256 hash
Colocation donated by:
Syndicate