--- On Mon, 18/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:

quoted text
> 
> But for mspro driver, it would be really hard for me to
> split it.
> I have rewritten a lot of code there.
> Can't we just review the end result instead of the patch?
> 
> To split the patches, I pretty much need to rewrite the
> whole thing once
> gain.
> I don't want to do that.
> 

First, a useful citation (Documentation/HOWTO:548):
"The Linux kernel community does not gladly accept large chunks of code
dropped on it all at once.  The changes need to be properly introduced,
discussed, and broken up into tiny, individual portions."

I actually attempted to submit a large "full rewrite" patch early on
during development of one of my drivers. I was a sole developer and it was
not even on a stable tree, as far as I can remember. Yet, that patch was
dropped immediately with the above given reason.

And yes, I had to rewrite the whole thing again, this time in small steps.



      
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/