Home » Mailing list archives » linux-kernel » 2010 » October » 19

Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inode disposal

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Nick Piggin
Subject: Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inode disposal
Date: Monday, October 18, 2010 - 8:54 pm

On Mon, Oct 18, 2010 at 02:27:02PM -0700, Sage Weil wrote:

Great, it was a bit nasty of ceph to add that in without documenting
it, but I guess it got past reviewers so it was up to them to ack it
or point it out.

I think we should probably enforce a rule that dcache_lock not nest
inside i_lock :) Anybody wanting to do that in future had better have
a really good reason.

 

It does, thanks.

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Inode Lock Scalability V4, Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 01/19] fs: switch bdev inode bdi's correctly, Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 02/19] kernel: add bl_list, Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 03/19] fs: Convert nr_inodes and nr_unused to per-c ..., Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 04/19] fs: Implement lazy LRU updates for inodes., Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 05/19] fs: inode split IO and LRU lists, Dave Chinner, (Sat Oct 16, 1:13 am)
[PATCH 06/19] fs: Clean up inode reference counting, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 08/19] fs: rework icount to be a locked variable, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 09/19] fs: Factor inode hash operations into functions, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 10/19] fs: Introduce per-bucket inode hash locks, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 11/19] fs: add a per-superblock lock for the inode list, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 13/19] fs: Protect inode->i_state with the inode->i ..., Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 16/19] fs: icache remove inode_lock, Dave Chinner, (Sat Oct 16, 1:14 am)
[PATCH 19/19] fs: do not assign default i_ino in new_inode, Dave Chinner, (Sat Oct 16, 1:14 am)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Eric Dumazet, (Sat Oct 16, 1:29 am)
Re: [PATCH 19/19] fs: do not assign default i_ino in new_inode, Eric Dumazet, (Sat Oct 16, 2:09 am)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Nick Piggin, (Sat Oct 16, 2:29 am)
Re: [PATCH 01/19] fs: switch bdev inode bdi's correctly, Nick Piggin, (Sat Oct 16, 2:30 am)
Re: [PATCH 02/19] kernel: add bl_list, Nick Piggin, (Sat Oct 16, 2:51 am)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Dave Chinner, (Sat Oct 16, 3:04 am)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Eric Dumazet, (Sat Oct 16, 3:27 am)
Re: [PATCH 01/19] fs: switch bdev inode bdi's correctly, Christoph Hellwig, (Sat Oct 16, 9:31 am)
Re: [PATCH 02/19] kernel: add bl_list, Christoph Hellwig, (Sat Oct 16, 9:32 am)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Christoph Hellwig, (Sat Oct 16, 9:59 am)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Peter Zijlstra, (Sat Oct 16, 10:26 am)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Nick Piggin, (Sat Oct 16, 10:29 am)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Nick Piggin, (Sat Oct 16, 10:34 am)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Christoph Hellwig, (Sat Oct 16, 5:47 pm)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Christoph Hellwig, (Sat Oct 16, 5:47 pm)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Dave Chinner, (Sat Oct 16, 6:09 pm)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Christoph Hellwig, (Sat Oct 16, 6:12 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Christoph Hellwig, (Sat Oct 16, 6:30 pm)
Re: [PATCH 04/19] fs: Implement lazy LRU updates for inodes., Dave Chinner, (Sat Oct 16, 6:53 pm)
Re: [PATCH 03/19] fs: Convert nr_inodes and nr_unused to p ..., Dave Chinner, (Sat Oct 16, 7:16 pm)
Re: Inode Lock Scalability V4, Dave Chinner, (Sat Oct 16, 7:47 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Nick Piggin, (Sat Oct 16, 7:49 pm)
Re: Inode Lock Scalability V4, Nick Piggin, (Sat Oct 16, 7:55 pm)
Re: Inode Lock Scalability V4, Nick Piggin, (Sat Oct 16, 7:57 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Dave Chinner, (Sat Oct 16, 9:13 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Nick Piggin, (Sat Oct 16, 10:13 pm)
Re: Inode Lock Scalability V4, Dave Chinner, (Sat Oct 16, 11:10 pm)
Re: Inode Lock Scalability V4, Nick Piggin, (Sat Oct 16, 11:34 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Dave Chinner, (Sat Oct 16, 11:52 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Nick Piggin, (Sun Oct 17, 12:05 am)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Dave Chinner, (Sun Oct 17, 4:39 pm)
Re: [PATCH 19/19] fs: do not assign default i_ino in new_inode, Eric Dumazet, (Mon Oct 18, 2:11 am)
Re: [PATCH 19/19] fs: do not assign default i_ino in new_inode, Christoph Hellwig, (Mon Oct 18, 7:48 am)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Sage Weil, (Mon Oct 18, 2:27 pm)
Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor in ..., Nick Piggin, (Mon Oct 18, 8:54 pm)