login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
October
»
18
Re: [PATCH 8/8] Call tick_check_idle before __irq_enter
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Peter Zijlstra
Subject:
Re: [PATCH 8/8] Call tick_check_idle before __irq_enter
Date: Monday, October 18, 2010 - 2:15 am
On Sun, 2010-10-17 at 17:05 +0800, Yong Zhang wrote:
quoted text
> On Mon, Oct 04, 2010 at 05:03:23PM -0700, Venkatesh Pallipadi wrote: > > diff --git a/kernel/softirq.c b/kernel/softirq.c > > index 267f7b7..6bb7e19 100644 > > --- a/kernel/softirq.c > > +++ b/kernel/softirq.c > > @@ -296,10 +296,16 @@ void irq_enter(void) > > > > rcu_irq_enter(); > > if (idle_cpu(cpu) && !in_interrupt()) { > > - __irq_enter(); > > + /* > > + * Prevent raise_softirq from needlessly waking up ksoftirqd > > + * here, as softirq will be serviced on return from interrupt. > > + */ > > + local_bh_disable(); > > tick_check_idle(cpu); > > - } else > > - __irq_enter(); > > + local_bh_enable(); > > _local_bh_enable() > > local_bh_enable() could invoke do_softirq().
This seems to indeed cure that explosion.. Thanks! --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Proper kernel irq time accounting -v4
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 1/8] si time accounting accounts bh_disable'd time ...
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 2/8] Consolidate account_system_vtime extern declar ...
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 3/8] Add a PF flag for ksoftirqd identification
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 4/8] Add IRQ_TIME_ACCOUNTING, finer accounting of i ...
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 5/8] x86: Add IRQ_TIME_ACCOUNTING in x86 -v4
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 6/8] sched: Do not account irq time to current task -v4
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 7/8] sched: Remove irq time from available CPU powe ...
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
[PATCH 8/8] Call tick_check_idle before __irq_enter
, Venkatesh Pallipadi
, (Mon Oct 4, 5:03 pm)
Re: Proper kernel irq time accounting -v4
, Venkatesh Pallipadi
, (Tue Oct 12, 12:00 pm)
Re: Proper kernel irq time accounting -v4
, Shaun Ruffell
, (Thu Oct 14, 9:12 am)
Re: Proper kernel irq time accounting -v4
, Venkatesh Pallipadi
, (Thu Oct 14, 11:19 am)
Re: Proper kernel irq time accounting -v4
, Shaun Ruffell
, (Thu Oct 14, 1:00 pm)
Re: [PATCH 3/8] Add a PF flag for ksoftirqd identification
, Peter Zijlstra
, (Fri Oct 15, 7:26 am)
Re: [PATCH 4/8] Add IRQ_TIME_ACCOUNTING, finer accounting ...
, Peter Zijlstra
, (Fri Oct 15, 7:28 am)
Re: [PATCH 5/8] x86: Add IRQ_TIME_ACCOUNTING in x86 -v4
, Peter Zijlstra
, (Fri Oct 15, 7:38 am)
Re: [PATCH 3/8] Add a PF flag for ksoftirqd identification
, Eric Dumazet
, (Fri Oct 15, 7:46 am)
Re: Proper kernel irq time accounting -v4
, Peter Zijlstra
, (Fri Oct 15, 8:11 am)
Re: Proper kernel irq time accounting -v4
, Peter Zijlstra
, (Fri Oct 15, 8:27 am)
Re: Proper kernel irq time accounting -v4
, Venkatesh Pallipadi
, (Fri Oct 15, 10:13 am)
Re: Proper kernel irq time accounting -v4
, Peter Zijlstra
, (Fri Oct 15, 10:20 am)
Re: [PATCH 8/8] Call tick_check_idle before __irq_enter
, Yong Zhang
, (Sun Oct 17, 2:05 am)
Re: Proper kernel irq time accounting -v4
, Yong Zhang
, (Sun Oct 17, 2:11 am)
Re: [PATCH 8/8] Call tick_check_idle before __irq_enter
, Peter Zijlstra
, (Mon Oct 18, 2:15 am)
[tip:sched/core] sched: Fix softirq time accounting
, tip-bot for Venkates ...
, (Mon Oct 18, 12:24 pm)
[tip:sched/core] sched: Consolidate account_system_vtime e ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:24 pm)
[tip:sched/core] sched: Add a PF flag for ksoftirqd identi ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:25 pm)
[tip:sched/core] sched: Add IRQ_TIME_ACCOUNTING, finer acc ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:25 pm)
[tip:sched/core] x86: Add IRQ_TIME_ACCOUNTING
, tip-bot for Venkates ...
, (Mon Oct 18, 12:26 pm)
[tip:sched/core] sched: Do not account irq time to current ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:26 pm)
[tip:sched/core] sched: Remove irq time from available CPU ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:26 pm)
[tip:sched/core] sched: Call tick_check_idle before __irq_ ...
, tip-bot for Venkates ...
, (Mon Oct 18, 12:27 pm)
[tip:sched/core] sched: Export account_system_vtime()
, tip-bot for Ingo Molnar
, (Mon Oct 18, 12:27 pm)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Yong Zhang
, (Mon Nov 29, 1:45 am)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Peter Zijlstra
, (Mon Nov 29, 4:59 am)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Yong Zhang
, (Mon Nov 29, 7:22 am)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Raistlin
, (Mon Nov 29, 10:06 am)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Yong Zhang
, (Mon Nov 29, 10:57 pm)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Venkatesh Pallipadi
, (Wed Dec 1, 11:55 am)
Re: [tip:sched/core] sched: Do not account irq time to cur ...
, Peter Zijlstra
, (Wed Dec 1, 12:16 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Boaz Harrosh
how to use KBUILD_EXTRA_SYMBOLS
Brandeburg, Jesse
RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e1000 toe1000e migration ...
Robin Lee Powell
NFS hang + umount -f: better behaviour requested.
David Rientjes
Re: [patch -mm 4/9 v2] oom: remove compulsory panic_on_oom mode
Rik van Riel
Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeab...
git
:
Fredrik Kuivinen
Re: fatal: unable to create '.git/index': File exists
Johannes Sixt
Re: How to pull remote branch with specified commit id?
Linus Torvalds
Re: Handling large files with GIT
Boyd Stephen Smith Jr.
Re: RFC: Flat directory for notes, or fan-out? Both!
Alex Riesen
Re: ! [rejected] master -> master (non-fast forward)
linux-netdev
:
Paulius Zaleckas
Re: [RFC] Patch to option HSO driver to the kernel
Jamie Lokier
Re: POHMELFS high performance network filesystem. Transactions, failover, performa...
Timo Teräs
ip xfrm policy semantics
Ron Mercer
[net-next PATCH 2/2] qlge: Version change to v1.00.00.27
Maciej W. Rozycki
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [PATCH] PHYLIB: IRQ event...
openbsd-misc
:
Sevan / Venture37
Re: This is what Linus Torvalds calls openBSD crowd
Siju George
This is what Linus Torvalds calls openBSD crowd
new_guy
Longest Uptime?
Skylar Hawk
Re: asus eee 1201n - acpitz0 critical temperature 255C (5282K), shutting down
Nick Guenther
Re: Forum engine
git-commits-head
:
Linux Kernel Mailing List
powerpc/fsl_msi: enable msi allocation in all banks
Linux Kernel Mailing List
[ARM] mmp: avengers lite (pxa168) board bring up
Linux Kernel Mailing List
checkpatch: warn on declaration with storage class not at the beginning
Linux Kernel Mailing List
USB: remove duplicate entry in Option driver and Pl2303 driver for Huawei modem
Linux Kernel Mailing List
update JFS entry in MAINTAINERS
Colocation donated by:
Syndicate