Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous page faults delivery.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Gleb Natapov

Subject: Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous page faults delivery.

Date: Sunday, October 10, 2010 - 6:27 am

On Sun, Oct 10, 2010 at 02:47:43PM +0200, Avi Kivity wrote:
quoted text>  On 10/07/2010 07:53 PM, Gleb Natapov wrote:
> >On Thu, Oct 07, 2010 at 02:42:06PM +0200, Avi Kivity wrote:
> >>   On 10/04/2010 05:56 PM, Gleb Natapov wrote:
> >>  >Guest enables async PF vcpu functionality using this MSR.
> >>  >
> >>  >   			return NON_PRESENT;
> >>  >+
> >>  >+MSR_KVM_ASYNC_PF_EN: 0x4b564d02
> >>  >+	data: Bits 63-6 hold 64-byte aligned physical address of a 32bit memory
> >>
> >>  Given that it must be aligned anyway, we can require it to be a
> >>  64-byte region and also require that the guest zero it before
> >>  writing the MSR.  That will give us a little more flexibility in the
> >>  future.
> >>
> >No code change needed, so OK.
> 
> The guest needs to allocate a 64-byte per-cpu entry instead of a
> 4-byte entry.
> 
Yes, noticed that already :(

quoted text> 
> >>  >+
> >>  >+	kvm_async_pf_wakeup_all(vcpu);
> >>
> >>  Why is this needed?  If all apfs are flushed at disable time, what
> >>  do we need to wake up?
> >For migration. Destination will rewrite msr and all processes will be
> >waked up.
> 
> Ok. What happens to apf completions that happen after all vcpus are stopped?
> 
They will be cleaned by kvm_clear_async_pf_completion_queue() on vcpu
destroy.

--
			Gleb.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH v6 00/12] KVM: Add host swap event notifications fo ..., Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 01/12] Add get_user_pages() variant that fails i ..., Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 05/12] Move kvm_smp_prepare_boot_cpu() from kvmc ..., Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 06/12] Add PV MSR to enable asynchronous page fa ..., Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 10/12] Handle async PF in non preemptable context, Gleb Natapov, (Mon Oct 4, 8:56 am)

[PATCH v6 12/12] Send async PF when guest is not in usersp ..., Gleb Natapov, (Mon Oct 4, 8:56 am)

Re: [PATCH v6 12/12] Send async PF when guest is not in us ..., Rik van Riel, (Mon Oct 4, 7:37 pm)

Re: [PATCH v6 10/12] Handle async PF in non preemptable co ..., Marcelo Tosatti, (Tue Oct 5, 12:51 pm)

Re: [PATCH v6 10/12] Handle async PF in non preemptable co ..., Gleb Natapov, (Wed Oct 6, 3:41 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Avi Kivity, (Thu Oct 7, 5:42 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Avi Kivity, (Thu Oct 7, 5:58 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Avi Kivity, (Thu Oct 7, 6:10 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Thu Oct 7, 10:14 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Avi Kivity, (Thu Oct 7, 10:18 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Rik van Riel, (Thu Oct 7, 10:48 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Gleb Natapov, (Thu Oct 7, 10:53 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Gleb Natapov, (Thu Oct 7, 10:59 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Thu Oct 7, 11:03 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Avi Kivity, (Sat Oct 9, 11:43 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Avi Kivity, (Sat Oct 9, 11:48 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Sun Oct 10, 12:56 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Sun Oct 10, 5:32 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Avi Kivity, (Sun Oct 10, 5:38 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Avi Kivity, (Sun Oct 10, 5:40 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Avi Kivity, (Sun Oct 10, 5:47 am)

Re: [PATCH v6 08/12] Handle async PF in a guest., Gleb Natapov, (Sun Oct 10, 6:22 am)

Re: [PATCH v6 06/12] Add PV MSR to enable asynchronous pag ..., Gleb Natapov, (Sun Oct 10, 6:27 am)

Re: [PATCH v6 10/12] Handle async PF in non preemptable co ..., Gleb Natapov, (Sun Oct 10, 7:25 am)


linux-kernel:
Mel Gorman	Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck	Re: [lm-sensors] Location for thermal drivers
David Woodhouse	Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B	Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra	Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head:
Linux Kernel Mailing List	[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List	USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List	lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List	[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List	[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev:
MERCEDES	Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller	Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller	Re: skb_segment() questions
Shan Wei	[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka	[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git:
Nicolas Sebrecht	git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano	Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff	Re: [PATCH] GIT commit statistics.
Alexandre Julliard	[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett	[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc:
Taisto Qvist XX	Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer	Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier	Re: jetway board sensors (Fintek F71805F)
admin	Drive a 2009 car from R799p/m
Antti Harri	Re: how to create a sha256 hash