[tip:tracing/urgent] tracing/filters: Fix MATCH_FRONT_ONLY filter matching

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: tip-bot for Li Zefan
Date: Saturday, January 16, 2010 - 2:43 am

Commit-ID:  285caad415f459f336247932b4db95a571357a02
Gitweb:     http://git.kernel.org/tip/285caad415f459f336247932b4db95a571357a02
Author:     Li Zefan <lizf@cn.fujitsu.com>
AuthorDate: Thu, 14 Jan 2010 10:53:21 +0800
Committer:  Steven Rostedt <rostedt@goodmis.org>
CommitDate: Thu, 14 Jan 2010 22:38:05 -0500

tracing/filters: Fix MATCH_FRONT_ONLY filter matching

MATCH_FRONT_ONLY actually is a full matching:

  # ./perf record -R -f -a -e lock:lock_acquire \
	--filter 'name ~rcu_*' sleep 1
  # ./perf trace
  (no output)

We should pass the length of the pattern string to strncmp().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4B4E8721.5090301@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace_events_filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 50504cb..11c3973 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -261,7 +261,7 @@ static int regex_match_full(char *str, struct regex *r, int len)
 
 static int regex_match_front(char *str, struct regex *r, int len)
 {
-	if (strncmp(str, r->pattern, len) == 0)
+	if (strncmp(str, r->pattern, r->len) == 0)
 		return 1;
 	return 0;
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 4/7] lib: Introduce strnstr(), Li Zefan, (Wed Jan 13, 7:53 pm)
[tip:tracing/urgent] ftrace: Fix MATCH_END_ONLY function f ..., tip-bot for Li Zefan, (Sat Jan 16, 2:42 am)
[tip:tracing/urgent] tracing/filters: Fix MATCH_FRONT_ONLY ..., tip-bot for Li Zefan, (Sat Jan 16, 2:43 am)
[tip:tracing/urgent] tracing/filters: Fix MATCH_END_ONLY f ..., tip-bot for Li Zefan, (Sat Jan 16, 2:43 am)
[tip:tracing/urgent] lib: Introduce strnstr(), tip-bot for Li Zefan, (Sat Jan 16, 2:43 am)
[tip:tracing/urgent] tracing/filters: Fix MATCH_MIDDLE_ONL ..., tip-bot for Li Zefan, (Sat Jan 16, 2:43 am)
[tip:tracing/urgent] tracing/filters: Fix MATCH_FULL filte ..., tip-bot for Li Zefan, (Sat Jan 16, 2:44 am)
[tip:tracing/urgent] tracing/filters: Add comment for matc ..., tip-bot for Li Zefan, (Sat Jan 16, 2:44 am)
Re: [PATCH 4/7] lib: Introduce strnstr(), Alex Riesen, (Sat Jan 16, 4:12 am)
Re: [PATCH 4/7] lib: Introduce strnstr(), Steven Rostedt, (Mon Jan 18, 7:53 am)
Re: [PATCH 4/7] lib: Introduce strnstr(), Alex Riesen, (Mon Jan 18, 8:56 am)