Re: [PATCH 1/2] atmel-mci: change use of dma slave interface

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Haavard Skinnemoen
Date: Wednesday, September 30, 2009 - 6:55 am

Nicolas Ferre <nicolas.ferre@atmel.com> wrote:

We used to have a struct dma_slave in linux/dmaengine.h which took care
of all this, but it got removed at some point.

How about introducing a new mach/atmel-mci.h file with a struct
mci_dma_data encapsulating either a struct dw_dma_slave or a struct
at_dma_slave, as well as any other DMA-related definitions needed by
the atmel-mci driver?

Then we just need to make sure that we either
  1) use the same name on all fields in struct {dw,at}_dma_slave which
     are used by the atmel-mci driver, or
  2) add accessor functions or macros for those fields.

I think I would prefer the latter, but both should work equally well.

Haavard
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/2] atmel-mci: change use of dma slave interface, Nicolas Ferre, (Thu Sep 17, 9:29 am)
Re: [PATCH 1/2] atmel-mci: change use of dma slave interface, Haavard Skinnemoen, (Wed Sep 30, 6:55 am)
Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc dri ..., Haavard Skinnemoen, (Tue Oct 27, 5:35 pm)
Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc dri ..., =?ISO-8859-1?Q?Thiag ..., (Tue Oct 27, 5:53 pm)
Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc dri ..., Haavard Skinnemoen, (Tue Oct 27, 6:31 pm)
Re: [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc dri ..., Haavard Skinnemoen, (Sat Nov 7, 4:20 am)
[PATCH] pio: add arch specific gpio_is_valid() function, Nicolas Ferre, (Mon Aug 23, 8:01 am)
Re: [PATCH] pio: add arch specific gpio_is_valid() function, Jean-Christophe PLAG ..., (Fri Sep 3, 9:41 am)