[PATCH -v2] perf: Don't list tracepoints without an id

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Peter Zijlstra
Date: Thursday, August 6, 2009 - 7:48 am

Stop perf list from displaying tracepoints without an id file.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 tools/perf/util/parse-events.c |   18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Index: linux-2.6/tools/perf/util/parse-events.c
===================================================================
--- linux-2.6.orig/tools/perf/util/parse-events.c
+++ linux-2.6/tools/perf/util/parse-events.c
@@ -121,13 +121,29 @@ static unsigned long hw_cache_stat[C(MAX
 	   (strcmp(sys_dirent.d_name, ".")) &&				       \
 	   (strcmp(sys_dirent.d_name, "..")))
 
+static int tp_event_has_id(struct dirent *sys_dir, struct dirent *evt_dir)
+{
+	char evt_path[MAXPATHLEN];
+	int fd;
+
+	snprintf(evt_path, MAXPATHLEN, "%s/%s/%s/id", debugfs_path,
+			sys_dir->d_name, evt_dir->d_name);
+	fd = open(evt_path, O_RDONLY);
+	if (fd < 0)
+		return -EINVAL;
+	close(fd);
+
+	return 0;
+}
+
 #define for_each_event(sys_dirent, evt_dir, evt_dirent, evt_next, file, st)    \
 	while (!readdir_r(evt_dir, &evt_dirent, &evt_next) && evt_next)        \
 	if (snprintf(file, MAXPATHLEN, "%s/%s/%s", debugfs_path,	       \
 		     sys_dirent.d_name, evt_dirent.d_name) &&		       \
 	   (!stat(file, &st)) && (S_ISDIR(st.st_mode)) &&		       \
 	   (strcmp(evt_dirent.d_name, ".")) &&				       \
-	   (strcmp(evt_dirent.d_name, "..")))
+	   (strcmp(evt_dirent.d_name, "..")) &&				       \
+	   (!tp_event_has_id(&sys_dirent, &evt_dirent)))
 
 #define MAX_EVENT_LENGTH 30
 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ftrace: fix perf-tracepoint OOPS, Peter Zijlstra, (Wed Aug 5, 11:41 am)
[tip:perfcounters/urgent] ftrace: Fix perf-tracepoint OOPS, tip-bot for Peter Zi ..., (Wed Aug 5, 11:48 am)
Re: [PATCH] ftrace: fix perf-tracepoint OOPS, Steven Rostedt, (Wed Aug 5, 11:53 am)
[PATCH] perf: Don't list tracepoints without an id, Peter Zijlstra, (Wed Aug 5, 12:23 pm)
[tip:perfcounters/urgent] ftrace: Fix perf-tracepoint OOPS, tip-bot for Peter Zi ..., (Wed Aug 5, 9:27 pm)
[PATCH -v2] perf: Don't list tracepoints without an id, Peter Zijlstra, (Thu Aug 6, 7:48 am)
[tip:perfcounters/urgent] perf: Don't list tracepoints wit ..., tip-bot for Peter Zi ..., (Fri Aug 7, 4:12 am)