Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch update

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Hendrik Brueckner

Subject: Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch update

Date: Tuesday, August 25, 2009 - 8:38 am

On Tue, Aug 25, 2009 at 03:52:32PM +0200, Frederic Weisbecker wrote:
quoted text> On Tue, Aug 25, 2009 at 02:31:11PM +0200, Hendrik Brueckner wrote:
> > This patch includes s390 arch updates for:
> > - tracing: Map syscall name to number (syscall_name_to_nr())
> > - tracing: Call arch_init_ftrace_syscalls at boot
> > - tracing: add support traceopint ids (set_syscall_{enter,exit}_id())
> > 
> > The patch already uses "NR_syscalls" instead of FTRACE_SYSCALL_MAX.
> > 
> > The patch is based on today's linux-next (20090825).
> > Since few of your patches already include s390 changes,
> > I would appreciate if you could add the patch to your patch set.
> > 
> > If you have any remarks, please let me know. 
> >   
> > Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> 
> 
> Looks good at a first glance.
Thanks

quoted text> > +int syscall_name_to_nr(char *name)
> > +{
> > +	int i;
> > +
> > +	if (!syscalls_metadata)
> > +		return -1;
> > +	for (i = 0; i < NR_syscalls; i++)
> > +		if (syscalls_metadata[i])
> > +			if (!strcmp(syscalls_metadata[i]->name, name))
> > +				return i;
> > +	return -1;
> > +}
> > +void set_syscall_enter_id(int num, int id)
> > +{
> > +	syscalls_metadata[num]->enter_id = id;
> > +}
> > +
> > +void set_syscall_exit_id(int num, int id)
> > +{
> > +	syscalls_metadata[num]->exit_id = id;
> > +}
> 
> The three helpers above seem very common between archs, I guess
> we can move them to the core: kernel/trace/trace_syscalls.c
I think it is a good idea to move the helper routines to
kernel/trace/trace_syscalls.c.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 00/12] add syscall tracepoints V3, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 02/12] call arch_init_ftrace_syscalls at boot, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 03/12] add DECLARE_TRACE_WITH_CALLBACK() macro, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 04/12] add syscall tracepoints, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 05/12] update FTRACE_SYSCALL_MAX, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 06/12] trace_event - raw_init bailout, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 07/12] add ftrace_event_call void * 'data' field, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 08/12] add trace events for each syscall entry/exit, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 09/12] add support traceopint ids, Jason Baron, (Mon Aug 10, 1:52 pm)

[PATCH 10/12] add perf counter support, Jason Baron, (Mon Aug 10, 1:53 pm)

[PATCH 11/12] add more namespace area to 'perf list' output, Jason Baron, (Mon Aug 10, 1:53 pm)

[PATCH 12/12] convert x86_64 mmap and uname to use DEFINE_ ..., Jason Baron, (Mon Aug 10, 1:53 pm)

Re: [PATCH 07/12] add ftrace_event_call void * 'data' field, Frederic Weisbecker, (Tue Aug 11, 3:09 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 11, 3:50 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Frederic Weisbecker, (Tue Aug 11, 4:00 am)

Re: [PATCH 09/12] add support traceopint ids, Frederic Weisbecker, (Tue Aug 11, 4:28 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Ingo Molnar, (Tue Aug 11, 4:45 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 11, 5:01 am)

Re: [PATCH 10/12] add perf counter support, Frederic Weisbecker, (Tue Aug 11, 5:12 am)

Re: [PATCH 10/12] add perf counter support, Ingo Molnar, (Tue Aug 11, 5:17 am)

Re: [PATCH 10/12] add perf counter support, Frederic Weisbecker, (Tue Aug 11, 5:25 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Matt Fleming, (Tue Aug 11, 12:39 pm)

Re: [PATCH 07/12] add ftrace_event_call void * 'data' field, Steven Rostedt, (Mon Aug 17, 3:19 pm)

Re: [PATCH 07/12] add ftrace_event_call void * 'data' field, Frederic Weisbecker, (Mon Aug 17, 4:09 pm)

Re: [PATCH 07/12] add ftrace_event_call void * 'data' field, Steven Rostedt, (Mon Aug 17, 5:06 pm)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Paul Mundt, (Mon Aug 24, 6:41 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Jason Baron, (Mon Aug 24, 7:06 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Paul Mundt, (Mon Aug 24, 7:15 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Frederic Weisbecker, (Mon Aug 24, 7:34 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Paul Mundt, (Mon Aug 24, 7:37 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Jason Baron, (Mon Aug 24, 7:42 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Paul Mundt, (Mon Aug 24, 7:50 am)

Re: [PATCH 05/12] update FTRACE_SYSCALL_MAX, Ingo Molnar, (Mon Aug 24, 11:34 am)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Hendrik Brueckner, (Tue Aug 25, 5:31 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Hendrik Brueckner, (Tue Aug 25, 5:50 am)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Frederic Weisbecker, (Tue Aug 25, 6:52 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 7:15 am)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Heiko Carstens, (Tue Aug 25, 7:39 am)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Hendrik Brueckner, (Tue Aug 25, 8:38 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Hendrik Brueckner, (Tue Aug 25, 9:02 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Tue Aug 25, 9:20 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 9:59 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Jason Baron, (Tue Aug 25, 10:04 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 10:31 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Tue Aug 25, 11:15 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Tue Aug 25, 11:31 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 12:42 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Tue Aug 25, 12:51 pm)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Frederic Weisbecker, (Tue Aug 25, 12:52 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 2:40 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Martin Schwidefsky, (Tue Aug 25, 3:04 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 3:09 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Tue Aug 25, 5:19 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Tue Aug 25, 5:42 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Peter Zijlstra, (Tue Aug 25, 11:21 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Peter Zijlstra, (Tue Aug 25, 11:48 pm)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Peter Zijlstra, (Wed Aug 26, 12:10 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Ingo Molnar, (Wed Aug 26, 12:28 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Heiko Carstens, (Wed Aug 26, 12:38 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Heiko Carstens, (Wed Aug 26, 12:47 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 5:32 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 5:35 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Heiko Carstens, (Wed Aug 26, 5:59 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 6:30 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Steven Rostedt, (Wed Aug 26, 6:48 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 6:53 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Peter Zijlstra, (Wed Aug 26, 6:56 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Heiko Carstens, (Wed Aug 26, 7:10 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 7:27 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Hendrik Brueckner, (Wed Aug 26, 7:41 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Steven Rostedt, (Wed Aug 26, 7:41 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Steven Rostedt, (Wed Aug 26, 7:43 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Steven Rostedt, (Wed Aug 26, 7:44 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Frederic Weisbecker, (Wed Aug 26, 9:14 am)

Re: [PATCH 00/12] add syscall tracepoints V3 - s390 arch u ..., Frederic Weisbecker, (Wed Aug 26, 9:53 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Wed Aug 26, 10:08 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Wed Aug 26, 10:10 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Wed Aug 26, 10:11 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, H. Peter Anvin, (Wed Aug 26, 10:24 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Christoph Hellwig, (Wed Aug 26, 11:41 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Christoph Hellwig, (Wed Aug 26, 11:42 am)

Re: [PATCH 08/12] add trace events for each syscall entry/exit, Mathieu Desnoyers, (Wed Aug 26, 12:01 pm)

[PATCH]: tracing: s390 arch updates for tracing syscalls, Hendrik Brueckner, (Thu Aug 27, 12:27 am)

[tip:tracing/core] tracing: Add syscall tracepoints - s390 ..., tip-bot for Hendrik ..., (Fri Aug 28, 5:27 am)

[tip:tracing/core] tracing: Check invalid syscall nr while ..., tip-bot for Hendrik ..., (Fri Aug 28, 5:27 am)

[tip:tracing/core] tracing: Don't trace kernel thread syscalls, tip-bot for Hendrik ..., (Fri Aug 28, 5:28 am)

Navigation

Popular discussions


linux-kernel:
Ken Chen	[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar	Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt	Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov	Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki	[Bug #16380] Loop devices act strangely in 2.6.35
git:
Steven Grimm	Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King	Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt	Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin	Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce	Re: [PATCH v2] Speed up bash completion loading
git-commits-head:
Linux Kernel Mailing List	cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List	sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List	IB/core: Add support for masked atomic operations
Linux Kernel Mailing List	V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List	ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev:
Inaky Perez-Gonzalez	[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil	[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux	Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller	Re: tun: Use netif_receive_skb instead of netif_rx
David Miller	Re: [net-next PATCH v2] llc enhancements
freebsd-current:
Matthew Fleming	Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com	Re: OT: 2d password
Hartmut Brandt	Re: problem with nss_ldap
Andrew Reilly	Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier	Re: Upcoming ABI Breakage in RELENG_7

Colocation donated by:

Syndicate