Re: [PATCH 5/6] aio: use lazy workqueues

Previous thread: nfs: LOCKDEP warning with 2.6.31-rc6 by Takashi Iwai on Thursday, August 20, 2009 - 3:18 am. (3 messages)

Next thread: [PATCH 6/6] sunrpc: use lazy workqueues by Jens Axboe on Thursday, August 20, 2009 - 3:20 am. (1 message)
From: Jens Axboe
Date: Thursday, August 20, 2009 - 3:20 am

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
---
 fs/aio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/aio.c b/fs/aio.c
index d065b2c..4103b59 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -72,7 +72,7 @@ static int __init aio_setup(void)
 	kiocb_cachep = KMEM_CACHE(kiocb, SLAB_HWCACHE_ALIGN|SLAB_PANIC);
 	kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC);
 
-	aio_wq = create_workqueue("aio");
+	aio_wq = create_lazy_workqueue("aio");
 
 	pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));
 
-- 
1.6.4.173.g3f189

--

From: Jeff Moyer
Date: Thursday, August 20, 2009 - 8:09 am

So far as I can tell, the aio workqueue isn't used for much these days.
We could probably get away with switching to keventd.  Zach, isn't
someone working on a patch to get rid of all of the -EIOCBRETRY
infrastructure?  That patch would probably make things clearer in this
area.

Cheers,
Jeff
--

From: Zach Brown
Date: Friday, August 21, 2009 - 11:31 am

It's only used by drivers/usb/gadget to implement O_DIRECT reads by
DMAing into kmalloc()ed memory and then performing the copy_to_user() in
the retry thread's task context after it has assumed the submitting

Yeah, a startling amount of fs/aio.c vanishes if we get rid of
EIOCBRETRY.  I'm puttering away at it, but I'll be on holiday next week
so it'll be a while before anything emerges.

- z
--

Previous thread: nfs: LOCKDEP warning with 2.6.31-rc6 by Takashi Iwai on Thursday, August 20, 2009 - 3:18 am. (3 messages)

Next thread: [PATCH 6/6] sunrpc: use lazy workqueues by Jens Axboe on Thursday, August 20, 2009 - 3:20 am. (1 message)