Re: microcode driver newly spews warnings

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: H. Peter Anvin
Date: Thursday, April 16, 2009 - 4:28 pm

Jeff Garzik wrote:

OK, what isn't clear to me is what the proper return value is in this 
case.  In particular, how with the caller react to mc_sysdev_add() 
returning a nonzero value, but still have the sysdev devices created and 
retained?

What I would expect happen would be that sysdev_register_driver() would 
return an error and we would unregister the notifier, which really isn't 
the right thing -- if the intent is to keep the sysdev devices around 
for a possible later update then we should presumably return zero there, 
i.e. ignore the return value from microcode_init_cpu(); completely?

	-hpa

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
microcode driver newly spews warnings, Jeff Garzik, (Mon Apr 13, 11:23 am)
Re: microcode driver newly spews warnings, Jeff Garzik, (Mon Apr 13, 11:25 am)
Re: microcode driver newly spews warnings, Ingo Molnar, (Mon Apr 13, 11:27 am)
Re: microcode driver newly spews warnings, Jeff Garzik, (Wed Apr 15, 7:10 am)
Re: microcode driver newly spews warnings, Dmitry Adamushko, (Wed Apr 15, 7:51 am)
Re: microcode driver newly spews warnings, Ingo Molnar, (Thu Apr 16, 4:07 pm)
Re: microcode driver newly spews warnings, Jeff Garzik, (Thu Apr 16, 4:21 pm)
Re: microcode driver newly spews warnings, H. Peter Anvin, (Thu Apr 16, 4:28 pm)
Re: microcode driver newly spews warnings, Dmitry Adamushko, (Thu Apr 16, 11:58 pm)