Re: [PATCH 3/9] bio-cgroup controller

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Thursday, April 16, 2009 - 3:29 pm

On Tue, 14 Apr 2009 22:21:14 +0200
Andrea Righi <righi.andrea@gmail.com> wrote:


Sorry, but I have to register extreme distress at the name of this. 
The term "bio" is well-established in the kernel and here we have a new
definition for the same term: "block I/O".

"bio" was a fine term for you to have chosen from the user's
perspective, but from the kernel developer perspective it is quite
horrid.  The patch adds a vast number of new symbols all into the
existing "bio_" namespace, many of which aren't related to `struct bio'
at all.

At least, I think that's what's happening.  Perhaps the controller
really _is_ designed to track `struct bio'?  If so, that's an odd thing
to tell userspace about.



Presumably it tracks all forms of block-based I/O and not just delayed
writeback.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/9] cgroup: io-throttle controller (v13), Andrea Righi, (Tue Apr 14, 1:21 pm)
[PATCH 1/9] io-throttle documentation, Andrea Righi, (Tue Apr 14, 1:21 pm)
[PATCH 3/9] bio-cgroup controller, Andrea Righi, (Tue Apr 14, 1:21 pm)
[PATCH 5/9] io-throttle controller infrastructure, Andrea Righi, (Tue Apr 14, 1:21 pm)
[PATCH 7/9] io-throttle instrumentation, Andrea Righi, (Tue Apr 14, 1:21 pm)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Tue Apr 14, 7:15 pm)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Wed Apr 15, 2:37 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Wed Apr 15, 5:38 am)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Wed Apr 15, 6:07 am)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Wed Apr 15, 6:23 am)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Wed Apr 15, 4:58 pm)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Thu Apr 16, 3:42 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Thu Apr 16, 5:00 am)
Re: [PATCH 0/9] cgroup: io-throttle controller (v13), Andrew Morton, (Thu Apr 16, 3:24 pm)
Re: [PATCH 3/9] bio-cgroup controller, Andrew Morton, (Thu Apr 16, 3:29 pm)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Thu Apr 16, 5:04 pm)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Thu Apr 16, 5:20 pm)
Re: [PATCH 3/9] bio-cgroup controller, Andrew Morton, (Thu Apr 16, 5:44 pm)
Re: [PATCH 1/9] io-throttle documentation, KAMEZAWA Hiroyuki, (Thu Apr 16, 6:24 pm)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Thu Apr 16, 6:44 pm)
Re: [PATCH 3/9] bio-cgroup controller, Takuya Yoshikawa, (Thu Apr 16, 6:49 pm)
Re: [PATCH 3/9] bio-cgroup controller, Balbir Singh, (Thu Apr 16, 6:50 pm)
Re: [PATCH 1/9] io-throttle documentation, Li Zefan, (Thu Apr 16, 6:56 pm)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Thu Apr 16, 7:24 pm)
Re: [PATCH 3/9] bio-cgroup controller, Andrew Morton, (Thu Apr 16, 9:15 pm)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Fri Apr 17, 12:22 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Fri Apr 17, 12:32 am)
Re: [PATCH 1/9] io-throttle documentation, Gui Jianfeng, (Fri Apr 17, 12:34 am)
Re: [PATCH 1/9] io-throttle documentation, KAMEZAWA Hiroyuki, (Fri Apr 17, 12:43 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Fri Apr 17, 12:48 am)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Fri Apr 17, 1:00 am)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Fri Apr 17, 1:48 am)
Re: [PATCH 3/9] bio-cgroup controller, KAMEZAWA Hiroyuki, (Fri Apr 17, 1:51 am)
Re: [PATCH 1/9] io-throttle documentation, Gui Jianfeng, (Fri Apr 17, 2:29 am)
Re: [PATCH 0/9] cgroup: io-throttle controller (v13), Andrea Righi, (Fri Apr 17, 2:37 am)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Fri Apr 17, 2:40 am)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Fri Apr 17, 2:44 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Fri Apr 17, 2:55 am)
Re: [PATCH 3/9] bio-cgroup controller, Balbir Singh, (Fri Apr 17, 3:22 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Fri Apr 17, 3:25 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Fri Apr 17, 3:41 am)
Block I/O tracking (was Re: [PATCH 3/9] bio-cgroup controller), =?ISO-8859-1?Q?Ferna ..., (Fri Apr 17, 4:27 am)
Re: [PATCH 1/9] io-throttle documentation, =?ISO-8859-1?Q?Ferna ..., (Fri Apr 17, 4:35 am)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Fri Apr 17, 10:39 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Fri Apr 17, 4:12 pm)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Sun Apr 19, 6:42 am)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Sun Apr 19, 6:54 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Sun Apr 19, 8:47 am)
Re: [PATCH 1/9] io-throttle documentation, Ryo Tsuruta, (Mon Apr 20, 2:38 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Mon Apr 20, 4:35 am)
Re: [PATCH 3/9] bio-cgroup controller, Andrea Righi, (Mon Apr 20, 7:56 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Mon Apr 20, 8:00 am)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Mon Apr 20, 2:28 pm)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Mon Apr 20, 3:05 pm)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Mon Apr 20, 6:08 pm)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Tue Apr 21, 1:37 am)
Re: [PATCH 3/9] bio-cgroup controller, Ryo Tsuruta, (Tue Apr 21, 4:39 am)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Tue Apr 21, 7:23 am)
Re: [PATCH 3/9] bio-cgroup controller, Balbir Singh, (Tue Apr 21, 8:31 am)
Re: [PATCH 1/9] io-throttle documentation, Vivek Goyal, (Tue Apr 21, 11:29 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Tue Apr 21, 2:28 pm)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Tue Apr 21, 2:36 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Tue Apr 21, 5:33 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Tue Apr 21, 6:21 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Wed Apr 22, 5:05 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Wed Apr 22, 7:54 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Wed Apr 22, 10:37 pm)
Re: [PATCH 9/9] ext3: do not throttle metadata and journal IO, KAMEZAWA Hiroyuki, (Thu Apr 23, 5:26 pm)
Re: [PATCH 1/9] io-throttle documentation, Ryo Tsuruta, (Mon Apr 27, 3:45 am)
Re: [PATCH 1/9] io-throttle documentation, Ryo Tsuruta, (Mon Apr 27, 5:15 am)
Re: [PATCH 1/9] io-throttle documentation, Andrea Righi, (Mon Apr 27, 2:56 pm)
Re: [PATCH 0/9] cgroup: io-throttle controller (v13), Alan D. Brunelle, (Thu Apr 30, 6:20 am)
Re: [PATCH 0/9] cgroup: io-throttle controller (v13), Andrea Righi, (Fri May 1, 4:11 am)