Re: [PATCH 2/8] tracing: create automated trace defines

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeremy Fitzhardinge
Date: Wednesday, April 15, 2009 - 7:56 pm

Mathieu Desnoyers wrote:

No.  That was the first roadblock, which caused massive cyclic 
dependencies between includes and consequent failure to define 
everything required.  I solved that by pushing __DO_TRACE out of line.  
Everything since then is a separate issue.

I suppose, but I think pushing __do_trace_##name out of line is cleaner 
anyway.  And I think it's very important that tracepoint.h have a 
*absolutely minimal* #include set, so that it can be safely included in 
as many contexts as possible.  asm/paravirt.h is complex enough as it 
is, and I really don't want tracepoint bringing in any extra headers at 
all.  linux/types.h is about the only acceptable one.


The void issue is irritating, but relatively minor compared to the 
rest.  If everything else gets solved except for the need to pass a 
dummy param to no-arg tracepoints, then I think it'll be a generally 
useful facility.

    J
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 2/8] tracing: create automated trace defines, Steven Rostedt, (Tue Apr 14, 10:23 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Tue Apr 14, 4:44 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Tue Apr 14, 6:45 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Wed Apr 15, 9:07 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Wed Apr 15, 7:34 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Wed Apr 15, 7:56 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Thu Apr 16, 4:44 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Thu Apr 16, 5:03 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Thu Apr 16, 5:13 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Thu Apr 16, 5:18 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Thu Apr 16, 5:28 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Thu Apr 16, 5:43 pm)
[PATCH] tracepoints : let subsystem nop-out the tracepoint ..., Mathieu Desnoyers, (Thu Apr 16, 8:05 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Tue Apr 21, 8:51 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Tue Apr 21, 10:18 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Steven Rostedt, (Tue Apr 21, 10:21 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Jeremy Fitzhardinge, (Tue Apr 21, 10:43 am)
Re: [PATCH 2/8] tracing: create automated trace defines, Steven Rostedt, (Tue Apr 21, 2:17 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Frank Ch. Eigler, (Tue Apr 21, 2:23 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Steven Rostedt, (Tue Apr 21, 2:33 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Mathieu Desnoyers, (Tue Apr 21, 10:47 pm)
Re: [PATCH 2/8] tracing: create automated trace defines, Steven Rostedt, (Tue Apr 21, 11:24 pm)