Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error() | KernelTrap

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error()

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Sergei Shtylyov

Subject: Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error()

Date: Monday, February 16, 2009 - 5:13 am

Hello, I wrote:

quoted text>> * Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature
>>   register and handle it in ->tf_read.
>>   
>
>  Doesn't seem like a good name -- you can't read the features 
> register. I should've commented to this patch earlier, of course...

   Moreover, the error register shoudn't be affeceted by the HOB bit, so 
this flag doesn't make sense.

MBR, Sergei


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)

[PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)

[PATCH 03/18] ide: remove ->dma_{status,command} fields fr ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)

[PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)

[PATCH 05/18] ide: factor out simplex handling from ide_pc ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:33 pm)

[PATCH 06/18] ide: add ->exec_command method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 07/18] ide: add ->read_status method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 08/18] ide: add ->read_altstatus method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 09/18] ide: add ->set_irq method, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 10/18] ide: change order of register access in ide_ ..., Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 11/18] ide: use ->tf_load in ide_config_drive_speed(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 12/18] ide: use ->tf_load in actual_try_to_identify(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 14/18] ide: use ->tf_read in ide_read_error(), Bartlomiej Zolnierki ..., (Fri Jun 20, 2:34 pm)

[PATCH 15/18] ide: add ide_read_device() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)

[PATCH 16/18] ide: add ide_read_ireason() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)

[PATCH 17/18] ide: add ide_read_bcount_and_ireason() helper, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)

[PATCH 18/18] ide: remove ->INB, ->OUTB and ->OUTBSYNC methods, Bartlomiej Zolnierki ..., (Fri Jun 20, 2:35 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Fri Jun 20, 3:03 pm)

Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_iden ..., Sergei Shtylyov, (Fri Jun 20, 4:14 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Bartlomiej Zolnierki ..., (Sat Jun 21, 12:06 pm)

Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_iden ..., Bartlomiej Zolnierki ..., (Sat Jun 21, 12:10 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Sat Jun 21, 12:29 pm)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 10:16 am)

Re: [PATCH 04/18] ide: remove ide_setup_dma(), Sergei Shtylyov, (Thu Aug 21, 10:56 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Wed Sep 3, 6:19 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierki ..., (Wed Sep 3, 11:13 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 11:15 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 11:49 am)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Bartlomiej Zolnierki ..., (Sun Sep 7, 12:23 pm)

Re: [PATCH 01/18] ide: add ->read_sff_dma_status method, Sergei Shtylyov, (Sun Sep 7, 3:26 pm)

Re: [PATCH 02/18] ide: use I/O ops directly in ide-dma.c, Sergei Shtylyov, (Mon Sep 8, 8:49 am)

Re: [PATCH 09/18] ide: add ->set_irq method, Sergei Shtylyov, (Wed Oct 15, 5:20 am)

Re: [PATCH 09/18] ide: add ->set_irq method, Bartlomiej Zolnierki ..., (Wed Oct 15, 11:22 am)

Re: [PATCH 09/18] ide: add ->set_irq method, Sergei Shtylyov, (Wed Oct 15, 2:22 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Sun Feb 15, 1:25 pm)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Sergei Shtylyov, (Sun Feb 15, 4:21 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Sun Feb 15, 5:08 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Mon Feb 16, 4:50 am)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:13 am)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:25 am)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Bartlomiej Zolnierki ..., (Mon Feb 16, 2:17 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Mon Feb 16, 2:51 pm)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:14 pm)

Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error(), Sergei Shtylyov, (Mon Feb 16, 5:50 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Mon Feb 16, 6:04 pm)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 5:23 am)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Bartlomiej Zolnierki ..., (Tue Feb 17, 7:43 am)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 8:13 am)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Tue Feb 17, 8:32 am)

Re: [PATCH 13/18] ide: use ->tf_load in SELECT_DRIVE(), Sergei Shtylyov, (Wed Mar 4, 8:43 am)

Navigation

Popular discussions


linux-kernel:
Eric Sandeen	Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages
Daniel Hazelton	Re: x86: 4kstacks default
Rusty Russell	Re: 2.6.22-rc3-mm1
Jeffrey V. Merkey	Re: Versioning file system
Matt Mackall	Re: [RFD] Documentation/HOWTO translated into Japanese
linux-netdev:
gregkh	Patch "IPv6: keep route for tentative address" has been added to the 2.6.34-stable...
Patrick McHardy	Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
Krzysztof Oledzki	Re: Error: an inet prefix is expected rather than "0/0".
Paul Gortmaker	[PATCH net-next 09/16] tipc: Relocate trivial link status functions to header file
webmaster Maintenance	&#32852;&#31995;&#31995;&#32479;&#31649;&#29702;&#21592;
git:
Johannes Schindelin	[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Junio C Hamano	Re: [PATCH] http-push: making HTTP push more robust and more user-friendly
Oliver Kullmann	Re: how to move with history?
Alex Riesen	Re: git exclude patterns for directory
Andreas Ericsson	Re: why not TortoiseGit
openbsd-misc:
Damien Miller	Re: Patching a SSH 'Weakness'
Stuart Henderson	Re: Apache Seg Fault after upgrade to 4.6 stable
Úlfar M. E. Johnson	installing openbsd in xen
Brian	CARP multicast and ADSL bridge
Eric Furman	Re: Defending OpenBSD Performance
git-commits-head:
Linux Kernel Mailing List	New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List	drivers/acpi: use kasprintf
Linux Kernel Mailing List	Staging: et131x: prune all the debug code
Linux Kernel Mailing List	PCI: introduce pci_pcie_cap()
Linux Kernel Mailing List	USB: g_multi: Multifunction Composite Gadget added

Colocation donated by:

Syndicate