Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-on PATCH attached)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Alan Cox <alan@...>

Cc: Joe Peterson <joe@...>, <linux-kernel@...>

Subject: Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-on PATCH attached)

Date: Tuesday, September 9, 2008 - 1:43 pm

On Tue, 9 Sep 2008 11:55:36 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

quoted text> On Mon, 8 Sep 2008 17:32:50 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Mon, 08 Sep 2008 10:11:46 -0600
> > Joe Peterson <joe@skyrush.com> wrote:
> > 
> > > +	spin_lock_irqsave(&tty->echo_lock, flags);
> > >  	lock_kernel();
> > 
> > Taking a spinlock outside lock_kernel() isn't good, and is quite unusual.
> > 
> > - It might be ab/ba deadlockable (I didn't check) (I trust you always
> >   test with lockdep enabled?)
> 
> lock_kernel can sleep.

That used to be the case, but the mutex_lock() version of the bkl got
removed.  It may of course come back.

quoted text> Its not allowed...
> 

yup.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] TTY: Fix loss of echoed characters, Joe Peterson, (Wed Aug 20, 11:36 am)

Re: [PATCH] TTY: Fix loss of echoed characters, Joe Peterson, (Tue Aug 26, 8:41 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Joe Peterson, (Mon Sep 8, 12:11 pm)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Andrew Morton, (Mon Sep 8, 8:32 pm)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Joe Peterson, (Tue Sep 9, 9:00 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Alan Cox, (Tue Sep 9, 9:12 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Joe Peterson, (Tue Sep 9, 9:15 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Alan Cox, (Tue Sep 9, 9:19 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Alan Cox, (Tue Sep 9, 6:55 am)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Andrew Morton, (Tue Sep 9, 1:43 pm)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Joe Peterson, (Tue Sep 9, 4:42 pm)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Andrew Morton, (Wed Sep 10, 7:39 pm)

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-o..., Joe Peterson, (Thu Sep 11, 8:53 am)


linux-kernel:
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Faik Uygur	Re: Linux 2.6.21-rc1
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Trent Piepho	[PATCH] [POWERPC] Improve (in\|out)_beXX() asm code
git:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jens Axboe	Re: [BUG] New Kernel Bugs
openbsd-misc:

Re: [PATCH] TTY: Fix loss of echoed characters (2nd follow-on PATCH attached)

Online users