Home » Mailing list archives » linux-kernel » 2008 » September » 9

Re: [git pull] x86 fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: David Sanders <linux@...>, Sam Ravnborg <sam@...>
Cc: <linux-kernel@...>, H. Peter Anvin <hpa@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, x86 maintainers <x86@...>, Sam Ravnborg <sam@...>, kbuild devel <kbuild-devel@...>
Subject: Re: [git pull] x86 fixes
Date: Tuesday, September 9, 2008 - 3:19 am

* Ingo Molnar  wrote:


>


Sam, i've applied Peter's fix (see the commit below) - do you have any

objections to us carrying this in x86/urgent? It's needed for the gcc

fix/workaround.


	Ingo


--------------->

From 095fbc7296ccfe41688e8ef136587b23f0e8c123 Mon Sep 17 00:00:00 2001

From: H. Peter Anvin

Date: Mon, 8 Sep 2008 14:43:11 -0700

Subject: [PATCH] kbuild: fix cc-option and cc-option-yn


David Sanders wrote:


> I'm getting this error:


Use -c instead of -S in cc-option and cc-option-yn, so we can probe

options related to the assembler.


Signed-off-by: H. Peter Anvin

Cc: Sam Ravnborg

Cc: kbuild devel

Signed-off-by: Ingo Molnar

---

 scripts/Kbuild.include |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include

index d64e6ba..982dcae 100644

--- a/scripts/Kbuild.include

+++ b/scripts/Kbuild.include

@@ -105,12 +105,12 @@ as-instr = $(call try-run,\

 # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586)


 cc-option = $(call try-run,\

-	$(CC) $(KBUILD_CFLAGS) $(1) -S -xc /dev/null -o "$$TMP",$(1),$(2))

+	$(CC) $(KBUILD_CFLAGS) $(1) -c -xc /dev/null -o "$$TMP",$(1),$(2))


 # cc-option-yn

 # Usage: flag := $(call cc-option-yn,-march=winchip-c6)

 cc-option-yn = $(call try-run,\

-	$(CC) $(KBUILD_CFLAGS) $(1) -S -xc /dev/null -o "$$TMP",y,n)

+	$(CC) $(KBUILD_CFLAGS) $(1) -c -xc /dev/null -o "$$TMP",y,n)


 # cc-option-align

 # Prefix align with either -falign or -malign

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 3:32 pm)
Re: [git pull] x86 fixes, David Sanders, (Tue Sep 9, 3:18 pm)
Re: [git pull] x86 fixes, Linus Torvalds, (Tue Sep 9, 3:56 pm)
Re: [git pull] x86 fixes, David Sanders, (Tue Sep 9, 4:37 pm)
Re: [git pull] x86 fixes, Linus Torvalds, (Tue Sep 9, 4:45 pm)
Re: [git pull] x86 fixes, Linus Torvalds, (Tue Sep 9, 4:46 pm)
Re: [git pull] x86 fixes, David Sanders, (Tue Sep 9, 4:53 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Tue Sep 9, 4:49 pm)
Re: [git pull] x86 fixes, David Sanders, (Mon Sep 8, 4:34 pm)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 5:43 pm)
Re: [git pull] x86 fixes, David Sanders, (Mon Sep 8, 6:16 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Tue Sep 9, 2:05 am)
Re: [git pull] x86 fixes, Ingo Molnar, (Tue Sep 9, 3:19 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 5:20 pm)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 5:22 pm)