login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
September
»
8
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code (3rd try)
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [author]
[view in full thread]
From: Masoud Sharbiani
Subject:
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code (3rd try)
Date: Monday, September 8, 2008 - 10:21 am
On Sun, Sep 07, 2008 at 08:10:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
quoted text
> > Hi, > > Masoud/Sergei: sorry for the bug and thanks for fixing it. > > On Sunday 07 September 2008, Sergei Shtylyov wrote: > > Hello, I wrote: > > >> diff --git a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c > > >> index eb107ee..4eae284 100644 > > >> --- a/drivers/ide/pci/hpt366.c > > >> +++ b/drivers/ide/pci/hpt366.c > > >> @@ -613,6 +613,14 @@ static int check_in_drive_list(ide_drive_t > > >> *drive, const char **list) > > >> return 0; > > >> } > > >> > > >> +static struct hpt_info *hpt3xx_get_info(struct device *dev) > > >> +{ > > >> + struct ide_host *host = pci_get_drvdata(to_pci_dev(pci_dev)); > > >> > > > > > > Oops, this just won't compile. :-/ > > > > BTW, there's no need to invoke to_pci_dev() at all since > > pci_get_drvdata(dev) boils down to dev_get_drvdata(&dev->dev) call. So, > > in order not to waste time on useless pointer tricks, we should just > > invoke the latter here. > > I corrected this and applied the patch.
Thanks! Masoud --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [author]
Messages in current thread:
[PATCH] Fix pointer arithmetic in hpt3xx driver code (3rd try)
, Masoud Sharbiani
, (Sat Sep 6, 10:18 am)
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code ( ...
, Sergei Shtylyov
, (Sun Sep 7, 2:21 am)
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code ( ...
, Sergei Shtylyov
, (Sun Sep 7, 4:20 am)
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code ( ...
, Bartlomiej Zolnierki ...
, (Sun Sep 7, 11:10 am)
Re: [PATCH] Fix pointer arithmetic in hpt3xx driver code ( ...
, Masoud Sharbiani
, (Mon Sep 8, 10:21 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
David Brownell
Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':
Matthew Garrett
Re: 2.6.25-rc6 regression - hang on resume [Bug 10319]
Andy Walls
Re: [PATCH 11/32] v4l/cx18: update workqueue usage
Greg Kroah-Hartman
[PATCH 17/36] sysdev: detect multiple driver registrations
Thomas Gleixner
[patch -mm 19/28] x86_64: Use generic cmos update
git
:
Mark Junker
git on MacOSX and files with decomposed utf-8 file names
Johannes Schindelin
Re: error: cannot lock ref 'refs/remotes/origin/*'
Pat Thoyts
[PATCH] git-gui: use themed tk widgets with Tk 8.5
Michael Witten
Re: 'git gc --aggressive' effectively unusable
Jonathan Nieder
Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patc...
linux-netdev
:
David Miller
Re: [PATCH 32/53] netns xfrm: finding policy in netns
Jean-Louis Dupond
Re: tg3 driver not advertising 1000mbit
Jan Engelhardt
[PATCH 1/3] net: tcp: make hybla selectable as default congestion module
Matt Mackall
Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference
Eric Dumazet
Re: HTB accuracy on 10GbE
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB (8018): Add em2860 chip ID
Linux Kernel Mailing List
ipv6: fix an oops when force unload ipv6 module
Linux Kernel Mailing List
[ARM] unconditionally define __virt_to_phys and __phys_to_virt
Linux Kernel Mailing List
ixgbe: fix automatic LRO/RSC settings for low latency
Linux Kernel Mailing List
3c515: convert to net_device_ops
openbsd-misc
:
Samuel Baldwin
Re: Forum engine
Robert
disklabel - cylinder rounding
nixlists
Re: Which laptops do the developers use?
Claudio Jeker
Re: OT: Python (was Re: vi in /bin)
Darrin Chandler
Re: That whole "Linux stealing our code" thing
Colocation donated by:
Syndicate