Re: Linux 2.6.25.17

Previous thread: kernel BUG at drivers/pci/intel-iommu.c:1373! by Chris Mason on Monday, September 8, 2008 - 7:26 am. (3 messages)

Next thread: Linux 2.6.26.4 by Greg KH on Monday, September 8, 2008 - 7:36 am. (7 messages)
From: Greg KH
Date: Monday, September 8, 2008 - 7:35 am

We (the -stable team) are announcing the release of the 2.6.25.17
kernel.

It contains lots of bugfixes, all over the map.  Any users of the 2.6.25
kernel series should upgrade to this version.  For details on the fixes,
see the changelog entries and the diffstat below.

I'll also be replying to this message with a copy of the patch between
2.6.25.16 and 2.6.25.17

The updated 2.6.25.y git tree can be found at:
        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.25.y.git
and can be browsed at the normal kernel.org git web browser:
        http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.25.y.git;a=summary

thanks,

greg k-h

------------

 Makefile                           |    2 
 arch/x86/kernel/cpu/mtrr/generic.c |   15 +++++
 crypto/authenc.c                   |   10 ++-
 drivers/net/forcedeth.c            |    4 -
 drivers/net/r8169.c                |    2 
 drivers/usb/class/cdc-acm.c        |    2 
 drivers/video/fb_defio.c           |   19 +++++++
 drivers/video/fbmem.c              |    4 +
 fs/cifs/file.c                     |    4 +
 fs/cramfs/inode.c                  |   84 ++++++++++++++------------------
 fs/nfsd/nfs4acl.c                  |    2 
 include/linux/fb.h                 |    3 +
 mm/page_alloc.c                    |    7 ++
 net/sched/sch_prio.c               |   16 ++++--
 net/sctp/auth.c                    |    7 ++
 net/sctp/endpointola.c             |    4 -
 net/sctp/socket.c                  |   96 ++++++++++++++++++++++++++++---------
 net/sunrpc/sysctl.c                |   18 +-----
 18 files changed, 198 insertions(+), 101 deletions(-)

Adam Litke (1):
      mm: make setup_zone_migrate_reserve() aware of overlapping nodes

Al Viro (1):
      cramfs: fix named-pipe handling

Alexey Dobriyan (1):
      USB: cdc-acm: don't unlock acm->mutex on error path

Ayaz Abdulla (1):
      forcedeth: fix checksum flag

Cyrill Gorcunov (1):
      sunrpc: fix possible overrun on read of ...
From: Greg KH
Date: Monday, September 8, 2008 - 7:35 am

diff --git a/Makefile b/Makefile
index dfb6252..cb23e66 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 25
-EXTRAVERSION = .16
+EXTRAVERSION = .17
 NAME = Funky Weasel is Jiggy wit it
 
 # *DOCUMENTATION*
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index 3e18db4..f49c970 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -229,6 +229,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 			     unsigned long *size, mtrr_type *type)
 {
 	unsigned int mask_lo, mask_hi, base_lo, base_hi;
+	unsigned int tmp, hi;
 
 	rdmsr(MTRRphysMask_MSR(reg), mask_lo, mask_hi);
 	if ((mask_lo & 0x800) == 0) {
@@ -242,8 +243,18 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 	rdmsr(MTRRphysBase_MSR(reg), base_lo, base_hi);
 
 	/* Work out the shifted address mask. */
-	mask_lo = size_or_mask | mask_hi << (32 - PAGE_SHIFT)
-	    | mask_lo >> PAGE_SHIFT;
+	tmp = mask_hi << (32 - PAGE_SHIFT) | mask_lo >> PAGE_SHIFT;
+	mask_lo = size_or_mask | tmp;
+	/* Expand tmp with high bits to all 1s*/
+	hi = fls(tmp);
+	if (hi > 0) {
+		tmp |= ~((1<<(hi - 1)) - 1);
+
+		if (tmp != mask_lo) {
+			WARN_ON("mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+			mask_lo = tmp;
+		}
+	}
 
 	/* This works correctly if size is a power of two, i.e. a
 	   contiguous range. */
diff --git a/crypto/authenc.c b/crypto/authenc.c
index 4b22676..fd9f06c 100644
--- a/crypto/authenc.c
+++ b/crypto/authenc.c
@@ -174,8 +174,9 @@ static int crypto_authenc_genicv(struct aead_request *req, u8 *iv,
 static void crypto_authenc_encrypt_done(struct crypto_async_request *req,
 					int err)
 {
+	struct aead_request *areq = req->data;
+
 	if (!err) {
-		struct aead_request *areq = req->data;
 		struct crypto_aead *authenc = crypto_aead_reqtfm(areq);
 		struct crypto_authenc_ctx *ctx = crypto_aead_ctx(authenc);
 		struct ...
From: linux-os (Dick Johnson)
Date: Monday, September 8, 2008 - 12:44 pm

[SNIPPED...]

I have a dual AMD Dell that I installed 2.6.25.17 into. It
produces severe FS corruption on a Serial ATA drive if I
build a kernel on it. I can build the kernel on one of my
SCSI drives with no problems.

If I remove one of the CPUs, there is no file-system corruption
so I fear that there is some lock missing somewhere in the
serial ATA driver code (ata_piix or sata_sil).

If anybody has anything to test with my setup, I can readily
test both with and without the two CPUs.


Cheers,
Dick Johnson
Penguin : Linux version 2.6.25.17 on an i686 machine (4786.48 BogoMips).
My book : http://www.AbominableFirebug.com/
_


****************************************************************
The information transmitted in this message is confidential and may be=
 privileged.  Any review, retransmission, dissemination, or other use of=
 this information by persons or entities other than the intended recipient=
 is prohibited.  If you are not the intended recipient, please notify=
 Analogic Corporation immediately - by replying to this message or by=
 sending an email to DeliveryErrors@analogic.com - and destroy all copies=
 of this information, including any attachments, without reading or=
 disclosing them.

Thank you.
From: Alan Cox
Date: Monday, September 8, 2008 - 1:03 pm

All the logic and locking is in the core code so would show up on all
sorts of boxes. You say you are using sata_sil - is this on an Nvidia

Can you duplicate this with the drives just on the ata_piix ?

Alan
--

From: linux-os (Dick Johnson)
Date: Monday, September 8, 2008 - 1:24 pm

The drives are on the ata_piix. I have no clue why the 'install'
added the sata_sil driver because I have never used on on this
machine! I note thet /etc/modprobe.conf has an alias for it so
at one time a Fedora install thought it found one!


Cheers,
Dick Johnson
Penguin : Linux version 2.6.25.17 on an i686 machine (4786.48 BogoMips).
My book : http://www.AbominableFirebug.com/
_


****************************************************************
The information transmitted in this message is confidential and may be privileged.  Any review, retransmission, dissemination, or other use of this information by persons or entities other than the intended recipient is prohibited.  If you are not the intended recipient, please notify Analogic Corporation immediately - by replying to this message or by sending an email to DeliveryErrors@analogic.com - and destroy all copies of this information, including any attachments, without reading or disclosing them.

Thank you.
--

From: Greg KH
Date: Monday, September 8, 2008 - 2:06 pm

Is this something new with 2.6.25.17, or has it always been the same for
all 2.6.25 kernels?

thanks,

greg k-h
--

From: linux-os (Dick Johnson)
Date: Tuesday, September 9, 2008 - 4:59 am

The previous kernel I used was linux-2.6.22.1  and this kernel doesn't
have the problem. I discovered the problem when I built and installed
the "latest stable" 2.6.25.17. My main working disk, a new SATA,
showed severe errors during each reboot. I can duplicate this at
will and remove the errors by removing my second CPU!


Cheers,
Dick Johnson
Penguin : Linux version 2.6.25.17 on an i686 machine (4786.48 BogoMips).
My book : http://www.AbominableFirebug.com/
_


****************************************************************
The information transmitted in this message is confidential and may be privileged.  Any review, retransmission, dissemination, or other use of this information by persons or entities other than the intended recipient is prohibited.  If you are not the intended recipient, please notify Analogic Corporation immediately - by replying to this message or by sending an email to DeliveryErrors@analogic.com - and destroy all copies of this information, including any attachments, without reading or disclosing them.

Thank you.
--

From: S.Çağlar
Date: Tuesday, October 14, 2008 - 1:19 pm

Hi;


That particular patch causes _lots_ of WARN_ON messages on one of our servers and following commit in Linus's tree solved that problem. If -stable team will release another .25 update maybe following patch can be considered to solve that sitation introduced with 2.6.2.5.17

commit 9754a5b840a209bc1f192d59f63e81b698a55ac8
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Aug 22 08:22:23 2008 +0200

    x86: work around MTRR mask setting, v2

    improve the debug printout:

    - make it actually display something
    - print it only once

    would be nice to have a WARN_ONCE() facility, to feed such things to
    kerneloops.org.

    Signed-off-by: Ingo Molnar <mingo@elte.hu>

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
--

From: Greg KH
Date: Friday, October 17, 2008 - 4:43 pm

Now queued up, thanks for letting us know.

greg k-h
--

Previous thread: kernel BUG at drivers/pci/intel-iommu.c:1373! by Chris Mason on Monday, September 8, 2008 - 7:26 am. (3 messages)

Next thread: Linux 2.6.26.4 by Greg KH on Monday, September 8, 2008 - 7:36 am. (7 messages)