Home » Mailing list archives » linux-kernel » 2008 » September » 8

[PATCH] mm: ifdef Quicklists in /proc/meminfo

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hugh Dickins <hugh@...>
To: Linus Torvalds <torvalds@...>
Cc: KOSAKI Motohiro <kosaki.motohiro@...>, Keiichiro Tokunaga <tokunaga.keiich@...>, Christoph Lameter <cl@...>, Andrew Morton <akpm@...>, <linux-kernel@...>
Subject: [PATCH] mm: ifdef Quicklists in /proc/meminfo
Date: Monday, September 8, 2008 - 8:57 am

A "Quicklists:          0 kB" line has just started appearing in
/proc/meminfo, but most architectures (including x86) don't have
them configured: may we please #ifdef it, like the highmem lines?

And those architectures which do have quicklists configured are
using them for page tables: so let's place it next to PageTables.

Signed-off-by: Hugh Dickins <hugh@veritas.com>
---

 fs/proc/proc_misc.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--- 2.6.27-rc5-git/fs/proc/proc_misc.c.0	2008-09-03 07:32:07.000000000 +0100
+++ linux/fs/proc/proc_misc.c	2008-09-08 13:07:41.000000000 +0100
@@ -183,6 +183,9 @@ static int meminfo_read_proc(char *page,
 		"SReclaimable: %8lu kB\n"
 		"SUnreclaim:   %8lu kB\n"
 		"PageTables:   %8lu kB\n"
+#ifdef CONFIG_QUICKLIST
+		"Quicklists:   %8lu kB\n"
+#endif
 		"NFS_Unstable: %8lu kB\n"
 		"Bounce:       %8lu kB\n"
 		"WritebackTmp: %8lu kB\n"
@@ -190,8 +193,7 @@ static int meminfo_read_proc(char *page,
 		"Committed_AS: %8lu kB\n"
 		"VmallocTotal: %8lu kB\n"
 		"VmallocUsed:  %8lu kB\n"
-		"VmallocChunk: %8lu kB\n"
-		"Quicklists:   %8lu kB\n",
+		"VmallocChunk: %8lu kB\n",
 		K(i.totalram),
 		K(i.freeram),
 		K(i.bufferram),
@@ -216,6 +218,9 @@ static int meminfo_read_proc(char *page,
 		K(global_page_state(NR_SLAB_RECLAIMABLE)),
 		K(global_page_state(NR_SLAB_UNRECLAIMABLE)),
 		K(global_page_state(NR_PAGETABLE)),
+#ifdef CONFIG_QUICKLIST
+		K(quicklist_total_size()),
+#endif
 		K(global_page_state(NR_UNSTABLE_NFS)),
 		K(global_page_state(NR_BOUNCE)),
 		K(global_page_state(NR_WRITEBACK_TEMP)),
@@ -223,8 +228,7 @@ static int meminfo_read_proc(char *page,
 		K(committed),
 		(unsigned long)VMALLOC_TOTAL >> 10,
 		vmi.used >> 10,
-		vmi.largest_chunk >> 10,
-		K(quicklist_total_size())
+		vmi.largest_chunk >> 10
 		);
 
 		len += hugetlb_report_meminfo(page + len);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] mm: ifdef Quicklists in /proc/meminfo, Hugh Dickins, (Mon Sep 8, 8:57 am)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, KOSAKI Motohiro, (Mon Sep 8, 7:43 pm)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, H. Peter Anvin, (Mon Sep 8, 7:57 pm)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, Jeremy Fitzhardinge, (Tue Sep 9, 7:48 pm)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, H. Peter Anvin, (Tue Sep 9, 7:50 pm)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, Hugh Dickins, (Tue Sep 9, 8:04 am)
Re: [PATCH] mm: ifdef Quicklists in /proc/meminfo, Christoph Lameter, (Mon Sep 8, 9:37 am)