[PATCH 14/18] ide-disk: use IDE_DFLAG_MEDIA_CHANGED

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Bartlomiej Zolnierkiewicz
Date: Sunday, September 7, 2008 - 3:16 pm

Set IDE_DFLAG_MEDIA_CHANGED in ide_gd_open() to signalize
ide_gd_media_changed() that that media has changed (instead
of relying on IDE_DFLAG_REMOVABLE).

There should be no functional changes caused by this patch.

Cc: Borislav Petkov <petkovbb@gmail.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-gd.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: b/drivers/ide/ide-gd.c
===================================================================
--- a/drivers/ide/ide-gd.c
+++ b/drivers/ide/ide-gd.c
@@ -154,6 +154,7 @@ static int ide_gd_open(struct inode *ino
 		 * and the door_lock is irrelevant at this point.
 		 */
 		ide_disk_set_doorlock(drive, 1);
+		drive->dev_flags |= IDE_DFLAG_MEDIA_CHANGED;
 		check_disk_change(inode->i_bdev);
 	}
 	return 0;
@@ -193,6 +194,7 @@ static int ide_gd_media_changed(struct g
 {
 	struct ide_disk_obj *idkp = ide_drv_g(disk, ide_disk_obj);
 	ide_drive_t *drive = idkp->drive;
+	int ret;
 
 	/* do not scan partitions twice if this is a removable device */
 	if (drive->dev_flags & IDE_DFLAG_ATTACH) {
@@ -200,8 +202,10 @@ static int ide_gd_media_changed(struct g
 		return 0;
 	}
 
-	/* if removable, always assume it was changed */
-	return !!(drive->dev_flags & IDE_DFLAG_REMOVABLE);
+	ret = !!(drive->dev_flags & IDE_DFLAG_MEDIA_CHANGED);
+	drive->dev_flags &= ~IDE_DFLAG_MEDIA_CHANGED;
+
+	return ret;
 }
 
 static int ide_gd_revalidate_disk(struct gendisk *disk)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/18] ide: add generic ATA/ATAPI disk driver, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 01/18] ide-disk: fix IDE_DFLAG_LBA48 handling on resume, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 02/18] ide-disk: lock media before checking for med ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 03/18] ide-floppy: use alloc_disk_node(), Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 04/18] ide-disk: use to_ide_drv() and ide_drv_g(), Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 05/18] ide-disk: move IDE_DFLAG_DOORLOCKING flag ha ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:14 pm)
[PATCH 06/18] ide-{disk,floppy}: set IDE_DFLAG_ATTACH in * ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 07/18] ide-floppy: drop 'floppy' argument from idef ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 08/18] ide-floppy: use drive-&gt;capacity64 for cachin ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 09/18] ide: IDE_AFLAG_MEDIA_CHANGED -&gt; IDE_DFLAG_ME ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 10/18] ide: IDE_AFLAG_WP -&gt; IDE_DFLAG_WP, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 11/18] ide: IDE_AFLAG_FORMAT_IN_PROGRESS -&gt; IDE_DFL ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 12/18] ide: remove IDE_AFLAG_NO_DOORLOCKING, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 13/18] ide-disk: factor out generic disk handling c ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:15 pm)
[PATCH 14/18] ide-disk: use IDE_DFLAG_MEDIA_CHANGED, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:16 pm)
[PATCH 15/18] ide-floppy: factor out generic disk handling ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:16 pm)
[PATCH 16/18] ide: prepare for merging ide-gd-floppy.c wit ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:16 pm)
[PATCH 17/18] ide: allow device drivers to specify per-dev ..., Bartlomiej Zolnierki ..., (Sun Sep 7, 3:16 pm)
[PATCH 18/18] ide: add generic ATA/ATAPI disk driver, Bartlomiej Zolnierki ..., (Sun Sep 7, 3:16 pm)
Re: [PATCH 00/18] ide: add generic ATA/ATAPI disk driver, Borislav Petkov, (Wed Sep 10, 4:20 am)
Re: [PATCH 08/18] ide-floppy: use drive-&gt;capacity64 for ca ..., Bartlomiej Zolnierki ..., (Sat Sep 27, 8:34 am)