* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

quoted text
> +	memory_corruption_check=0/1 [X86]

could you please add a second .config parameter as well:

  CONFIG_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y

which turns this parameter 1 without having to specify it on the boot 
command line. That way -tip's randconfig testing can check this on a 
couple of boxes and the WARN() will be detected automatically.

Also, i'd suggest to make the defaults of the scanning parameters be as 
widely enabled as reasonable - we want to see how much real problems 
this can catch.

quoted text
> +config X86_CHECK_BIOS_CORRUPTION
> +        bool "Check for low memory corruption"
> +	default y

please make it default-disabled.

Looks good otherwise.

	Ingo
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/