Re: [RFC patch 0/4] TSC calibration improvements

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Saturday, September 6, 2008 - 1:55 pm

On Sat, 6 Sep 2008, Linus Torvalds wrote:


Oh, you mean te "--expect" in the last pit_expect_msb(). Yeah, that one 
looks bogus, but I don't understand what it has to do with gcc at all.

"expect" is an unsigned char. There are absolutely _zero_ issues with 
overflow, underflow, random phases of the moon, madness levels or anything 
else. But yes, it does look like Ingo screwed up when adding that final 
check, since expect was already decremented at the end of the loop.

Ingo? Did you actually test it?

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Thu Sep 4, 8:18 am)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 8:36 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 8:45 am)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 9:00 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 9:21 am)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 9:36 am)
Re: [RFC patch 0/4] TSC calibration improvements, Alok Kataria, (Thu Sep 4, 10:39 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 10:41 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 10:53 am)
Re: [RFC patch 0/4] TSC calibration improvements, Alan Cox, (Thu Sep 4, 11:07 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 11:26 am)
Re: [RFC patch 0/4] TSC calibration improvements, H. Peter Anvin, (Thu Sep 4, 11:30 am)
Re: [RFC patch 0/4] TSC calibration improvements, Alok Kataria, (Thu Sep 4, 11:31 am)
Re: [RFC patch 0/4] TSC calibration improvements, H. Peter Anvin, (Thu Sep 4, 11:34 am)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 1:09 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 1:43 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 1:52 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 1:53 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Valdis.Kletnieks, (Thu Sep 4, 2:00 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 2:09 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 2:21 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 2:30 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 2:33 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 2:34 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Alok Kataria, (Thu Sep 4, 2:38 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Thu Sep 4, 2:39 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Thu Sep 4, 2:52 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Alok Kataria, (Thu Sep 4, 3:09 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Alok Kataria, (Fri Sep 5, 3:18 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Fri Sep 5, 3:34 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 1:03 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 1:29 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 1:37 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 1:50 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 1:52 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 1:55 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 1:58 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 1:59 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 2:07 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 2:10 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 2:15 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 2:15 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 2:22 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 2:26 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Thomas Gleixner, (Sat Sep 6, 2:30 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Linus Torvalds, (Sat Sep 6, 2:32 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Ingo Molnar, (Sat Sep 6, 3:40 pm)
Re: [RFC patch 0/4] TSC calibration improvements, Willy Tarreau, (Sat Sep 6, 11:01 pm)