Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Maciej W. Rozycki
Date: Saturday, September 6, 2008 - 11:45 am

On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:


 Honestly, this one should probably use sprintf() or suchlike to avoid the
mess of printk() calls building a line of output from pieces.  It's quite
easy to calculate here what the maximum size of the buffer required could
be and automatic arrays can have variable size, so no need for the hassle
of heap management.  Calls to printk() without a trailing newline should
be avoided where possible as it messes up logging priority if a message
pops up from an interrupt inbetween.

  Maciej
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 3/3] x86: io-apic - code style cleaning for set ..., Maciej W. Rozycki, (Sat Sep 6, 11:45 am)