Home » Mailing list archives » linux-kernel » 2008 » September » 6

Re: 2.6.27-rc5-mm1 compilation fix with gcc 3.4.6

Previous thread: [PATCH] proc: more debugging for "already registered" case by Alexey Dobriyan on Friday, September 5, 2008 - 2:36 pm. (1 message)

Next thread: [PATCH 2/3] x86: reduce stack requirements for send_call_func_ipi by Mike Travis on Friday, September 5, 2008 - 2:40 pm. (1 message)
[view original message]
From: Krzysztof Helt
Subject: 2.6.27-rc5-mm1 compilation fix with gcc 3.4.6
Date: Friday, September 5, 2008 - 2:46 pm

Hi Andrew,

I found that 2.6.27-rc5-mm1 does not compile with gcc 3.4.6.
The error is:
  CC      kernel/sched.o
kernel/sched.c: In function `start_rt_bandwidth':
kernel/sched.c:208: sorry, unimplemented: inlining failed in call to 'rt_bandwidth_enabled': function body not available
kernel/sched.c:214: sorry, unimplemented: called from here
make[1]: *** [kernel/sched.o] Error 1
make: *** [kernel] Error 2

It seems that the gcc 3.4.6 requires full inline definition before first usage.
The patch below fixes the compilation problem.

Regards,
Krzysztof

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl> (if needed>

diff -urp linux-ref/kernel/sched.c linux-mm/kernel/sched.c
--- linux-ref/kernel/sched.c	2008-09-05 23:39:02.000000000 +0200
+++ linux-mm/kernel/sched.c	2008-09-05 23:41:12.779563125 +0200
@@ -205,7 +205,10 @@ void init_rt_bandwidth(struct rt_bandwid
 	rt_b->rt_period_timer.cb_mode = HRTIMER_CB_IRQSAFE_NO_SOFTIRQ;
 }
 
-static inline int rt_bandwidth_enabled(void);
+static inline int rt_bandwidth_enabled(void)
+{
+	return sysctl_sched_rt_runtime >= 0;
+}
 
 static void start_rt_bandwidth(struct rt_bandwidth *rt_b)
 {
@@ -844,11 +847,6 @@ static inline u64 global_rt_runtime(void
 	return (u64)sysctl_sched_rt_runtime * NSEC_PER_USEC;
 }
 
-static inline int rt_bandwidth_enabled(void)
-{
-	return sysctl_sched_rt_runtime >= 0;
-}
-
 #ifndef prepare_arch_switch
 # define prepare_arch_switch(next)	do { } while (0)
 #endif


----------------------------------------------------------------------
Nie zwlekaj! Tapetuj z nami!
Sprawdz >>  http://link.interia.pl/f1f01

--


[ message continues ]
[view original message]
From: Ingo Molnar
Subject: Re: 2.6.27-rc5-mm1 compilation fix with gcc 3.4.6
Date: Saturday, September 6, 2008 - 6:17 am

applied to tip/sched/rt, thanks Krzysztof!

	Ingo
--


[ message continues ]
Previous thread: [PATCH] proc: more debugging for "already registered" case by Alexey Dobriyan on Friday, September 5, 2008 - 2:36 pm. (1 message)

Next thread: [PATCH 2/3] x86: reduce stack requirements for send_call_func_ipi by Mike Travis on Friday, September 5, 2008 - 2:40 pm. (1 message)