Home » Mailing list archives » linux-kernel » 2008 » September » 6

Re: [PATCH] ucb1400_ts depends SND_AC97_BUS

Previous thread: [PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads by Henrik Rydberg on Thursday, September 4, 2008 - 6:19 pm. (6 messages)

Next thread: [PATCH 01/16] x86: make detect_ht depends on X86_HT by Yinghai Lu on Thursday, September 4, 2008 - 8:08 pm. (17 messages)
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 7:57 pm

Can we get this patch or some patch into the input tree for linux-next?

Currently ucb1400_core using ac97_bus_type is the #1 build failure in linux-next.


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--


[ message continues ]
[view original message]
From: Nicolas Pitre
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 9:37 pm

This patch is commit e1036502e5263851259d147771226161e5ccc85a and 
appeared in mainline almost 2 years ago.


Nicolas
--


[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 9:44 pm

Ack.  Sorry about that.  Wrong ucb thread.

ucb1400_core still has build errors in linux-next
since it uses ac97_bus_type even when CONFIG_SOUND=n.


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--


[ message continues ]
[view original message]
From: Nicolas Pitre
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 10:09 pm

Both sound (AC97) and UCB1400 should be able to select CONFIG_AC97_BUS 
independently from each other.

And in linux/sound/Makefile one can find this note:

	# This one must be compilable even if sound is configured out
	obj-$(CONFIG_AC97_BUS) += ac97_bus.o

This was fixed 2 years ago.  Who broke it this time?


Nicolas
--


[ message continues ]
[view original message]
From: Takashi Iwai
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 11:46 pm

At Fri, 05 Sep 2008 01:09:48 -0400 (EDT),

Oh, it must be me.

Could you check the patch below?


thanks,

Takashi

diff --git a/sound/Kconfig b/sound/Kconfig
index a37bee0..164a53a 100644
--- a/sound/Kconfig
+++ b/sound/Kconfig
@@ -91,6 +91,9 @@ endif # SOUND_PRIME
 
 endif # !M68K
 
+endif # SOUND
+
+# AC97_BUS is used from both sound and ucb1400
 config AC97_BUS
 	tristate
 	help
@@ -99,4 +102,3 @@ config AC97_BUS
 	  sound although they're sharing the AC97 bus. Concerned drivers
 	  should "select" this.
 
-endif # SOUND
--


[ message continues ]
[view original message]
From: Nicolas Pitre
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 7:52 am

I think both your patch and the one I previously posted are needed.


Nicolas
--


[ message continues ]
[view original message]
From: Takashi Iwai
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 9:26 am

At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),

Could you repost?  I can't find it easily now.

thanks,

Takashi
--


[ message continues ]
[view original message]
From: Nicolas Pitre
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 9:32 am

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 6e1e8c6..22cf319 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
 
 config TOUCHSCREEN_UCB1400
 	tristate "Philips UCB1400 touchscreen"
-	select AC97_BUS
 	depends on UCB1400_CORE
 	help
 	  This enables support for the Philips UCB1400 touchscreen interface.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 5dba165..70355d3 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -52,6 +52,7 @@ config HTC_PASIC3
 
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
+	select AC97_BUS
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.


Nicolas
--


[ message continues ]
[view original message]
From: Takashi Iwai
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 10:17 am

At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),

Thanks.  For linux-next, yes, it's needed.  But it's not for 2.6.27.

Meanwhile, my fix should be included in 2.6.27 since it's a
regression.

Randy, could you check whether these two patches fix your problem?
I'll put my patch to my tree for the next pull request after your
confirmation.

Can Nicolas's patch be to input tree, or any other taker?


thanks,

--


[ message continues ]
[view original message]
From: Dmitry Torokhov
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 11:33 am

I'll take it.

-- 
Dmitry
--


[ message continues ]
[view original message]
From: Takashi Iwai
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Saturday, September 6, 2008 - 2:54 am

At Fri, 5 Sep 2008 14:33:18 -0400,

Thanks!


Takashi
--


[ message continues ]
[view original message]
From: Randy Dunlap
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Friday, September 5, 2008 - 2:09 pm

--


[ message continues ]
[view original message]
From: Takashi Iwai
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Saturday, September 6, 2008 - 2:53 am

At Fri, 05 Sep 2008 14:09:24 -0700,

Thanks for checking!


Takashi
--


[ message continues ]
[view original message]
From: Nicolas Pitre
Subject: Re: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Thursday, September 4, 2008 - 10:27 pm

What about this?

diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
index 6e1e8c6..22cf319 100644
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC
 
 config TOUCHSCREEN_UCB1400
 	tristate "Philips UCB1400 touchscreen"
-	select AC97_BUS
 	depends on UCB1400_CORE
 	help
 	  This enables support for the Philips UCB1400 touchscreen interface.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 5dba165..70355d3 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -52,6 +52,7 @@ config HTC_PASIC3
 
 config UCB1400_CORE
 	tristate "Philips UCB1400 Core driver"
+	select AC97_BUS
 	help
 	  This enables support for the Philips UCB1400 core functions.
 	  The UCB1400 is an AC97 audio codec.


Nicolas
--


[ message continues ]
Previous thread: [PATCH 2/2] input: mousedev: Emulate right and middle buttons for single-button touchpads by Henrik Rydberg on Thursday, September 4, 2008 - 6:19 pm. (6 messages)

Next thread: [PATCH 01/16] x86: make detect_ht depends on X86_HT by Yinghai Lu on Thursday, September 4, 2008 - 8:08 pm. (17 messages)