I have now two different devices that refer to the same hardware:

lrwxrwxrwx 1 root root 0 2008-09-06 11:04 acpi_video0 -> ../../devices/virtual/backlight/acpi_video0/
lrwxrwxrwx 1 root root 0 2008-09-06 11:04 toshiba -> ../../devices/virtual/backlight/toshiba/

Unfortunately, due to ACPI implementation the acpi_video0 one is much
inferior (as it provides only effectively two levels instead of 8);
and user level tools are apparently quite confused which one to select.

Is there any mechanism that would allow tochiba_acpi to claim brightness
for internal LCD screen that video would not attempt to grab it too?

Of course manually disabling brightness handling in video is always possible,
still is nice for this to be handled automatically.
[ message continues ]

ble,

Actually it is not. brightness_switch_enabled only disables event handling;
it still resets actual brightness on loading and creates sysfs files to


[ message continues ]

It is in latest ACPI test branch queued for 2.6.28.
The problem in bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9614
is another. But the patchset pointed to in comment #43 should fix several, 
also your problem.

If not, please tell me and open a new bug.

Thanks,

       Thomas
--

[ message continues ]

It was exactly the right one. I'll get a look at adding proper detection
for Toshiba HCI systems. Thank you!
[ message continues ]

It is still not in rc2; is it scheduled for 2.6.28 or delayed further?
[ message continues ]

Right, it's not there.
Len, what happened with the:
"Check for ACPI backlight support otherwise use vendor ACPIdrivers - version 4"
patches?

They are pretty essential for video.ko.
Otherwise graphics devices may get double poked (through vendor_acpi.ko drivers)
or may register for graphics cards which are not there.

    Thomas
--

[ message continues ]

Do you have a pointer to those patches?

Thanks,
Rafael
--

[ message continues ]

So far I am running with these commits from git://git.kernel.org/pub/scm/li=
nux/kernel/git/ak/linux-acpi-2.6:

commit f43d728731c691772ddc29e50d25c68a859935b5
Author: Thomas Renninger <trenn@suse.de>
Date:   Fri Aug 1 17:37:55 2008 +0200

    Check for ACPI backlight support otherwise use vendor ACPI drivers


commit ad9ed8385ed6ec5be8da7094db911c824258ceec
Author: Thomas Renninger <trenn@suse.de>
Date:   Fri Aug 1 17:37:54 2008 +0200

    ACPI: video: Ignore devices that aren't present in hardware

I have been waiting for in-tree inclusion to submit patches for
toshiba_acpi against stable base.

[ message continues ]

This tree does not exist anymore...

Andrey, do you still have a local copy?
Could you use git format-patch and repost the whole series
(should be about 11 patches) to Len and CC me.
It would be some work for me to recollect everything.

I hope Len is reading that soon and can give a comment why this was
in Andi's, but did not get into his ACPI git tree...

This should directly go into ACPI test branch again.
It would be great if it could still get cherry-picked into .28.

Thanks,

     Thomas

Norbert: I just saw your brightness complains about your Sony on the acpi 
list. You should start testing with the patchset we are talking about here.
video.ko is rather broken without them.



--

[ message continues ]

Do you have at least subjects for the patches? I have only
been using the quoted below, so I am not sure which other to pick.
Here is what git log --author=3DRenninger gives me:

Thu Aug 28 17:26:10 2008 +0200 ACPI video: Debug interface used for error m=
essage cleanup
=46ri Aug 1 17:37:55 2008 +0200 Check for ACPI backlight support otherwise =
use vendor ACPI drivers
=46ri Aug 1 17:37:54 2008 +0200 ACPI: video: Ignore devices that aren't pre=
sent in hardware
Mon Jul 23 14:44:41 2007 +0200 ACPI: autoload modules - Create __mod_acpi_d=
evice_table symbol for all ACPI drivers
Mon Jun 26 23:58:43 2006 -0400 ACPI: Enable ACPI error messages w/o CONFIG_=
ACPI_DEBUG
Tue Nov 8 05:27:00 2005 -0500 [ACPI] Fix Null pointer deref in video/lcd/br=
ightness

If you have open git repository, I could probably just push my


[ message continues ]

It is now linux-acpi-summer2008-2.6
I renamed to avoid confusion with Len's tree.
But Len should have taken all the patches in there.

-Andi
--

[ message continues ]

Hmm, looks like he did not.
Thanks for the pointer to the old tree, that made things easy.
I am going to post them to Len privately for inclusion into his test branch 
for now, there should be no need to post them on several lists a fifth 
time...
Let's see whether they still pop up in his next pull request for .28, 
hopefully they do...

Thanks,

      Thomas
--

[ message continues ]

Ah, the commit id's above solved the mystery.
It looks like andi checked these patches directly into his
"test" branch rather than a topic branch.  eg. they were
sitting on top of the old pcc_acpi driver etc.

So I lost them when I deleted the old test branch
in order to merge the updated topic branches
into a new test branch.

-Len

--

[ message continues ]

I remember they were in Andi's ACPI test branch already.
Andi/Len do you have an idea what happened to them?

   Thomas
--

[ message continues ]

Yes, the patches are in Andi's test tree currently.

please run
#git-clone
git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-acpi-2.6
acpi_test
#git-branch -r
#git-branch --track test origin/test
#git-checkout test

to get the source code if you want to give it a try. :)

thanks,
rui

--

[ message continues ]